1. 23 May, 2005 1 commit
    • unknown's avatar
      Fixed on BUG#6048: Stored procedure causes operating system reboot · c6f2053a
      unknown authored
        Memory leak in locally evalutated expressions during SP execution fixed by
        reusing allocated item slots when possible.
        Note: No test case added, since the test is a stress test that tries to make
        the machine to run out of memory.
        Second attempt, now tested with debug build, valgrind build, max (optimized)
        build, with and without --debug, --vagrind and --ps-protocol.
        Errors in trigger and view test with --debug in debug build where present
        before this patch, and likewise for valgrind warnings for view test in
        valgrind build with --ps-protocol.
      
      
      sql/item.cc:
        Init rsize in Item (for SP item reusal).
      sql/item.h:
        Addes special new operator for reuse of Items, for SP internal use only.
      sql/sp_head.cc:
        Reuse items assigned internally in SPs when possible.
      sql/sp_rcontext.cc:
        Reuse items assigned internally in SPs when possible.
        Moved the local variable assignment here (from sp_head) to avoid
        duplicated code.
      sql/sp_rcontext.h:
        New arg to sp_rcontext::set_item_eval() (and some coding style).
      sql/sql_class.cc:
        Adjusted call to new set_item_eval().
      c6f2053a
  2. 21 May, 2005 5 commits
    • unknown's avatar
      ha_innodb.cc: · 0768ab1d
      unknown authored
        The natural InnoDB type for NEWDECIMAL is FIXBINARY, not BINARY, since there probably is no benefit from stripping trailing bytes 0x20; note that tables created with 5.0.6 and containing DECIMAL do not need to be rebuilt, as BINARY works as well; note that because of Jani's fix to bug 10465, tables created with 5.0.? - 5.0.5 DO NEED TO BE REBUILT if they contain DECIMAL
      
      
      sql/ha_innodb.cc:
        The natural InnoDB type for NEWDECIMAL is FIXBINARY, not BINARY, since there probably is no benefit from stripping trailing bytes 0x20; note that tables created with 5.0.6 and containing DECIMAL do not need to be rebuilt, as BINARY works as well; note that because of Jani's fix to bug 10465, tables created with 5.0.? - 5.0.5 DO NEED TO BE REBUILT if they contain DECIMAL
      0768ab1d
    • unknown's avatar
      join_outer.test, join_outer.result: · 75d2a612
      unknown authored
        Added test cases for bug #9938.
      item.h:
        Fixed bug #9938: missing method not_null_tables for Item_ref.
      
      
      sql/item.h:
        Fixed bug #9938: missing method not_null_tables for Item_ref.
      mysql-test/t/join_outer.test:
        Added test cases for bug #9938.
      75d2a612
    • unknown's avatar
      sql_select.cc: · 393e63e5
      unknown authored
        Added missing comment for fix of #10561.
      
      
      sql/sql_select.cc:
        Added missing comment for fix of #10561.
      393e63e5
    • unknown's avatar
      opt_range.cc: · fbf65001
      unknown authored
        Post review corrections for optimization request #10561.
      
      
      sql/opt_range.cc:
        Post review corrections for optimization request #10561.
      fbf65001
    • unknown's avatar
      range.result, range.test: · 0688454c
      unknown authored
        Added test cases for optimization request #10561.
      opt_range.cc, sql_select.cc:
        Fixed bug #10561: an optimization request to allow
        range analysis for NOT IN and NOT BETWEEN.
      
      
      sql/sql_select.cc:
        Fixed bug #10561: an optimization request to allow
        range analysis for NOT IN and NOT BETWEEN.
      sql/opt_range.cc:
        Fixed bug #10561: an optimization request to allow
        range analysis for NOT IN and NOT BETWEEN.
      mysql-test/t/range.test:
        Added test cases for optimization request #10561.
      mysql-test/r/range.result:
        Added test cases for optimization request #10561.
      0688454c
  3. 20 May, 2005 22 commits
    • unknown's avatar
      Merge mdk10.(none):/home/reggie/bk/bug9148 · 7055a4fa
      unknown authored
      into mdk10.(none):/home/reggie/bk/mysql-5.0
      
      7055a4fa
    • unknown's avatar
      8ec1ffc6
    • unknown's avatar
      fixed conflicts · c7b3b3f0
      unknown authored
      
      VC++Files/mysys/mysys.dsp:
        Auto merged
      include/my_sys.h:
        Auto merged
      sql/sql_db.cc:
        Auto merged
      c7b3b3f0
    • unknown's avatar
      Merge rburnett@bk-internal.mysql.com:/home/bk/mysql-5.0 · 348ae81b
      unknown authored
      into mdk10.(none):/home/reggie/bk/mysql-5.0
      
      
      sql/spatial.cc:
        Auto merged
      348ae81b
    • unknown's avatar
      BUG# 9148: Denial of service · d7a4a8b6
      unknown authored
      The problem was that on Windows the access method indicates that access to file 
      such as "com1" and "lpt1" is allowed (since they are device names) and
      this causes mysql to attempt to open them as databases or tables.
      
      The fix was to write our own my_access method that uses other Win32 functions
      to determine if the given argument is indeed a file and has to requested
      mode.
      
      
      VC++Files/mysys/mysys.dsp:
        added my_access
      VC++Files/mysys/mysys_ia64.dsp:
        added my_access.c
      include/my_sys.h:
        if on windows, we use my_access.
        if not on windows, then my_access points to the native access method
      mysys/Makefile.am:
        added my_access to mysys build file
      mysys/mf_pack.c:
        changed call to access to my_access
      sql/sql_db.cc:
        changed call to access to my_access
      d7a4a8b6
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 971b3ca6
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0
      
      971b3ca6
    • unknown's avatar
      Fixed BUG#10537: Server crashes while loading data file into table through · 5e8fbc83
      unknown authored
                        procedure.
        by simply disabling 'load' in stored procedures, like it's already disabled
        for prepared statements. (They must be made "re-execution" safe before
        working with either PS or SP.)
      
      
      mysql-test/r/sp-error.result:
        New test case for BUG#10537.
      mysql-test/t/sp-error.test:
        New test case for BUG#10537.
      sql/sql_yacc.yy:
        Disable LOAD in stored procedures (just as for prepared statements).
      5e8fbc83
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/mysql-5.0-build · 4d1de5b6
      unknown authored
      into mysql.com:/mnt/archive/svoj/mysql/mysql-5.0
      
      4d1de5b6
    • unknown's avatar
      WL#2286 - Compile MySQL w/YASSL support · 9aff64b6
      unknown authored
      Portability fixes
      
      
      extra/yassl/include/buffer.hpp:
        Use assert.h instead of less portable cassert
      extra/yassl/include/log.hpp:
        Use stdio.h instead of less portable cstdio
      extra/yassl/include/socket_wrapper.hpp:
        Use assert.h instead of less portable cassert
      extra/yassl/mySTL/helpers.hpp:
        Use stdlib.h instead of less portable cstdlib
      extra/yassl/mySTL/stdexcept.hpp:
        Use string.h instead of less portable cstring
      extra/yassl/mySTL/vector.hpp:
        Use assert.h instead of less portable cassert
      extra/yassl/src/ssl.cpp:
        Use stdio.h instead of less portable cstdio
      extra/yassl/taocrypt/include/block.hpp:
        Use stddef.h instead of less portable cstddef, always use ptrdiff_t instead of less portable std::ptrdiff_t
      extra/yassl/taocrypt/include/file.hpp:
        Use stdio.h instead of less portable cstdio
      extra/yassl/taocrypt/include/integer.hpp:
        Use string.h instead of less portable cstring
      extra/yassl/taocrypt/include/runtime.hpp:
        Use stdlib.h instead of less portable cstdlib
      extra/yassl/taocrypt/src/dh.cpp:
        Use math.h instead of less portable cmatch
      9aff64b6
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 8b31de23
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-bug-5.0
      
      8b31de23
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · cb31e251
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      cb31e251
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 8aecc3f8
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/release/mysql-5.0
      
      8aecc3f8
    • unknown's avatar
      Merge mysql.com:/usr/home/ram/work/mysql-4.1-build · eb2a4c65
      unknown authored
      into mysql.com:/usr/home/ram/work/mysql-4.1
      
      eb2a4c65
    • unknown's avatar
      a fix (bug #10757: gis-rtree.test fails) · 526525dc
      unknown authored
      
      
      myisam/sp_key.c:
        a fix (bug #10757: gis-rtree.test fails)
        float8get() doesn't properly work with local variables sometimes.
      526525dc
    • unknown's avatar
      Add missing test result · 587c37f8
      unknown authored
      
      mysql-test/t/subselect.test:
        Add test of result
      587c37f8
    • unknown's avatar
      Macos 10.4 compatibility changes · 543bec09
      unknown authored
      
      include/my_global.h:
        make it compilable on mac os
      ndb/src/kernel/SimBlockList.cpp:
        make it compilable with gcc 4.0
      543bec09
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 66e76cf1
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      
      sql/sql_select.cc:
        Auto merged
      66e76cf1
    • unknown's avatar
      compatibility issues · b0f2cab3
      unknown authored
      Fixed errors reported by valgrind (some errors in NDB remains)
      
      
      myisam/rt_split.c:
        Added missing cast that caused problem on novell
        (minor code cleanup)
      ndb/src/ndbapi/Ndb.cpp:
        Moved DBUG_ENTER to remove warning from DBUG library
      sql/field_conv.cc:
        Added test for valgrind/purify to avoid warning
      sql/item_sum.cc:
        Removed comment and added ASSERT as setup can't be called twice anymore
      sql/sql_delete.cc:
        Fixed wrong return value
      sql/sql_parse.cc:
        More debugging
      sql/sql_select.cc:
        Removed duplicate call to setup() which caused a memory leak
      strings/my_vsnprintf.c:
        Added support for '%c' (used when printing my_getopt errors)
      b0f2cab3
    • unknown's avatar
      do not try to use equal field from outer query as field of local join (BUG#6384) · 1f169836
      unknown authored
      
      mysql-test/r/subselect.result:
        changes in plans
        test for bug#6384
      mysql-test/t/subselect.test:
        test for bug#6384
      sql/sql_select.cc:
        do not set equal field from outer query
      1f169836
    • unknown's avatar
      Merge gluh.mysql.r18.ru:/home/gluh/release/mysql-5.0-build · ab38fce6
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/release/mysql-5.0
      
      ab38fce6
    • unknown's avatar
      addition of "REFERENCED_TABLE_SCHEMA", · 61fd55ac
      unknown authored
        "REFERENCED_TABLE_NAME", "REFERENCED_COLUMN_NAME" fields into
        KEY_COLUMN_USAGE table
      
      
      61fd55ac
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-5.0-build · 93855a82
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-5.0-clean
      
      93855a82
  4. 19 May, 2005 12 commits