1. 18 Jan, 2007 3 commits
  2. 17 Jan, 2007 1 commit
    • marko's avatar
      branches/zip: btr_copy_externally_stored_field_prefix_low(): · 60c96ae3
      marko authored
      Split the code to subroutines.
      
      btr_copy_blob_prefix(): New function: copy the prefix of the externally
      stored part of an uncompressed BLOB.
      
      btr_copy_zblob_prefix(): New function: copy the prefix of the externally
      stored part of a compressed BLOB.
      
      btr_blob_get_part_len(), btr_blob_get_next_page_no(): Add const qualifier
      to the parameter.
      60c96ae3
  3. 16 Jan, 2007 13 commits
  4. 15 Jan, 2007 1 commit
    • marko's avatar
      branches/zip: When adding a page to the buffer pool, add it to · 134aff29
      marko authored
      buf_pool->page_hash and buf_pool->LRU before releasing buf_pool->mutex.
      
      buf_page_init_for_read(), buf_page_create(): Allocate the compressed
      page after the block has been added to the buffer pool.  Document the
      reason for this.
      134aff29
  5. 14 Jan, 2007 1 commit
  6. 13 Jan, 2007 1 commit
  7. 12 Jan, 2007 6 commits
    • marko's avatar
      branches/zip: Improve Valgrind diagnostics. · b91b8f49
      marko authored
      buf_buddy_relocate(): Document that src may have been split and some of
      it may be in buf_pool->zip_free[j] for some j<i, thus mach_read_from_4()
      may be reading from free memory.  Check buffer pages only for addressability,
      not for being completely initialized.  Ensure that block descriptors are
      completely initialized.
      
      buf_buddy_remove_from_free(): Check prev->state and next->state in
      UNIV_DEBUG && UNIV_DEBUG_VALGRIND builds.
      
      buf_buddy_free_low(): Flag the entire block valid prior to invoking
      buf_buddy_remove_from_free() in order to avoid a Valgrind warning about
      the debug assertion on bpage->state.  Remove the Valgrind check for
      buddy being completely allocated.  If it has been split to smaller blocks,
      some of those blocks may be free.
      b91b8f49
    • marko's avatar
      branches/zip: trx_sys_create_doublewrite_buf(): Revert the change of r1208. · 8030ac37
      marko authored
      We cannot clear the page with memset(), because the page number and
      tablespace id have already been stamped on it.
      8030ac37
    • marko's avatar
      e7d8e537
    • marko's avatar
      branches/zip: Add the buf_pool->zip_free[] accessor functions · 8420d4b6
      marko authored
      buf_buddy_add_to_free() and buf_buddy_remove_from_free().
      Remove some bogus Valgrind warnings.  Improve Valgrind instrumentation.
      8420d4b6
    • marko's avatar
      branches/zip: Improve Valgrind instrumentation of allocated memory. · 5637695a
      marko authored
      UNIV_MEM_FREE(): Declare a memory area free.
      UNIV_MEM_ALLOC(): Declare a memory area allocated (but uninitialized).
      UNIV_MEM_DESC(): Associate a memory area with a control block.
      UNIV_MEM_UNDESC(): Unassociate a control block.
      
      trx_sys_create_doublewrite_buf(): Clear the buffer with memset().
      
      buf_page_init(): Add a bogus UNIV_MEM_VALID(block->frame) to silence
      valid warnings about InnoDB data pages containing uninitialized data.
      
      buf_LRU_get_free_only(): Add UNIV_MEM_ALLOC(block->frame).
      
      buf_LRU_get_free_block(): Add UNIV_MEM_DESC(block->page.zip.data, block).
      
      buf_LRU_free_block(): Add UNIV_MEM_DESC(b->zip.data, b) when allocating
      a compressed-only control block for a compressed page.
      
      buf_LRU_block_free_non_file_page(): Replace UNIV_MEM_INVALID() with
      UNIV_MEM_FREE().
      
      buf_LRU_block_remove_hashed_page(): Add UNIV_MEM_UNDESC(bpage) when
      deallocating a compressed-only control block.  Add
      UNIV_MEM_INVALID(block->frame).  (The frame should be flagged free
      by buf_LRU_block_free_non_file_page() moments later.)
      
      buf0buddy.c: Disable some extra checks in Valgrind-instrumented builds.
      Add UNIV_MEM_VALID(), UNIV_MEM_INVALID(), UNIV_MEM_FREE(), UNIV_MEM_ALLOC()
      as necessary.
      5637695a
    • marko's avatar
      branches/zip: buf_relocate(): Copy the block. Invalidate the source block. · 069514de
      marko authored
      buf_buddy_block_free(), buf_buddy_free_low(): Flag the freed bytes
      uninitialized.
      
      buf_page_init_for_read(), buf_buddy_relocate(): Do not refer to bpage
      after invoking buf_relocate().
      
      buf_buddy_relocate(): Flag src uninitialized.
      069514de
  8. 10 Jan, 2007 4 commits
  9. 09 Jan, 2007 6 commits
  10. 08 Jan, 2007 3 commits
  11. 05 Jan, 2007 1 commit
    • marko's avatar
      branches/zip: Make zlib use InnoDB memory heaps. · 6670fe35
      marko authored
      page_zip_malloc(): Replace ut_malloc(...) with mem_heap_alloc(opaque, ...).
      
      page_zip_free(): Dummy function (cannot deallocate from InnoDB memory
      heaps, and zlib seems to defer deallocation to the very end anyway).
      
      page_zip_compress(): Create a big enough heap for the needs of zlib.
      Replace deflateInit() with deflateInit2().
      
      page_zip_decompress(): Create a big enough heap for the needs of zlib.
      Replace inflateInit() with inflateInit2().
      6670fe35