1. 28 Nov, 2007 4 commits
    • unknown's avatar
      Merge mysql.com:/Users/davi/mysql/bugs/31479-5.0 · cb9e2b8f
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-runtime
      
      
      mysql-test/r/lock_multi.result:
        Null merge.
      mysql-test/t/lock_multi.test:
        Null merge.
      sql/sql_table.cc:
        Null merge.
      cb9e2b8f
    • unknown's avatar
      Bug#31479 Bad lock interaction if CREATE TABLE LIKE is killed · 6a6d4b07
      unknown authored
      Kill of a CREATE TABLE source_table LIKE statement waiting for a
      name-lock on the source table causes a bad lock interaction.
      
      The mysql_create_like_table() has a bug that if the connection is
      killed while waiting for the name-lock on the source table, it will
      jump to the wrong error path and try to unlock the source table and
      LOCK_open, but both weren't locked.
      
      The solution is to simple return when the name lock request is killed,
      it's safe to do so because no lock was acquired and no cleanup is needed.
      
      Original bug report also contains description of other problems
      related to this scenario but they either already fixed in 5.1 or
      will be addressed separately (see bug report for details).
      
      
      mysql-test/r/lock_multi.result:
        Add test case result for Bug#31479
      mysql-test/t/lock_multi.test:
        Add test case for Bug#31479
      sql/sql_table.cc:
        Rerturn TRUE when the lock gets killed.
      6a6d4b07
    • unknown's avatar
      Merge kpettersson@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 91e001fe
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      91e001fe
    • unknown's avatar
      Error number increased; fixing broken number. · 910f0238
      unknown authored
      910f0238
  2. 27 Nov, 2007 2 commits
  3. 26 Nov, 2007 17 commits
    • unknown's avatar
      Remove disabling of testcases · 3817f07c
      unknown authored
      3817f07c
    • unknown's avatar
      Bug#25146 Some warnings/errors not shown when using --show-warnings · 204fe148
      unknown authored
       - Additional patch to fix compiler warnings
      
      
      client/mysql.cc:
        Initialize warnings to 0 to avid compiler warning
        Call 'print_warnings' also when error occured
      mysql-test/r/mysql.result:
        Change test to make is possible to see that second set of warnings
        are from second invocation of mysql
      mysql-test/t/mysql.test:
        Change test to make is possible to see that second set of warnings
        are from second invocation of mysql
      204fe148
    • unknown's avatar
      Revert · 379e98ac
      unknown authored
      379e98ac
    • unknown's avatar
      Merge kpettersson@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · e4d373f2
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      e4d373f2
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug16470/my51-bug16470 · 63b292da
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      mysql-test/r/grant.result:
        Auto merged
      mysql-test/t/grant.test:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        manual merge
      63b292da
    • unknown's avatar
      Merge mysql.com:/Users/davi/mysql/bugs/29592-5.0 · 44a1eada
      unknown authored
      into  mysql.com:/Users/davi/mysql/bugs/29592-5.1
      
      
      include/mysql.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      libmysql/libmysql.def:
        Auto merged
      libmysqld/libmysqld.def:
        Auto merged
      include/mysql_h.ic:
        Update ABI check file.
      44a1eada
    • unknown's avatar
      Bug#16470 crash on grant if old grant tables · 5fad7671
      unknown authored
      Loading 4.1 into 5.0 or 5.1 failed silently because procs_priv table missing.
      This caused the server to crash on any attempt to store new grants because
      of uninitialized structures.
      
      This patch breaks up the grant loading function into two phases to allow
      for procs_priv table to fail with an warning instead of crashing the server.
      
      
      mysql-test/r/grant.result:
        Test case
      mysql-test/t/grant.test:
        Test case making sure that FLUSH PRIVILEGES doesn't crash the server if
        procs_priv is removed.
      sql/sql_acl.cc:
        - Refactored grant_reload into two phases: 1. open and lock tables_priv and 
          columns_priv tables, read the data, close tables. 2. open and lock
          procs_priv, read data, close table. Since the tables are independant of
          each other there will be no race conditions and it will be possible to
          handle situations where the procs_priv table isn't present.
        - Refactored the helper function grant_load into new grant_load (without
          procs_priv table) and grant_load_procs_priv.
      sql/sql_parse.cc:
        - Changed comment style to doxygen style.
      5fad7671
    • unknown's avatar
      Bug#29592 SQL Injection issue · 6e512d61
      unknown authored
      Remove the mysql_odbc_escape_string() function. The function
      has multi-byte character escaping issues, doesn't honor the
      NO_BACKSLASH_ESCAPES mode and is not used anymore by the
      Connector/ODBC as of 3.51.17.
      
      
      include/mysql.h:
        Remove mysql_odbc_escape_string() prototype.
      include/mysql_h.ic:
        Update abi check file, mostly line changes and mysql_odbc_escape_string
        removal.
      libmysql/libmysql.c:
        Remove mysql_odbc_escape_string() body.
      libmysql/libmysql.def:
        Remove mysql_odbc_escape_string()
      libmysqld/libmysqld.def:
        Remove mysql_odbc_escape_string()
      6e512d61
    • unknown's avatar
      dc2a65c8
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-rpl-merge · 27069f1b
      unknown authored
      into  pilot.mysql.com:/data/msvensson/mysql/mysql-5.1-rpl-merge
      
      27069f1b
    • unknown's avatar
      Add suppressions for expected warning messages that appears in · 76541720
      unknown authored
      slave's error log when running rpl_extraColmaster_*.test 
      
      76541720
    • unknown's avatar
      7183643c
    • unknown's avatar
      f87514df
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug32436/my51-bug32436 · 35e43ac9
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      sql/item_func.cc:
        Auto merged
      35e43ac9
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug32436/my50-bug32436 · b237fbac
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/bug32436/my51-bug32436
      
      
      sql/item_func.cc:
        Auto merged
      b237fbac
    • unknown's avatar
      Bug #32436 KILL QUERY completely deadlocks mysqld · 6bf5fd40
      unknown authored
      Sending several "KILL QUERY" statements to target a connection running
      "SELECT SLEEP" could freeze the server.
      
      The locking order in Item_func_sleep was wrong and this could lead to a
      dead lock.
      
      This patch solves the issue by resolving the locking order properly.
      
      
      sql/item_func.cc:
        - Moved LOCK_user_locks critical region so that it doesn't share space with
          mysys_var->mutex region; this can lead to deadlock.
      6bf5fd40
    • unknown's avatar
      Disabling failing test that has been reported as bug. · 8548ce00
      unknown authored
      
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Disabling failing test.
      8548ce00
  4. 23 Nov, 2007 3 commits
    • unknown's avatar
      Merge bodhi.(none):/opt/local/work/mysql-5.0-runtime · a44dd180
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_yacc.yy:
        Manual merge.
      a44dd180
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 77f3e0ab
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      77f3e0ab
    • unknown's avatar
      Post-merge fixes. · 62581535
      unknown authored
      
      mysql-test/r/innodb.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_binlog_grant.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_extraColmaster_innodb.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_extraColmaster_myisam.result:
        Result change.
      mysql-test/suite/rpl/t/disabled.def:
        Enabling some tests.
      mysql-test/suite/rpl/t/rpl_binlog_grant.test:
        Adding missing master-slave.inc, causing previous tests to pollute
        the binary log.
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Enabling some tests.
      62581535
  5. 22 Nov, 2007 11 commits
  6. 21 Nov, 2007 3 commits
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1 · 2b8ded6b
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl-merge
      
      
      client/mysql.cc:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/r/mysql.result:
        Auto merged
      mysql-test/suite/ndb/r/ndb_dd_basic.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_extraCol_innodb.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_extraCol_myisam.result:
        Auto merged
      mysql-test/suite/rpl_ndb/r/rpl_ndb_extraCol.result:
        Auto merged
      mysql-test/t/ctype_uca.test:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      mysql-test/t/innodb.test:
        Auto merged
      mysql-test/t/mysql.test:
        Auto merged
      mysql-test/t/partition.test:
        Auto merged
      mysql-test/t/subselect.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/r/innodb.result:
        Manual merge.
      2b8ded6b
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug31153/my51-bug31153 · ab62ea34
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      ab62ea34
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.0-build · 0bdc06e8
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build
      
      0bdc06e8