1. 28 Mar, 2008 28 commits
    • unknown's avatar
      Merge quad.opbmk:/mnt/raid/alik/MySQL/devel/5.0-bt · cbd1f78b
      unknown authored
      into  quad.opbmk:/mnt/raid/alik/MySQL/devel/5.1-bt-merged
      
      
      mysql-test/t/loaddata.test:
        Auto merged
      mysql-test/r/loaddata.result:
        Manually merged.
      sql/share/errmsg.txt:
        Manually merged.
      sql/sql_load.cc:
        Manually merged.
      cbd1f78b
    • unknown's avatar
      Fix tree: · fdf7e6f5
      unknown authored
        1. Use 'dat' extension, because it is handled in Makefile.am;
        2. Fix typo: the bug id is 35469, not 35649.
      
      
      mysql-test/std_data/bug35469.dat:
        Rename: mysql-test/std_data/bug35649.data -> mysql-test/std_data/bug35469.dat
      mysql-test/r/loaddata.result:
        Update result file.
      mysql-test/t/loaddata.test:
        1. Use 'dat' extension, because it is handled in Makefile.am;
        2. Fix typo: the bug id is 35469, not 35649.
      fdf7e6f5
    • unknown's avatar
      Fixes to eliminate compiler warnings. · de944022
      unknown authored
      
      sql/log.cc:
        Reordering initialalizer list to eliminate compiler warnings.
      de944022
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-bugteam · 59ad7fdb
      unknown authored
      into  quad.opbmk:/mnt/raid/alik/MySQL/devel/5.0-bt
      
      59ad7fdb
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · e8218ca2
      unknown authored
      into  mats-laptop.(none):/home/bk/b29020-mysql-5.1-rpl
      
      
      sql/sql_insert.cc:
        Auto merged
      e8218ca2
    • unknown's avatar
      Post-merge fixes to remove test failures resulting from merge. · 42bbd79f
      unknown authored
      
      mysql-test/suite/binlog/r/binlog_row_ctype_ucs.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_extraCol_myisam.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_switch_stm_row_mixed.result:
        Result change.
      mysql-test/suite/rpl/t/rpl_switch_stm_row_mixed.test:
        Removing rows causing tests to be non-deterministic.
      42bbd79f
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · 2a840c60
      unknown authored
      into  moonbone.local:/work/27219-bug-5.1
      
      2a840c60
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · ff5df7df
      unknown authored
      into  mysql.com:/home/ram/work/mysql-5.1-bugteam
      
      ff5df7df
    • unknown's avatar
      Fix for Bug#35469: server crash with LOAD DATA INFILE to a VIEW. · a6f04bb3
      unknown authored
      The problem was that LOAD DATA code (sql_load.cc) didn't take into
      account that there may be items, representing references to other
      columns. This is a usual case in views. The crash happened because
      Item_direct_view_ref was casted to Item_user_var_as_out_param,
      which is not a base class.
      
      The fix is to
        1) Handle references properly;
        2) Ensure that an item is treated as a user variable only when
           it is a user variable indeed;
        3) Report an error if LOAD DATA is used to load data into
           non-updatable column.
      
      
      mysql-test/r/loaddata.result:
        Update result file.
      mysql-test/t/loaddata.test:
        Add a test case form Bug#35469: server crash with
        LOAD DATA INFILE to a VIEW.
      sql/share/errmsg.txt:
        Introduce a new error.
      sql/sql_load.cc:
        Handle reference-items properly.
      mysql-test/std_data/bug35649.data:
        Add a data file for the test case.
      a6f04bb3
    • unknown's avatar
      Fix for bug #35392: Delete all statement does not execute properly · d916f544
      unknown authored
      after few delete statements
      
      Problem: changing a file size might require that it must be 
      unmapped beforehand.
        
      Fix: unmap the file before changing its size.
      
      
      mysql-test/r/temp_table.result:
        Fix for bug #35392: Delete all statement does not execute properly 
        after few delete statements
          - test result.
      mysql-test/t/temp_table.test:
        Fix for bug #35392: Delete all statement does not execute properly 
        after few delete statements
          - test case.
      storage/myisam/mi_delete_all.c:
        Fix for bug #35392: Delete all statement does not execute properly 
        after few delete statements
          - unmap file before changing its size as it's required 
            by SetEndOfFile() function (see my_chsize()).
          - as no other threads allowed to perform concurrent inserts 
            when delete_all is called, mmap_lock locking removed.
      d916f544
    • unknown's avatar
      Merge moonbone.local:/work/27219-5.0-opt-mysql · 490de4d8
      unknown authored
      into  moonbone.local:/work/27219-bug-5.1
      
      
      sql/item_subselect.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/item_sum.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/group_by.result:
        SCCS merged
      mysql-test/t/group_by.test:
        SCCS merged
      sql/item.cc:
        SCCS merged
      sql/sql_lex.h:
        SCCS merged
      490de4d8
    • unknown's avatar
      Merge witty.:/Users/mattiasj/clones/bug21413-51-engines · 60d10271
      unknown authored
      into  witty.:/Users/mattiasj/clones/bug21413-51-bugteam
      
      60d10271
    • unknown's avatar
      Merge witty.:/Users/mattiasj/clones/bug21413-50-engines · ec43246d
      unknown authored
      into  witty.:/Users/mattiasj/clones/bug21413-50-bugteam
      
      ec43246d
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · e3ba9a69
      unknown authored
      into  mats-laptop.(none):/home/bk/b29020-mysql-5.1-rpl
      
      
      mysql-test/suite/binlog/r/binlog_base64_flag.result:
        Auto merged
      mysql-test/suite/binlog/t/binlog_base64_flag.test:
        Auto merged
      mysql-test/suite/rpl/r/rpl_row_create_table.result:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/log_event.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      e3ba9a69
    • unknown's avatar
      Merge witty.:/Users/mattiasj/clones/bug21413-50-engines · ad64909c
      unknown authored
      into  witty.:/Users/mattiasj/clones/bug21413-51-engines
      
      
      sql/sql_insert.cc:
        Auto merged
      ad64909c
    • unknown's avatar
      Merge witty.:/Users/mattiasj/Public/shared-vms/bug21413-41-engines · 5e7d2481
      unknown authored
      into  witty.:/Users/mattiasj/clones/bug21413-50-engines
      
      
      sql/sql_insert.cc:
        Manual merge
      5e7d2481
    • unknown's avatar
      Bug#21413 - Engine table handler used by multiple threads · 97b3c330
      unknown authored
                  in REPLACE DELAYED
          
      post push patch, removing the optimization for
      copying delayed_insert variables.
      
      
      sql/sql_insert.cc:
        Bug#21413 - Engine table handler used by multiple threads
                    in REPLACE DELAYED
        
        post push patch, removing the optimization for
        copying delayed_insert variables.
        (restored some parts which caused errors)
      97b3c330
    • unknown's avatar
      BUG#29020 (Event results not correctly replicated to slave in RBR): · 66a443a0
      unknown authored
      The bug allow multiple executing transactions working with non-transactional
      to interfere with each others by interleaving the events of different trans-
      actions.
      
      Bug is fixed by writing non-transactional events to the transaction cache and
      flushing the cache to the binary log at statement commit. To mimic the behavior
      of normal statement-based replication, we flush the transaction cache in row-
      based mode when there is no committed statements in the transaction cache,
      which means we are committing the first one. This means that it will be written
      to the binary log as a "mini-transaction" with just the rows for the statement.
      
      Note that the changes here does not take effect when building the server with
      HAVE_TRANSACTIONS set to false, but it is not clear if this was possible before
      this patch either.
      
      For row-based logging, we also have that when AUTOCOMMIT=1, the code now always
      generates a BEGIN/COMMIT pair for single statements, or BEGIN/ROLLBACK pair in the
      case of non-transactional changes in a statement that was rolled back. Note that
      for the case where changes to a non-transactional table causes a rollback due
      to error, the statement will now be logged with a BEGIN/ROLLBACK pair, even
      though some changes has been committed to the non-transactional table.
      
      
      mysql-test/extra/rpl_tests/rpl_row_delayed_ins.test:
        Removing SHOW BINLOG EVENTS causing test to be non-deterministic.
      mysql-test/r/ctype_cp932_binlog_row.result:
        Result change.
      mysql-test/suite/binlog/r/binlog_base64_flag.result:
        Result change.
      mysql-test/suite/binlog/r/binlog_multi_engine.result:
        Result file change.
      mysql-test/suite/binlog/r/binlog_row_binlog.result:
        Result file change.
      mysql-test/suite/binlog/r/binlog_row_ctype_ucs.result:
        Result file change.
      mysql-test/suite/binlog/r/binlog_row_insert_select.result:
        Result file change.
      mysql-test/suite/binlog/r/binlog_row_mix_innodb_myisam.result:
        Result file change.
      mysql-test/suite/binlog/r/binlog_stm_binlog.result:
        Result file change.
      mysql-test/suite/binlog/t/binlog_base64_flag.test:
        Removing table that will be used in test to prevent failing if preceeding
        tests forgot to drop the table.
      mysql-test/suite/rpl/r/rpl_rbr_to_sbr.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_basic_11bugs.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_create_table.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_delayed_ins.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_flsh_tbls.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_inexist_tbl.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_log.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_log_innodb.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_until.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_slave_skip.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_switch_stm_row_mixed.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_truncate_2myisam.result:
        Result file change.
      mysql-test/suite/rpl/t/rpl_row_create_table.test:
        Binlog position change.
      mysql-test/suite/rpl/t/rpl_row_flsh_tbls.test:
        Binlog position change.
      mysql-test/suite/rpl/t/rpl_row_mysqlbinlog.test:
        Binlog position change. Added stop position to mysqlbinlog argments to prevent
        extreneous output.
      mysql-test/suite/rpl/t/rpl_row_until.test:
        Binlog position change.
      mysql-test/suite/rpl/t/rpl_slave_skip.test:
        Binlog position change.
      mysql-test/suite/rpl/t/rpl_switch_stm_row_mixed.test:
        Removing extreneous SHOW BINLOG EVENTS causing test to be non-deterministic.
      mysql-test/suite/rpl_ndb/r/rpl_ndb_log.result:
        Result change.
      sql/log.cc:
        Adding variable at_least_one_stmt to denote that there is at least one
        statement committed to the transaction cache (but there might be more).
        
        Removing duplicate checks from binlog_end_trans(). The transaction cache
        should always be committed or rolled back when this function is called.
        
        Correcting conditions for binlog_rollback() and binlog_commit() and removing
        the previous "invisible commit" in favor of always using explicit commits
        in the binary log.
      sql/log_event.cc:
        Marking table map event to be cached. Removing Muted_query_log_event from code.
      sql/log_event.h:
        Removing unused class Muted_query_log_event.
      sql/sql_insert.cc:
        Adding missing call to ha_autocommit_or_rollback() for delayed thread. Marking
        CREATE-SELECT statements as transactional, since they don't need to be logged.
      66a443a0
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-bugteam · 22cd570b
      unknown authored
      into  moonbone.local:/work/27219-5.0-opt-mysql
      
      
      sql/item.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      22cd570b
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/merge-5.0-bugteam · 4e6f0e2e
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam
      
      
      sql/sql_acl.cc:
        Auto merged
      4e6f0e2e
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1 · ffe4016b
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam
      
      
      sql/sql_acl.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      ffe4016b
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 04735c04
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.0-bugteam
      
      
      sql/sql_acl.cc:
        Auto merged
      04735c04
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/merge-5.0-bugteam · 8400d442
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam
      
      8400d442
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1 · 9db1668d
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam
      
      
      mysql-test/r/grant.result:
        Auto merged
      mysql-test/t/grant.test:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_connect.cc:
        Auto merged
      9db1668d
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · 0619a0a5
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam
      
      0619a0a5
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 1a512292
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.0-bugteam
      
      1a512292
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/merge-5.0-bugteam · 043d0714
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam
      
      
      mysql-test/t/grant.test:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      mysql-test/r/grant.result:
        merge 5.0-bugteam to 5.1-bugteam
      043d0714
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · 235117d5
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B35206-5.1-bugteam
      
      
      sql/sql_select.cc:
        Auto merged
      235117d5
  2. 27 Mar, 2008 12 commits
    • unknown's avatar
      Merge mysql.com:/misc/mysql/mysql-5.0-opt · b04e344a
      unknown authored
      into  mysql.com:/misc/mysql/mysql-5.1-opt
      
      
      CMakeLists.txt:
        Auto merged
      configure.in:
        Auto merged
      include/config-win.h:
        Auto merged
      include/my_global.h:
        Auto merged
      b04e344a
    • unknown's avatar
      Merge mysql.com:/misc/mysql/mysql-5.0 · f723dec4
      unknown authored
      into  mysql.com:/misc/mysql/mysql-5.0-opt
      
      
      CMakeLists.txt:
        Auto merged
      configure.in:
        Auto merged
      include/config-win.h:
        Auto merged
      include/my_global.h:
        Auto merged
      f723dec4
    • unknown's avatar
      Merge mysql.com:/misc/mysql/mysql-5.1 · 938e0817
      unknown authored
      into  mysql.com:/misc/mysql/mysql-5.1-opt
      
      
      CMakeLists.txt:
        Auto merged
      configure.in:
        Auto merged
      include/config-win.h:
        Auto merged
      include/my_global.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_db.cc:
        Auto merged
      storage/innobase/handler/ha_innodb.cc:
        Auto merged
      938e0817
    • unknown's avatar
      Bug #35206: select query result different if the key is indexed or not · 82242b93
      unknown authored
      The code for executing indexed ORDER BY was not setting all the 
      internal fields correctly when selecting to execute ORDER BY over
      and index.
      Fixed by change the access method to one that will use the 
      quick indexed access if one is selected while selecting indexed
      ORDER BY.
      
      
      mysql-test/r/order_by.result:
        Bug #35206: test case
      mysql-test/t/order_by.test:
        Bug #35206: test case
      sql/sql_select.cc:
        Bug #35206: Change the access method when selecting a 
        quick indexed access.
      82242b93
    • unknown's avatar
      Bug#27219: Aggregate functions in ORDER BY. · 9e65582b
      unknown authored
      Mixing aggregate functions and non-grouping columns is not allowed in the
      ONLY_FULL_GROUP_BY mode. However in some cases the error wasn't thrown because
      of insufficient check.
      
      In order to check more thoroughly the new algorithm employs a list of outer
      fields used in a sum function and a SELECT_LEX::full_group_by_flag.
      Each non-outer field checked to find out whether it's aggregated or not and
      the current select is marked accordingly.
      All outer fields that are used under an aggregate function are added to the
      Item_sum::outer_fields list and later checked by the Item_sum::check_sum_func
      function.
      
      
      mysql-test/t/group_by.test:
        Added a test case for the bug#27219: Aggregate functions in ORDER BY.
      mysql-test/r/group_by.result:
        Added a test case for the bug#27219: Aggregate functions in ORDER BY.
      sql/sql_select.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        Implementation of new check for mixing non aggregated fields and aggregation
        function in the ONLY_FULL_GROUP_BY mode.
      sql/sql_lex.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        Initialization of the full_group_by_flag bitmap.
        SELECT_LEX::test_limit function doesn't reset ORDER BY
        clause anymore.
      sql/sql_lex.h:
        Bug#27219: Aggregate functions in ORDER BY.
        The full_group_by_flag is added to the SELECT_LEX class.
      sql/item_sum.h:
        Bug#27219: Aggregate functions in ORDER BY.
        The outer_fields list is added to the Item_sum class.
      sql/mysql_priv.h:
        Bug#27219: Aggregate functions in ORDER BY.
        Defined a set of constants used in the new check for mixing non aggregated
        fields and sum functions in the ONLY_FULL_GROUP_BY_MODE.
      sql/item_subselect.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        The Item_in_subselect::select_in_like_transformer function now drops
        ORDER BY clause in all selects in a subquery.
      sql/item_sum.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        Now the Item_sum::check_sum_func function now checks whether fields in the
        outer_fields list are aggregated or not and marks selects accordingly.
      sql/item.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        Now the Item_field::fix_fields function checks whether the field is aggregated
        or not and marks its select_lex accordingly.
      9e65582b
    • unknown's avatar
      Bug#35272: @@global.key_buffer_size = 4294967295 let the server crash · df93bab5
      unknown authored
      reverting test that has been obsoleted by changes to the code
      
      
      mysql-test/r/key_cache.result:
        reverting test that has been obsoleted by changes to the code
      mysql-test/t/key_cache.test:
        reverting test that has been obsoleted by changes to the code
      df93bab5
    • unknown's avatar
      Merge host.loc:/home/uchum/work/5.0-opt · 50f2f20c
      unknown authored
      into  host.loc:/home/uchum/work/5.1-opt
      
      
      configure.in:
        Auto merged
      sql/item.cc:
        Auto merged
      50f2f20c
    • unknown's avatar
      Merge host.loc:/home/uchum/work/mysql-5.0 · abd0aeb8
      unknown authored
      into  host.loc:/home/uchum/work/5.0-opt
      
      
      configure.in:
        Auto merged
      sql/item.cc:
        Auto merged
      abd0aeb8
    • unknown's avatar
      Merge witty.:/Users/mattiasj/clones/bug21413-50-engines · 37562f7f
      unknown authored
      into  witty.:/Users/mattiasj/clones/bug21413-51-engines
      
      
      sql/sql_insert.cc:
        manual merge
      37562f7f
    • unknown's avatar
      Merge witty.:/Users/mattiasj/Public/shared-vms/bug21413-41-engines · 09edf843
      unknown authored
      into  witty.:/Users/mattiasj/clones/bug21413-50-engines
      
      
      sql/sql_insert.cc:
        Manual merge
      09edf843
    • unknown's avatar
      Patch clean up. · d71bd5fa
      unknown authored
      Fixed interference between tests: Users were added but not properly removed.
      This caused later tests to fail.
      
      
      mysql-test/r/grant.result:
        Fixed interference between tests: Users were added but not properly removed.
        This caused later tests to fail.
      mysql-test/t/grant.test:
        Fixed interference between tests: Users were added but not properly removed.
        This caused later tests to fail.
      d71bd5fa
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · f1af4839
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      f1af4839