1. 03 Dec, 2019 7 commits
  2. 02 Dec, 2019 2 commits
  3. 30 Nov, 2019 3 commits
  4. 29 Nov, 2019 4 commits
    • HF's avatar
      MENT-510 Failing test(s): perfschema.threads_insert_delayed. · 3fb0fe40
      HF authored
      orig_test_id should be set properly.
      Also fixed sporadic test failure.
      3fb0fe40
    • Anel Husakovic's avatar
    • Daniel Black's avatar
      MDEV-15503: mtr fix --strace · 866e5c25
      Daniel Black authored
      $glob_mysql_test_dir was the wrong directory for strace output as
      it was for in-tree builds only so failed for:
      * out of tree builds
      * --parallel; and
      * --mem
      
      strace output wasn't saved.
      
      strace-option never replaced existing arguments (so ammended
      documentation).
      
      strace-client didn't accept an argument as described.
      
      Replaced specification of client with this with 'stracer' to be
      consistent with --debugger option.
      
      For consistency with debugger options, --client-strace was added to
      execute the strace on the mysqltest.
      
      Example: Running one test
      
      $ ./mtr --strace --client-strace funcs_1.is_table_constraints
      Logging: ./mtr  --strace --client-strace funcs_1.is_table_constraints
      vardir: /home/anel/mariadb/5.5/mysql-test/var
      Checking leftover processes...
      Removing old var directory...
       - WARNING: Using the 'mysql-test/var' symlink
      Creating var directory '/home/anel/mariadb/5.5/mysql-test/var'...
      Checking supported features...
      MariaDB Version 5.5.67-MariaDB-debug
      Installing system database...
       - SSL connections supported
       - binaries are debug compiled
      Collecting tests...
      
      ==============================================================================
      
      TEST                                      RESULT   TIME (ms) or COMMENT
      --------------------------------------------------------------------------
      
      worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019
      funcs_1.is_table_constraints             [ pass ]   1270
      --------------------------------------------------------------------------
      The servers were restarted 0 times
      Spent 1.270 of 3 seconds executing testcases
      
      Completed: All 1 tests were successful
      
      $ find -L . -name \*strace -ls
            653     56 -rw-r--r--   1 anel     anel        57147 Nov 29 15:08 ./var/log/mysqltest.strace
            646   1768 -rw-r--r--   1 anel     anel      1809855 Nov 29 15:08 ./var/log/mysqld.1.strace
      
      Example: Running test in parallel
      
      $ mysql-test/mtr --strace --client-strace  --mem --parallel=3  main.select
      Logging: /home/dan/software_projects/mariadb-server/mysql-test/mysql-test-run.pl  --strace --client-strace --mem --parallel=3 main.select
      vardir: /home/dan/software_projects/build-mariadb-10.3/mysql-test/var
      Checking leftover processes...
      Removing old var directory...
      Creating var directory '/home/dan/software_projects/build-mariadb-10.3/mysql-test/var'...
       - symlinking 'var' to '/dev/shm/var_auto_0v2E'
      Checking supported features...
      MariaDB Version 5.5.67-MariaDB
       - SSL connections supported
      Collecting tests...
      Installing system database...
      
      ==============================================================================
      
      TEST                                  WORKER RESULT   TIME (ms) or COMMENT
      --------------------------------------------------------------------------
      
      worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019
      worker[3]  - 'localhost:16040' was not free
      worker[2] Using MTR_BUILD_THREAD 301, with reserved ports 16020..16039
      worker[3] Using MTR_BUILD_THREAD 303, with reserved ports 16060..16079
      main.select                              w1 [ pass ]   7310
      --------------------------------------------------------------------------
      The servers were restarted 0 times
      Spent 7.310 of 11 seconds executing testcases
      
      Completed: All 1 tests were successful.
      
      $ find mysql-test/var/ -name \*strace -ls
        5213766   1212 -rw-r--r--   1  dan      dan       1237817 May 20 16:47 mysql-test/var/1/log/mysqltest.strace
        5214733  13016 -rw-r--r--   1  dan      dan      13328335 May 20 16:47 mysql-test/var/1/log/mysqld.1.strace
      
      $ mysql-test/mtr --strace --client-strace --strace-option='-e' --strace-option='trace=openat'  --mem --parallel=3  main.select
      ...
      $ find mysql-test/var/ -name \*strace -ls
        5220790      8 -rw-r--r--   1  dan      dan          6291 May 20 17:02 mysql-test/var/3/log/mysqltest.strace
        5224140    308 -rw-r--r--   1  dan      dan        314356 May 20 17:02 mysql-test/var/3/log/mysqld.1.strace
      $ more mysql-test/var/3/mysqltest.strace
      1692  openat(AT_FDCWD, "/home/dan/software_projects/mariadb-server/libmysql/.libs/tls/x86_64/x86_64/libpthread.so.0", O_RDONLY|O_CLOEXEC) =
      -1 ENOENT (No such file or directory)
      1692  openat(AT_FDCWD, "/home/dan/software_projects/mariadb-server/libmysql/.libs/tls/x86_64/libpthread.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOE
      NT (No such file or directory)
      
      Closes #600
      866e5c25
    • Vlad Lesin's avatar
      MDEV-18310: Aria engine: Undo phase failed with "Got error 121 when · bd11bd63
      Vlad Lesin authored
      executing undo undo_key_delete" upon startup on datadir restored from
      incremental backup
      
      aria_log* files were not copied on --prepare --incremental-dir step from
      incremental to destination backup directory.
      bd11bd63
  5. 28 Nov, 2019 2 commits
  6. 27 Nov, 2019 2 commits
  7. 26 Nov, 2019 8 commits
    • Vicențiu Ciorbaru's avatar
    • Olivier Bertrand's avatar
      - Fix MDEV-13782 · f0da39be
      Olivier Bertrand authored
        Problem with NOT LIKE queries.
        modified:   storage/connect/ha_connect.cc
        modified:   sql/item_cmpfunc.h
      
      - Fix MDEV-21084
        Misusage of strncat could cause buffer overflow.
        modified:   storage/connect/reldef.cpp
        modified:   storage/connect/tabcmg.cpp
        modified:   storage/connect/tabjson.cpp
        modified:   storage/connect/tabrest.cpp
        modified:   storage/connect/tabxml.cpp
      f0da39be
    • Vicențiu Ciorbaru's avatar
      MDEV-13288: Proper fix for cracklib-runtime · 427eedd0
      Vicențiu Ciorbaru authored
      The required dependencies should be added through the autobake script,
      to also cover distributions that do not support libcrack2.
      427eedd0
    • Eugene Kosov's avatar
      fix double io_destroy() + cleanup · 49ed1ae3
      Eugene Kosov authored
      49ed1ae3
    • Marko Mäkelä's avatar
      MDEV-21152 Bogus debug assertion btr_pcur_is_after_last_in_tree() in ibuf code · a8395853
      Marko Mäkelä authored
      As noted in commit abd45cdc
      a search with PAGE_CUR_GE may land on the supremum record on
      a leaf page that is not the rightmost leaf page. This could occur
      when all keys on the current page are smaller than the search key,
      and the smallest key on the successor page is larger than the search key.
      
      Hence, after a failed PAGE_CUR_GE search, assertions
      btr_pcur_is_after_last_in_tree() are bogus
      and should be replaced with btr_pcur_is_after_last_on_page().
      a8395853
    • Vicențiu Ciorbaru's avatar
      MDEV-13288: Upstream debian patch · ed2379f9
      Vicențiu Ciorbaru authored
      ed2379f9
    • Seth Shelnutt's avatar
      23664bc7
    • seppo's avatar
      MDEV-19572 async slave node fails to apply MyISAM only writes (#1418) · 38839854
      seppo authored
      The problem happens when MariaDB master replicates writes for only non InnoDB
      tables (e.g. writes to MyISAM table(s)). Async slave node, in Galera cluster,
      can apply these writes successfully, but it will, in the end, write gtid position in
      mysql.gtid_slave_pos table. mysql.gtid_slave_pos table is InnoDB engine, and
      this write makes innodb handlerton part of the replicated "transaction".
      Note that wsrep patch identifies that write to gtid_slave_pos should not be replicated
      and skips appending wsrep keys for these writes. However, as InnoDB was present
      in the transaction, and there are replication events (for MyISAM table) in transaction
      cache, but there are no appended keys, wsrep raises an error, and this makes the söave
      thread to stop.
      
      The fix is simply to not treat it as an error if async slave tries to replicate a write
      set with binlog events, but no keys. We just skip wsrep replication and return successfully.
      
      This commit contains also a mtr test which forces mysql.gtid_slave_pos table isto be
      of InnoDB engine, and executes MyISAM only write through asyn replication.
      
      There is additional fix for declaring IO and background slave threads as non wsrep.
      These threads should not write anything for wsrep replication, and this is just a safeguard
      to make sure nothing leaks into cluster from these slave threads.
      38839854
  8. 25 Nov, 2019 1 commit
    • willhan's avatar
      MDEV-17508 Fix bug for spider when using "not like" · 3551cd32
      willhan authored
      fix bug for spider where using "not like" (#890)
      
      test case:
      t1 is a spider engine table;
        CREATE TABLE `t1` (
        `id` int(11) NOT NULL DEFAULT '0',
        `name` char(64) DEFAULT NULL,
        PRIMARY KEY (`id`)
      ) ENGINE=SPIDER
      
      query: "select * from t1 where name  not like 'x%' " would dispatch "select xxx name name like 'x%' " to remote mysqld, is wrong
      3551cd32
  9. 24 Nov, 2019 1 commit
    • Olivier Bertrand's avatar
      These changed were made after pulling 10.2.30 from origin · fb91774e
      Olivier Bertrand authored
      ---------------------------------------------------------
      - Temporarily fix MDEV-13782 by commenting out LIKE_FUNC in CondFilter
        modified:   storage/connect/ha_connect.cc
      
      - Remove use of hack tables
        modified:   storage/connect/connect.cc
        modified:   storage/connect/connect.h
        modified:   storage/connect/ha_connect.cc
        modified:   storage/connect/xtable.h
      fb91774e
  10. 22 Nov, 2019 1 commit
  11. 21 Nov, 2019 6 commits
    • Olivier Bertrand's avatar
    • Olivier Bertrand's avatar
    • Olivier Bertrand's avatar
    • Olivier Bertrand's avatar
      These changed were made after pulling 10.2.30 from origin · 3ad05417
      Olivier Bertrand authored
      ---------------------------------------------------------
      - Temporarily fix MDEV-13782 by commenting out LIKE_FUNC i, CondFilter
        modified:   storage/connect/ha_connect.cc
      
      - Make Rest available for MariaDB binary distributed versions.
        modified:   storage/connect/CMakeLists.txt
      
      - Remove unused declaration
        modified:   storage/connect/filter.h
      3ad05417
    • Eugene Kosov's avatar
      cleanup Linux AIO · d30e51fa
      Eugene Kosov authored
      Replace all io_context* occurrences with io_context_t
      
      Even in release mode die immediately when some io_* functions return
      EINVAL. This always means some programming bug and it's better to fail fast.
      
      LinuxAIOHandler::resubmit(): fix condition. Stop ignoring -1 return code which
      corresponds to EPERM and io_submit() really can return this one.
      
      Use io_destroy() to stop leaking io_context_t.
      
      Make m_aio_ctx std::vector instead of C array. I think that internal check
      for index overflow might be useful.
      
      Add debug assertions for EFAULT because for me receiving it
      looks like a programming bug.
      d30e51fa
    • Eugene Kosov's avatar
      cleanup DBUG · a51f3b09
      Eugene Kosov authored
      DbugParse(): removed mutex lock/unlock which should protect file writes only.
      And no file writes happen in this function.
      
      DbugFlush(): move mutex_unlock out of this method because fflush() doesn't
      need any locking.
      
      Slow stuff like mutex lock/unlock and accessing errno (TLS)
      is moved to a more narrow scope.
      a51f3b09
  12. 20 Nov, 2019 1 commit
  13. 19 Nov, 2019 2 commits