1. 27 Aug, 2008 1 commit
  2. 25 Aug, 2008 1 commit
    • Joerg Bruehe's avatar
      Bug#37098 Get rid of "Installed (but unpackaged)" files in the RPM build · 8a5406a3
      Joerg Bruehe authored
      Mostly, this affected files (programs, scripts, and manual pages)
      which got built during a RPM build but were not listed in the
      appropriate "%files" section of the "spec" file.
      This is fixed now, they are added.
      
      To make this consistent, this patch also makes the build of "innochecksum"
      (and its inclusion in a tar.gz or other package) depend on whether InnoDB
      is configured in the build.
      
      Also, some tools to create Windows packages are irrelevant in any binary
      Unix package (not the sources !), and so they are deleted before packaging.
      
      configure.in:
        To prevent "innochecksum" from getting built even if InnoDB is not configured
        (and then being included in such packages),
        we need an "automake condition" that evaluates whether we have InnoDB.
      extra/Makefile.am:
        Evaluate the new automake condition about having InnoDB,
        and make the build of "innochecksum" depend on it.
      man/Makefile.am:
        Cleanup: There are manual files which we do not need,
        like those about tools for Windows builds / packaging
        (irrelevant in any Unix binary package)
        and about NDB tools which do not get built.
      scripts/make_binary_distribution.sh:
        In any Unix binary package, do not include tools for Windows builds
        (and their manual pages).
        This does not affect source packages, of course.
      support-files/mysql.spec.sh:
        There were several files (binaries, scripts, and manuals)
        which got built with a RPM but never packages,
        add them to the respective RPM.
      8a5406a3
  3. 31 Jul, 2008 2 commits
  4. 30 Jul, 2008 1 commit
    • Georgi Kodinov's avatar
      Bug#37662 nested if() inside sum() is parsed in exponential time · 03805cbb
      Georgi Kodinov authored
            
      min() and max() functions are implemented in MySQL as macros.
      This means that max(a,b) is expanded to: ((a) > (b) ? (a) : (b))
      Note how 'a' is quoted two times.
      Now imagine 'a' is a recursive function call that's several 10s of levels deep.
      And the recursive function does max() with a function arg as well to dive into
      recursion.
      This means that simple function call can take most of the clock time.
      Identified and fixed several such calls to max()/min() : including the IF() 
      sql function implementation.
      
      mysql-test/r/func_if.result:
        Bug#37662 test case
      mysql-test/t/func_if.test:
        Bug#37662 test case
      sql/item.cc:
        Bug#37662 don't call expensive functions as arguments to min/max
      sql/item_cmpfunc.cc:
        Bug#37662 don't call expensive functions as arguments to min/max
      sql/item_func.cc:
        Bug#37662 don't call expensive functions as arguments to min/max
      03805cbb
  5. 29 Jul, 2008 1 commit
  6. 28 Jul, 2008 1 commit
  7. 26 Jul, 2008 1 commit
    • Igor Babaev's avatar
      Fixed bug #38191. · 59229a6b
      Igor Babaev authored
      Calling List<Cached_item>::delete_elements for the same list twice
      caused a crash of the server in the function JOIN::cleaunup.
      Ensured that delete_elements() in JOIN::cleanup would be called only once.
      
      
      mysql-test/r/subselect.result:
        Added a test case for bug #38191.
      mysql-test/t/subselect.test:
        Added a test case for bug #38191.
      sql/sql_select.cc:
        Fixed bug #38191.
        Ensured that delete_elements() in JOIN::cleanup would be called only once.
      59229a6b
  8. 25 Jul, 2008 4 commits
  9. 24 Jul, 2008 5 commits
  10. 23 Jul, 2008 5 commits
    • Sven Sandberg's avatar
      BUG#37733: rpl.rpl_flushlog_loop 'row' fails sporadically on pushbuild · 7aa7c81a
      Sven Sandberg authored
      BUG#37884: rpl_row_basic_2myisam and rpl_row_basic_3innodb fail sporadically in pushbuild
      These have been fixed in 5.1-rpl. Re-applying fix for BUG#37884
      in 5.1-bugteam, and disabling rpl_flushlog_loop for BUG#37733 in
      5.1-bugteam.
      
      
      mysql-test/extra/rpl_tests/rpl_row_basic.test:
        Missing sync_slave_with_master added.
      mysql-test/suite/rpl/t/disabled.def:
        Disabling rpl_flushlog_loop until the fixed version gets
        merged from 5.1-rpl
      7aa7c81a
    • Horst Hunger's avatar
    • Georgi Kodinov's avatar
      Bug#37830 : ORDER BY ASC/DESC - no difference · 5cf6d460
      Georgi Kodinov authored
                        
      Range scan in descending order for c <= <col> <= c type of
      ranges was ignoring the DESC flag.
      However some engines like InnoDB have the primary key parts 
      as a suffix for every secondary key.
      When such primary key suffix is used for ordering ignoring 
      the DESC is not valid.
      But we generally would like to do this because it's faster.
                  
      Fixed by performing only reverse scan if the primary key is used.
      Removed some dead code in the process.
      
      mysql-test/r/innodb_mysql.result:
        Bug#37830 : test case
      mysql-test/t/innodb_mysql.test:
        Bug#37830 : test case
      sql/opt_range.cc:
        Bug#37830 : 
        - preserve and use used_key_parts to
          distinguish when a primary key suffix is used
        - removed some dead code
      sql/opt_range.h:
        Bug#37830 : 
        - preserve used_key_parts
        - dead code removed
      sql/sql_select.cc:
        Bug#37830 : Do only reverse order traversal
        if the primary key suffix is used.
      5cf6d460
    • Horst Hunger's avatar
      dbd9d07d
    • Horst Hunger's avatar
      merge from parent · d9037d41
      Horst Hunger authored
      d9037d41
  11. 22 Jul, 2008 17 commits
  12. 21 Jul, 2008 1 commit