1. 28 Jan, 2008 2 commits
    • unknown's avatar
      Remove spurious commented out test line. · cdc66b12
      unknown authored
      
      mysql-test/t/lock_multi.test:
        Remove spurious test line.
      cdc66b12
    • unknown's avatar
      Bug#30331 Table_locks_waited shows inaccurate values · 3d5e32b2
      unknown authored
      The problem is that the Table_locks_waited was incremented only
      when the lock request succeed. If a thread waiting for the lock
      gets killed or the lock request is aborted, the variable would
      not be incremented, leading to inaccurate values in the variable.
      
      The solution is to increment the Table_locks_waited whenever the
      lock request is queued. This reflects better the intended behavior
      of the variable -- show how many times a lock was waited.
      
      
      mysql-test/r/lock_multi.result:
        Add test case result for Bug#30331
      mysql-test/t/lock_multi.test:
        Add test case for Bug#30331
      mysys/thr_lock.c:
        Increment locks_waited whenever the thread is supposed
        to wait for the lock.
      3d5e32b2
  2. 24 Jan, 2008 4 commits
  3. 23 Jan, 2008 5 commits
    • unknown's avatar
      Manual merge · e63a0501
      unknown authored
      e63a0501
    • unknown's avatar
      Merge lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-33618 · 9d96bb98
      unknown authored
      into  lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.1-33618
      
      
      mysql-test/r/sp-code.result:
        Auto merged
      mysql-test/t/sp-code.test:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sp_rcontext.cc:
        Auto merged
      9d96bb98
    • unknown's avatar
      manual merge · 8430df5a
      unknown authored
      8430df5a
    • unknown's avatar
      Merge malff@bk-internal.mysql.com:/home/bk/mysql-5.0-runtime · e7b65baa
      unknown authored
      into  lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-33618
      
      
      mysql-test/t/sp.test:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      e7b65baa
    • unknown's avatar
      Bug#33618 (Crash in sp_rcontext) · e6a077e3
      unknown authored
      Bug 33983 (Stored Procedures: wrong end <label> syntax is accepted)
      
      The server used to crash when REPEAT or another control instruction
      was used in conjunction with labels and a LEAVE instruction.
      
      The crash was caused by a missing "pop" of handlers or cursors in the
      code representing the stored program. When executing the code in a loop,
      this missing "pop" would result in a stack overflow, corrupting memory.
      
      Code generation has been fixed to produce the missing h_pop/c_pop
      instructions.
      
      Also, the logic checking that labels at the beginning and the end of a
      statement are matched was incorrect, causing Bug 33983.
      End labels, when used, must match the label used at the beginning of a block.
      
      
      mysql-test/r/sp-code.result:
        Bug#33618 (Crash in sp_rcontext)
      mysql-test/r/sp-error.result:
        Bug 33983 (Stored Procedures: wrong end <label> syntax is accepted)
      mysql-test/r/sp.result:
        Bug#33618 (Crash in sp_rcontext)
      mysql-test/t/sp-code.test:
        Bug#33618 (Crash in sp_rcontext)
      mysql-test/t/sp-error.test:
        Bug 33983 (Stored Procedures: wrong end <label> syntax is accepted)
      mysql-test/t/sp.test:
        Bug#33618 (Crash in sp_rcontext)
      sql/sp_head.cc:
        Bug#33618 (Crash in sp_rcontext)
      sql/sp_head.h:
        Bug#33618 (Crash in sp_rcontext)
      sql/sp_rcontext.cc:
        Bug#33618 (Crash in sp_rcontext)
      sql/sp_rcontext.h:
        Bug#33618 (Crash in sp_rcontext)
      sql/sql_yacc.yy:
        Bug#33618 (Crash in sp_rcontext)
      e6a077e3
  4. 20 Jan, 2008 2 commits
  5. 19 Jan, 2008 7 commits
    • unknown's avatar
      Fix merge. · fca38dd7
      unknown authored
      fca38dd7
    • unknown's avatar
      Merge ibm.:/home/alik/Documents/MySQL/devel/5.0-rt · 6e142eeb
      unknown authored
      into  ibm.:/home/alik/Documents/MySQL/devel/5.1-rt-merged-5.0-rt
      
      
      mysql-test/t/sp.test:
        Manually merged.
      6e142eeb
    • unknown's avatar
      Merge ibm.:/home/alik/Documents/MySQL/devel/5.1 · b9ec8f6a
      unknown authored
      into  ibm.:/home/alik/Documents/MySQL/devel/5.1-rt-merged-5.1
      
      
      configure.in:
        Auto merged
      client/mysqldump.c:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/unireg.cc:
        Auto merged
      b9ec8f6a
    • unknown's avatar
      Post-merge fixes. · 80857e0d
      unknown authored
      
      mysql-test/r/group_by.result:
        Post-merge fix after merging 5.0-opt to 5.1-opt.
      mysql-test/t/disabled.def:
        Disabled innodb_mysql back, bug #32724 is still not fixed.
      80857e0d
    • unknown's avatar
      Merge ibm.:/home/alik/Documents/MySQL/devel/5.0 · 5410627b
      unknown authored
      into  ibm.:/home/alik/Documents/MySQL/devel/5.0-rt-merged-5.0
      
      
      5410627b
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · 153771ed
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/group_by.result:
        Auto merged
      mysql-test/r/type_decimal.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/type_decimal.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/subselect.result:
        Manual merge.
      mysql-test/t/group_by.test:
        Manual merge.
      mysql-test/t/subselect.test:
        Manual merge.
      mysql-test/t/view.test:
        Manual merge.
      153771ed
    • unknown's avatar
      Raise version number after cloning 5.1.23-rc · 37ff91b3
      unknown authored
      37ff91b3
  6. 18 Jan, 2008 2 commits
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 35b035cf
      unknown authored
      into  lamia.dupka:/home/mhansson/my50-bug33143-again-pushee
      
      
      35b035cf
    • unknown's avatar
      BUG#33794 "MySQL crashes executing specific query": · c71a6428
      unknown authored
      The problem occurred when one had a subquery that had an equality X=Y where 
      Y referred to a named select list expression from the parent select. MySQL 
      crashed when trying to use the X=Y equality for ref-based access. 
      
      Fixed by allowing non-Item_field items in the described case.
      
      
      mysql-test/r/subselect.result:
        BUG#33794 "MySQL crashes executing specific query"
        - Testcase
      mysql-test/t/subselect.test:
        BUG#33794 "MySQL crashes executing specific query"
        - Testcase
      sql/sql_select.cc:
        BUG#33794 "MySQL crashes executing specific query"
        get_store_key() assumed that if it got a reference
          t.key=Item_outer_ref(Item_direct_ref(x)) 
        then x was an Item_field object, which is not the case when one refers to a
        named select list expression out ot subquery.
      c71a6428
  7. 17 Jan, 2008 3 commits
  8. 16 Jan, 2008 1 commit
    • unknown's avatar
      A minor cleanup. · bab13c89
      unknown authored
      
      sql/sql_insert.cc:
        Remove a redundant call to my_error() -- in case of out of memory, the error
        is reported already by operator new (Delayed_inserts inherits from ilink).
      bab13c89
  9. 14 Jan, 2008 1 commit
    • unknown's avatar
      Bug#33143: Incorrect ORDER BY for ROUND()/TRUNCATE() result · f9440588
      unknown authored
      The ROUND(X, D) function would change the Item::decimals field during
      execution to achieve the effect of a dynamic number of decimal digits.
      This caused a series of bugs:
      Bug #30617:Round() function not working under some circumstances in InnoDB
      Bug #33402:ROUND with decimal and non-constant cannot round to 0 decimal places
      Bug #30889:filesort and order by with float/numeric crashes server
      Fixed by never changing the number of shown digits for DECIMAL when
      used with a nonconstant number of decimal digits.
      
      
      mysql-test/r/type_decimal.result:
        Bug#33143: Test result
      mysql-test/t/type_decimal.test:
        Bug#33143: Test case
      sql/item_func.cc:
        Bug#33143: 
        - Moved the DECIMAL_MAX_SCALE limitation to fix_length_and_dec.
        - Removed resetting of Item::decimals field.
        - set the frac field of the output value to current scale.
      strings/decimal.c:
        Bug#33143: It is necessary to set all digits in the buffer following the 
        rounded one to zero, as they may now be displayed.
      f9440588
  10. 12 Jan, 2008 1 commit
  11. 11 Jan, 2008 12 commits
    • unknown's avatar
      Post merge fix for BUG 33728 · 7e93d048
      unknown authored
      
      include/Makefile.am:
        Include gcc_builtins.h header in the list.
      7e93d048
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 783b6070
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-runtime
      
      
      783b6070
    • unknown's avatar
      Bug#33728 Atomic builtins · 26af3c7e
      unknown authored
      Use compiler provided atomic builtins as a 'backend' for
      MySQL's atomic primitives. The builtins are available on
      a handful of platforms and compilers.
      
      
      configure.in:
        Check if the compiler provides atomic builtins and
        that __sync_lock_test_and_set stores the correct value.
      include/atomic/nolock.h:
        Use the atomic builtins if available.
      include/atomic/gcc_builtins.h:
        Implement the atomic ADD, SWAP, CAS, STORE (or operation
        optimized away) and LOAD primitives using atomic builtins
        provided by the compiler.
      26af3c7e
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · a034c714
      unknown authored
      into  lamia.dupka:/home/mhansson/my51-bug31797-pushee
      
      
      a034c714
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.1-opt · c37689f1
      unknown authored
      into  linux-st28.site:/home/martin/mysql/src/bug31797/my51-bug31797-pushee
      
      
      mysql-test/r/group_by.result:
        Auto merged
      mysql-test/t/group_by.test:
        Auto merged
      sql/item.cc:
        Auto merged
      c37689f1
    • unknown's avatar
      Merge linux-st28.site:/home/martin/mysql/src/bug31797/my50-bug31797 · ab0f3e46
      unknown authored
      into  linux-st28.site:/home/martin/mysql/src/bug31797/my51-bug31797
      
      
      sql/item.cc:
        Auto merged
      mysql-test/r/group_by.result:
        Bug#31797: Manual merge
      mysql-test/t/group_by.test:
        Bug#31797: Manual merge
      ab0f3e46
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.1-opt · 4ddfa7ba
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.1-opt-bug33697
      
      
      mysql-test/t/disabled.def:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      4ddfa7ba
    • unknown's avatar
      Fixed bug #33697. · d8363a40
      unknown authored
      When the function test_if_skip_sort_order prefers index backward scan 
      to ref access the corresponding access functions must be set accordingly.
      
      
      mysql-test/include/mix1.inc:
        Added a test case for bug #33697.
        Corrected one previous bad merge.
      mysql-test/r/innodb_mysql.result:
        Added a test case for bug #33697.
      mysql-test/t/disabled.def:
        Turned innodb_mysql test on.
      d8363a40
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.0-opt · 7bd7e988
      unknown authored
      into  linux-st28.site:/home/martin/mysql/src/bug31797/my50-bug31797-pushee
      
      
      sql/item.cc:
        Auto merged
      mysql-test/r/group_by.result:
        Bug#31797: Manual merge
      mysql-test/t/group_by.test:
        Bug#31797: Manual merge
      7bd7e988
    • unknown's avatar
      Bug#31797: error while parsing subqueries -- WHERE is parsed as HAVING · df8e9fc2
      unknown authored
      The name resolution for correlated subqueries and HAVING clauses
      failed to distinguish which of two was being performed when there 
      was a reference to an outer aliased field.
      Fixed by adding the condition that HAVING clause name resulotion
      is being performed.
      
      
      mysql-test/r/group_by.result:
        Bug#31797: Test result
      mysql-test/t/group_by.test:
        Bug#31797: Test case
      sql/item.cc:
        Bug#31797: 
        Corrected function comment.
        The fix, raising the error is restricted to HAVING name resolution.
      df8e9fc2
    • unknown's avatar
      Merge host.loc:/home/uchum/work/5.1-opt-33699 · d52a1a14
      unknown authored
      into  host.loc:/home/uchum/work/5.1-opt
      
      
      mysql-test/extra/rpl_tests/rpl_extraMaster_Col.test:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      mysql-test/suite/rpl/r/rpl_extraColmaster_innodb.result:
        Merge with local tree (bug#33699).
      mysql-test/suite/rpl/r/rpl_extraColmaster_myisam.result:
        Merge with local tree (bug#33699).
      d52a1a14
    • unknown's avatar
      Bug#29477: Not all fields of the target table were checked to have a default · 72ebb0aa
      unknown authored
      value when inserting into a view.
      
      The mysql_prepare_insert function checks all fields of the target table that
      directly or indirectly (through a view) are specified in the INSERT
      statement to have a default value. This check can be skipped if the INSERT
      statement doesn't mention any insert fields. In case of a view this allows
      fields that aren't mentioned in the view to bypass the check.
      
      Now fields of the target table are always checked to have a default value
      when insert goes into a view.
      
      
      mysql-test/t/view.test:
        Added a test case for the bug#29477: Not all fields of the target table were 
        checked to have a default value when inserting into a view.
      mysql-test/r/view.result:
        Added a test case for the bug#29477: Not all fields of the target table were 
        checked to have a default value when inserting into a view.
      sql/sql_insert.cc:
        Bug#29477: Not all fields of the target table were checked to have a default
        value when inserting into a view.
        Now fields of the target table are always checked to have a default value
        when insert goes into a view.
      72ebb0aa