1. 19 Apr, 2007 1 commit
    • unknown's avatar
      corrrection of test case · cf63c505
      unknown authored
      
      mysql-test/r/ndb_binlog_ddl_multi.result:
        corrrection of test case
        (this was actually a bug that had not been spotted, that was fixed by previous patch)
      cf63c505
  2. 18 Apr, 2007 4 commits
    • unknown's avatar
      revert back to old show_binlog_events asto many test failures, and create a... · 4cb86e6e
      unknown authored
      revert back to old show_binlog_events asto many test failures, and create a show_binlog_events2 instead
      
      
      BitKeeper/etc/ignore:
        Added client/log_event_old.cc client/log_event_old.h client/rpl_record_old.cc client/rpl_record_old.h libmysqld/log_event_old.cc libmysqld/rpl_record.cc libmysqld/rpl_record_old.cc to the ignore list
      mysql-test/include/show_binlog_events2.inc:
        New BitKeeper file ``mysql-test/include/show_binlog_events2.inc''
      4cb86e6e
    • unknown's avatar
      Bug #27076 · 852bac88
      unknown authored
       - test case
      
      
      sql/ha_ndbcluster_binlog.cc:
        drop table not logged when it should
      mysql-test/r/ndb_binlog_log_bin.result:
        New BitKeeper file ``mysql-test/r/ndb_binlog_log_bin.result''
      mysql-test/t/ndb_binlog_log_bin.test:
        New BitKeeper file ``mysql-test/t/ndb_binlog_log_bin.test''
      852bac88
    • unknown's avatar
      Bug #27076 Cluster does not honor SQL_LOG_BIN flag · ca564999
      unknown authored
      - both for data schema operations
      - also make sure schema events vet the right server id when injected into the binlog
      - use same mechanism to signal server_id in bug#17095, and reserve some "id's" for flagging special conditions on the event, in this case do not log it
      - enable printing of server ids in the testcases to show that we cot it right
      
      
      ca564999
    • unknown's avatar
      Bug#17095 circular replication · b895ed4c
      unknown authored
      - make sure any value is set for linked operations as well, e.g. blob tables
      
      
      b895ed4c
  3. 17 Apr, 2007 2 commits
  4. 16 Apr, 2007 2 commits
  5. 13 Apr, 2007 17 commits
    • unknown's avatar
      Fixes to make it compile when using Sun CC and restoring some changes · a8bcc697
      unknown authored
      done in previous patches.
      
      There is an error in the Sun CC compiler that treats parameters that
      differ in only qualifier as different, even though this is not
      allowed by the standard (ISO/IEC 14882:2003, Section 13.1).
      
      
      sql/log_event.cc:
        Removing const qualifier since it causes linker error.
      sql/log_event.h:
        Restoring time_t instead of my_time_t since it causes warnings
        elsewhere.  Renaming parameters to functions since they hide
        member variable (which causes warnings on Sun CC).
      sql/rpl_record.cc:
        Removing const qualifier since it causes linker error.
      sql/rpl_rli.cc:
        Restoring time_t instead of my_time_t since it causes warnings
        elsewhere. Removing const qualifier since it causes linker error.
      sql/rpl_rli.h:
        Restoring time_t instead of my_time_t since it causes warnings
        elsewhere. Removing const qualifier since it causes linker error.
      a8bcc697
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · 461608cc
      unknown authored
      into  capulet.net:/home/bk/mysql-5.1-rpl
      
      
      461608cc
    • unknown's avatar
      Yet another time_t fix. · 61aaf48d
      unknown authored
      
      sql/log_event.h:
        Changing time_t to my_time_t.
      61aaf48d
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · 1540b7f4
      unknown authored
      into  capulet.net:/home/bk/mysql-5.1-rpl
      
      
      1540b7f4
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.1-rpl · 3bea3620
      unknown authored
      into  romeo.(none):/home/bk/b27779-mysql-5.1-rpl
      
      
      3bea3620
    • unknown's avatar
      Fixing portability problem by using my_time_t instead of time_t. · bb35cd04
      unknown authored
      
      sql/slave.cc:
        Using my_time_t instead of time_t.
      bb35cd04
    • unknown's avatar
      WL#2735: Refactor replication · 0d3f926a
      unknown authored
      Factoring out pack_row() and unpack_row() into new files
      rpl_record.{cc,h}.
      
      
      libmysqld/Makefile.am:
        Adding file rpl_record.cc
      sql/CMakeLists.txt:
        Adding file rpl_record.cc
      sql/Makefile.am:
        Adding file rpl_record.cc and rpl_record.h
      sql/log_event.cc:
        Moving implementation of unpack_row() into "rpl_record.cc".
        Adding inclusion of header file "rpl_record.h".
      sql/log_event_old.cc:
        Signature of do_prepare_row() changed.
      sql/log_event_old.h:
        Adding copyright.
      sql/rpl_record_old.cc:
        Signature of do_prepare_row() changed.
      sql/rpl_record_old.h:
        Adding copyright.
        Signature of do_prepare_row() changed.
      sql/sql_class.cc:
        Moving implementation THD::pack_row() into "rpl_record.cc" and rewriting
        it to be a global function.
        Adding inclusion of header file "rpl_record.h".
      sql/sql_class.h:
        Removing pack_row() as THD member function.
      sql/rpl_record.cc:
        New BitKeeper file ``sql/rpl_record.cc''
      sql/rpl_record.h:
        New BitKeeper file ``sql/rpl_record.h''
      0d3f926a
    • unknown's avatar
      BUG#17095 (Cluster RBR in circle does not terminate): · dc125bb3
      unknown authored
      Updating result files with wrong server id for BEGIN and COMMIT
      events.
      
      
      mysql-test/r/rpl_ndb_log.result:
        Result mismatch.
      dc125bb3
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · 9d38af2c
      unknown authored
      into  capulet.net:/home/bk/mysql-5.1-rpl
      
      
      9d38af2c
    • unknown's avatar
      Fixing compile problem on some platforms resulting from building a · 5ca905a6
      unknown authored
      configuration with HAVE_REPLICATION undefined, which causes the
      *_rows_log_event_old classes to only have a default constructor. This
      generates an error on some platforms, since the base classes does 
      not have a default constructor defined.
      
      Updating signatures of do_prepare_row() for classes above, since
      signatures in base classes changed.
      
      
      sql/log_event_old.h:
        Adding constructor since when HAVE_REPLICATION is not defined, the
        class will not have any constructor, which generates an error on
        some platforms.  Updating signature of do_prepare_row() since
        signature changed in base classes.
      5ca905a6
    • unknown's avatar
      Fixing portability issues regarding use of time_t. · d54c905f
      unknown authored
      
      sql/rpl_rli.cc:
        Changing signature for stmt_done() to use my_time_t instead of time_t.
      sql/rpl_rli.h:
        Changing signature for stmt_done() to use my_time_t instead of time_t.
        Changing last_master_timestamp to use my_time_t instead of time_t.
      d54c905f
    • unknown's avatar
      Fixing result file · c301a05e
      unknown authored
      
      mysql-test/r/rpl_ndb_circular_simplex.result:
        Result change
      c301a05e
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · bf065810
      unknown authored
      into  romeo.(none):/home/bkroot/mysql-5.1-rpl
      
      
      bf065810
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.1-rpl · 337031f1
      unknown authored
      into  romeo.(none):/home/bk/b27779-mysql-5.1-rpl
      
      
      sql/log_event.cc:
        Auto merged
      sql/log_event.h:
        Auto merged
      337031f1
    • unknown's avatar
      Merge mysql.com:/home/bar/mysql-5.0.b20095 · d8cb1181
      unknown authored
      into  mysql.com:/home/bar/mysql-5.1-new-rpl
      
      
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      sql/field_conv.cc:
        Auto merged
      d8cb1181
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · 40dc6be6
      unknown authored
      into  mysql.com:/home/bar/mysql-5.0.b20095
      
      
      40dc6be6
    • unknown's avatar
      Bug#20095 Changing length of VARCHAR field with UTF8 collation does not truncate values · 2a4ab288
      unknown authored
      Problem: single byte do_varstring1() function was called, which didn't
      check limit on "number of character", and checked only "number of bytes".
      Fix: adding a multi-byte aware function do_varstring1_mb(),
      to limit on "number of characters"
      
      
      mysql-test/r/ctype_utf8.result:
        Adding test case
      mysql-test/t/ctype_utf8.test:
        Adding test case
      sql/field_conv.cc:
        Adding missing function to copy VARCHAR strings
        having one length byte.
      2a4ab288
  6. 12 Apr, 2007 13 commits
    • unknown's avatar
      remove warning · 83f394c7
      unknown authored
      83f394c7
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · 5256b5f3
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-new-rpl
      
      
      5256b5f3
    • unknown's avatar
      Bug#17095 circular replication for ndb · f3d010f7
      unknown authored
      - test case
      - reset server id in injector
      
      
      client/mysqltest.c:
        save master pos for ndb should look at handled epoch instead of applied
      sql/rpl_injector.cc:
        Bug#17095 circular replication for ndb
        - reset server id in injector
      mysql-test/r/rpl_ndb_circular.result:
        New BitKeeper file ``mysql-test/r/rpl_ndb_circular.result''
      mysql-test/t/rpl_ndb_circular.test:
        New BitKeeper file ``mysql-test/t/rpl_ndb_circular.test''
      f3d010f7
    • unknown's avatar
      BUG#27779 (Slave cannot read old rows log events): · 5c35b417
      unknown authored
      Taking code from before BUG#22583 and incorporating as events to be able
      to read old events. Also incorporating old pack and unpack functions
      into patch.
      
      
      client/Makefile.am:
        Adding files log_event_old.{h,cc} and rpl_record_old.{h,cc}
      client/mysqlbinlog.cc:
        Adding log_event_old.cc.
      libmysqld/Makefile.am:
        Adding files log_event_old.{h,cc} and rpl_record_old.{h,cc}
      sql/CMakeLists.txt:
        Adding files log_event_old.{h,cc} and rpl_record_old.{h,cc}
      sql/Makefile.am:
        Adding files log_event_old.{h,cc} and rpl_record_old.{h,cc}
      sql/log_event.cc:
        Adding code to read pre-GA rows events.
      sql/log_event.h:
        Refactoring to support inheritance and including "old" events definitions.
      sql/log_event_old.cc:
        New BitKeeper file ``sql/log_event_old.cc''
      sql/log_event_old.h:
        New BitKeeper file ``sql/log_event_old.h''
      sql/rpl_record_old.cc:
        New BitKeeper file ``sql/rpl_record_old.cc''
      sql/rpl_record_old.h:
        New BitKeeper file ``sql/rpl_record_old.h''
      5c35b417
    • unknown's avatar
      BUG#25688 (RBR: circular replication may cause STMT_END_F flags to · 89bceacb
      unknown authored
      be skipped):
      
      Fixing test since a replace assumed that we were on slave when we were
      on master.
      
      
      mysql-test/r/rpl_ndb_circular_simplex.result:
        Result file change
      mysql-test/t/rpl_ndb_circular_simplex.test:
        Incorrectly used MASTER_PORT instead of SLAVE_PORT for test. (This is
        circular replication, you know. The roles of slave and master is kind
        of blurred. Mea culpa.)
      89bceacb
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · 11fa402d
      unknown authored
      into  capulet.net:/home/bk/mysql-5.1-rpl
      
      
      11fa402d
    • unknown's avatar
      Adding build file for Solaris on AMD64 · 6dcd6aae
      unknown authored
      
      BUILD/compile-solaris-amd64:
        New BitKeeper file ``BUILD/compile-solaris-amd64''
      6dcd6aae
    • unknown's avatar
      BUG#25688 (RBR: circular replication may cause STMT_END_F flags to be · e36bbbef
      unknown authored
      skipped):
      
      Post-merge changes.
      
      
      sql/ha_ndbcluster.cc:
        Adding missing include file.
      e36bbbef
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.1-new-rpl · 955cbc3a
      unknown authored
      into  romeo.(none):/home/bk/b25688-mysql-5.1-rpl
      
      
      sql/item_func.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/repl_failsafe.cc:
        Auto merged
      sql/rpl_mi.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      955cbc3a
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · 8baded90
      unknown authored
      into  romeo.(none):/home/bkroot/mysql-5.1-rpl
      
      
      sql/mysqld.cc:
        Auto merged
      8baded90
    • unknown's avatar
      BUG#25688 (RBR: circular replication may cause STMT_END_F flags to be · 6ed9fc6b
      unknown authored
      skipped):
      
      By moving statement end actions from Rows_log_event::do_apply_event() to
      Rows_log_event::do_update_pos() they will always be executed, even if
      Rows_log_event::do_apply_event() is skipped because the event originated
      at the same server. This because Rows_log_event::do_update_pos() is always
      executed (unless Rows_log_event::do_apply_event() failed with an error,
      in which case the slave stops with an error anyway). 
      
      Adding test case.
      
      Fixing logic to detect if inside a group. If a rotate event occured
      when an initial prefix of events for a statement, but for which the
      table did contain a key, last_event_start_time is set to zero, causing
      rotate to end the group but without unlocking any tables. This left a
      lock hanging around, which subsequently triggered an assertion when a
      second attempt was made to lock the same sequence of tables.
      
      In order to solve the above problem, a new flag was added to the relay
      log info structure that is used to indicate that the replication thread
      is currently executing a statement. Using this flag, the replication
      thread is in a group if it is either in a statement or inside a trans-
      action.
      
      The patch also eliminates some gratuitous header file inclusions that
      were not needed (and caused compile errors) and replaced them with
      forward definitions.
      
      
      sql/item_func.cc:
        Including definition of MASTER_INFO.
      sql/log.cc:
        Including definition of RELAY_LOG_INFO since it is used in the file.
      sql/log_event.cc:
        Moving statement end actions from Rows_log_event::do_apply_event() to
        Rows_log_event::do_update_pos().
        Factoring out code to update group positions and event positions into
        relay log info structure.
        ---
        Adding debugging printouts.
        Fixing logic to detect if inside a group.
      sql/log_event.h:
        Adding Rows_log_event::do_update_pos().
      sql/mysqld.cc:
        Including definition of MASTER_INFO.
      sql/repl_failsafe.cc:
        Including definition of MASTER_INFO.
      sql/rpl_mi.h:
        Including definition of RELAY_LOG_INFO since it is used in the file.
      sql/rpl_rli.cc:
        Adding member function stmt_done() to do after-statement updates of the
        relay log info structure.
      sql/rpl_rli.h:
        Adding member function stmt_done() to do after-statement updates of the
        relay log info structure.
      sql/set_var.cc:
        Including definition of MASTER_INFO.
      sql/slave.cc:
        Adding debuging printouts.
      sql/slave.h:
        Removing inclusion definitions of MASTER_INFO and RELAY_LOG_INFO and
        replacing them with forward declarations since the classes are not
        used in the file. The gratuitous inclusion lead to compile errors in
        the two classes above in files that used neither.
      sql/sql_binlog.cc:
        Including definition of RELAY_LOG_INFO since it is used in the file.
      sql/sql_class.cc:
        Including definition of RELAY_LOG_INFO since it is used in the file.
      sql/sql_class.h:
        Removing inclusion definitions of RELAY_LOG_INFO and replacing it
        with forward declaration since the class is not used in the file.
        The gratuitous inclusion lead to compile errors in the class above
        in files didn't use the class.
      sql/sql_insert.cc:
        Including definition of MASTER_INFO.
      sql/sql_repl.cc:
        Including definition of MASTER_INFO.
      mysql-test/r/rpl_ndb_circular_simplex.result:
        New BitKeeper file ``mysql-test/r/rpl_ndb_circular_simplex.result''
      mysql-test/t/rpl_ndb_circular_simplex.test:
        New BitKeeper file ``mysql-test/t/rpl_ndb_circular_simplex.test''
      6ed9fc6b
    • unknown's avatar
      Merge mysql.com:/home/bar/mysql-5.0-rpl · 6277365f
      unknown authored
      into  mysql.com:/home/bar/mysql-5.1-new-rpl
      
      
      sql/mysqld.cc:
        Auto merged
      6277365f
    • unknown's avatar
      mysqld.cc: · 1992907b
      unknown authored
        Removing wrong MYF(0) argument.
      
      
      sql/mysqld.cc:
        Removing wrong MYF(0) argument.
      1992907b
  7. 11 Apr, 2007 1 commit