1. 27 Jun, 2007 5 commits
  2. 26 Jun, 2007 5 commits
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/50 · 37ca9982
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      37ca9982
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · a66c8c67
      unknown authored
      into  amd64.(none):/src/bug24732/my50-bug24732
      
      a66c8c67
    • unknown's avatar
      Bug#24732 Executables do not include Vista manifests · eb9feac9
      unknown authored
      - Corrected manifest attributes.
      
      
      CMakeLists.txt:
        Bug#24732 Executables do not include Vista manifests
        - Use correct value for 64 built binaries.
      win/create_manifest.js:
        Bug#24732 Executables do not include Vista manifests
        - Remove type attribute as the only valid value is win32.
      win/mysql_manifest.cmake:
        Bug#24732 Executables do not include Vista manifests
        - Remove type attribute.
      eb9feac9
    • unknown's avatar
      Bug#25657 mysql-test-run.pl kill itself under ActiveState perl · 6f90aa2c
      unknown authored
       - Various fixes for running mysql-test-run.pl on ActiveState perl
         for windows. Reading it's source in win32/win32.c helps...
      
      
      mysql-test/lib/mtr_process.pl:
        Use "real_pid" when killing the process on ActiveState perl for windows
        Wait blocking for the pseudo pid to exit.
        Change "sleep_until_file_created" to return 1 when pidfile has been
        created - this should avoid early wakeup if $pid was 0
      mysql-test/lib/mtr_timer.pl:
        Wake timer process with signal 15 to avoid to avoid resource leak
        on ActiveState perl for windows.
        Install signal handler in timer process to  exit gracefully
      mysql-test/mysql-test-run.pl:
        Read "real_pid" of process from pid_file - to be used when killing the
        process on ActiveState perl
        Drop the --console option to mysqld
        Pass "real_pid" to mtr_check_stop_server so it can select to use it
        Correct two argument declarations
      6f90aa2c
    • unknown's avatar
      Merge pilot.(none):/data/msvensson/mysql/mysql-5.0-maint · 924e64e3
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/bug25657/my50-bug25657-new2
      
      924e64e3
  3. 25 Jun, 2007 5 commits
    • unknown's avatar
      Bug#22540: Incorrect value in column End_log_pos of SHOW BINLOG EVENTS using InnoDB · 86cad7de
      unknown authored
      end_log_pos data within a transaction are relative to
      the start of the transaction rather than absolute.
      we fix those groups in situ before writing the log out.
      
      additional comments and handling for groups with very
      large single events, as suggested by Guilhem.
      
      86cad7de
    • unknown's avatar
      Bug #22540: Incorrect value in column End_log_pos of SHOW BINLOG EVENTS using InnoDB · b3b0fb2c
      unknown authored
      fix binlog-writing so that end_log_pos is given correctly even
      within transactions for both SHOW BINLOG and SHOW MASTER STATUS,
      that is as absolute values (from log start) rather than relative
      values (from transaction's start).
      ---
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint
      into  sin.intern.azundris.com:/home/tnurnberg/22540/50-22540
      
      
      mysql-test/r/binlog.result:
        Bug #22540: Incorrect value in column End_log_pos of SHOW BINLOG EVENTS using InnoDB
        
        show that end_log_pos in SHOW BINLOG EVENTS is correct even in transactions.
        show that SHOW MASTER STATUS returns correct values while in transactions
        (so that mysqldump --master-data will work correctly).
        also remove bdb dependency.
        ---
        manual merge
      mysql-test/t/binlog.test:
        Bug #22540: Incorrect value in column End_log_pos of SHOW BINLOG EVENTS using InnoDB
        
        show that end_log_pos in SHOW BINLOG EVENTS is correct even in transactions.
        show that SHOW MASTER STATUS returns correct values while in transactions
        (so that mysqldump --master-data will work correctly).
        also remove bdb dependency.
      sql/log.cc:
        Bug #22540: Incorrect value in column End_log_pos of SHOW BINLOG EVENTS using InnoDB
        
        fix output for SHOW BINLOG EVENTS so that end_log_pos is given correctly
        even within transactions. do this by rewriting the commit-buffer in place.
      b3b0fb2c
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1-opt · 30f5af6f
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      30f5af6f
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0 · 4380493d
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      4380493d
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1 · 7d8a30f5
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/4.1-opt
      
      7d8a30f5
  4. 24 Jun, 2007 3 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 683a1119
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug25602
      
      
      sql/sql_select.cc:
        Auto merged
      683a1119
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0 · 98646c96
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      sql/log_event.cc:
        Auto merged
      98646c96
    • unknown's avatar
      Fixed bug #25602. A query with DISTINCT in the select list to which · 09e2b603
      unknown authored
      the loose scan optimization for grouping queries was applied returned 
      a wrong result set when the query was used with the SQL_BIG_RESULT
      option.
      
      The SQL_BIG_RESULT option forces to use sorting algorithm for grouping
      queries instead of employing a suitable index. The current loose scan
      optimization is applied only for one table queries when the suitable
      index is covering. It does not make sense to use sort algorithm in this
      case. However the create_sort_index function does not take into account
      the possible choice of the loose scan to implement the DISTINCT operator
      which makes sorting unnecessary. Moreover the current implementation of
      the loose scan for queries with distinct assumes that sorting will
      never happen. Thus in this case create_sort_index should not call
      the function filesort.
      
      
      mysql-test/r/group_min_max.result:
        Added a test case for bug #25602.
      mysql-test/t/group_min_max.test:
        Added a test case for bug #25602.
      09e2b603
  5. 23 Jun, 2007 5 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1-opt · 6688a54f
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      6688a54f
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29095 · e45576ac
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      e45576ac
    • unknown's avatar
      Fixed bug #29095. · e7778b65
      unknown authored
      INSERT into table from SELECT from the same table
      with ORDER BY and LIMIT was inserting other data
      than sole SELECT ... ORDER BY ... LIMIT returns.
      
      One part of the patch for bug #9676 improperly pushed
      LIMIT to temporary table in the presence of the ORDER BY
      clause.
      That part has been removed.
      
      
      sql/sql_select.cc:
        Fixed bug #29095.
        One part of the patch for bug #9676 improperly pushed
        LIMIT to temporary table in the presence of the ORDER BY
        clause.
        That part has been removed.
      mysql-test/t/insert_select.test:
        Expanded the test case for bug #9676.
        Created a test case for bug #29095.
      mysql-test/r/insert_select.result:
        Expanded the test case for bug #9676.
        Created a test case for bug #29095.
      e7778b65
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · fc840a57
      unknown authored
      into  mysql.com:/home/ram/work/b29079/b29079.5.0
      
      fc840a57
    • unknown's avatar
      Merge mysql.com:/home/ram/work/b29079/b29079.4.1 · 56576d9a
      unknown authored
      into  mysql.com:/home/ram/work/b29079/b29079.5.0
      
      
      include/my_global.h:
        Auto merged
      56576d9a
  6. 22 Jun, 2007 10 commits
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 77825106
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      77825106
    • unknown's avatar
      Add the "nist" suite to the "test-bt" target, · 21905996
      unknown authored
      to be run only if it is available on the machine.
      
      21905996
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 9f368072
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28400-5.0-opt
      
      9f368072
    • unknown's avatar
      Bug #27383: Crash in test "mysql_client_test" · 0200ffc7
      unknown authored
      The C optimizer may decide that data access operations
      through pointer of different type are not related to 
      the original data (strict aliasing).
      This is what happens in fetch_long_with_conversion(),
      when called as part of mysql_stmt_fetch() : it tries 
      to check for truncation errors by first storing float
      (and other types of data) into a char * buffer and then 
      accesses them through a float pointer.
      This is done to prevent the effects of excess precision
      when using FPU registers.
      However the doublestore() macro converts a double pointer
      to an union pointer. This violates the strict aliasing rule.
      Fixed by making the intermediary variables volatile (
      to not re-introduce the excess precision bug) and using
      the intermediary value instead of the char * buffer.
      Note that there can be loss of precision for both signed
      and unsigned 64 bit integers converted to double and back,
      so the check must stay there (even for compatibility 
      reasons).
      Based on the excellent analysis in bug 28400.
      
      
      libmysql/libmysql.c:
        Bug #27383: avoid pointer aliasing problems while 
        not re-violating the Intel FPU gcc bug.
      0200ffc7
    • unknown's avatar
      Fix for bug #29079: Semantics of "bigint" depend on platform specifics (size, signedness of char ?) · 2960b680
      unknown authored
      Problem: long and long long types mess in a comparison may lead to wrong results on some platforms.
      Fix: prefer [unsigned] long long as [u]longlong as it's used unconditionally in many places.
      
      
      include/my_global.h:
        Fix for bug #29079: Semantics of "bigint" depend on platform specifics (size, signedness of char ?)
          - use [unsigned] long long as [u]longlong if sizeof(long long) == 8, to avoid type mess,
            as we use [unsigned] long long unconditionally in many places, for example in constants 
            with [U]LL suffix.
      2960b680
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 49dcd6ec
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      49dcd6ec
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 3300b8eb
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      3300b8eb
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 0adc47a6
      unknown authored
      into  mysql.com:/home/hf/work/28839/my50-28839
      
      0adc47a6
    • unknown's avatar
      rpl_skip_error.test fixed · d58aeec1
      unknown authored
      
      mysql-test/r/rpl_skip_error.result:
        test result fixed
      mysql-test/t/rpl_skip_error.test:
        inconsistent column results hidden
      d58aeec1
    • unknown's avatar
      Bug #29138 'kill' fails in pushbuild · 86ae7940
      unknown authored
      The reason the "reap;" succeeds unexpectedly is because the query was completing(almost always) and the network buffer was big enough to store the query result (sometimes) on Windows, meaning the response was completely sent before the server thread could be killed.
      
      Therefore we use a much longer running query that doesn't have a chance to fully complete before the reap happens, testing the kill properly.
      
      
      mysql-test/r/kill.result:
        We use a much longer running query that doesn't have a chance to fully complete before the reap happens.
      mysql-test/t/kill.test:
        We use a much longer running query that doesn't have a chance to fully complete before the reap happens.
      86ae7940
  7. 21 Jun, 2007 7 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · c0cc2fee
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug29104
      
      
      sql/item.cc:
        Auto merged
      c0cc2fee
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/maint/41 · 839c07db
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      839c07db
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · 6367bd2a
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      
      mysql-test/t/innodb.test:
        Auto merged
      mysql-test/r/innodb.result:
        Manual merge
      6367bd2a
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1-rpl · 42247162
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/41
      
      42247162
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · d3662296
      unknown authored
      into  amd64.(none):/src/bug27029/my50-bug27029
      
      
      myisam/sort.c:
        Auto merged
      d3662296
    • unknown's avatar
      Bug#27029 alter table ... enable keys crashes mysqld on large table · 8d27f335
      unknown authored
      - When creating an index for the sort, the number of rows plus 1 is used 
      to allocate a buffer.  In this test case, the number of rows 4294967295 
      is the max value of an unsigned integer, so when 1 was added to it, a 
      buffer of size 0 was allocated causing the crash.
      - Create new test suite for this bug's test suite as per QA.
      
      
      myisam/sort.c:
        Bug#27029 alter table ... enable keys crashes mysqld on large table
        - Check to make sure the value of records is < UINT_MAX32 to avoid a 
        false positive on the remaining condition.
      mysql-test/suite/large_tests/README.TXT:
        Bug#27029 alter table ... enable keys crashes mysqld on large table
        - New testsuite for large tests.
        - Added mtr hint for potential testers.
      mysql-test/suite/large_tests/r/alter_table.result:
        Bug#27029 alter table ... enable keys crashes mysqld on large table
        - New testsuite for large tests.
        - Added results for bug.
      mysql-test/suite/large_tests/t/alter_table.test:
        Bug#27029 alter table ... enable keys crashes mysqld on large table
        - New testsuite for large tests.
        - Added test for bug.
      8d27f335
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/50 · 6c70aa11
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      
      configure.in:
        Auto merged
      6c70aa11