1. 11 Oct, 2022 7 commits
  2. 10 Oct, 2022 3 commits
  3. 09 Oct, 2022 6 commits
  4. 07 Oct, 2022 5 commits
  5. 06 Oct, 2022 5 commits
  6. 05 Oct, 2022 12 commits
    • Marko Mäkelä's avatar
      f600690c
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 65d0c57c
      Marko Mäkelä authored
      65d0c57c
    • Aleksey Midenkov's avatar
      MDEV-29697 Assertion failure in Diagnostics_area::set_ok_status · 074e3582
      Aleksey Midenkov authored
                 upon CREATE OR REPLACE causing ER_UPDATE_TABLE_USED
      
      Missed set return status to 1.
      074e3582
    • Aleksey Midenkov's avatar
      MDEV-28576 RENAME COLUMN with NOCOPY algorithm leads to corrupt partitioned table · 0779e2cb
      Aleksey Midenkov authored
      When f.ex. table is partitioned by HASH(a) and we rename column `a' to
      `b' partitioning filter stays unchanged: HASH(a). That's the wrong
      behavior.
      
      The patch updates partitioning filter in accordance to the new columns
      names. That includes partition/subpartition expression and
      partition/subpartition field list.
      0779e2cb
    • Aleksey Midenkov's avatar
      MDEV-28576 Ability to manipulate List<const char *> · 4eb8c35b
      Aleksey Midenkov authored
      For "const char *" replace() and after() accepted const as "T *" and
      passed forward "void *". This cannot be cast implicitly, so we better
      use "const void *" instead of "void *" in the input interface. This
      way we avoid problems with using List for any const type.
      4eb8c35b
    • Vlad Lesin's avatar
      MDEV-27927 row_sel_try_search_shortcut_for_mysql() does not latch a page,... · c0eda62a
      Vlad Lesin authored
      MDEV-27927 row_sel_try_search_shortcut_for_mysql() does not latch a page, violating read view isolation
      
      btr_search_guess_on_hash() would only acquire an index page latch if it
      is invoked with ahi_latch=NULL. If it's invoked from
      row_sel_try_search_shortcut_for_mysql() with ahi_latch!=NULL, a page
      will not be latched, and row_search_mvcc() will get a pointer to the
      record, which can be changed by some other transaction before the record
      was stored in result buffer with row_sel_store_mysql_rec() call.
      
      ahi_latch argument of btr_cur_search_to_nth_level_func() and
      btr_pcur_open_with_no_init_func() is used only for
      row_sel_try_search_shortcut_for_mysql().
      btr_cur_search_to_nth_level_func(..., ahi_latch !=0, ...) is invoked
      only from btr_pcur_open_with_no_init_func(..., ahi_latch !=0, ...),
      which, in turns, is invoked only from
      row_sel_try_search_shortcut_for_mysql().
      
      I suppose that separate case with ahi_latch!=0 was intentionally
      implemented to protect row_sel_store_mysql_rec() call in
      row_search_mvcc() just after row_sel_try_search_shortcut_for_mysql()
      call. After the ahi_latch was moved from row_seach_mvcc() to
      row_sel_try_search_shortcut_for_mysql(), there is no need in it at all
      if btr_search_guess_on_hash() latches a page unconditionally. And if
      btr_search_guess_on_hash() latched the page, any access to the record in
      row_sel_try_search_shortcut_for_mysql() after btr_pcur_open_with_no_init()
      call will be protected with the page latch.
      
      The fix is to remove ahi_latch argument from
      btr_pcur_open_with_no_init_func(), btr_cur_search_to_nth_level_func()
      and btr_search_guess_on_hash().
      
      There will not be test, as to test it we need to freeze some SELECT
      execution in the point between row_sel_try_search_shortcut_for_mysql()
      and row_sel_store_mysql_rec() calls in row_search_mvcc(), and to change
      the record in some other transaction to let row_sel_store_mysql_rec() to
      store changed record in result buffer. Buf we can't do this with the
      fix, as the page will be latched in btr_search_guess_on_hash() call.
      c0eda62a
    • Marko Mäkelä's avatar
      MDEV-29710: Valgrind tests massively fail due to silently killing server on shutdown timeout · 111cbdf3
      Marko Mäkelä authored
      Let us disable Valgrind on tests that would fail because a
      server shutdown or a STOP SLAVE command would take longer,
      causing the test harness to forcibly and silently kill the server
      due to an exceeded timeout.
      111cbdf3
    • Marko Mäkelä's avatar
      MDEV-29710: Disable main.log_slow under Valgrind · e0bcff10
      Marko Mäkelä authored
      Under Valgrind, this test may occasionally fail because the sleep-based
      timeouts of less than 1 second could be exceeded.
      e0bcff10
    • Marko Mäkelä's avatar
      MDEV-29710: Disable sys_vars.innodb_flush_method_func under Valgrind · 380e06f8
      Marko Mäkelä authored
      The test could emit some I/O error when run under Valgrind.
      380e06f8
    • Marko Mäkelä's avatar
      c64e2d60
    • Marko Mäkelä's avatar
      Remove HAVE_SNPRINTF · df97eb14
      Marko Mäkelä authored
      This fixes up commit 77c184df
      which explicitly specifies that we use ISO/IEC 9899:1999 (C99),
      which includes the snprintf() function.
      df97eb14
    • Marko Mäkelä's avatar
      MDEV-29666 InnoDB fails to purge secondary index records when indexed virtual columns exist · 1562b2c2
      Marko Mäkelä authored
      row_purge_get_partial(): Replaces trx_undo_rec_get_partial_row().
      Also copy the purge_node_t::ref to the purge_node_t::row.
      In this way, the clustered index key fields will always be
      available, even if thanks to
      commit d384ead0 (MDEV-14799)
      they would no longer be repeated in the remaining part of the
      undo log record.
      1562b2c2
  7. 04 Oct, 2022 2 commits
    • Julius Goryavsky's avatar
      MDEV-27682: bundled wsrep_notify.sh causes mariadbd to freeze during start · 19f0b96d
      Julius Goryavsky authored
      This commit adds automation that will reduce the possibility
      of user errors when customizing wsrep_notify.sh (in particular
      caused by user-specified parameters). Now all leading and trailing
      spaces are removed from the user-specified parameters and automatic
      port and host address substitution has been added to scripts, as
      well as automatic password substitution to the client command line,
      only if it is specified in the wsrep_notify.sh and not as empty
      strings. Also added support for automatic substitution of the all
      SSL-related parameters and improved parsing for ipv6 addresses
      (to allow "[...]" notation for ipv6 addresses). Also added a
      test to check if the wsrep notify script will works with SSL.
      19f0b96d
    • Monty's avatar
      Disable valgrind for test in main that takes > 200 seconds · d1bc469d
      Monty authored
      One can run these with --valgrind --big
      d1bc469d