1. 19 Apr, 2017 1 commit
    • Oleksandr Byelkin's avatar
      Fix use of `require` in mysql-test-run. · d185f1d6
      Oleksandr Byelkin authored
      The motivation for this is that Perl is moving towards not having
      current directory ./ in @INC by default. This is causing
      mysql-test-run.pl to fail in latest Debian Unstable:
      
        https://lists.debian.org/debian-devel-announce/2016/08/msg00013.html
      
      However, we have `use "lib"`, there is no need for current directory
      in @INC, except for a gross hack. In mtr_cases.pm, there is a
      `require "mtr_misc.pl"`, which hides mtr_misc.pl away in mtr_cases
      namespace. And things only work because mysql-test-run.pl loads it
      with a different name, `require "lib/mtr_misc.pl"`! (Perl will
      `require` only once for each unique filename).
      
      Fix this by only using `require` in main program, and referencing
      functions with :: scope from other namespaces. For multi-use in
      different namespaces, proper `use` modules should be used.
      Signed-off-by: default avatarKristian Nielsen <knielsen@knielsen-hq.org>
      d185f1d6
  2. 13 Apr, 2017 1 commit
  3. 11 Apr, 2017 1 commit
  4. 07 Apr, 2017 1 commit
  5. 04 Apr, 2017 1 commit
    • Igor Babaev's avatar
      Fixed the bug mdev-12429 and its duplicates mdev-12145 and mdev-9886. · b0395d87
      Igor Babaev authored
      Also fixed a wrong result for a test case for mdev-7691
      (the alternative one).
      The test  cases for all these bug have materialized semi-joins used
      inside dependent sub-queries.
      
      The patch actually reverts the change inroduced by Monty in 2003.
      It looks like this change is not valid anymore after the implementation
      of semi-joins.
      Adjusted output from EXPLAIN for many other test cases.
      b0395d87
  6. 24 Mar, 2017 1 commit
  7. 21 Mar, 2017 1 commit
  8. 18 Mar, 2017 1 commit
    • Bharathy Satish's avatar
      Bug #25717383: MYSQLDUMP MAY EXECUTE ANY ARBITRARY QUERY · 6fa5e081
      Bharathy Satish authored
      While writing comments if database object names has a new
      line character, then next line is considered a command, rather
      than a comment.
      This patch fixes the way comments are constructed in mysqldump.
      
      (cherry picked from commit 1099f9d17b1c697c2760f86556f5bae7d202b444)
      6fa5e081
  9. 17 Mar, 2017 1 commit
  10. 14 Mar, 2017 2 commits
  11. 13 Mar, 2017 1 commit
  12. 12 Mar, 2017 1 commit
  13. 10 Mar, 2017 1 commit
  14. 09 Mar, 2017 1 commit
  15. 08 Mar, 2017 6 commits
  16. 06 Mar, 2017 1 commit
  17. 05 Mar, 2017 1 commit
  18. 03 Mar, 2017 1 commit
    • Marko Mäkelä's avatar
      MDEV-11520: Retry posix_fallocate() after EINTR. · 6b8173b6
      Marko Mäkelä authored
      The function posix_fallocate() as well as the Linux system call
      fallocate() can return EINTR when the operation was interrupted
      by a signal. In that case, keep retrying the operation, except
      if InnoDB shutdown has been initiated.
      6b8173b6
  19. 28 Feb, 2017 1 commit
  20. 27 Feb, 2017 15 commits
    • Igor Babaev's avatar
      Fixed bug mdev-12099. · 5a0fff50
      Igor Babaev authored
      The function mysql_derived_merge() erroneously did not mark newly formed
      AND formulas in ON conditions with the flag abort_on_null. As a result
      not_null_tables() calculated incorrectly for these conditions. This
      could prevent conversion of embedded outer joins into inner joins.
      
      Changed a test case from table_elim.test to preserve the former execution
      plan.
      5a0fff50
    • Sergei Golubchik's avatar
      MDEV-5999 MySQL Bug#12766319 - 61865: RENAME USER DOES NOT WORK CORRECTLY -... · 199f88cb
      Sergei Golubchik authored
      MDEV-5999 MySQL Bug#12766319 - 61865: RENAME USER DOES NOT WORK CORRECTLY - REQUIRES FLUSH PRIVILEGES
      
      use update_hostname() to update the hostname.
      test case comes from
      
        commit 0abdeed1d6d
        Author: gopal.shankar@oracle.com <>
        Date:   Thu Mar 29 00:20:54 2012 +0530
      
          Bug#12766319 - 61865: RENAME USER DOES NOT WORK CORRECTLY -
                                REQUIRES FLUSH PRIVILEGES
      199f88cb
    • Dmitry Lenev's avatar
      Fix for bug#11759114 - '51401: GRANT TREATS NONEXISTENT · 494a9415
      Dmitry Lenev authored
      FUNCTIONS/PRIVILEGES DIFFERENTLY'.
      
      The problem was that attempt to grant EXECUTE or ALTER
      ROUTINE privilege on stored procedure which didn't exist
      succeed instead of returning an appropriate error like
      it happens in similar situation for stored functions or
      tables.
      
      The code which handles granting of privileges on individual
      routine calls sp_exist_routines() function to check if routine
      exists and assumes that the 3rd parameter of the latter
      specifies whether it should check for existence of stored
      procedure or function. In practice, this parameter had
      completely different meaning and, as result, this check was
      not done properly for stored procedures.
      
      This fix addresses this problem by bringing sp_exist_routines()
      signature and code in line with expectation of its caller.
      494a9415
    • Sergei Golubchik's avatar
      delete the installation warning for CentOS4/RHEL4 · 0a480f03
      Sergei Golubchik authored
      it went out of support five years ago
      0a480f03
    • Sergei Golubchik's avatar
    • Sergei Golubchik's avatar
      713d5136
    • Sergei Golubchik's avatar
      MDEV-10788 Not able to compile source with -DBUILD_CONFIG=mysql_release -DCMAKE_BUILD_TYPE=Debug · 831b5318
      Sergei Golubchik authored
      It's too plainful to require <my_config.h> to be included first
      for third-party storage engines. And anyway, some source files
      might not include <my_config.h> at all, so there is no guarantee
      that all parts of the binary will see identical definitions of system
      structures (e.g. struct stat).
      
      Define _FILE_OFFSET_BITS on the compiler's command line instead.
      831b5318
    • Sergei Golubchik's avatar
      MDEV-11505 wrong databasename in mysqldump comment · 44534487
      Sergei Golubchik authored
      fix_for_comment() uses a static buffer. cannot have two
      fix_for_comment() calls as arguments to one printf().
      44534487
    • Sergei Golubchik's avatar
      bugfix: remove my_delete_with_symlink() · d72dbb41
      Sergei Golubchik authored
      it was race condition prone. instead use either a pair of my_delete()
      calls with already resolved paths, or a safe high-level function
      my_handler_delete_with_symlink(), like MyISAM and Aria already do.
      d72dbb41
    • Sergei Golubchik's avatar
      race-condition safe implementation of test_if_data_home_dir() · 955f2f03
      Sergei Golubchik authored
      don't realpath() twice
      955f2f03
    • Sergei Golubchik's avatar
    • Sergei Golubchik's avatar
      support MY_NOSYMLINKS in my_delete() · 6d503245
      Sergei Golubchik authored
      6d503245
    • Sergei Golubchik's avatar
      compilation failure · f2d24ea6
      Sergei Golubchik authored
      At least it would be a compilation failure with -DDONT_ALLOW_SHOW_COMMANDS.
      Otherwise it only confuses ctags to ignore ~75% of sql_parse.cc
      f2d24ea6
    • Sergei Golubchik's avatar
      cleanup: remove now-unused argument · b6862c91
      Sergei Golubchik authored
      b6862c91
    • Sergei Golubchik's avatar
      MDEV-11902 mi_open race condition · b27fd90a
      Sergei Golubchik authored
      TOCTOU bug. The path is checked to be valid, symlinks are resolved.
      Then the resolved path is opened. Between the check and the open,
      there's a window when one can replace some path component with a
      symlink, bypassing validity checks.
      
      Fix: after we resolved all symlinks in the path, don't allow open()
      to resolve symlinks, there should be none.
      
      Compared to the old MyISAM/Aria code:
      * fastpath. Opening of not-symlinked files is just one open(),
        no fn_format() and lstat() anymore.
      * opening of symlinked tables doesn't do fn_format() and lstat() either.
        it also doesn't to realpath() (which was lstat-ing every path
        component), instead if opens every path component with O_PATH.
      * share->data_file_name stores realpath(path) not readlink(path). So,
        SHOW CREATE TABLE needs to do lstat/readlink() now (see ::info()),
        and certain error messages (cannot open file "XXX") show the real
        file path with all symlinks resolved.
      b27fd90a