1. 30 Apr, 2020 12 commits
  2. 29 Apr, 2020 7 commits
  3. 28 Apr, 2020 4 commits
    • Marko Mäkelä's avatar
      InnoDB 5.6.48 · 713e427b
      Marko Mäkelä authored
      713e427b
    • Marko Mäkelä's avatar
      MDEV-22393 Corruption for SET GLOBAL innodb_ string variables · 70418074
      Marko Mäkelä authored
      Several MYSQL_SYSVAR_STR parameters that employ both a validate
      function callback fail to copy the string for saving the
      validated value. The affected variables include the following:
      
      innodb_ft_aux_table
      innodb_ft_server_stopword_table
      innodb_ft_user_stopword_table
      innodb_buffer_pool_filename
      
      The test case is an enhanced version of
      mysql/mysql-server@0b0c30641fd66336e87394ac28587e40864f8af9
      and the code changes are inspired by their fixes.
      
      We are also importing and adjusting the test innodb_fts.stopword
      to get coverage for the variable innodb_ft_user_stopword_table.
      
      buf_dump(), buf_load(): Protect srv_buf_dump_filename with
      LOCK_global_system_variables.
      
      fts_load_user_stopword(): Minor cleanup
      
      fts_load_stopword(): Remove the parameter global_stopword_table.
      
      innobase_fts_load_stopword(): Protect innodb_server_stopword_table
      against concurrent SET GLOBAL.
      70418074
    • Marko Mäkelä's avatar
      MDEV-22392 Race condition on SET GLOBAL innodb_buffer_pool_evict='uncompressed' · cce1b6e2
      Marko Mäkelä authored
      innodb_buffer_pool_evict_uncompressed(): Restart the loop when
      prev_block might not enjoy mutex protection.
      
      This is based on
      mysql/mysql-server@eccaecac070b6747ecf14d6b9150791f8c3e8f6d
      cce1b6e2
    • Marko Mäkelä's avatar
      Remove a duplicated copyright message · cf64d27b
      Marko Mäkelä authored
      cf64d27b
  4. 27 Apr, 2020 8 commits
    • Marko Mäkelä's avatar
      XtraDB 5.6.47-87.0 · d956175d
      Marko Mäkelä authored
      The only change is a change of the version number.
      As noted in commit 02af6278
      there were no changes to InnoDB between MySQL 5.6.46 and 5.6.47
      either.
      d956175d
    • Marko Mäkelä's avatar
      MDEV-7962 wsrep_on() takes 0.14% in OLTP RO · edbdfc2f
      Marko Mäkelä authored
      The function wsrep_on() was being called rather frequently
      in InnoDB and XtraDB. Let us cache it in trx_t and invoke
      trx_t::is_wsrep() instead.
      
      innobase_trx_init(): Cache trx->wsrep = wsrep_on(thd).
      
      ha_innobase::write_row(): Replace many repeated calls to current_thd,
      and test the cheapest condition first.
      edbdfc2f
    • Sergei Golubchik's avatar
      MDEV-22271 Excessive stack memory usage due to WSREP_LOG · dd4124c2
      Sergei Golubchik authored
      fix embedded innodb_plugin tests
      
      followup for 7198c6ab
      dd4124c2
    • Sergei Golubchik's avatar
      MDEV-22078 MariaDB-compat missing from MariaDB 10.4 CentOS 8 Yum Repo · f462fbac
      Sergei Golubchik authored
      Backport INSALL_SYMLINK cmake macro from 10.3.
      It'll make libmysqlclient_r.* symlinks to link to the actual
      shared library file, not to another symlink.
      
      As a bonus it'll fix cmake warning about deprecated LOCATION property
      f462fbac
    • Marko Mäkelä's avatar
      MDEV-22203: WSREP_ON is unnecessarily expensive to evaluate · 6be05ceb
      Marko Mäkelä authored
      This is a backport of the applicable part of
      commit 93475aff and
      commit 2c39f69d
      from 10.4.
      
      Before 10.4 and Galera 4, WSREP_ON is a macro that points to
      a global Boolean variable, so it is not that expensive to
      evaluate, but we will add an unlikely() hint around it.
      
      WSREP_ON_NEW: Remove. This macro was introduced in
      commit c863159c
      when reverting WSREP_ON to its previous definition.
      
      We replace some use of WSREP_ON with WSREP(thd), like it was done
      in 93475aff. Note: the macro
      WSREP() in 10.1 is equivalent to WSREP_NNULL() in 10.4.
      
      Item_func_rand::seed_random(): Avoid invoking current_thd
      when WSREP is not enabled.
      6be05ceb
    • Marko Mäkelä's avatar
      Fix clang 10 warnings · 758fbec6
      Marko Mäkelä authored
      _ma_fetch_keypage(): Correct an assertion that used to always hold.
      Thanks to clang -Wint-in-bool-context for flagging this.
      
      double_to_datetime_with_warn(): Suppress -Wimplicit-int-float-conversion
      by adding a cast. LONGLONG_MAX converted to double will actually be
      LONGLONG_MAX+1.
      758fbec6
    • Marko Mäkelä's avatar
      6a3fc110
    • Marko Mäkelä's avatar
      MDEV-22271: Follow-up fix of --embedded · d28ee189
      Marko Mäkelä authored
      Since commit 7198c6ab
      the ./mtr --embedded tests would fail to start innodb_plugin
      because of an undefined reference to the symbol wsrep_log().
      
      Let us define a stub for that function. The embedded server
      is never built WITH_WSREP, but there are no separate storage
      engine builds for the embedded server. Hence, by default,
      the dynamic InnoDB storage engine plugin would be built WITH_WSREP
      and it would fail to load into the embedded server library due to
      a reference to the undefined symbol.
      d28ee189
  5. 25 Apr, 2020 1 commit
  6. 24 Apr, 2020 1 commit
  7. 23 Apr, 2020 1 commit
  8. 18 Apr, 2020 1 commit
    • Igor Babaev's avatar
      MDEV-21932 Another attempt to fix the bug . · 29cdd508
      Igor Babaev authored
      The first patch for the bug was erroneous: it did not take into account
      the fact that the modified function get_key_scans_params() was called in
      different contexts. As a result the patch caused a regression bug MDEV-22191.
      The patch for this bug introduced an extra parameter. Actually we can
      do without this parameter and use the fourth parameter for the same
      puropose - to differentiate between the calls of the function for range
      access and for index merge access.
      
      Also removed the call of get_key_scans_params() in the code of the function
      merge_same_index_scans() as not needed.
      29cdd508
  9. 17 Apr, 2020 2 commits
    • Marko Mäkelä's avatar
      Fix GCC 10 -Woverflow · ad4b7056
      Marko Mäkelä authored
      maria_page_crc_check_index(): Do not attempt to convert
      HA_ERR_WRONG_CRC (176) to my_bool (char).
      On platforms where char is signed, the 176 will be converted to -80.
      
      It turns out that the callers only care whether the result is zero.
      Let us return 1 in this case, like we do in all other error cases.
      ad4b7056
    • Marko Mäkelä's avatar
      MDEV-22271 Excessive stack memory usage due to WSREP_LOG · 7198c6ab
      Marko Mäkelä authored
      Several tests that involve stored procedures fail on 10.4 kvm-asan
      (clang 10) due to stack overrun. The main contributor to this stack
      overrun is mysql_execute_command(), which is invoked recursively
      during stored procedure execution.
      
      Rebuilding with cmake -DWITH_WSREP=OFF shrunk the stack frame size
      of mysql_execute_command() by more than 10 kilobytes in a
      WITH_ASAN=ON, CMAKE_BUILD_TYPE=Debug build. The culprit
      turned out to be the macro WSREP_LOG, which is allocating a
      separate 1KiB buffer for every occurrence.
      
      We replace the macro with a function, so that the stack will be
      allocated only when the function is actually invoked. In this way,
      no stack space will be wasted by default (when WSREP and Galera
      are disabled).
      
      This backports commit b6c5657e
      from MariaDB 10.3.1.
      
      Without ASAN, compilers can be smarter and optimize the stack usage.
      The original commit message mentions that 1KiB was saved on GCC 5.4,
      and 4KiB on Mac OS X Lion, which presumably uses a clang-based compiler.
      7198c6ab
  10. 16 Apr, 2020 3 commits