1. 19 Oct, 2007 1 commit
    • unknown's avatar
      BUG#28618 (Skipping into the middle of a group with SQL_SLAVE_SKIP_COUNTER · d29fe86f
      unknown authored
      is possible):
      
      When skipping the beginning of a transaction starting with BEGIN, the OPTION_BEGIN
      flag was not set correctly, which caused the slave to not recognize that it was
      inside a group. This patch sets the OPTION_BEGIN flag for BEGIN, COMMIT, ROLLBACK,
      and XID events. It also adds checks if inside a group before decreasing the
      slave skip counter to zero.
      
      Begin_query_log_event was not marked that it could not end a group, which is now
      corrected.
      
      
      mysql-test/extra/rpl_tests/rpl_extraSlave_Col.test:
        Correcting slave skip counter to get the correct behaviour.
      mysql-test/suite/rpl/r/rpl_slave_skip.result:
        Result change.
      mysql-test/suite/rpl/t/rpl_slave_skip.test:
        Adding tests to check that skipping works for transactions:
        - Skipping one group with BEGIN first
        - Skipping two groups with BEGIN first
        - Skipping one group without BEGIN first but with AUTOCOMMIT=0
        - LOAD DATA INFILE under statement-based replication
      mysql-test/suite/rpl_ndb/r/rpl_ndb_extraCol.result:
        Result change.
      sql/log_event.cc:
        Adding checks if we're in a group when the slave skip counter is 1.
        In that case, we should keep going.
        
        Adding helping member function Log_event::continue_group() denoting
        that this event cannot end a group, and if the skip counter indicates
        that the group ends after this event, it should not decrease the skip
        counter.
        
        Query_log_event will change the OPTION_BEGIN flag for BEGIN, COMMIT, and
        ROLLBACK, even when skipping because of a positive skip count, and
        Xid_log_event will also affect the OPTION_BEGIN flag, even when being
        skipped.
        
        Begin_load_query_log_event cannot end a group, so it is marked to
        continue the group.
      sql/log_event.h:
        Adding helper function Log_event::continue_group().
      sql/rpl_rli.h:
        Adding Relay_log_info::get_flag() to get the value of a
        replication flag.
      sql/slave.cc:
        Adding debug output and changing debug message.
      mysql-test/suite/rpl/data/rpl_bug28618.dat:
        New BitKeeper file ``mysql-test/suite/rpl/data/rpl_bug28618.dat''
      mysql-test/suite/rpl/t/rpl_slave_skip-slave.opt:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_slave_skip-slave.opt''
      d29fe86f
  2. 24 Sep, 2007 2 commits
  3. 21 Sep, 2007 1 commit
  4. 20 Sep, 2007 2 commits
    • unknown's avatar
      Merge kindahl-laptop.dnsalias.net:/home/bkroot/mysql-5.1-rpl · 0ade39d4
      unknown authored
      into  kindahl-laptop.dnsalias.net:/home/bk/b31076-mysql-5.1-rpl
      
      
      sql/log_event.cc:
        Auto merged
      0ade39d4
    • unknown's avatar
      BUG#31076 (Server crashes when start slave is issued): · 0cbf0f8e
      unknown authored
      Row-based replication crashes when replicating from pre-5.1.22 to 5.1.22
      due to an uninitialized variable.
      
      
      sql/log_event.cc:
        Initializing m_null_bits to null so that it can be detected that it
        was not initialized later.
      mysql-test/suite/rpl/r/rpl_bug31076.result:
        New BitKeeper file ``mysql-test/suite/rpl/r/rpl_bug31076.result''
      mysql-test/suite/rpl/t/rpl_bug31076.test:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_bug31076.test''
      0cbf0f8e
  5. 17 Sep, 2007 4 commits
    • unknown's avatar
      Merge lthalmann@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · 6fedb24e
      unknown authored
      into  mysql.com:/nfsdisk1/lars/bkroot/mysql-5.1-new-rpl
      
      6fedb24e
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge · d71b5e56
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.1-merge
      
      
      sql/sql_insert.cc:
        Auto merged
      d71b5e56
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-5.1-new-rpl · cbcc5bb6
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.1-merge
      
      
      sql/field.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/rpl_utility.cc:
        Auto merged
      sql/rpl_utility.h:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      cbcc5bb6
    • unknown's avatar
      Merge: bug@27417,23333 and bug#28960 tests with 5.1 · 534a8370
      unknown authored
      
      mysql-test/suite/binlog/r/binlog_row_mix_innodb_myisam.result:
        results changed
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        results changed
      mysql-test/suite/binlog/t/binlog_row_mix_innodb_myisam.test:
        calling included file with testing bug#27417,23333. bug#28960 is not an rbr bug.
      mysql-test/suite/binlog/t/binlog_stm_mix_innodb_myisam.test:
        moved SF() with side effects bugs to a separate includable file.
        This test verifies STMT format whereas binlog_row test is reposible for
        ROW format.
      mysql-test/extra/binlog_tests/mix_innodb_myisam_side_effects.test:
        sourced part for bugs with SF() etc having side effects of midifying
        non-transactional tables.
      534a8370
  6. 16 Sep, 2007 2 commits
    • unknown's avatar
      Merge: bug#27417,23333 manual work for fixing tests and a source code. · 9f8b990b
      unknown authored
      
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        results changed due to 
        1. tt table made temporary is it's supposed to; 
        2. show master status is turned into binlog pos masking-out macro
        3. merge defect for select_insert::abort()
      mysql-test/suite/binlog/t/binlog_stm_mix_innodb_myisam.test:
        masking-out binlog postions in the results via 
        source include/show_binlog_events.inc;
      sql/sql_insert.cc:
        merging defect in not applied hunk for select_insert::abort() is fixed
      9f8b990b
    • unknown's avatar
      Manual merge fixes/tests for bugs_28960,27417,23333. · c6055e7a
      unknown authored
      
      mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test:
        follow-up of the previous manual resolve. The snippet is moved into the heading
        file.
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        results changed
      mysql-test/suite/binlog/t/binlog_stm_mix_innodb_myisam.test:
        removing explicit offsets from report;
        appending bug#27417,23333,28960 related snippet, addressing left TODO:s.
      mysql-test/suite/rpl/r/rpl_packet.result:
        results changed
      mysql-test/suite/rpl/t/rpl_packet.test:
        fixing row/stmt compatibility with #-ing out unneeded values
      c6055e7a
  7. 15 Sep, 2007 1 commit
    • unknown's avatar
      Merge dl145j.mysql.com:/tmp/andrei/mysql-5.0-rpl · d5c25b0c
      unknown authored
      into  dl145j.mysql.com:/tmp/andrei/5.1-merge
      
      
      BitKeeper/deleted/.del-sp_trans_log.result:
        Auto merged
      BitKeeper/deleted/.del-sp_trans_log.test:
        Auto merged
      mysql-test/suite/rpl/r/rpl_packet.result:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        should be re-recorded
      mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test:
        manual merge
      mysql-test/suite/rpl/t/rpl_packet.test:
        manual merge
      sql/slave.cc:
        manual merge
      sql/sql_insert.cc:
        manual merge - installing 5.0 patch logics
      sql/sql_load.cc:
        manual merge
      d5c25b0c
  8. 14 Sep, 2007 2 commits
    • unknown's avatar
      Merge mysql_cab_desk.:C:/source/c++/mysql-5.1-new-rpl · 6ffea6be
      unknown authored
      into  mysql_cab_desk.:C:/source/c++/mysql-5.1_BUG_30790
      
      6ffea6be
    • unknown's avatar
      BUG#30790 : Suspicious code in rpl_utility.cc · d458d941
      unknown authored
      This patch clarifies some of the coding choices with documentationa and
      removes a limitation in the code for future expansion of the CHAR and
      BINARY fields to length > 255.
      
      
      sql/field.cc:
        BUG#30790 : Suspicious code in rpl_utility.cc
        
        This patch adds an assertion to ensure we are not attempting to encode
        negative values.
      sql/log_event.cc:
        BUG#30790 : Suspicious code in rpl_utility.cc
        
        This patch adds comments to help explain the choice of variable types.
      sql/rpl_utility.cc:
        BUG#30790 : Suspicious code in rpl_utility.cc
        
        This patch removes code from the calc_field_size that is not needed and
        was ambiguous. Originally intended to future expansion, the code was
        not needed.
        
        Also added are comments to help explain some portions of the code.
        
        A change was made to the korr method to use the unsigned version to 
        avoid extended sign problems.
      sql/rpl_utility.h:
        BUG#30790 : Suspicious code in rpl_utility.cc
        
        This patch corrects some type discrepencies and removes an extra cast.
      d458d941
  9. 10 Sep, 2007 4 commits
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/MERGE/mysql-4.1-merge · 6e104d69
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge
      
      6e104d69
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-5.1-new-rpl · 36906fb7
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.1-merge
      
      
      mysql-test/suite/ndb/r/ndb_dd_basic.result:
        Auto merged
      mysql-test/suite/rpl/include/rpl_mixed_dml.inc:
        Auto merged
      mysql-test/suite/rpl/r/rpl_innodb_mixed_dml.result:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/log_event_old.cc:
        Auto merged
      sql/log_event_old.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/rpl_record.cc:
        Auto merged
      sql/rpl_record.h:
        Auto merged
      sql/rpl_utility.cc:
        Auto merged
      sql/rpl_utility.h:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/slave.h:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_string.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/unireg.h:
        Auto merged
      mysql-test/suite/rpl/t/disabled.def:
        Manual merge
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Manual merge
      sql/log_event.cc:
        Manual merge
      sql/log_event.h:
        Manual merge
      sql/sql_yacc.yy:
        Manual merge
      36906fb7
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-5.0-rpl · 37c591ce
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge
      
      
      sql/sql_insert.cc:
        Auto merged
      37c591ce
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-4.1-rpl · 98d1973f
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-4.1-merge
      
      98d1973f
  10. 07 Sep, 2007 1 commit
  11. 06 Sep, 2007 4 commits
  12. 05 Sep, 2007 5 commits
    • unknown's avatar
      Merge omega.weblab:/home/malff/TREE/mysql-5.1-base · 1a96ea56
      unknown authored
      into  omega.weblab:/home/malff/TREE/mysql-5.1-rt-merge
      
      1a96ea56
    • unknown's avatar
      Merge malff@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 9b64b7ab
      unknown authored
      into  omega.weblab:/home/malff/TREE/mysql-5.1-cleanup
      
      9b64b7ab
    • unknown's avatar
      Test events_logs_tests cleanup · c8f104fd
      unknown authored
      Fixed test failure under heavy load, in case truncate table is slow.
      
      
      mysql-test/r/events_logs_tests.result:
        Fixed test failure under heavy load, in case truncate table is slow.
      mysql-test/t/events_logs_tests.test:
        Fixed test failure under heavy load, in case truncate table is slow.
      c8f104fd
    • unknown's avatar
      The test case for Bug#29936 doesn't work with the embedded version, · c6119599
      unknown authored
      the first query is not running while we are doing wait queries on
      a second connection.
      
      
      mysql-test/r/sp.result:
        Remove test case result for Bug#29936, moving to sp_notembedded.result
      mysql-test/r/sp_notembedded.result:
        Test case result for Bug#29936, moved from sp.result
      mysql-test/t/sp.test:
        Remove test case for Bug#29936, moving to sp_notembedded.test
      mysql-test/t/sp_notembedded.test:
        Test case result for Bug#29936, moved from sp.test
      c6119599
    • unknown's avatar
      Discovered a bug while working with backup. Since it is possible to execute a... · 9bc74eef
      unknown authored
      Discovered a bug while working with backup. Since it is possible to execute a statement in a pre/post statment clause that can return a result, we need to test for that and free it. 
      
      
      client/mysqlslap.c:
        Cleanup resuls if rows are returned.
      9bc74eef
  13. 04 Sep, 2007 7 commits
  14. 03 Sep, 2007 4 commits