1. 13 Jun, 2006 1 commit
    • unknown's avatar
      BUG#17928 testBackup fails in error handling testcases · d2a491b5
      unknown authored
      Reproduced failure of NFMaster on my laptop, this is the fix with some added
      debug information to help people in the future when they trigger asserts in
      AsyncFile (ndbfs helper threads).
      
      
      storage/ndb/src/kernel/blocks/backup/Backup.cpp:
        In Backup::checkFile(Signal*, BackupFilePtr), only send FSCLOSEREQ if file
        is not already being closed.
        
        Add debug printouts if DEBUG_ABORT is defined to help in finding the problem.
        
        Only set filePtr.p->fileClosing when we are actually closing the file, not when
        we're anticipating a close.
        
        In Backup::closeFiles(Signal*,BackupRecordPtr), when we're closing a file,
        make sure we've queued everything to be written out before sending FSCLOSEREQ.
        
        This solves two problems:
        - in testBackup (NFMaster) on my machine (but not in autotest since the end of
        March for whatever reason), we were hitting an assert in the buffer for files
        saying we hadn't written everything out of the buffer before closing. (for the
        interested, it was 10 bytes of data)
        - once I'd fixed the above (by the checkFile before close) I'd then get really
        nonsensical trace dumps in NFMaster for ERROR_INSERT 10003. It turns out that
        any asserts in AsyncFile (the thread that NDBFS runs to do its bidding) don't
        cause anything to be written out anywhere and you're left scratching your head
        as to what on earth happenned (apart from getting "caught signal 6, aborted").
        What really was happenning was we were then calling FSCLOSEREQ one too many times,
        hitting the assert on trying to close an fd of -1 in AsyncFile.
      storage/ndb/src/kernel/blocks/ndbfs/AsyncFile.cpp:
        It turns out that any asserts in AsyncFile (the thread that NDBFS runs to do 
        its bidding) don't cause anything to be written out anywhere and you're left 
        scratching your head as to what on earth happenned (apart from getting 
        "caught signal 6, aborted"). What really was happenning was we were then 
        calling FSCLOSEREQ one too many times, hitting the assert on trying to close
        an fd of -1 in AsyncFile.
        
        Added DEBUG printouts for every assert in AsyncFile
      d2a491b5
  2. 12 Jun, 2006 15 commits
    • unknown's avatar
      Added order by · def8e0ce
      unknown authored
      def8e0ce
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.1 · 334453f9
      unknown authored
      into  mysql.com:/home/marty/MySQL/mysql-5.1
      
      
      storage/ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbDictionaryImpl.hpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbScanOperation.cpp:
        Auto merged
      storage/ndb/src/ndbapi/ndberror.c:
        Auto merged
      334453f9
    • unknown's avatar
      sql_delete.cc: · 77446405
      unknown authored
        Bug #18864  TRUNCATE TABLE doesn't reset AUTO_INCREMENT value on ndb table: locked lock_OPEN mutex to support TRUNCATE with re-create and cluster binlog
      Many files:
        Bug #18864  TRUNCATE TABLE doesn't reset AUTO_INCREMENT value on ndb table: adaption to MySQ Cluster replication
      ndb_lock.result, ha_ndbcluster.cc:
        Fix for Bug #18184  SELECT ... FOR UPDATE does not work..: Adaption to 5.1 code
      NdbDictionaryImpl.hpp:
        Fix of bad merge
      
      
      storage/ndb/src/ndbapi/NdbDictionaryImpl.hpp:
        Fix of bad merge
      sql/ha_ndbcluster.cc:
        Fix for Bug #18184  SELECT ... FOR UPDATE does not work..: Adaption to 5.1 code
      mysql-test/r/ndb_lock.result:
        Fix for Bug #18184  SELECT ... FOR UPDATE does not work..: Adaption to 5.1 code
      sql/ha_ndbcluster_binlog.cc:
        Bug #18864  TRUNCATE TABLE doesn't reset AUTO_INCREMENT value on ndb table: adaption to MySQ Cluster replication
      mysql-test/r/rpl_ndb_basic.result:
        Bug #18864  TRUNCATE TABLE doesn't reset AUTO_INCREMENT value on ndb table: adaption to MySQ Cluster replication
      mysql-test/t/rpl_ndb_basic.test:
        Bug #18864  TRUNCATE TABLE doesn't reset AUTO_INCREMENT value on ndb table: adaption to MySQ Cluster replication
      sql/ha_ndbcluster_binlog.h:
        Bug #18864  TRUNCATE TABLE doesn't reset AUTO_INCREMENT value on ndb table: adaption to MySQ Cluster replication
      sql/sql_delete.cc:
        Bug #18864  TRUNCATE TABLE doesn't reset AUTO_INCREMENT value on ndb table: locked lock_OPEN mutex to support TRUNCATE with re-create and cluster binlog
      77446405
    • unknown's avatar
      Merge jonas@perch:src/51-jonas · 12655063
      unknown authored
      into  poseidon.ndb.mysql.com:/home/tomas/mysql-5.1-new-ndb
      
      
      storage/ndb/src/kernel/blocks/ERROR_codes.txt:
        Auto merged
      storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/Services.cpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Auto merged
      storage/ndb/test/ndbapi/testNodeRestart.cpp:
        Auto merged
      storage/ndb/test/run-test/daily-basic-tests.txt:
        Auto merged
      12655063
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.1 · 37d97b58
      unknown authored
      into  poseidon.ndb.mysql.com:/home/tomas/mysql-5.1-new-ndb
      
      
      37d97b58
    • unknown's avatar
      Merge poseidon.ndb.mysql.com:/home/tomas/mysql-5.0 · 059d28f7
      unknown authored
      into  poseidon.ndb.mysql.com:/home/tomas/mysql-5.1-new-ndb
      
      
      storage/ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/Services.cpp:
        Auto merged
      059d28f7
    • unknown's avatar
      Merge poseidon.ndb.mysql.com:/home/tomas/mysql-4.1 · ce450e50
      unknown authored
      into  poseidon.ndb.mysql.com:/home/tomas/mysql-5.0
      
      
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      ndb/src/mgmsrv/Services.cpp:
        Auto merged
      ce450e50
    • unknown's avatar
      Bug #20336 CLUSTERLOG commands have no effect · 40d687eb
      unknown authored
      - always calculate max log level on node start
      - send event subscribe uncond
      
      
      ndb/src/mgmsrv/Services.cpp:
        Bug #20336 CLUSTERLOG commands have no effect
        - always send log level update
      40d687eb
    • unknown's avatar
      Merge mysql.com:/home/marty/MySQL/mysql-5.0 · 6ac45568
      unknown authored
      into  mysql.com:/home/marty/MySQL/mysql-5.1
      
      
      mysql-test/t/ndb_lock.test:
        Auto merged
      sql/ha_ndbcluster.h:
        Auto merged
      sql/handler.h:
        Auto merged
      storage/ndb/include/ndbapi/NdbIndexScanOperation.hpp:
        Auto merged
      storage/ndb/include/ndbapi/NdbScanOperation.hpp:
        Auto merged
      mysql-test/r/ndb_lock.result:
        Merge
      sql/ha_ndbcluster.cc:
        Merge
      storage/ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Merge
      storage/ndb/src/ndbapi/NdbDictionaryImpl.hpp:
        Merge
      storage/ndb/src/ndbapi/NdbScanOperation.cpp:
        Merge
      storage/ndb/src/ndbapi/ndberror.c:
        Merge
      6ac45568
    • unknown's avatar
      Fix for Bug #18184 SELECT ... FOR UPDATE does not work..: Skipped lock check... · 55d554bd
      unknown authored
       Fix for Bug #18184  SELECT ... FOR UPDATE does not work..: Skipped lock check for full table scan due to bug #20390 SELECT FOR UPDATE does not release locks of untouched rows in full table scans
      
      
      
      55d554bd
    • unknown's avatar
      Fix for Bug #18184 SELECT ... FOR UPDATE does not work..: Added missing... · d043b5ea
      unknown authored
       Fix for Bug #18184  SELECT ... FOR UPDATE does not work..: Added missing parameter for readTuples in index scan
      
      
      
      d043b5ea
    • unknown's avatar
      Merge mysql.com:/home/marty/MySQL/mysql-4.1 · 8ea10584
      unknown authored
      into  mysql.com:/home/marty/MySQL/mysql-5.0
      
      
      sql/ha_ndbcluster.cc:
        Merge (using local)
      8ea10584
    • unknown's avatar
    • unknown's avatar
      Added lock test on index scan · a3f36966
      unknown authored
      a3f36966
    • unknown's avatar
      Moved back comment to correct method · fc9da882
      unknown authored
      fc9da882
  3. 10 Jun, 2006 1 commit
  4. 09 Jun, 2006 22 commits
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.1 · 1ab93b89
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-5.1
      
      
      1ab93b89
    • unknown's avatar
      Disable im_life_cycle test · 45d01b1a
      unknown authored
      45d01b1a
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.1 · 87b06d07
      unknown authored
      into  rurik.mysql.com:/home/igor/dev/mysql-5.1-0
      
      
      87b06d07
    • unknown's avatar
      Post-merge fixes · 388e8843
      unknown authored
      388e8843
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.1 · 2ef66fca
      unknown authored
      into mysql.com:/home/psergey/mysql-5.1-bug19684
      
      
      sql/opt_range.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      2ef66fca
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-5.1--main · 761c75f3
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.1-amerge
      
      
      761c75f3
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-5.1--main · 0e0755ea
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.1-amerge
      
      
      0e0755ea
    • unknown's avatar
      Merge · 0ad73944
      unknown authored
      
      sql/log.cc:
        Auto merged
      sql/sql_insert.cc:
        SCCS merged
      0ad73944
    • unknown's avatar
      Merge mysql.com:/M51/bug20303-5.1 into mysql.com:/M51/mysql-5.1 · 2da24bb6
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      2da24bb6
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-5.1--main · cd53e516
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.1-amerge
      
      
      cd53e516
    • unknown's avatar
      Merge mysql.com:/M50/bug20303-5.0 into mysql.com:/M51/bug20303-5.1 · 741edd2e
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      741edd2e
    • unknown's avatar
      Merge poseidon.ndb.mysql.com:/home/tomas/mysql-5.0 · 8e206126
      unknown authored
      into  poseidon.ndb.mysql.com:/home/tomas/mysql-5.1-new-ndb
      
      
      storage/ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/MgmtSrvr.hpp:
        Auto merged
      storage/ndb/src/mgmsrv/Services.cpp:
        Auto merged
      8e206126
    • unknown's avatar
      Bug #13266 Online adding of MySQLD causes cluster to crash · be6403eb
      unknown authored
      - check node type, if configuration has not bee updated, type will be undefined, and conenction will be refused
      
      
      storage/ndb/include/kernel/signaldata/AllocNodeId.hpp:
        Bug #13266 Online adding of MySQLD causes cluster to crash
        - propagate node type on allocation
      storage/ndb/src/mgmsrv/MgmtSrvr.cpp:
        Bug #13266 Online adding of MySQLD causes cluster to crash
        - propagate node type on allocation
      storage/ndb/src/mgmsrv/MgmtSrvr.hpp:
        Bug #13266 Online adding of MySQLD causes cluster to crash
        - propagate node type on allocation
      storage/ndb/src/ndbapi/ndberror.c:
        Bug #13266 Online adding of MySQLD causes cluster to crash
        - propagate node type on allocation
      be6403eb
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-5.1-jonas · 894ec16b
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/51-jonas
      
      
      894ec16b
    • unknown's avatar
      Merge mysql.com:/home/marty/MySQL/mysql-4.1 · b2d3ac1b
      unknown authored
      into  mysql.com:/home/marty/MySQL/mysql-5.0
      
      
      ndb/src/ndbapi/ndberror.c:
        Auto merged
      BitKeeper/deleted/.del-NdbResultSet.cpp~84d192cf3f42600d:
        Merge (keeping local)
      BitKeeper/deleted/.del-NdbResultSet.hpp~e0042f4c18088ff6:
        Merge (keeping local)
      ndb/include/ndbapi/NdbIndexScanOperation.hpp:
        Merge
      ndb/include/ndbapi/NdbScanOperation.hpp:
        Merge
      ndb/src/ndbapi/NdbScanOperation.cpp:
        Merge
      sql/ha_ndbcluster.cc:
        Merge (using local, will fix manually)
      sql/ha_ndbcluster.h:
        Merge
      b2d3ac1b
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-5.1-jonas · 3fbc5ffe
      unknown authored
      into mc01.ndb.mysql.com:/space/jonas/mysql-5.1-jonas
      
      
      3fbc5ffe
    • unknown's avatar
      ndb - fix 5.1 scan error handling problem · 26917822
      unknown authored
        Make sure that error gets set corretly also
          when error code directly after taking mutex
      
      
      storage/ndb/src/ndbapi/NdbScanOperation.cpp:
        Make sure that error gets set corretly also
          when error code directly after taking mutex
      26917822
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/tmp_merge · 156a1662
      unknown authored
      into  rurik.mysql.com:/home/igor/dev/mysql-5.1-0
      
      
      mysql-test/r/ssl.result:
        Manual merge
      mysql-test/r/ssl_compress.result:
        Manual merge
      156a1662
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/tmp_merge · d0dad4bf
      unknown authored
      into  rurik.mysql.com:/home/igor/dev/mysql-5.1-0
      
      
      BitKeeper/deleted/.del-generate_prefix_files.pl:
        Delete: extra/yassl/include/openssl/generate_prefix_files.pl
      BitKeeper/deleted/.del-prefix_crypto.h:
        Delete: extra/yassl/include/openssl/prefix_crypto.h
      BitKeeper/deleted/.del-prefix_ssl.h:
        Delete: extra/yassl/include/openssl/prefix_ssl.h
      BitKeeper/deleted/.del-Makefile.am~abb265028eb9b6a7:
        Auto merged
      BitKeeper/deleted/.del-init_db.sql~af2dfeabaa348dd7:
        Auto merged
      BitKeeper/deleted/.del-yassl.m4~e55e55c1e863abaf:
        Auto merged
      client/mysqltest.c:
        Auto merged
      extra/yassl/include/openssl/crypto.h:
        Auto merged
      extra/yassl/include/openssl/ssl.h:
        Auto merged
      extra/yassl/include/yassl_int.hpp:
        Auto merged
      extra/yassl/src/Makefile.am:
        Auto merged
      extra/yassl/src/ssl.cpp:
        Auto merged
      extra/yassl/src/template_instnt.cpp:
        Auto merged
      extra/yassl/src/yassl_int.cpp:
        Auto merged
      extra/yassl/testsuite/Makefile.am:
        Auto merged
      extra/yassl/yassl.vcproj:
        Auto merged
      include/violite.h:
        Auto merged
      libmysql/Makefile.am:
        Auto merged
      libmysql_r/Makefile.am:
        Auto merged
      libmysqld/examples/Makefile.am:
        Auto merged
      mysql-test/include/common-tests.inc:
        Auto merged
      mysql-test/r/analyze.result:
        Auto merged
      mysql-test/r/grant.result:
        Auto merged
      mysql-test/r/key_cache.result:
        Auto merged
      mysql-test/r/preload.result:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/analyze.test:
        Auto merged
      mysql-test/t/explain.test:
        Auto merged
      mysql-test/t/grant.test:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      scripts/make_win_src_distribution.sh:
        Auto merged
      server-tools/instance-manager/Makefile.am:
        Auto merged
      sql/Makefile.am:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      storage/ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Auto merged
      vio/Makefile.am:
        Auto merged
      client/Makefile.am:
        Manual merge
      libmysqld/Makefile.am:
        Manual merge
      mysql-test/r/compress.result:
        Manual merge
      mysql-test/r/explain.result:
        Manual merge
      mysql-test/r/select.result:
        Manual merge
      mysql-test/r/view.result:
        Manual merge
      mysql-test/t/select.test:
        Manual merge
      mysql-test/t/view.test:
        Manual merge
      sql/sql_base.cc:
        Manual merge
      sql/sql_parse.cc:
        Manual merge
      d0dad4bf
    • unknown's avatar
      ndb - · a2e35a66
      unknown authored
        restore --with-ndb-ccflags functionality
      
      
      config/ac-macros/ha_ndbcluster.m4:
        restore --with-ndb-ccflags functionality
      a2e35a66
    • unknown's avatar
    • unknown's avatar
      ndb - testframework · 6aa63d18
      unknown authored
        impl. ugly flag to skip dict cache invalidation as it break all testSystemRestart testcases
      
      
      storage/ndb/src/ndbapi/ClusterMgr.cpp:
        impl. ugly flag to skip dict cache invalidation as it break all testSystemRestart testcases
      storage/ndb/test/src/NDBT_Test.cpp:
        impl. ugly flag to skip dict cache invalidation as it break all testSystemRestart testcases
      6aa63d18
  5. 08 Jun, 2006 1 commit