1. 12 Oct, 2007 1 commit
  2. 04 Oct, 2007 1 commit
    • unknown's avatar
      Bug #31155 gis types in union'd select cause crash. · f0bbd9c4
      unknown authored
      We use get_geometry_type() call to decide the exact type
      of a geometry field to be created (POINT, POLYGON etc)
      Though this function was only implemented for few items.
      In the bug's case we need to call this function for the
      Item_sum instance, where it was not implemented, what is
      the reason of the crash.
      Fixed by implementing virtual Item::get_geometry_type(),
      so it can be called for any Item.
      
      
      sql/item.h:
        Bug #31155 gis types in union'd select cause crash.
        virtual Item::geometry_type() added instead of
        various geometry_type() fucntions.
      sql/item.cc:
        Bug #31155 gis types in union'd select cause crash.
        
        Unified virtual ::get_geometry_type() function used
      sql/item_geofunc.cc:
        Bug #31155 gis types in union'd select cause crash.
        
        virtual Item::geometry_type() implemented for geo-Items.
        Mostly previous ::get_geometry_type() implementation changed
      sql/item_geofunc.h:
        Bug #31155 gis types in union'd select cause crash.
        
        get_geometry_type() declarations unified
      f0bbd9c4
  3. 01 Oct, 2007 6 commits
  4. 29 Sep, 2007 1 commit
    • unknown's avatar
      view_grant.result, view_grant.test: · 854abbe9
      unknown authored
        Corrected test case for the bug#29908.
      
      
      mysql-test/t/view_grant.test:
        Corrected test case for the bug#29908.
      mysql-test/r/view_grant.result:
        Corrected test case for the bug#29908.
      854abbe9
  5. 28 Sep, 2007 12 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 614cf6ad
      unknown authored
      into  moonbone.local:/work/27990-bug-5.0-opt-mysql
      
      
      sql/field.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      614cf6ad
    • unknown's avatar
      Bug#27990: Wrong info in MYSQL_FIELD struct members when a tmp table was used. · acb3c59b
      unknown authored
      The change_to_use_tmp_fields function leaves the orig_table member of an
      expression's tmp table field filled for the new Item_field being created.
      Later orig_table is used by the Field::make_field function to provide some
      info about original table and field name to a user. This is ok for a field
      but for an expression it should be empty.
      
      The change_to_use_tmp_fields function now resets orig_table member of
      an expression's tmp table field to prevent providing a wrong info to a user.
      The Field::make_field function now resets the table_name and the org_col_name
      variables when the orig_table is set to 0.
      
      
      sql/field.cc:
        Bug#27990: Wrong info in MYSQL_FIELD struct members when a tmp table was used.
        The Field::make_field function now resets the table_name and the org_col_name
        variables when the orig_table is set to 0.
      sql/sql_select.cc:
        Bug#27990: Wrong info in MYSQL_FIELD struct members when a tmp table was used.
        The change_to_use_tmp_fields function now resets orig_table member of
        an expression's tmp table field to prevent providing a wrong info to a user.
      tests/mysql_client_test.c:
        The test case for the bug#21635 is altered to test behavior on both const and
        non-const tables.
      acb3c59b
    • unknown's avatar
      Bug #30832: Assertion + crash with select name_const('test', now()); · 52a6c31f
      unknown authored
      The NAME_CONST function is required to work correctly with constants only.
      When executed with functions that return types other than those returned by
      Item::field_type (string, int, decimal, or real), the result gets cast to
      one of those types. This cannot happen for constants.
      Fixed by only allowing constants as arguments to NAME_CONST.
      
      
      mysql-test/r/func_misc.result:
        Bug#30832: Test result
      mysql-test/t/func_misc.test:
        Bug#30832: Test case
      sql/item.h:
        Bug#30832: The fix
      52a6c31f
    • unknown's avatar
      Merge macbook:mysql/work/B30587-5.0-opt · cff94452
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B30587-5.1-opt
      
      
      mysql-test/r/func_math.result:
        Auto merged
      mysql-test/t/func_math.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      cff94452
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · ef89cecf
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B30587-5.0-opt
      
      
      sql/item_func.cc:
        Auto merged
      ef89cecf
    • unknown's avatar
      Bug #30587: mysql crashes when trying to group by TIME div NUMBER · 17b09640
      unknown authored
      When calculating the result length of an integer DIV function 
      the number of decimals was used without checking the result type
      first. Thus an uninitialized number of decimals was used for some 
      types. This caused an excessive amount of memory to be allocated 
      for the field's buffer and crashed the server.
      
       
      Fixed by using the number of decimals only for data types that 
      can have decimals and thus have valid decimals number.
      
      
      mysql-test/r/func_math.result:
        Bug #30587: test case
      mysql-test/t/func_math.test:
        Bug #30587: test case
      sql/item_func.cc:
        Bug #30587: Don't use decimals on a type that doesn't have them.
      17b09640
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 85cb523a
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      85cb523a
    • unknown's avatar
      Bug#30795 Query on INFORMATION_SCHEMA.SCHEMATA, wrong result · 77122922
      unknown authored
      skip the check of directory presence for 'information_schema' name
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      sql/sql_show.cc:
        skip the check of directory presence for 'information_schema' name
      77122922
    • unknown's avatar
      Bug#30689 Wrong content in I_S.VIEWS.VIEW_DEFINITION if VIEW is based on I_S · 95cb251c
      unknown authored
      view_body_utf8 attribute type is changed to 'escaped string'
      
      
      mysql-test/r/ddl_i18n_koi8r.result:
        result fix
      mysql-test/r/ddl_i18n_utf8.result:
        result fix
      mysql-test/r/information_schema.result:
        result fix
      mysql-test/t/information_schema.test:
        test case
      95cb251c
    • unknown's avatar
      Bug#30665: Post-merge fix · 256cc88d
      unknown authored
      256cc88d
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.1-opt · 52ff4cbf
      unknown authored
      into  dl145s.mysql.com:/data0/mhansson/my51-bug30665
      
      
      sql/sql_select.cc:
        Auto merged
      52ff4cbf
    • unknown's avatar
      Bug#30665: Inconsistent optimization of IGNORE INDEX FOR {ORDER BY|GROUP BY} · ad2fb477
      unknown authored
      The optimizer takes different execution paths during EXPLAIN than SELECT,
      this fix relates only to EXPLAIN, hence no behavior changes.
      The test of sort keys for ORDER BY was prohibited from considering keys
      that were mentioned in IGNORE KEYS FOR ORDER BY. This led to two 
      inconsistencies: One was that IGNORE INDEX FOR GROUP BY and 
      IGNORE INDEX FOR ORDER BY gave apparently different EXPLAINs; the latter 
      erroneously claimed to do filesort. The second inconsistency 
      is that the test of sort keys is called twice, finding a sort key the first
      time but not the second time, leading to the mentioned filesort.
      
      Fixed by making the test of sort keys consider all enabled 
      keys on the table. This test rejects keys that are not covering, and for 
      covering keys the hint should be ignored anyway. 
      
      
      mysql-test/r/group_by.result:
        Bug#30665: Changed test result. The plan gets more efficient here. 
        The output is included in order to show that it is still correct.
      mysql-test/r/order_by.result:
        Bug#30665: Test result
      mysql-test/t/group_by.test:
        Bug#30665: Changed test case to show correctness of changed plan
      mysql-test/t/order_by.test:
        Bug#30665: Test case
      sql/sql_select.cc:
        Bug#30665: 
        - the fix: Give test_if_skip_sort_order all keys not the subset of non-disabled keys.
        - Added comment to test_if_skip_sort_order
      ad2fb477
  6. 27 Sep, 2007 10 commits
  7. 26 Sep, 2007 5 commits
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/users/gshchepa/5.1-opt-31075 · 706b7d87
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      706b7d87
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.1-opt-29985 · a4a17920
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      a4a17920
    • unknown's avatar
      merge of the fix for bug 27802 & 27216 to 5.1-opt · 05d767db
      unknown authored
      
      mysql-test/r/view.result:
        merge of the fix for bug 27802 to 5.1
      sql/item_cmpfunc.h:
        merge of the fix for bug 27216 to 5.1
      sql/sql_insert.cc:
        merge of the fix for bug 27216 to 5.1
      sql/sql_lex.h:
        merge of the fix for bug 27802 to 5.1
      sql/sql_select.cc:
        merge of the fix for bug 27802 to 5.1
      sql/table.h:
        merge of the fix for bug 27802 to 5.1
      05d767db
    • unknown's avatar
      merged bug 28702 5.0-opt->5.1-opt · baaff867
      unknown authored
      
      mysql-test/r/view.result:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/table.h:
        Auto merged
      baaff867
    • unknown's avatar
      Fixed bug #31075. · 508e2bb9
      unknown authored
      The `SELECT col FROM t WHERE col NOT IN (col, ...) GROUP BY col'
      crashed in the range optimizer.
      
      The get_func_mm_tree function has been modified to check the
      Item_func_in::array field for the NULL value before using of that
      value.
      
      
      sql/opt_range.cc:
        Fixed bug #31075.
        The get_func_mm_tree function has been modified to check the
        Item_func_in::array field for the NULL value before using of that
        value.
      mysql-test/t/func_in.test:
        Added test case for bug #31075.
      mysql-test/r/func_in.result:
        Added test case for bug #31075.
      508e2bb9
  8. 24 Sep, 2007 4 commits
    • unknown's avatar
      Merge sunlight.local:/local_work/27216-bug-5.0-opt-mysql · 29da4baf
      unknown authored
      into  sunlight.local:/local_work/merge-5.1-opt-mysql
      
      
      libmysql/libmysql.c:
        Auto merged
      mysql-test/r/date_formats.result:
        Auto merged
      mysql-test/r/insert_select.result:
        Auto merged
      mysql-test/t/insert_select.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/protocol.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      mysql-test/r/type_datetime.result:
        Manually merged
      mysql-test/t/type_datetime.test:
        Manually merged
      sql/item_cmpfunc.cc:
        Manually merged
      sql/item_cmpfunc.h:
        Manually merged
      sql/sql_insert.cc:
        Manually merged
      29da4baf
    • unknown's avatar
      Bug #28702: VIEWs defined with USE/FORCE KEY ignore that request · 6c3aa88e
      unknown authored
      When storing the VIEW the CREATE VIEW command is reconstructed 
      from the parse tree. While constructing the command string
      the index hints specified should also be printed.
      Fixed by adding code to print the index hints when printing a 
      table in the FROM clause.
      
      
      mysql-test/r/view.result:
        Bug #28702: test case
      mysql-test/t/view.test:
        Bug #28702: test case
      sql/sql_select.cc:
        Bug #28702: preserve index hints in a VIEW definition.
      sql/table.h:
        Bug #28702: preserve index hints in a VIEW definition.
      6c3aa88e
    • unknown's avatar
      merging bug 28701 to 5.1-opt · ba5fd4e7
      unknown authored
      ba5fd4e7
    • unknown's avatar
      merge of bug 28701 5.0-opt -> 5.1-opt · 68bca00b
      unknown authored
      
      sql/sql_view.cc:
        Auto merged
      68bca00b