1. 02 Feb, 2018 1 commit
  2. 01 Feb, 2018 11 commits
  3. 31 Jan, 2018 3 commits
  4. 30 Jan, 2018 4 commits
    • Vladislav Vaintroub's avatar
      Roles : Initialize variables that are passed to update_role_db() · c744dde7
      Vladislav Vaintroub authored
      Fixes "uninitialized variable used"  crashes (Windows compiled for
      debug  e.g /RTC1 option)
      
      Also enable roles suite on buildbot.
      c744dde7
    • Marko Mäkelä's avatar
      MDEV-11415 Remove excessive undo logging during ALTER TABLE…ALGORITHM=COPY · 0ba6aaf0
      Marko Mäkelä authored
      If a crash occurs during ALTER TABLE…ALGORITHM=COPY, InnoDB would spend
      a lot of time rolling back writes to the intermediate copy of the table.
      To reduce the amount of busy work done, a work-around was introduced in
      commit fd069e2b in MySQL 4.1.8 and 5.0.2,
      to commit the transaction after every 10,000 inserted rows.
      
      A proper fix would have been to disable the undo logging altogether and
      to simply drop the intermediate copy of the table on subsequent server
      startup. This is what happens in MariaDB 10.3 with MDEV-14717,MDEV-14585.
      In MariaDB 10.2, the intermediate copy of the table would be left behind
      with a name starting with the string #sql.
      
      This is a backport of a bug fix from MySQL 8.0.0 to MariaDB,
      contributed by jixianliang <271365745@qq.com>.
      
      Unlike recent MySQL, MariaDB supports ALTER IGNORE. For that operation
      InnoDB must for now keep the undo logging enabled, so that the latest
      row can be rolled back in case of an error.
      
      In Galera cluster, the LOAD DATA statement will retain the existing
      behaviour and commit the transaction after every 10,000 rows if
      the parameter wsrep_load_data_splitting=ON is set. The logic to do
      so (the wsrep_load_data_split() function and the call
      handler::extra(HA_EXTRA_FAKE_START_STMT)) are joint work
      by Ji Xianliang and Marko Mäkelä.
      
      The original fix:
      
      Author: Thirunarayanan Balathandayuthapani <thirunarayanan.balathandayuth@oracle.com>
      Date:   Wed Dec 2 16:09:15 2015 +0530
      
      Bug#17479594 AVOID INTERMEDIATE COMMIT WHILE DOING ALTER TABLE ALGORITHM=COPY
      
      Problem:
      
      During ALTER TABLE, we commit and restart the transaction for every
      10,000 rows, so that the rollback after recovery would not take so long.
      
      Fix:
      
      Suppress the undo logging during copy alter operation. If fts_index is
      present then insert directly into fts auxiliary table rather
      than doing at commit time.
      
      ha_innobase::num_write_row: Remove the variable.
      
      ha_innobase::write_row(): Remove the hack for committing every 10000 rows.
      
      row_lock_table_for_mysql(): Remove the extra 2 parameters.
      
      lock_get_src_table(), lock_is_table_exclusive(): Remove.
      Reviewed-by: default avatarMarko Mäkelä <marko.makela@oracle.com>
      Reviewed-by: default avatarShaohua Wang <shaohua.wang@oracle.com>
      Reviewed-by: default avatarJon Olav Hauglid <jon.hauglid@oracle.com>
      0ba6aaf0
    • Jan Lindström's avatar
      MDEV-14875: galera_new_cluster crashes mysqld when existing server contains databases · 446b3d35
      Jan Lindström authored
      Fortify wsrep_hton so that wsrep calls are not done to NULL-pointers.
      446b3d35
    • Monty's avatar
      Fix some wrong test result · cea431e1
      Monty authored
      - Galera tests that was not updated with connection change
        messages
      - Disabled some TokuDB tests that always timed out.
        These should be enabled again when we have an option to
        specicy timeouts per tests.
      cea431e1
  5. 29 Jan, 2018 3 commits
  6. 28 Jan, 2018 1 commit
  7. 27 Jan, 2018 3 commits
    • Monty's avatar
      Fixed compiler warnings · 95f39339
      Monty authored
      Only warnings, should not have caused any bugs in old code
      95f39339
    • Monty's avatar
      Disable rocksdb when building with ASAN · 8ff5ddae
      Monty authored
      I disabled rocksdb in ASAN build as I got a link error when
      it's included
      8ff5ddae
    • Andrei Elkin's avatar
      MDEV-14721 Big transaction events get lost on semisync master when · c09371dc
      Andrei Elkin authored
                 replicate_events_marked_for_skip=FILTER_ON_MASTER
      
      When events of a big transaction are binlogged offsetting over 2GB from
      the beginning of the log the semisync master's dump thread
      lost such events.
      The events were skipped by the Dump thread that found their skipping
      status erroneously.
      
      The current fixes make sure the skipping status is computed correctly.
      The test verifies them simulating the 2GB offset.
      c09371dc
  8. 26 Jan, 2018 6 commits
  9. 25 Jan, 2018 1 commit
  10. 24 Jan, 2018 4 commits
    • Monty's avatar
      Fix for MDEV-12730 · 7fc25cfb
      Monty authored
      Assertion `count > 0' failed in rpl_parallel_thread_pool::
      get_thread, rpl.rpl_parallel failed in buildbot
      
      The reason for this is that one thread can call
      rpl_parallel_resize_pool_if_no_slaves() while
      another thread calls at the same time
      rpl_parallel_activate_pool(). If rpl_parallel_active_pool() is
      called before rpl_parallel_resize_pool_if_no_slaves() has
      finished, pool->count will be set to 0 even if there exists
      active slave threads.
      
      Added a mutex lock in rpl_parallel_activate_pool() to protect against this scenario, which seams to fix this issue.
      7fc25cfb
    • Monty's avatar
      MDEV-15057 Crash when using an unknown identifier as an SP parameter · 0dbe3dbe
      Monty authored
      It crashed because we accessed lex->current_select when
      it was a NULL, which is the case for SP parameters or
      local variables.
      0dbe3dbe
    • Marko Mäkelä's avatar
    • Marko Mäkelä's avatar
      MDEV-15016: multiple page cleaner threads use a lot of CPU · ac3e7f78
      Marko Mäkelä authored
      While the bug was reported as a regression of
      MDEV-11025 Make number of page cleaner threads variable dynamic
      in MariaDB Server 10.3, the code that MariaDB Server 10.2
      inherited from MySQL 5.7.4 (WL#6642) looks prone to similar errors.
      
      pc_flush_slot(): If there is no work to do, reset the is_requested
      signal, to avoid potential busy-waiting in
      buf_flush_page_cleaner_worker(). If the coordinator thread has shut
      down, avoid resetting the is_requested event, to avoid a potential
      hang at shutdown if there are multiple worker threads.
      ac3e7f78
  11. 23 Jan, 2018 3 commits