- 24 Jul, 2010 4 commits
-
-
Vladislav Vaintroub authored
Fix some issues with WiX packaging, particularly major upgrade and change scenarios. * remember binary location and data location (for major upgrade) * use custom UI, which is WiX Mondo extended for major upgrade dialog (no feature selection screen shown on major upgrade, only upgrade confirmation). This is necessary to prevent changing installation path during upgrade (services are not reregistered, so they would have invalid binary path is it is changed) * Hide datafiles that are installed into ProgramFiles, show ones that are installed in ProgramData * Make MSI buildable with nmake * Fix autotools "make dist" Makefile.am: Fix autotools "make dist" configure.in: Fix autotools "make dist" packaging/Makefile.am: Fix autotools "make dist" packaging/WiX/CMakeLists.txt: Use custom UI, for major upgrades packaging/WiX/CPackWixConfig.cmake: Show user editable datafiles in feature selection dialog, not datafiles installed into ProgramFiles directory packaging/WiX/create_msi.cmake.in: Use custom UI, fix nmake build for installer packaging/WiX/custom_ui.wxs: Use custom UI packaging/WiX/extra.wxs.in: Show user editable datafiles in feature selection dialog, not datafiles installed into ProgramFiles directory packaging/WiX/mysql_server.wxs.in: Remember install locations of binaries and user editable datafiles.
-
Davi Arnaut authored
Fix assorted warnings in order for the warning-mode to be effective.
-
Davi Arnaut authored
-
Davi Arnaut authored
Post-merge fix: remove remaining casts which are now unnecessary and are actually causing warnings.
-
- 23 Jul, 2010 10 commits
-
-
Davi Arnaut authored
Remove wrappers around inline -- static inline is used without wrappers throughout the source code. We rely on the compiler or linker to eliminate unused static functions.
-
Davi Arnaut authored
Remove workarounds for ancient systems. mysys/default.c: Make cast more explicit to ensure a correct offset.
-
Davi Arnaut authored
Remove unused string functions. include/m_string.h: Remove prototypes for unused string functions and for functions that do not exist anymore.
-
Davi Arnaut authored
Remove unused macros or macro which are always defined. include/my_global.h: Remove unused macros and move macros which aren't used globally.
-
Davi Arnaut authored
Remove the obsolete and buggy bmove512, use memcpy instead.
-
Davi Arnaut authored
Remove the ancient and dead raid code. By now, even the server side has been removed.
-
Davi Arnaut authored
Remove unused source code and associated paraphernalia.
-
Davi Arnaut authored
Remove Windows related files which aren't used anymore.
-
Davi Arnaut authored
Remove unused variables.
-
Davi Arnaut authored
Remove code that has been disabled for a long time.
-
- 20 Jul, 2010 1 commit
-
-
Davi Arnaut authored
-
- 23 Jul, 2010 3 commits
-
-
Davi Arnaut authored
Bug#52261: 64 bit atomic operations do not work on Solaris i386 gcc in debug compilation One of the various problems was that the source operand to CMPXCHG8b was marked as a input/output operand, causing GCC to use the EBX register as the destination register for the CMPXCHG8b instruction. This could lead to crashes as the EBX register is also implicitly used by the instruction, causing the value to be potentially garbaged and a protection fault once the value is used to access a position in memory. Another problem was the lack of proper clobbers for the atomic operations and, also, a discrepancy between the implementations for the Compare and Set operation. The specific problems are described and fixed by Kristian Nielsen patches: Patch: 1 Fix bugs in my_atomic_cas*(val,cmp,new) that *cmp is accessed after CAS succeds. In the gcc builtin implementation, problem was that *cmp was read again after atomic CAS to check if old *val == *cmp; this fails if CAS is successful and another thread modifies *cmp in-between. In the x86-gcc implementation, problem was that *cmp was set also in the case of successful CAS; this means there is a window where it can clobber a value written by another thread after successful CAS. Patch 2: Add a GCC asm "memory" clobber to primitives that imply a memory barrier. This signifies to GCC that any potentially aliased memory must be flushed before the operation, and re-read after the operation, so that read or modification in other threads of such memory values will work as intended. In effect, it makes these primitives work as memory barriers for the compiler as well as the CPU. This is better and more correct than adding "volatile" to variables. include/atomic/gcc_builtins.h: Do not read from *cmp after the operation as it might be already gone if the operation was successful. include/atomic/nolock.h: Prefer system provided atomics over the broken x86 asm. include/atomic/x86-gcc.h: Do not mark source operands as input/output operands. Add proper memory clobbers. include/my_atomic.h: Add notes about my_atomic_add and my_atomic_cas behaviors. unittest/mysys/my_atomic-t.c: Remove work around, if it fails, there is either a problem with the atomic operations code or the specific compiler version should be black-listed.
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
- 20 Jul, 2010 2 commits
-
-
Jonathan Perkin authored
-
Alexander Nozdrin authored
-
- 19 Jul, 2010 7 commits
-
-
Davi Arnaut authored
-
Evgeny Potemkin authored
This bug is a design flaw of the fix for the bug#33546. It assumed that an item can be used only in one comparison context, but actually it isn't the case. Item_cache_datetime is used to store result for MIX/MAX aggregate functions. Because Arg_comparator always compares datetime values as INTs when possible the Item_cache_datetime most time caches only INT value. But since all datetime values has STRING result type MIN/MAX functions are asked for a STRING value when the result is being sent to a client. The Item_cache_datetime was designed to avoid conversions and get INT/STRING values from an underlying item, but at the moment the values is asked underlying item doesn't hold it anymore thus wrong result is returned. Beside that MIN/MAX aggregate functions was wrongly initializing cached result and this led to a wrong result. The Item::has_compatible_context helper function is added. It checks whether this and given items has the same comparison context or can be compared as DATETIME values by Arg_comparator. The equality propagation optimization is adjusted to take into account that items which being compared as DATETIME can have different comparison contexts. The Item_cache_datetime now converts cached INT value to a correct STRING DATETIME value by means of number_to_datetime & my_TIME_to_str functions. The Arg_comparator::set_cmp_context_for_datetime helper function is added. It sets comparison context of items being compared as DATETIMEs to INT if items will be compared as longlong. The Item_sum_hybrid::setup function now correctly initializes its result value. In order to avoid unnecessary conversions Item_sum_hybrid now states that it can provide correct longlong value if the item being aggregated can do it too. mysql-test/r/group_by.result: Added a test case for the bug#49771. sql/item.cc: Bug#49771: Incorrect MIN/MAX for date/time values. The equality propagation mechanism is adjusted to take into account that items which being compared as DATETIME can have different comparison contexts. The Item_cache_datetime now converts cached INT value to a correct STRING DATETIME/TIME value. sql/item.h: Bug#49771: Incorrect MIN/MAX for date/time values. The Item::has_compatible_context helper function is added. It checks whether this and given items has the same comparison context or can be compared as DATETIME values by Arg_comparator. Added Item_cache::clear helper function. sql/item_cmpfunc.cc: Bug#49771: Incorrect MIN/MAX for date/time values. The Arg_comparator::set_cmp_func now sets the correct comparison context for items being compared as DATETIME values. sql/item_cmpfunc.h: Bug#49771: Incorrect MIN/MAX for date/time values. The Arg_comparator::set_cmp_context_for_datetime helper function is added. It sets comparison context of items being compared as DATETIMEs to INT if items will be compared as longlong. sql/item_sum.cc: Bug#49771: Incorrect MIN/MAX for date/time values. The Item_sum_hybrid::setup function now correctly initializes its result value. sql/item_sum.h: Bug#49771: Incorrect MIN/MAX for date/time values. In order to avoid unnecessary conversions Item_sum_hybrid now states that it can provide correct longlong value if the item being aggregated can do it too.
-
Jonathan Perkin authored
Put '-features=no%except' back into Solaris/x86 CXXFLAGS.
-
Alexander Nozdrin authored
Conflicts: - scripts/CMakeLists.txt
-
unknown authored
-
Jon Olav Hauglid authored
-
Jon Olav Hauglid authored
This assert checks that the server does not try to send OK to the client if there has been some error during processing. This is done to make sure that the error is in fact sent to the client. The problem was that view errors during processing of WHERE conditions in UPDATE statements where not detected by the update code. It therefore tried to send OK to the client, triggering the assert. The bug was only noticeable in debug builds. This patch fixes the problem by making sure that the update code checks for errors during condition processing and acts accordingly.
-
- 17 Jul, 2010 2 commits
-
-
Davi Arnaut authored
Post-merge fix: remove leftovers from safemalloc removal.
-
Andrei Elkin authored
-
- 16 Jul, 2010 11 commits
-
-
Davi Arnaut authored
-
Andrei Elkin authored
applying bundle made for next-mr-bugfixing to trunk-bugfixing branch of the bug
-
Andrei Elkin authored
applying bundle made for next-mr-bugfixing to trunk-bugfixing branch of the bug
-
Davi Arnaut authored
-
Davi Arnaut authored
Bug#47139: Test "merge" crashes in "embedded" run Backport patch for Bug#47139
-
Georgi Kodinov authored
-
Marc Alff authored
Backport from mysql-next-mr (5.6) to mysql-trunk (5.5)
-
Marc Alff authored
Backport from mysql-next-mr (5.6) to mysql-trunk (5.5)
-
Marc Alff authored
Backport from mysql-next-mr (5.6) to mysql-trunk (5.5)
-
Marc Alff authored
Backport from mysql-next-mr (5.6) to mysql-trunk (5.5)
-
Georgi Kodinov authored
-