1. 11 Sep, 2019 1 commit
  2. 09 Sep, 2019 1 commit
  3. 04 Sep, 2019 1 commit
  4. 03 Sep, 2019 2 commits
  5. 01 Sep, 2019 1 commit
  6. 28 Aug, 2019 2 commits
  7. 27 Aug, 2019 2 commits
  8. 26 Aug, 2019 2 commits
    • Julius Goryavsky's avatar
      MDEV-20420: SST failed after MDEV-18863 in some test configurations · de0f93fb
      Julius Goryavsky authored
      After applying MDEV-18863, in some test configurations, SST
      may fails due to duplication of some parameters (in particular
      "--port") in the main part of the command line and after
      "--mysqld-args", as well as due to incorrect interpretation
      of the parameter "--port" passed after "--mysqld-args" when
      the SST script is invoked without explicitly specifying a port
      for SST. In addition, it is necessary to correctly handle spaces,
      quotation marks and special characters when copying original
      arguments from the argv[] array to a new command line (after
      "--mysqld-args"). This patch resolves these shortcomings.
      de0f93fb
    • Sujatha's avatar
      MDEV-20188: binlog.binlog_stm_drop_tmp_tbl fails in buildbot with Unknown table on exec · 4a9fb905
      Sujatha authored
      Analysis:
      ========
      As part of BUG#28642318 fix, two new test cases were added. The first test
      case tests a scenario where two sessions are present, in which the first
      session has a regular table named 't1' and another session has a temporary
      table named 't1'. Test executes a DELETE statement on regular table. These
      statements are captured from binary log and replayed back on new client
      connection to prove that DELETE statement is applied successfully. Note that
      the binlog contains only CREATE TEMPORARY TABLE part hence a temporary table
      gets created in new connection. This replaying logic is implemented by using
      '--exec $MYSQL' command. If the new connection gets disconnected within the
      scope of first test case the test passes, i.e the temporary table gets dropped
      as part thread cleanup. But on slow platforms the connection gets closed at
      the time of execution of test case 2. When the temporary table is dropped as
      part thread cleanup a "DROP TEMPORARY TABLE t1" is written into the binary
      log. In test case two the same sessions continue to exist and and table names
      are reused to test a new bug scenario. The additional "DROP TEMPORARY TABLE"
      command drops second test specific tables which results in "Unknown table"
      error.
      
      Fix:
      ====
      Rename the second case specific table to 't2'. Even if the close connection
      from test case one happens later the drop command with has
      'DROP /*!40005 TEMPORARY */ TABLE IF EXISTS `t1`' will not result in an error.
      4a9fb905
  9. 22 Aug, 2019 2 commits
  10. 21 Aug, 2019 2 commits
  11. 20 Aug, 2019 5 commits
  12. 19 Aug, 2019 2 commits
    • Julius Goryavsky's avatar
      MDEV-18863: Galera SST scripts can't read [mysqldN] option groups · 457dc9d6
      Julius Goryavsky authored
      Some users and some scripts (for example, mysqld_multi.sh) use special
      option groups with names like [mysqld1], [mysqld2], ..., [mysqldN].
      
      But SST scripts can't currently fully support these option groups.
      The only option group-related value it gets from the server is
      --defaults-group-suffix, if that option was set for mysqld when
      the server was started.
      
      However, the SST scripts does not get told by the server to read
      these option groups, so this means that the SST script will fail
      to read options like innodb-data-home-dir when it is in a option
      group like [mysqld1]...[mysqldN].
      
      Moreover, SST scripts ignore many parameters that can be passed
      to them explicitly and cannot transfer them further, for example,
      to the input of mariabackup utility. Ideally, we want to transfer
      all the parameters of the original mysqld call to utilities such
      as mariabackup, however the SST script does not receive these
      parameters from the server and therefore cannot transfer them to
      mariabackup.
      
      To correct these shortcomings, we need to transfer to the scripts
      all of the parameters of the original mysqld call, and in the SST
      scripts themselves provide for the transfer all of these parameters
      to utilities such as mariabackup. To prevent these parameters from
      mixing with the script's own parameters, they should be transferred
      to SST script after the special option "--mysqld-args", followed by
      the string argument with the original parameters, as it received by
      the mysqld call at the time of launch (further all these parameters
      will be passed to mariabackup, for example).
      
      In addition, the SST scripts themselves must be refined so that
      they can read the parameters from the user-selected group, not just
      from the global mysqld configuration group. And also so that they
      can receive the parameters (which important for their work) as
      command-line arguments.
      457dc9d6
    • Igor Babaev's avatar
      MDEV-20265 Unknown column in field list · e746f451
      Igor Babaev authored
      This patch corrects the fix of the patch for mdev-19421 that resolved
      the problem of parsing some embedded join expressions such as
        t1 join t2 left join t3 on t2.a=t3.a on t1.a=t2.a.
      Yet the patch contained a bug that prevented proper context analysis
      of the queries where such expressions were used together with comma
      separated table references in from clauses.
      e746f451
  13. 16 Aug, 2019 4 commits
    • Alexander Barkov's avatar
      f987de71
    • Sergei Petrunia's avatar
      MDEV-19834 Selectivity of an equality condition discounted twice · ecdacf72
      Sergei Petrunia authored
      Update test results.
      ecdacf72
    • Alexander Barkov's avatar
      MDEV-15955 Assertion `field_types == 0 || field_types[field_pos] ==... · ec1f195e
      Alexander Barkov authored
      MDEV-15955 Assertion `field_types == 0 || field_types[field_pos] == MYSQL_TYPE_LONGLONG' failed in Protocol_text::store_longlong
      ec1f195e
    • Jan Lindström's avatar
      MDEV-18778: mysql_tzinfo_to_sql does not work correctly in MariaDB Galera · fa740888
      Jan Lindström authored
      There were two problems:
      
      (1) If user wanted same time zone information on all nodes in the Galera
      cluster all updates were not replicated as time zone information was
      stored on MyISAM tables. This is fixed on Galera by altering time zone
      tables to InnoDB while they are modified.
      
      (2) If user wanted different time zone information to nodes in the Galera
      cluster TRUNCATE TABLE for time zone tables was replicated by Galera
      destroying time zone information from other nodes. This is fixed
      on Galera by introducing new option for mysql_tzinfo_to_sql_symlink
      tool --skip-write-binlog to disable Galera replication while
      time zone tables are modified.
      
      Changes to be committed:
      	modified:   mysql-test/r/mysql_tzinfo_to_sql_symlink.result
      	modified:   mysql-test/suite/wsrep/r/mysql_tzinfo_to_sql_symlink.result
      	new file:   mysql-test/suite/wsrep/r/mysql_tzinfo_to_sql_symlink_skip.result
      	new file:   mysql-test/suite/wsrep/t/mysql_tzinfo_to_sql_symlink_skip.test
      	modified:   sql/tztime.cc
      fa740888
  14. 15 Aug, 2019 1 commit
  15. 13 Aug, 2019 3 commits
  16. 12 Aug, 2019 4 commits
  17. 09 Aug, 2019 1 commit
    • Sachin's avatar
      MDEV-17614 INSERT on dup key update is replication unsafe · 284c72ea
      Sachin authored
      Problem:-
      When mysql executes INSERT ON DUPLICATE KEY INSERT, the storage engine checks
      if the inserted row would generate a duplicate key error. If yes, it returns
      the existing row to mysql, mysql updates it and sends it back to the storage
      engine.When the table has more than one unique or primary key, this statement
      is sensitive to the order in which the storage engines checks the keys.
      Depending on this order, the storage engine may determine different rows
      to mysql, and hence mysql can update different rows.The order that the
      storage engine checks keys is not deterministic. For example, InnoDB checks
      keys in an order that depends on the order in which indexes were added to
      the table. The first added index is checked first. So if master and slave
      have added indexes in different orders, then slave may go out of sync.
      
      Solution:-
      Make INSERT...ON DUPLICATE KEY UPDATE unsafe while using stmt or mixed format
      When there is more then one unique key.
      Although there is two exception.
        1. Auto Increment key is not counted because Innodb will get gap lock for
          failed Insert and concurrent insert will get a next increment value. But if
          user supplies auto inc value it can be unsafe.
        2. Count only unique keys for which insertion is performed.
      
      So this patch also addresses the bug id #72921
      284c72ea
  18. 07 Aug, 2019 1 commit
  19. 05 Aug, 2019 1 commit
    • Sujatha's avatar
      MDEV-18930: Failed CREATE OR REPLACE TEMPORARY not written into binary log... · eef75404
      Sujatha authored
      MDEV-18930: Failed CREATE OR REPLACE TEMPORARY not written into binary log makes data on master and slave diverge
      
      Problem:
      =======
      Failed CREATE OR REPLACE TEMPORARY TABLE statement which dropped the table but
      failed at a later stage of creation of temporary table is not written to
      binarylog in row based replication. This causes the slave to diverge.
      
      Analysis:
      ========
      CREATE OR REPLACE statements work as shown below.
      
      CREATE OR REPLACE TABLE table_name (a int);
      is basically the same as:
      
      DROP TABLE IF EXISTS table_name;
      CREATE TABLE table_name (a int);
      
      Hence every CREATE OR REPLACE TABLE command which dropped the table should be
      written to binary log, even when following CREATE TABLE part fails. In order
      to achieve this, during the execution of CREATE OR REPLACE command, when a
      table is dropped 'thd->log_current_statement' flag is set. When table creation
      results in an error within 'mysql_create_table' code, the error handling part
      looks for this flag. If it is set the failed CREATE OR REPLACE statement is
      written into the binary log inspite of error. This ensure that slave doesn't
      diverge from the master. In case of row based replication the error handling
      code returns very early, if the table is of type temporary. This is done based
      on the assumption that temporary tables are not replicated in row based
      replication.
      
      It fails to handle the cases where a temporary table was created as part of
      statement based replication at an earlier stage and the binary log format was
      changed to row because of an unsafe statement. In this case when a CREATE OR
      REPLACE statement is executed on this temporary table it will dropped but the
      query will not be written to binary log. Hence slave diverges.
      
      Fix:
      ===
      In error handling code check the return status of create table operation. If
      it is successful and replication mode is row based and table is of type
      temporary then return. Other wise proceed further to the code which checks for
      thd->log_current_statement flag and does appropriate logging.
      eef75404
  20. 01 Aug, 2019 1 commit
  21. 31 Jul, 2019 1 commit