1. 27 May, 2020 6 commits
  2. 26 May, 2020 2 commits
    • Sergey Vojtovich's avatar
      MDEV-22697 - InnoDB: remove trx->no · 03dcdad2
      Sergey Vojtovich authored
      trx->no is duplicated by trx->rw_trx_hash_element->no for no good reason.
      The latter is preferred for performance reasons: allows to avoid taking
      trx->rw_trx_hash_element->mutex when snapshotting.
      03dcdad2
    • Sergey Vojtovich's avatar
      MDEV-22593 - InnoDB: don't take trx_sys.mutex in ReadView::open() · 50b0ce44
      Sergey Vojtovich authored
      This was the last abuse of trx_sys.mutex, which is now exclusively
      protecting trx_sys.trx_list.
      
      This global acquisition was also potential scalability bottleneck for
      oltp_read_write benchmark. Although it didn't expose itself as such due
      to larger scalability issues.
      
      Replaced trx_sys.mutex based synchronisation between ReadView creator
      thread and purge coordinator thread performing latest view clone with
      ReadView::m_mutex.
      
      It also allowed to simplify tri-state view m_state down to boolean
      m_open flag.
      
      For performance reasons trx->read_view.close() is left as atomic relaxed
      store, so that we don't have to waste resources for otherwise meaningless
      mutex acquisition.
      50b0ce44
  3. 25 May, 2020 5 commits
  4. 24 May, 2020 1 commit
  5. 23 May, 2020 20 commits
    • Monty's avatar
      Fixed failure in sysvars_server_embedded,32bit · 6532b100
      Monty authored
      Updated the corresponding rdiff file
      6532b100
    • Monty's avatar
      Fixed failure in flush_read_lock.test · fc8359f0
      Monty authored
      The failure was:
      mysqltest: At line 1737: query 'reap' failed: 1397: XAER_NOTA: Unknown XID
      
      The bug was in the test case int that it executed REAP XA COMMIT before
      the connection had truly disconnected
      fc8359f0
    • Monty's avatar
      Fixed error in galera_vote_rejoin_ddl · c779ef26
      Monty authored
      The bug was that sometimes one get check errors like:
      -AUTO_INCREMENT_OFFSET  4
      +AUTO_INCREMENT_OFFSET  3
      c779ef26
    • Monty's avatar
      Only apply wsrep_trx_fragment_size to InnoDB tables · f4ddde06
      Monty authored
      MDEV-22617 Galera node crashes when trying to log to slow_log table in
      streaming replication mode
      
      Other things:
      - Changed name of wsrep_after_row(two arguments) to
        wsrep_after_row_internal(one argument) to not depended on the
        function signature with unused arguments.
      f4ddde06
    • Monty's avatar
      Fixed access to undefined memory found by valgrind and MSAN · c4bf4b7a
      Monty authored
      When my_vsnprintf() is patched, the code protected disabled with
      'WAITING_FOR_BUGFIX_TO_VSPRINTF' should be enabled again. Also all %b
      formats in this patch should be revert to %s again
      c4bf4b7a
    • Monty's avatar
      Don't print "Trying to delete tablespace several 10x times per second" · dcc0baf5
      Monty authored
      Now this InnoDB message is printed after one second of stalled operations
      and then every 10 seconds
      dcc0baf5
    • Monty's avatar
      Fixed compiler warnings from gcc and clang 5.0.1 · 4ea171ff
      Monty authored
      4ea171ff
    • Monty's avatar
      9bf479b0
    • Monty's avatar
      Aria will now register it's transactions · 4102f158
      Monty authored
      MDEV-22531 Remove maria::implicit_commit()
      MDEV-22607 Assertion `ha_info->ht() != binlog_hton' failed in
                 MYSQL_BIN_LOG::unlog_xa_prepare
      
      From the handler point of view, Aria now looks like a transactional
      engine. One effect of this is that we don't need to call
      maria::implicit_commit() anymore.
      
      This change also forces the server to call trans_commit_stmt() after doing
      any read or writes to system tables.  This work will also make it easier
      to later allow users to have system tables in other engines than Aria.
      
      To handle the case that Aria doesn't support rollback, a new
      handlerton flag, HTON_NO_ROLLBACK, was added to engines that has
      transactions without rollback (for the moment only binlog and Aria).
      
      Other things
      - Moved freeing of MARIA_SHARE to a separate function as the MARIA_SHARE
        can be still part of a transaction even if the table has closed.
      - Changed Aria checkpoint to use the new MARIA_SHARE free function. This
        fixes a possible memory leak when using S3 tables
      - Changed testing of binlog_hton to instead test for HTON_NO_ROLLBACK
      - Removed checking of has_transaction_manager() in handler.cc as we can
        assume that as the transaction was started by the engine, it does
        support transactions.
      - Added new class 'start_new_trans' that can be used to start indepdendent
        sub transactions, for example while reading mysql.proc, using help or
        status tables etc.
      - open_system_tables...() and open_proc_table_for_Read() doesn't anymore
        take a Open_tables_backup list. This is now handled by 'start_new_trans'.
      - Split thd::has_transactions() to thd::has_transactions() and
        thd::has_transactions_and_rollback()
      - Added handlerton code to free cached transactions objects.
        Needed by InnoDB.
      
      squash! 2ed35999f2a2d84f1c786a21ade5db716b6f1bbc
      4102f158
    • Monty's avatar
      Change THD->transaction to a pointer to enable multiple transactions · d1d47264
      Monty authored
      All changes (except one) is of type
      thd->transaction.  -> thd->transaction->
      
      thd->transaction points by default to 'thd->default_transaction'
      This allows us to 'easily' have multiple active transactions for a
      THD object, like when reading data from the mysql.proc table
      d1d47264
    • Monty's avatar
      Fix that BACKUP STAGE BLOCK_COMMIT blocks commit to the Aria engine · 7ae812cf
      Monty authored
      MDEV-22468 BACKUP STAGE BLOCK_COMMIT should block commit in the Aria engine
      
      This is needed to ensure that mariabackup works properly with Aria tables
      
      This code ads new calls to ha_maria::implicit_commit(). These will be
      deleted by MDEV-22531 Remove maria::implicit_commit().
      7ae812cf
    • Monty's avatar
      MDEV-18286 Assertion `pagecache->cnt_for_resize_op ... · b1561563
      Monty authored
      This patch is also pushed in 10.4. It's pushed separately in 10.5 as there
      are some additional cases in 10.5 to take care of.
      
      When merging if there is conflicts, use this code, not the 10.4 code.
      b1561563
    • Monty's avatar
      7cb16096
    • Monty's avatar
      Remove unneeded this-> usage from sql_lex.cc · 82d2dc90
      Monty authored
      82d2dc90
    • Monty's avatar
      Proper fix of User_variables_tracker::store · 36019df3
      Monty authored
      - Don't use 'auto' to declare variables (lazy and makes code harder to read)
      - Fixed length to use correct type
      36019df3
    • Monty's avatar
      b1fabf6c
    • Monty's avatar
      Don't include mysql-test/var* files in git · 93281221
      Monty authored
      I constantly store temporary 'var' directories as var2, var3 for
      comparisons and having them in citool is annyoing
      93281221
    • Monty's avatar
      Fixed typo in variable description · c287dc9b
      Monty authored
      c287dc9b
    • Monty's avatar
      Fixed bug thr_lock_info_init · 610bb1d2
      Monty authored
      This bug didn't cause any issues with current usage
      610bb1d2
    • Monty's avatar
      Update libmarias3 to fix a memory leak · 8cf166bf
      Monty authored
      8cf166bf
  6. 22 May, 2020 3 commits
    • Marko Mäkelä's avatar
      Cleanup: Remove a startup message · 51f0fa4e
      Marko Mäkelä authored
      The GCC __atomic_ functions were removed already in
      commit 2b47f8ff,
      and starting with MariaDB Server 10.4, InnoDB relies mostly
      on C++11 std::atomic.
      51f0fa4e
    • Marko Mäkelä's avatar
      MDEV-22669 InnoDB lacks CRC-32C acceleration on IA-32 · afdd6b1d
      Marko Mäkelä authored
      In mysql/mysql-server@17e497bdb793bc6b8360aa1c626dcd8bb5cfad1b
      MySQL 5.6.3 introduced innodb_checksum_algorithm=crc32 and
      implemented it for AMD64 using the SSE 4.2 instructions
      (incorrectly advertised as "SSE2" in a startup message).
      It was not implemented on IA-32 or on Windows.
      
      Since MariaDB 10.2.11 commit 2401d14e
      we make use of the SSE4.2 CRC-32C instructions on Windows on both IA-32
      and AMD64.
      
      Let us be consistent and implement CRC-32C for IA-32 on all
      available platforms. GCC 4.8.2 and GCC 4.8.5 complain
      "error: PIC register clobbered by 'ebx' in 'asm'"
      so we will only enable this code for IA-32 starting with GCC 5.
      
      Also, we will clean up the implementation further after
      commit 1312b4eb.
      
      has_sse4_2(): Replaces ut_cpuid().
      
      ut_crc32c_8(): Replaces ut_crc32_8_hw().
      
      ut_crc32c_64(): Replaces ut_crc32_64_low_hw(), ut_crc32_64_hw().
      
      ut_crc32_hw(): Rewrite.
      
      ut_crc32c_8_sw(): Replaces ut_crc32_8_sw().
      
      ut_crc32c_64_sw(): Replaces ut_crc32_64_low_sw(), ut_crc32_64_sw().
      
      ut_crc32_sw(): Rewrite. Avoid code bloat and do not unroll the
      ut_crc32c_64_sw() loop, because no benefit has been demonstrated.
      
      ut_crc32_init(): Only invoke ut_crc32_slice8_table_init()
      if no acceleration is available.
      afdd6b1d
    • Marko Mäkelä's avatar
      MDEV-7318: Fix a test case · 14f1453b
      Marko Mäkelä authored
      14f1453b
  7. 20 May, 2020 3 commits