- 27 May, 2020 6 commits
-
-
Sergey Vojtovich authored
InnoDB mutex monitor is accessing mutexes of poisoned (cached) trx objects. Unpoison ReadView::m_mutex similarly to trx_t::mutex. This is regression after MDEV-22593.
-
Monty authored
-
Monty authored
- Remove extra ',' and quotes - Remove extra newline and remove double newlines - Added options --lsn-redo-end and --lsn-undo-end to aria_read_log - Allow one to give the aria_read_log lsn aruments as number,0xhexnumber, the same way as lsn's are written by aria_read_log - Don't write full pages to redo log with EXTRA_DEBUG as this takes up a lot of disk and there has not been a need for this extra loggging for a long time. Instead one should use EXTRA_ARIA_DEBUG instead.
-
Monty authored
-
Marko Mäkelä authored
commit 8ccb3caa micro-optimized page_id_t as a wrapper of uint64_t. buf_dump_t: Remove, and replace with page_id_t, which uses exactly the same encoding. buf_page_info_t: Replace space_id,page_num with page_id_t id. i_s_innodb_set_page_type(): Remove unnecessary code. The buf_page_info_t::id was already assigned at the start of the only caller, i_s_innodb_buffer_page_get_info().
-
Marko Mäkelä authored
-
- 26 May, 2020 2 commits
-
-
Sergey Vojtovich authored
trx->no is duplicated by trx->rw_trx_hash_element->no for no good reason. The latter is preferred for performance reasons: allows to avoid taking trx->rw_trx_hash_element->mutex when snapshotting.
-
Sergey Vojtovich authored
This was the last abuse of trx_sys.mutex, which is now exclusively protecting trx_sys.trx_list. This global acquisition was also potential scalability bottleneck for oltp_read_write benchmark. Although it didn't expose itself as such due to larger scalability issues. Replaced trx_sys.mutex based synchronisation between ReadView creator thread and purge coordinator thread performing latest view clone with ReadView::m_mutex. It also allowed to simplify tri-state view m_state down to boolean m_open flag. For performance reasons trx->read_view.close() is left as atomic relaxed store, so that we don't have to waste resources for otherwise meaningless mutex acquisition.
-
- 25 May, 2020 5 commits
-
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
MDEV-22696 TP_pool_generic::set_pool_size logic so that it marks each connection to change group before the next socket read.
-
Vladislav Vaintroub authored
MDEV-22696 Threadpool : make sure thd->event_scheduler.data does not change as long as THD is in server_threads.
-
Vladislav Vaintroub authored
-
Marko Mäkelä authored
-
- 24 May, 2020 1 commit
-
-
Monty authored
Calling stmt rollback closed the transaction, which caused the above issue
-
- 23 May, 2020 20 commits
-
-
Monty authored
Updated the corresponding rdiff file
-
Monty authored
The failure was: mysqltest: At line 1737: query 'reap' failed: 1397: XAER_NOTA: Unknown XID The bug was in the test case int that it executed REAP XA COMMIT before the connection had truly disconnected
-
Monty authored
The bug was that sometimes one get check errors like: -AUTO_INCREMENT_OFFSET 4 +AUTO_INCREMENT_OFFSET 3
-
Monty authored
MDEV-22617 Galera node crashes when trying to log to slow_log table in streaming replication mode Other things: - Changed name of wsrep_after_row(two arguments) to wsrep_after_row_internal(one argument) to not depended on the function signature with unused arguments.
-
Monty authored
When my_vsnprintf() is patched, the code protected disabled with 'WAITING_FOR_BUGFIX_TO_VSPRINTF' should be enabled again. Also all %b formats in this patch should be revert to %s again
-
Monty authored
Now this InnoDB message is printed after one second of stalled operations and then every 10 seconds
-
Monty authored
-
Monty authored
-
Monty authored
MDEV-22531 Remove maria::implicit_commit() MDEV-22607 Assertion `ha_info->ht() != binlog_hton' failed in MYSQL_BIN_LOG::unlog_xa_prepare From the handler point of view, Aria now looks like a transactional engine. One effect of this is that we don't need to call maria::implicit_commit() anymore. This change also forces the server to call trans_commit_stmt() after doing any read or writes to system tables. This work will also make it easier to later allow users to have system tables in other engines than Aria. To handle the case that Aria doesn't support rollback, a new handlerton flag, HTON_NO_ROLLBACK, was added to engines that has transactions without rollback (for the moment only binlog and Aria). Other things - Moved freeing of MARIA_SHARE to a separate function as the MARIA_SHARE can be still part of a transaction even if the table has closed. - Changed Aria checkpoint to use the new MARIA_SHARE free function. This fixes a possible memory leak when using S3 tables - Changed testing of binlog_hton to instead test for HTON_NO_ROLLBACK - Removed checking of has_transaction_manager() in handler.cc as we can assume that as the transaction was started by the engine, it does support transactions. - Added new class 'start_new_trans' that can be used to start indepdendent sub transactions, for example while reading mysql.proc, using help or status tables etc. - open_system_tables...() and open_proc_table_for_Read() doesn't anymore take a Open_tables_backup list. This is now handled by 'start_new_trans'. - Split thd::has_transactions() to thd::has_transactions() and thd::has_transactions_and_rollback() - Added handlerton code to free cached transactions objects. Needed by InnoDB. squash! 2ed35999f2a2d84f1c786a21ade5db716b6f1bbc
-
Monty authored
All changes (except one) is of type thd->transaction. -> thd->transaction-> thd->transaction points by default to 'thd->default_transaction' This allows us to 'easily' have multiple active transactions for a THD object, like when reading data from the mysql.proc table
-
Monty authored
MDEV-22468 BACKUP STAGE BLOCK_COMMIT should block commit in the Aria engine This is needed to ensure that mariabackup works properly with Aria tables This code ads new calls to ha_maria::implicit_commit(). These will be deleted by MDEV-22531 Remove maria::implicit_commit().
-
Monty authored
This patch is also pushed in 10.4. It's pushed separately in 10.5 as there are some additional cases in 10.5 to take care of. When merging if there is conflicts, use this code, not the 10.4 code.
-
Monty authored
-
Monty authored
-
Monty authored
- Don't use 'auto' to declare variables (lazy and makes code harder to read) - Fixed length to use correct type
-
Monty authored
-
Monty authored
I constantly store temporary 'var' directories as var2, var3 for comparisons and having them in citool is annyoing
-
Monty authored
-
Monty authored
This bug didn't cause any issues with current usage
-
Monty authored
-
- 22 May, 2020 3 commits
-
-
Marko Mäkelä authored
The GCC __atomic_ functions were removed already in commit 2b47f8ff, and starting with MariaDB Server 10.4, InnoDB relies mostly on C++11 std::atomic.
-
Marko Mäkelä authored
In mysql/mysql-server@17e497bdb793bc6b8360aa1c626dcd8bb5cfad1b MySQL 5.6.3 introduced innodb_checksum_algorithm=crc32 and implemented it for AMD64 using the SSE 4.2 instructions (incorrectly advertised as "SSE2" in a startup message). It was not implemented on IA-32 or on Windows. Since MariaDB 10.2.11 commit 2401d14e we make use of the SSE4.2 CRC-32C instructions on Windows on both IA-32 and AMD64. Let us be consistent and implement CRC-32C for IA-32 on all available platforms. GCC 4.8.2 and GCC 4.8.5 complain "error: PIC register clobbered by 'ebx' in 'asm'" so we will only enable this code for IA-32 starting with GCC 5. Also, we will clean up the implementation further after commit 1312b4eb. has_sse4_2(): Replaces ut_cpuid(). ut_crc32c_8(): Replaces ut_crc32_8_hw(). ut_crc32c_64(): Replaces ut_crc32_64_low_hw(), ut_crc32_64_hw(). ut_crc32_hw(): Rewrite. ut_crc32c_8_sw(): Replaces ut_crc32_8_sw(). ut_crc32c_64_sw(): Replaces ut_crc32_64_low_sw(), ut_crc32_64_sw(). ut_crc32_sw(): Rewrite. Avoid code bloat and do not unroll the ut_crc32c_64_sw() loop, because no benefit has been demonstrated. ut_crc32_init(): Only invoke ut_crc32_slice8_table_init() if no acceleration is available.
-
Marko Mäkelä authored
-
- 20 May, 2020 3 commits
-
-
Sergei Golubchik authored
-
Sujatha authored
-
Sujatha authored
MDEV-22451: SIGSEGV in __memmove_avx_unaligned_erms/memcpy from _my_b_write on CREATE after RESET MASTER Merge branch '10.3' into 10.4
-