1. 14 Nov, 2007 1 commit
  2. 13 Nov, 2007 9 commits
    • unknown's avatar
      Merge mysql.com:/home/hf/work/32067/my51-32067 · a552dee2
      unknown authored
      into  mysql.com:/home/hf/work/31305/my51-31305
      
      
      mysql-test/r/partition.result:
        Auto merged
      mysql-test/t/partition.test:
        Auto merged
      a552dee2
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 6268dfeb
      unknown authored
      into  mysql.com:/home/hf/work/31305/my51-31305
      
      6268dfeb
    • unknown's avatar
      de621848
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/autopush/B31562-5.0-opt · ac1e7a85
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B31562-5.1-opt
      
      
      sql/item.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/lowercase_view.result:
        merge bug 31562 5.0->5.1: changed explain format
      ac1e7a85
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 062f27ee
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B31562-5.0-opt
      
      
      sql/item.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      062f27ee
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 347c7a84
      unknown authored
      into  moonbone.local:/work/30081-bug-5.1-opt-mysql
      
      
      client/mysql.cc:
        Auto merged
      mysql-test/r/information_schema.result:
        Auto merged
      mysql-test/r/log_tables.result:
        Auto merged
      mysql-test/t/information_schema.test:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      347c7a84
    • unknown's avatar
      Bug#30081: "ON UPDATE CURRENT_TIMESTAMP" wasn't shown by the SHOW FIELDS · 6c5ffabe
      unknown authored
      command and reported to a client.
      
      The fact that a timestamp field will be set to NO on UPDATE wasn't shown 
      by the SHOW COMMAND and reported to a client through connectors. This led to
      problems in the ODBC connector and might lead to a user confusion.
      
      A new filed flag called ON_UPDATE_NOW_FLAG is added. 
      Constructors of the Field_timestamp set it when a field should be set to NOW
      on UPDATE.
      
      The get_schema_column_record function now reports whether a timestamp field
      will be set to NOW on UPDATE.
      
      
      mysql-test/t/information_schema.test:
        A test case adjusted after fixing the bug#30081.
      mysql-test/r/type_timestamp.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/type_ranges.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/show_check.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/ps_5merge.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/ps_4heap.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/ps_3innodb.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/ps_2myisam.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/metadata.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/log_tables.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/information_schema.result:
        A test case adjusted after fixing the bug#30081.
      mysql-test/r/grant.result:
        Adjusted a test case after fixing bug#30081.
      tests/mysql_client_test.c:
        A test case adjusted after fixing the bug#30081.
      sql/sql_show.cc:
        Bug#30081: "ON UPDATE CURRENT_TIMESTAMP" wasn't shown by the SHOW FIELDS
        command and reported to a client.
        The get_schema_column_record function now reports whether a timestamp field
        will be set to NOW on UPDATE.
      sql/field.cc:
        Bug#30081: "ON UPDATE CURRENT_TIMESTAMP" wasn't shown by the SHOW FIELDS
        command and reported to a client.
        Constructors of the Field_timestamp set the ON_UPDATE_NOW_FLAG on a field when
        it should be set to NOW on UPDATE.
      include/mysql_com.h:
        Bug#30081: "ON UPDATE CURRENT_TIMESTAMP" wasn't shown by the SHOW FIELDS
        command and reported to a client.
        A new filed flag called ON_UPDATE_NOW_FLAG  is added.
      client/mysql.cc:
        Bug#30081: "ON UPDATE CURRENT_TIMESTAMP" wasn't shown by the SHOW FIELDS
        command and reported to a client.
        The fieldflag2str function is adjusted to print the ON_UPDATE_NOW_FLAG.
      6c5ffabe
    • unknown's avatar
      Bug #31562: HAVING and lower case · 5dc81f4f
      unknown authored
      The columns in HAVING can reference the GROUP BY and 
      SELECT columns. There can be "table" prefixes when
      referencing these columns. And these "table" prefixes
      in HAVING use the table alias if available.
      This means that table aliases are subject to the same
      storage rules as table names and are dependent on 
      lower_case_table_names in the same way as the table 
      names are.
      Fixed by :
      1. Treating table aliases as table names
      and make them lowercase when printing out the SQL
      statement for view persistence.
      2. Using case insensitive comparison for table 
      aliases when requested by lower_case_table_names
      
      
      mysql-test/r/lowercase_view.result:
        Bug #31562: test case
      mysql-test/t/lowercase_view.test:
        Bug #31562: test case
      sql/item.cc:
        Bug #31562: lower_case_table_name contious comparison
        when searching in GROUP BY
      sql/sql_base.cc:
        Bug #31562: lower_case_table_name contious comparison
        when searching in SELECT
      sql/sql_select.cc:
        Bug #31562: treat table aliases as table names
        and make them lowercase when printing
      5dc81f4f
    • unknown's avatar
      test fixed · 09d2e2f8
      unknown authored
      
      mysql-test/r/partition_innodb.result:
        result fixed
      mysql-test/t/partition_innodb.test:
        number of subpartitions fixed
      09d2e2f8
  3. 12 Nov, 2007 10 commits
    • unknown's avatar
      Bug #32067 Partitions: crash with timestamp column. · 81d83c1c
      unknown authored
      Partition handler fails updating tables with partitioning
      based on timestamp field, as it calculates the timestamp field
      AFTER it calculates the number of partition of a record.
      
      Fixed by adding timestamp_field->set_time() call and disabling
      such consequent calls
      
      
      mysql-test/r/partition.result:
        Bug #32067 Partitions: crash with timestamp column.
        
        test result
      mysql-test/t/partition.test:
        Bug #32067 Partitions: crash with timestamp column.
        
        test case
      sql/ha_partition.cc:
        Bug #32067 Partitions: crash with timestamp column.
        
        do timestamp_field->set_time() in the ha_partition::update_row()
      81d83c1c
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 4fd3b1a7
      unknown authored
      into  mysql.com:/home/hf/work/mysql-5.1-opt
      
      4fd3b1a7
    • unknown's avatar
      'no innodb engine' test failure fixed · 13db8ea8
      unknown authored
      
      mysql-test/r/partition.result:
        test result fixed
      mysql-test/r/partition_innodb.result:
        test result fixed
      mysql-test/t/partition.test:
        test moved to partition_innodb
      mysql-test/t/partition_innodb.test:
        test moved from partition.test
      13db8ea8
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/mysql-5.0-opt · 1f396959
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      1f396959
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug30666/my51-bug29131 · f42b6193
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/select.result:
        Manual merge.
      mysql-test/t/select.test:
        Manual merge.
      f42b6193
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug30666/my50-bug29131 · eb4c1727
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/select.result:
        Manual merge.
      mysql-test/t/select.test:
        Manual merge.
      eb4c1727
    • unknown's avatar
      Merge mysql.com:/home/hf/work/31305/my50-31305 · b425a905
      unknown authored
      into  mysql.com:/home/hf/work/31305/my51-31305
      
      
      BitKeeper/etc/ignore:
        auto-union
      storage/myisam/mi_dynrec.c:
        Auto merged
      b425a905
    • unknown's avatar
      Merge mysql.com:/home/hf/work/31305/my41-31305 · b07eb0f1
      unknown authored
      into  mysql.com:/home/hf/work/31305/my50-31305
      
      
      BitKeeper/etc/ignore:
        auto-union
      myisam/mi_dynrec.c:
        Auto merged
      b07eb0f1
    • unknown's avatar
      Bug #31305 myisam tables crash when they are near capacity. · 23efd897
      unknown authored
      When we insert a record into MYISAM table which is almost 'full',
      we first write record data in the free space inside a file, and then
      check if we have enough space after the end of the file.
      So if we don't have the space, table will left corrupted.
      Similar error also happens when we updata MYISAM tables.
      
      Fixed by modifying write_dynamic_record and update_dynamic_record functions
      to check for free space before writing parts of a record
      
      
      BitKeeper/etc/ignore:
        Added libmysql_r/client_settings.h libmysqld/ha_blackhole.cc to the ignore list
      myisam/mi_dynrec.c:
        Bug #31305 myisam tables crash when they are near capacity.
        
        now we check space left in table in write_dynamic_record
        and update_dynamic_record functions.
        If we don't have enough room for the new (updated) record, return with the
        error.
      mysql-test/r/almost_full.result:
        New BitKeeper file ``mysql-test/r/almost_full.result''
      mysql-test/t/almost_full.test:
        New BitKeeper file ``mysql-test/t/almost_full.test''
      23efd897
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug30666/my50-bug29131 · be00ae27
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug30666/my51-bug29131
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      be00ae27
  4. 11 Nov, 2007 2 commits
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 8321278f
      unknown authored
      into  mysql.com:/misc/mysql/31700/51-31700
      
      8321278f
    • unknown's avatar
      Merge gleb.loc:/home/uchum/5.0-opt · aa95c4a7
      unknown authored
      into  gleb.loc:/home/uchum/5.1-opt
      
      
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/sp_rcontext.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      mysql-test/r/subselect.result:
        Merge with 5.0-opt.
      mysql-test/t/subselect.test:
        Merge with 5.0-opt.
      aa95c4a7
  5. 10 Nov, 2007 18 commits
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 26126ce0
      unknown authored
      into  mysql.com:/misc/mysql/31700/50-31700
      
      
      sql/sql_select.cc:
        Auto merged
      26126ce0
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · cde21b92
      unknown authored
      into  mysql.com:/scratch/tnurnberg/31700/51-31700
      
      
      sql/sql_select.cc:
        Auto merged
      cde21b92
    • unknown's avatar
      Bug#31700: thd->examined_row_count not incremented for 'const' type queries · fd7ab763
      unknown authored
      add 5.1-specific test showing that 'const' access increments 'examined'
      counter in slow query log.
      
      
      mysql-test/r/log_tables.result:
        5.1-only test showing that 'const' access increments counters
      mysql-test/t/log_tables.test:
        5.1-only test showing that 'const' access increments counters
      fd7ab763
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · c0df12e3
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      c0df12e3
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-28076 · 55fad0d6
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      55fad0d6
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/mysql-5.0-opt · 13451ac1
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      13451ac1
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32202/my51-bug26215 · 440be5ba
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      sql/sql_select.cc:
        Auto merged
      440be5ba
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32202/my50-bug26215 · 158e4dd1
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      158e4dd1
    • unknown's avatar
      Fixed bug #28076: inconsistent binary/varbinary comparison. · 419eb9aa
      unknown authored
      After adding an index the <VARBINARY> IN (SELECT <BINARY> ...)
      clause returned a wrong result: the VARBINARY value was illegally padded
      with zero bytes to the length of the BINARY column for the index search.
      (<VARBINARY>, ...) IN (SELECT <BINARY>, ... ) clauses are affected too.
      
      
      sql/item.cc:
        Fixed bug #28076.
        The Item_cache_str::save_in_field method has been overloaded
        to check cached values for an illegal padding before the saving
        into a field.
      sql/item.h:
        Fixed bug #28076.
        The Item_cache_str::is_varbinary flag has been added and the
        Item_cache_str::save_in_field method has been overloaded to prevent
        cached values from an illegal padding when saving in fields.
        The signature of the Item_cache::get_cache method has been
        changed to accept pointers to Item instead of Item_result
        values.
      sql/item_cmpfunc.cc:
        Fixed bug #28076.
        The Item_in_optimizer::fix_left method has been modified to
        to call Item_cache::get_cache in a new manner.
      sql/item_subselect.cc:
        Fixed bug #28076.
        The subselect_indexsubquery_engine::exec method has been
        modified to take into account field conversion errors
        (copy&paste from subselect_uniquesubquery_engine::exec).
      sql/sp_rcontext.cc:
        Fixed bug #28076.
        The sp_rcontext::create_case_expr_holder method has been
        modified to call Item_cache::get_cache in a new manner.
      sql/sp_rcontext.h:
        Fixed bug #28076.
        The sp_rcontext::create_case_expr_holder method signature
        has been modified to pass Item pointers to the
        Item_cache::get_cache method.
      sql/sql_class.cc:
        Fixed bug #28076.
        The select_max_min_finder_subselect::send_data method has been
        modified to call Item_cache::get_cache in a new manner.
      mysql-test/t/subselect.test:
        Added test case for bug #28076.
      mysql-test/r/subselect.result:
        Added test case for bug #28076.
      419eb9aa
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32202/my50-bug26215 · 61f0d69e
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug32202/my51-bug26215
      
      
      mysql-test/r/group_by.result:
        Manual merge.
      mysql-test/t/group_by.test:
        Manual merge.
      sql/sql_select.cc:
        Manual merge.
      61f0d69e
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 1aa96453
      unknown authored
      into  mysql.com:/home/hf/work/31893/my51-31893
      
      1aa96453
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 6b4f56bf
      unknown authored
      into  mysql.com:/misc/mysql/31700/50-31700
      
      
      sql/sql_select.cc:
        Auto merged
      6b4f56bf
    • unknown's avatar
      Merge mysql.com:/misc/mysql/31700/50-31700 · 2e05c63d
      unknown authored
      into  mysql.com:/misc/mysql/31700/51-31700
      
      
      sql/sql_class.h:
        Auto merged
      sql/sql_select.cc:
        manual merge
      2e05c63d
    • unknown's avatar
      Bug#31700: thd->examined_row_count not incremented for 'const' type queries · d80c681f
      unknown authored
      UNIQUE (eq-ref) lookups result in table being considered as a "constant" table.
      Queries that consist of only constant tables are processed in do_select() in a
      special way that doesn't invoke evaluate_join_record(), and therefore doesn't
      increase the counters join->examined_rows and join->thd->row_count.
      
      The patch increases these counters in this special case.
      
      NOTICE:
      This behavior seems to contradict what the documentation says in Sect. 5.11.4:
      "Queries handled by the query cache are not added to the slow query log, nor
      are queries that would not benefit from the presence of an index because the
      table has zero rows or one row."
      
      No test case in 5.0 as issue shows only in slow query log, and other counters
      can give subtly different values (with regard to counting in create_sort_index(),
      synthetic rows in ROLLUP, etc.).
      
      
      sql/sql_class.h:
        add documentation for some variables
      sql/sql_select.cc:
        Don't forget const tables when counting read records!
      d80c681f
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 1402b141
      unknown authored
      into  mysql.com:/misc/mysql/31800/51-31800
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      1402b141
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 1220e719
      unknown authored
      into  mysql.com:/scratch/tnurnberg/31800/50-31800
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      1220e719
    • unknown's avatar
      Merge mysql.com:/misc/mysql/31800/50-31800 · a29d1a97
      unknown authored
      into  mysql.com:/misc/mysql/31800/51-31800
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql-common/my_time.c:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      a29d1a97
    • unknown's avatar
      Bug#31800: Date comparison fails with timezone and slashes for greater than comparison · 2cb9a44c
      unknown authored
      BETWEEN was more lenient with regard to what it accepted as a DATE/DATETIME
      in comparisons than greater-than and less-than were. ChangeSet makes < >
      comparisons similarly robust with regard to trailing garbage (" GMT-1")
      and "missing" leading zeros. Now all three comparators behave similarly
      in that they throw a warning for "junk" at the end of the data, but then
      proceed anyway if possible. Before < > fell back on a string- (rather than
      date-) comparison when a warning-condition was raised in the string-to-date
      conversion. Now the fallback only happens on actual errors, while warning-
      conditions still result in a warning being to delivered to the client.
      
      
      mysql-test/r/select.result:
        Show that we compare DATE/DATETIME-like strings as date(time)s
        now, rather than as bin-strings.
        Adjust older result as "2005-09-3a" is now correctly seen as
        "2005-09-3" + trailing garbage, rather than as "2005-09-30".
      mysql-test/t/select.test:
        Show that we compare DATE/DATETIME-like strings as date(time)s
        now, rather than as bin-strings.
      sql-common/my_time.c:
        correct/clarify date-related comments, particulary for check_date().
        doxygenize comment while at it.
      sql/item_cmpfunc.cc:
        get_date_from_str() no longer signals an error when all we had
        was a warning-condition -- and one we already gave the user a
        warning for at that. Preamble doxygenized.
      2cb9a44c