1. 12 Mar, 2020 5 commits
    • Marko Mäkelä's avatar
      MDEV-21907: Fix some -Wconversion outside InnoDB · d82ac8d3
      Marko Mäkelä authored
      Some .c and .cc files are compiled as part of Mariabackup.
      Enabling -Wconversion for InnoDB would also enable it for
      Mariabackup. The .h files are being included during
      InnoDB or Mariabackup compilation.
      
      Notably, GCC 5 (but not GCC 4 or 6 or later versions)
      would report -Wconversion for x|=y when the type is
      unsigned char. So, we will either write x=(uchar)(x|y)
      or disable the -Wconversion warning for GCC 5.
      
      bitmap_set_bit(), bitmap_flip_bit(), bitmap_clear_bit(), bitmap_is_set():
      Always implement as inline functions.
      d82ac8d3
    • Marko Mäkelä's avatar
    • Marko Mäkelä's avatar
      MDEV-21924 Clean up InnoDB GIS record comparison · 8be3794b
      Marko Mäkelä authored
      The extension of the record comparison functions for SPATIAL INDEX in
      mysql/mysql-server@b66ad511b61fffe75c58d0a607cdb837c6e6c821
      was suboptimal for multiple reasons:
      
      Some functions used unnecessary temporary variables of the int type,
      instead of the more appropriate size_t, causing type mismatch.
      
      Many functions unnecessarily required rec_get_offsets() to be
      computed, or a parameter for length, although the size of the
      minimum bounding rectangle (MBR) is hard-coded as
      SPDIMS * 2 * sizeof(double), or 32 bytes.
      
      In InnoDB SPATIAL INDEX records, there always is a 32-byte key
      followed by either a 4-byte child page number or the PRIMARY KEY value.
      
      The length parameters were not properly validated.
      The function cmp_geometry_field() was making an incorrect attempt
      at checking that the lengths are at least sizeof(double) (8 bytes),
      even though the function is accessing up to 32 bytes in both MBR.
      
      Functions that are called from only one compilation unit are defined
      in another compilation unit, making the code harder to follow and
      potentially slower to execute.
      
      cmp_dtuple_rec_with_gis(): FIXME: Correct the debug assertion
      and possibly the function TABLE_SHARE::init_from_binary_frm_image()
      or related code, which causes an unexpected length of
      DATA_MBR_LEN + 2 bytes to be passed to this function.
      8be3794b
    • Marko Mäkelä's avatar
      MDEV-13362: Fix -Wset-but-unused · 0d767778
      Marko Mäkelä authored
      0d767778
    • Julius Goryavsky's avatar
      MDEV-13362: implement --require_secure_transport option · 28fabc86
      Julius Goryavsky authored
      Currently, if a user wants to require TLS for every connection made
      over the network, then every user account on the system needs to be
      created with "REQUIRE SSL" or one of the other TLS options.
      
      Implementing a require_secure_transport system varuable (which,
      in particular, can be set using the --require_secure_transport=ON
      command line option) in the MariaDB Server would make it a lot
      easier to require TLS (or other secure transport) system-wide.
      
      This patch implements this new system variable, adds the ability
      to set it with SQL statements, from the command line and from the
      configuration file, and also contains improvements for mtr that allow
      the user to establish non-secure TCP/IP connections (for example,
      to verify the operation of the new option).
      28fabc86
  2. 11 Mar, 2020 4 commits
  3. 10 Mar, 2020 31 commits