1. 02 Apr, 2019 3 commits
  2. 01 Apr, 2019 10 commits
    • Monty's avatar
      index_merge_innodb did sometimes give wrong results · 88400450
      Monty authored
      Fixed by adding more rows to a table
      
      Other things:
      - Speed up index_merge tests 20% by adding begin/commit around loops that
        generated rows.
      88400450
    • Monty's avatar
      MDEV-19116 Speed up rotation of binary logs · 48810a00
      Monty authored
      Fixed by caching last binary log number used in last_used_log_number
      
      Other things:
      - Moved locking of LOCK_log form new_file_impl() to new_file(). This fixed
        a bug where LOCK_log could have been unlocked even if 'need_lock' was
        not set.  Removed not anymore used argument need_lock.
      - Made generate_new_name() virtual to simplify the code between
        other logs and binary log.
      
      Reviewed by Andrei Elkin
      48810a00
    • Monty's avatar
      MDEV-19117 Don't keep binary log index file locked during show binary logs · adb70162
      Monty authored
      On some systems with 10,000+ binlogs, show binary logs could block
      log rotation for more than 10 seconds.
      
      This patch fixes this by first caching all binary log names and
      releases all mutexes while calculating the sizes of the binary logs.
      
      Other things:
      - Ensure that reinit_io_cache() sets end_of_file when moving to read_cache.
        This ensures that external changes of the underlying file is known to
        the cache.
      - get_binlog_list() is made more efficent and show_binlogs() is changed
        to call get_binlog_list()
      
      Reviewed by Andrei Elkin
      adb70162
    • Monty's avatar
    • Michael Widenius's avatar
      Write information about restart in .result · b5615eff
      Michael Widenius authored
      Idea comes from MySQL which does something similar
      b5615eff
    • Michael Widenius's avatar
    • Monty's avatar
      Fixed valgrind warning: Wrong usage of c_ptr() · 5b15f68e
      Monty authored
      5b15f68e
    • Michael Widenius's avatar
      48c6726b
    • Marko Mäkelä's avatar
      MDEV-17380 innodb_flush_neighbors=ON should be ignored on SSD · 10dd290b
      Marko Mäkelä authored
      For tablespaces that do not reside on spinning storage, it does
      not make sense to attempt to write nearby pages when writing out
      dirty pages from the InnoDB buffer pool. It is actually detrimental
      to performance and to the life span of flash ROM storage.
      
      With this change, MariaDB will detect whether an InnoDB file resides
      on solid-state storage. The detection has been implemented for Linux
      and Microsoft Windows. For other systems, we will err on the safe side
      and assume that files reside on SSD.
      
      As part of this change, we will reduce the number of fstat() calls
      when opening data files on POSIX systems and slightly clean up some
      file I/O code.
      
      FIXME: os_is_sparse_file_supported() on POSIX works in a destructive
      manner. Thus, we can only invoke it when creating files, not when
      opening them.
      
      For diagnostics, we introduce the column ON_SSD to the table
      INFORMATION_SCHEMA.INNODB_TABLESPACES_SCRUBBING. The table
      INNODB_SYS_TABLESPACES might seem more appropriate, but its purpose
      is to reflect the contents of the InnoDB system table SYS_TABLESPACES,
      which we would like to remove at some point.
      
      On Microsoft Windows, querying StorageDeviceSeekPenaltyProperty
      sometimes returns ERROR_GEN_FAILURE instead of ERROR_INVALID_FUNCTION
      or ERROR_NOT_SUPPORTED. We will silently ignore also this error,
      and assume that the file does not reside on SSD.
      
      On Linux, the detection will be based on the files
      /sys/block/*/queue/rotational and /sys/block/*/dev.
      Especially for USB storage, it is possible that
      /sys/block/*/queue/rotational will wrongly report 1 instead of 0.
      
      fil_node_t::on_ssd: Whether the InnoDB data file resides on
      solid-state storage.
      
      fil_system_t::ssd: Collection of Linux block devices that reside on
      non-rotational storage.
      
      fil_system_t::create(): Detect ssd on Linux based on the contents
      of /sys/block/*/queue/rotational and /sys/block/*/dev.
      
      fil_system_t::is_ssd(dev_t): Determine if a Linux block device is
      non-rotational. Partitions will be identified with the containing
      block device by assuming that the least significant 4 bits of the
      minor number identify a partition, and that the "partition number"
      of the entire device is 0.
      10dd290b
    • Alexander Barkov's avatar
      2d825e97
  3. 29 Mar, 2019 5 commits
  4. 28 Mar, 2019 2 commits
  5. 27 Mar, 2019 1 commit
  6. 26 Mar, 2019 13 commits
  7. 25 Mar, 2019 6 commits
    • Daniel Bartholomew's avatar
      bump the VERSION · b30bbb7d
      Daniel Bartholomew authored
      b30bbb7d
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 8b480df6
      Marko Mäkelä authored
      8b480df6
    • Marko Mäkelä's avatar
      Fix the Windows build · 07096ada
      Marko Mäkelä authored
      btr_cur_compress_recommendation(): Backport a change from 10.3.
      
      This is a follow-up to commit 1bd98154.
      07096ada
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · dbc0d576
      Marko Mäkelä authored
      dbc0d576
    • Marko Mäkelä's avatar
      MDEV-19022: InnoDB fails to cleanup useless B-tree pages · 525e79b0
      Marko Mäkelä authored
      The test case for reproducing MDEV-14126 demonstrates that InnoDB can
      end up with an index tree where a non-leaf page has only one child page.
      
      The test case innodb.innodb_bug14676111 demonstrates that such pages
      are sometimes unavoidable, because InnoDB does not implement any sort
      of B-tree rotation.
      
      But, there is no reason to allow a root page with only one child page.
      
      btr_cur_node_ptr_delete(): Replaces btr_node_ptr_delete().
      
      btr_page_get_father(): Declare globally.
      
      btr_discard_only_page_on_level(): Declare with ATTRIBUTE_COLD.
      It turns out that this function is not covered by the
      innodb.innodb_bug14676111 test case after all.
      
      btr_discard_page(): If the root page ends up having only one child
      page, shrink the tree by invoking btr_lift_page_up().
      525e79b0
    • Marko Mäkelä's avatar
      Avoid sign mismatch in comparisons · ade0a0e9
      Marko Mäkelä authored
      This is follow-up to commit 1bd98154.
      ade0a0e9