- 23 Oct, 2007 1 commit
-
-
davi@moksha.local/moksha.com.br authored
The problem is that when copying the supplied username and database, no bounds checking is performed on the fixed-length buffer. A sufficiently large (> 512) user string can easily cause stack corruption. Since this API can be used from PHP and other programs, this is a serious problem. The solution is to increase the buffer size to the accepted size in similar functions and perform bounds checking when copying the username and database.
-
- 18 Oct, 2007 1 commit
-
-
malff@lambda.hsd1.co.comcast.net. authored
into lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-rt-merge
-
- 17 Oct, 2007 4 commits
-
-
dkatz@damien-katzs-computer.local authored
Previously, UDF *_init functions were passed constant strings with erroneous lengths. The length came from the containing variable's size, not the length of the value itself. Now the *_init functions get the constant as a null terminated string with the correct length supplied too.
-
tsmith@ramayana.hindu.god authored
in middle of block)
-
kaa@polly.(none) authored
into polly.(none):/home/kaa/src/maint/mysql-5.0-maint
-
kaa@polly.(none) authored
-
- 16 Oct, 2007 6 commits
-
-
malff@lambda.hsd1.co.comcast.net. authored
-
malff@lambda.hsd1.co.comcast.net. authored
into lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-28318-rework
-
malff@lambda.hsd1.co.comcast.net. authored
-
kaa@polly.(none) authored
into polly.(none):/home/kaa/src/maint/mysql-5.0-maint
-
kaa@polly.(none) authored
into polly.(none):/home/kaa/src/maint/mysql-4.1-maint
-
malff@lambda.hsd1.co.comcast.net. authored
The root cause of the issue was that the CREATE FUNCTION grammar, for User Defined Functions, was using the sp_name rule. The sp_name rule is intended for fully qualified stored procedure names, like either ident.ident, or just ident but with a default database implicitly selected. A UDF does not have a fully qualified name, only a name (ident), and should not use the sp_name grammar fragment during parsing. The fix is to re-organize the CREATE FUNCTION grammar, to better separate: - creating UDF (no definer, can have AGGREGATE, simple ident) - creating Stored Functions (definer, no AGGREGATE, fully qualified name) With the test case provided, another issue was exposed which is also fixed: the DROP FUNCTION statement was using sp_name and also failing when no database is implicitly selected, when droping UDF functions. The fix is also to change the grammar so that DROP FUNCTION works with both the ident.ident syntax (to drop a stored function), or just the ident syntax (to drop either a UDF or a Stored Function, in the current database)
-
- 15 Oct, 2007 5 commits
-
-
dkatz@damien-katzs-computer.local authored
into damien-katzs-computer.local:/Users/dkatz/mysql-5.0-runtime
-
msvensson@pilot.mysql.com authored
into pilot.mysql.com:/data/msvensson/mysql/mysql-5.0-maint
-
ramil/ram@ramil.myoffice.izhnet.ru authored
into mysql.com:/home/ram/work/b31154/b31154.5.0
-
ramil/ram@ramil.myoffice.izhnet.ru authored
into mysql.com:/home/ram/work/b31154/b31154.5.0
-
ramil/ram@ramil.myoffice.izhnet.ru authored
into mysql.com:/home/ram/work/b30885/b30885.5.0
-
- 12 Oct, 2007 12 commits
-
-
mtaylor@solace.(none) authored
into solace.(none):/home/mtaylor/src/mysql/mysql-5.0-maint
-
mtaylor@solace.(none) authored
-
tnurnberg@sin.intern.azundris.com authored
into sin.intern.azundris.com:/home/tnurnberg/30951/50-30951
-
davi@moksha.com.br authored
into moksha.com.br:/Users/davi/mysql/mysql-5.0-runtime
-
davi@moksha.com.br authored
If mysql_lock_tables fails because the lock was aborted, we need to reset thd->some_tables_delete, otherwise we might loop indefinitely because handler's tables are not closed in a standard way, meaning that close_thread_tables() (which resets some_tables_deleted) is not used. This patch fixes sporadical failures of handler_myisam/innodb tests which were introduced by previous fix for this bug.
-
kaa@polly.(none) authored
into polly.(none):/home/kaa/src/maint/mysql-5.0-maint
-
kaa@polly.(none) authored
(compiler issue ?) Problem: Improper compile-time flags on AIX prevented use of files > 2 GB. This resulted in Max_data_length being truncated to 2 GB by MyISAM code. Solution: Reverted large-file changes from the fix for bug10776. We need to define _LARGE_FILES on AIX to have support for files > 2 GB. Since _LARGE_FILE_API is incompatible with _LARGE_FILES and may be automatically defined by including standards.h, we also need a workaround to avoid this conflict.
-
tnurnberg@sin.intern.azundris.com authored
into sin.intern.azundris.com:/home/tnurnberg/30951/50-30951
-
tnurnberg@sin.intern.azundris.com authored
makedate() will fold years below 100 into the 1970-2069 range. CS removes code that also wrongly folded years between 100 and 200 into that range, which should be left unchanged. Backport from 5.1.
-
tnurnberg@sin.intern.azundris.com authored
into sin.intern.azundris.com:/home/tnurnberg/30821/50-30821
-
tnurnberg@sin.intern.azundris.com authored
Options to mysqld were not processed correctly because switch statement was missing some "break"s. CS adds them. No test case; would require .opt file and server restart. Manually tested.
-
mtaylor@solace.(none) authored
-
- 11 Oct, 2007 3 commits
-
-
Problem: GROUP_CONCAT(DISTINCT BIT_FIELD...) uses a tree to store keys; which are constructed using a temporary table fields, see Item_func_group_concat::setup(). As a) we don't store null bits in the tree where the bit fields store parts of their data and b) there's no method to properly compare two table records we've got problem. Fix: convert BIT fields to INT in the temporary table used.
-
kaa@polly.(none) authored
myisam_sort_buffer_size. An incorrect length of the sort buffer was used when calculating the maximum number of keys. When myisam_sort_buffer_size is small enough, this could result in the number of keys < number of BUFFPEK structures which in turn led to use of uninitialized BUFFPEKs. Fixed by correcting the buffer length calculation.
-
ssh://bk-internal.mysql.com//home/bk/mysql-5.0-maintkaa@polly.(none) authored
into polly.(none):/home/kaa/src/maint/mysql-5.0-maint
-
- 10 Oct, 2007 8 commits
-
-
tsmith@ramayana.hindu.god authored
into ramayana.hindu.god:/home/tsmith/m/bk/maint/50
-
tsmith@ramayana.hindu.god authored
Introduced in mark_transaction_to_rollback(), part of fix for bug 24989; fix is to check thd for NULL before using it.
-
kaa@polly.(none) authored
into polly.(none):/home/kaa/src/maint/mysql-5.0-maint
-
kaa@polly.(none) authored
into polly.(none):/home/kaa/src/maint/mysql-5.0-maint
-
kaa@polly.(none) authored
into polly.(none):/home/kaa/src/maint/mysql-4.1-maint
-
kaa@polly.(none) authored
into polly.(none):/home/kaa/src/maint/bug28878/my50-bug28878
-
dkatz@damien-katzs-computer.local authored
into damien-katzs-computer.local:/Users/dkatz/mysql-5.0-runtime
-
anozdrin/alik@station. authored
-