1. 06 Feb, 2008 1 commit
  2. 04 Feb, 2008 1 commit
    • marko's avatar
      branches/zip: Apply some fixes suggested by Heikki. · c9087d7d
      marko authored
      btr_cur_pessimistic_update(): Note why the externally stored columns
      of a record on a latched page cannot have been purged.
      
      trx_undo_get_undo_rec(): Clarify that the stack of versions is locked
      all the way down to the purge view.
      
      trx_undo_prev_version_build(): Set *old_vers = NULL also when the record
      could have been purged already.  Add some clarifying comments.
      c9087d7d
  3. 30 Jan, 2008 1 commit
  4. 29 Jan, 2008 1 commit
    • vasil's avatar
      branches/zip: · c80d5da0
      vasil authored
      Require PROCESS privileges instead of SUPER to view INFORMATION_SCHEMA tables.
      
      Suggested by:	Sergei Golubchik <serg@mysql.com> (in a private email,
      		pointed http://bugs.mysql.com/32710)
      
      c80d5da0
  5. 28 Jan, 2008 1 commit
  6. 25 Jan, 2008 3 commits
    • marko's avatar
      branches/zip: Assert in the adaptive hash that the insert buffer B-tree · 993c02cf
      marko authored
      is not indexed.
      
      btr_search_update_hash_ref(), btr_search_drop_page_hash_index(),
      btr_search_build_page_hash_index(), btr_search_update_hash_on_delete(),
      btr_search_update_hash_node_on_insert(), btr_search_update_hash_on_insert(),
      btr_search_validate():
      Assert that hashed blocks do not belong to the insert buffer tree.
      
      btr_search_move_or_delete_hash_entries():
      When invoked on the insert buffer tree, assert that neither block is hashed.
      993c02cf
    • marko's avatar
      branches/zip: Fast index creation: Release locks on system tables before · e1e958d4
      marko authored
      creating indexes.  Lock the user table inside the user transaction.
      
      enum trx_dict_op: Remove TRX_OP_INDEX_MAY_WAIT.
      
      ha_innobase::add_index(): Lock the user tables within prebuilt->trx.
      Commit the data dictionary transaction before creating indexes.
      
      ha_innobase::final_drop_index(): Lock the user table within prebuilt->trx.
      e1e958d4
    • marko's avatar
      branches/zip: Introduce the accessor function dict_index_is_ibuf() · 0a63ed9c
      marko authored
      for determining if an index is the insert buffer B-tree.
      0a63ed9c
  7. 24 Jan, 2008 2 commits
  8. 23 Jan, 2008 2 commits
    • marko's avatar
      branches/zip: When storing a longer prefix of an externally stored column · b52a30e0
      marko authored
      to the undo log, also store the original length of the column, so that the
      changes will be correctly undone in transaction rollback or when fetching
      previous versions of the row.
      
      innodb-zip.test: New file, for tests of the compression.
      
      upd_field_t: Add orig_len, the original length of new_val.
      
      btr_push_update_extern_fields(): Restore the original prefix of the column.
      Add the parameter heap where memory will be allocated if necessary.
      
      trx_undo_rec_get_col_val(): Add the output parameter orig_len.
      
      trx_undo_page_report_modify_ext(): New function: Write an externally
      stored column to the undo log.  This is only called from
      trx_undo_page_report_modify(), and this is the only caller of
      trx_undo_page_fetch_ext().
      
      trx_undo_update_rec_get_update(): Read the original length of the column
      prefix to upd_field->orig_len.
      b52a30e0
    • vasil's avatar
      branches/zip: · 5ee41a15
      vasil authored
       
      Include univ.i in mysql_addons.h because univ.i includes innodb_redefine.h
      which is needed to rename the functions in this file with ibd_ prefix in
      the dynamic InnoDB plugin. Aka the renaming magic, required for the dynamic
      plugin to work.
      
      Approved by:	Marko
      5ee41a15
  9. 22 Jan, 2008 1 commit
    • inaam's avatar
      branches/zip: · 5c087094
      inaam authored
      Cast to  ib_uint64_t the mask for align down before doing the '~' operation on it.
      
      Reviewed by: Heikki
      5c087094
  10. 21 Jan, 2008 1 commit
    • marko's avatar
      branches/zip: row_sel_get_clust_rec_for_mysql(): Similar to the function · 793b1fe3
      marko authored
      row_sel_get_clust_rec(), return if a previous version of the clustered index
      record does not exist in the read view.  This bug was made and found by
      Heikki.  It was harmless as long as the clustered index record contained
      a long enough local prefix of externally stored columns, to allow secondary
      index records to be built without fetching BLOBs.
      
      InnoDB transactions should never look at a clustered index record whose
      transaction identifier (DB_TRX_ID) is not visible in the transaction's
      read view.
      793b1fe3
  11. 17 Jan, 2008 1 commit
    • marko's avatar
      branches/zip: Avoid infinite page splits on compressed tables. · 0d59bf8e
      marko authored
      btr_page_get_sure_split_rec(): Remove the check if insert_size
      exceeds free_space.
      
      btr_page_split_and_insert(): If a compressed page has already been split,
      avoid further splits by inserting the record to an empty page.  As a
      performance optimization, avoid invoking btr_page_insert_fits() on
      compressed tables.
      0d59bf8e
  12. 16 Jan, 2008 7 commits
    • marko's avatar
      branches/zip: btr_page_get_sure_split_rec(): Return NULL when the record · b060f8ba
      marko authored
      is not guaranteed to fit on a compressed page, instead of letting
      an assertion fail.
      b060f8ba
    • marko's avatar
      branches/zip: os_mem_alloc_large(), os_mem_free_large(): · 038ac6e2
      marko authored
      Update ut_total_allocated_memory.
      038ac6e2
    • marko's avatar
      branches/zip: Free the buffer pool at shutdown. · 214ced4e
      marko authored
      buf_pool_free(): New function: Free all chunks of the buffer pool.
      
      innobase_shutdown_for_mysql(): Call buf_pool_free() right before
      ut_free_all_mem().
      214ced4e
    • marko's avatar
      branches/zip: Add comments about the lock and latch protection of externally · e693d517
      marko authored
      stored columns (BLOBs).
      
      btr_copy_blob_prefix(), btr_copy_zblob_prefix(),
      btr_copy_externally_stored_field_prefix_low(),
      btr_copy_externally_stored_field_prefix(),
      btr_copy_externally_stored_field(),
      btr_rec_copy_externally_stored_field():
      Note that the page containing the clustered index record that points to
      the BLOB must be latched.
      
      btr_copy_zblob_prefix(): Note that there is no latch on the page, and thus
      all accesses to a given page via this function must be covered by the same
      set of locks or latches.
      
      btr_copy_zblob_prefix(): Note that the block acquired by
      buf_page_get_zip() is protected by an exclusive table lock or
      or by a latch on the clustered index record.
      e693d517
    • marko's avatar
      branches/zip: Fetch externally stored columns only when the clustered index · da25388d
      marko authored
      record is protected by a latch or a lock.
      
      dtuple_copy(): New function: Copy a data tuple.
      
      row_upd_replace(): New function: Apply on a row an update vector that
      was built for the clustered index.  Set up a cache of externally stored
      column prefixes if needed.
      
      undo_node_t: Add the fields undo_row, undo_ext.
      
      row_undo_search_clust_to_pcur(): Initialize undo_row and undo_ext.
      
      row_undo_mod_upd_exist_sec(): Instead of fetching prefixes of
      externally stored columns, use the undo_row and undo_ext that were
      initialized in row_undo_search_clust_to_pcur().
      
      upd_node_t: Remove the field n_ext.  Add the fields upd_row and upd_ext.
      
      row_upd_store_row(): Initialize the upd_row and upd_ext fields of upd_node_t.
      
      row_upd_sec_index_entry(), row_upd_clust_rec_by_insert(): Instead of
      fetching prefixes of externally stored columns, use the upd_row
      and upd_ext that were initialized in row_upd_store_row().
      da25388d
    • marko's avatar
      branches/zip: row_undo_ins_parse_undo_rec(): Initialize node->update · 9188a049
      marko authored
      so that it will not be uninitialized when the undo record is being
      processed.
      9188a049
    • vasil's avatar
      branches/zip: · 12c03b43
      vasil authored
       
      Move the column trx_weight near the end in the
      information_schema.innodb_trx table.
      
      Suggested by:	Ken
      Approved by:	Marko
      12c03b43
  13. 15 Jan, 2008 2 commits
  14. 14 Jan, 2008 3 commits
  15. 11 Jan, 2008 3 commits
    • marko's avatar
      branches/zip: Clarify why certain calls of · aaccf926
      marko authored
      btr_rec_copy_externally_stored_field() are safe.
      
      row_merge_copy_blobs(): Note that the table is locked during index creation.
      Therefore, none of its BLOBs can be freed.
      
      row_sel_fetch_columns(): Note that rec must be protected by a page latch.
      Add const qualifier to rec.
      
      row_sel_get_clust_rec(): Note that the clustered index record is protected
      by a page latch that was acquired when the persistent cursor was positioned
      and that the latch will be freed by mini-transaction commit.
      
      row_sel_try_search_shortcut(): Check the delete-mark flag before fetching
      the columns.  Note that the clustered index record is protected
      by a page latch that was acquired when the persistent cursor was positioned
      and that the latch will be freed by mini-transaction commit.
      
      row_sel(), row_search_for_mysql(): Note that the clustered index record
      is protected by a page latch that was acquired when the persistent cursor
      was positioned and that the latch will be freed by mini-transaction commit.
      
      row_sel_field_store_in_mysql_format(): Add const qualifier to data.
      
      row_sel_store_mysql_rec(), row_sel_push_cache_row_for_mysql():
      Add const qualifier to rec.  Note that rec must be protected by a page latch.
      aaccf926
    • marko's avatar
    • marko's avatar
      branches/zip: Add clarifying comments that the clustered index record must · f6f4a52b
      marko authored
      be protected from being deleted while any externally stored columns are
      being fetched.
      
      row_ext_create(),
      row_upd_index_replace_new_col_vals(),
      row_upd_index_replace_new_col_vals_index_pos(),
      row_sel_sec_rec_is_for_blob(),
      row_sel_sec_rec_is_for_clust_rec(): Note that the clustered
      index record must be covered by a lock or a page latch.
      
      row_upd_sec_index_entry(), row_upd_clust_rec_by_insert(),
      row_undo_mod_upd_exist_sec(): Note that these functions probably
      do not obtain an appropriate lock on the clustered index record
      before fetching any externally stored columns.
      f6f4a52b
  16. 10 Jan, 2008 4 commits
    • marko's avatar
      branches/zip: buf_LRU_search_and_free_block(): Do not forbid the release · 0d025934
      marko authored
      of the buffer pool mutex.  Apparently, it is temporarily released also
      in older versions of MySQL/InnoDB for the duration of the
      btr_search_drop_page_hash_index() call [in buf_LRU_free_block()].
      0d025934
    • marko's avatar
      1cbf67cd
    • marko's avatar
      branches/zip: Add instrumentation for prohibiting the release of · 7ac6a343
      marko authored
      the buffer pool mutex.  The instrumentation can be activated by
      defining UNIV_DEBUG or UNIV_BUF_DEBUG at compilation time.
      
      buf_pool_mutex_exit_forbidden: New variable.  When this is nonzero,
      an assertion will fail in buf_pool_mutex_exit().
      
      buf_pool_mutex_exit_forbid(): Macro for declaring that the buffer pool
      mutex must not be released.  Calls may be nested.
      
      buf_pool_mutex_exit_allow(): Macro for declaring that the buffer pool
      mutex may be released.  Calls may be nested.
      
      buf_LRU_search_and_free_block(): Prohibit buf_pool_mutex_exit() in the
      scope of the function.
      
      buf_LRU_free_block(): Prohibit buf_pool_mutex_exit() in buf_buddy_alloc()
      and buf_buddy_free().
      
      buf_LRU_block_remove_hashed_page(): Prohibit buf_pool_mutex_exit()
      in buf_buddy_free().
      7ac6a343
    • marko's avatar
      branches/zip: Implement wrappers for all operations on the buffer pool mutex. · cdb5b464
      marko authored
      buf_pool->mutex: Rename to buf_pool_mutex, so that the wrappers will have
      to be used when changes are merged from other source trees.
      
      buf_pool->zip_mutex: Rename to buf_pool_zip_mutex.
      
      buf_pool_mutex_own(), buf_pool_mutex_enter(), buf_pool_mutex_exit():
      Wrappers for buf_pool_mutex.
      cdb5b464
  17. 09 Jan, 2008 1 commit
    • marko's avatar
      branches/zip: Clean up index->to_be_dropped after a failed DROP INDEX. · 4c8c6f37
      marko authored
      ha_innobase::final_drop_index(): If row_merge_drop_table() fails, clear
      the to_be_dropped flags.  This was the error fixed in this commit; the rest
      is just additional safety.
      
      ha_innobase::final_drop_index(): After dropping the flagged indexes,
      assert that none of the remaining indexes are flagged to_be_dropped.
      
      ha_innobase::prepare_drop_index(): Assert that no index has been flagged
      for deletion.  When checking foreign key constraints, simply traverse the
      list of indexes and check if any of the indexes that were just flagged
      to_be_dropped.  On error, clear the to_be_dropped flags with simple list
      traversal.
      4c8c6f37
  18. 07 Jan, 2008 2 commits
  19. 04 Jan, 2008 3 commits