1. 30 Nov, 2017 2 commits
  2. 29 Nov, 2017 3 commits
    • Aleksey Midenkov's avatar
      FRM: fail to load extra2 option with size 1 fix · 51b30586
      Aleksey Midenkov authored
      From comment in unreg.h:
      
        Types of values in the MariaDB extra2 frm segment.
        Each value is written as
          type:       1 byte
          length:     1 byte  (1..255) or \0 and 2 bytes.
          binary value of the 'length' bytes.
      
      length == 1 is valid.
      51b30586
    • Alexander Barkov's avatar
    • Alexander Barkov's avatar
      MDEV-14467 Item_param: replace {INT|DECIMAL|REAL|STRING|TIME}_VALUE with Type_handler · e01d33d7
      Alexander Barkov authored
      1. Removing data type specific constants from enum_item_param_state,
         adding SHORT_DATA_VALUE instead.
      2. Replacing tests for Item_param::state for the removed constants to
         tests for Type_handler::cmp_type() against {INT|REAL|TIME|DECIAML}_RESULT.
         Deriving Item_param::PValue from Type_handler_hybrid_field_type,
         to store the data type handler of the current value of the parameter.
      
      3. Moving Item_param::decimal_value and Item_param::str_value_ptr
         to Item_param::PValue. Adding Item_param::PValue::m_string
         and changing Item_param to use it to store string values,
         instead of Item::str_value. The intent is to replace Item_param::value
         to a st_value based implementation in the future, to avoid duplicate code.
         Adding a sub-class Item::PValue_simple, to implement
         Item_param::PValue::swap() easier.
         Remaming Item_basic_value::fix_charset_and_length_from_str_value()
         to fix_charset_and_length() and adding the "CHARSET_INFO" pointer
         parameter, instead of getting it directly from item->str_value.charset().
         Changing Item_param to pass value.m_string.charset() instead
         of str_value.charset().
         Adding a String argument to the overloaded
         fix_charset_and_length_from_str_value() and changing Item_param
         to pass value.m_string instead of str_value.
      
      4. Replacing the case in Item_param::save_in_field() to a call
         for Type_handler::Item_save_in_field().
      
      5. Adding new methods into Item_param::PValue:
         val_real(), val_int(), val_decimal(), val_str().
         Changing the corresponding Item_param methods
         to use these new Item_param::PValue methods
         internally. Adding a helper method
         Item_param::can_return_value() and removing
         duplicate code in Item_param::val_xxx().
      
      6. Removing value.set_handler() from Item_param::set_conversion()
         and Type_handler_xxx::Item_param_set_from_value().
         It's now done inside Item_param::set_param_func(),
         Item_param::set_value() and Item_param::set_limit_clause_param().
      
      7. Changing Type_handler_int_result::Item_param_set_from_value()
         to set max_length using attr->max_length instead of
         MY_INT64_NUM_DECIMAL_DIGITS, to preserve the data type
         of the assigned expression more precisely.
      
      8. Adding Type_handler_hybrid_field_type::swap(),
         using it in Item_param::PValue::swap().
      
      9. Moving the data-type specific code from
         Item_param::query_val_str(), Item_param::eq(),
         Item_param::clone_item() to
         Item_param::value_query_type_str(),
         Item_param::value_eq(), Item_param::value_clone_item(),
         to split the "state" dependent code and
         the data type dependent code.
         Later we'll split the data type related code further
         and add new methods in Type_handler. This will be done
         after we replace Item_param::PValue to st_value.
      
      10. Adding asserts into set_int(), set_double(), set_decimal(),
         set_time(), set_str(), set_longdata() to make sure that
         the value set to Item_param corresponds to the previously
         set data type handler.
      
      11. Adding tests into t/ps.test and suite/binlog/t/binlog_stm_ps.test,
         to cover Item_param::print() and Item_param::append_for_log()
         for LIMIT clause parameters.
         Note, the patch does not change the behavior covered by the new
         tests. Adding for better code coverage.
      
      12. Adding tests for more precise integer data type in queries like this:
          EXECUTE IMMEDIATE
           'CREATE OR REPLACE TABLE t1 AS SELECT 999999999 AS a,? AS b'
            USING 999999999;
          The explicit integer literal and the same integer literal
          passed as a PS parameter now produce columns of the same data type.
          Re-recording old results in ps.result, gis.result, func_hybrid_type.result
          accordingly.
      e01d33d7
  3. 28 Nov, 2017 7 commits
  4. 27 Nov, 2017 5 commits
  5. 24 Nov, 2017 13 commits
    • Vladislav Vaintroub's avatar
      Fix warning. · 414d3a3e
      Vladislav Vaintroub authored
      414d3a3e
    • Sergey Vojtovich's avatar
      Fixed build failure with PFS disabled · 4cc20c88
      Sergey Vojtovich authored
      mariabackup fails to builds with PFS disabled. The reason was missing include,
      which was included by PFS otherwise.
      4cc20c88
    • Vladislav Vaintroub's avatar
      Merge remote-tracking branch 'origin/10.1' into 10.2 · 9cefffda
      Vladislav Vaintroub authored
      # Conflicts:
      #	storage/innobase/include/os0file.h
      9cefffda
    • Vladislav Vaintroub's avatar
      40756c91
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · f1cc6e38
      Marko Mäkelä authored
      f1cc6e38
    • Marko Mäkelä's avatar
      MDEV-14499 Mariabackup 10.2 fails to back up a multi-file InnoDB system tablespace · 6979d204
      Marko Mäkelä authored
      When Mariabackup is invoked on an instance that uses a multi-file
      InnoDB system tablespace, it may fail to other files of the system
      tablespace than the first one.
      This was revealed by the MDEV-14447 test case.
      The offending code is assuming that the first page of each data file
      is page 0. But, in multi-file system tablespaces that is not the case.
      
      xb_fil_cur_open(): Instead of re-reading the first page of the file,
      rely on the fil_space_t metadata that already exists in memory.
      
      xb_get_space_flags(): Remove.
      6979d204
    • Michael Widenius's avatar
    • Vladislav Vaintroub's avatar
      59150361
    • Sergey Vojtovich's avatar
      Fixed build failure with PFS disabled · abf61fd9
      Sergey Vojtovich authored
      mariabackup fails to builds with PFS disabled. The reason was missing include,
      which was included by PFS otherwise.
      abf61fd9
    • Sergey Vojtovich's avatar
      Fix hang in buf_flush_set_page_cleaner_thread_cnt · 17529785
      Sergey Vojtovich authored
      Running mysqld with innodb-buffer-pool-instances > 1 hangs on startup.
      
      On startup wrong variables was being used to detect number of page cleaner
      threads. As a result no threads were actually started. And subsequent code
      waits for threads to start forever.
      
      Fixed by using page_cleaner->n_workers, which holds number of page cleaner
      threads (0 at startup) instead of srv_n_page_cleaners, which holds number
      of requested page cleaner threads (4 by default).
      17529785
    • Alexander Barkov's avatar
      MDEV-14494 Move set_param_xxx() in sql_prepare.cc to methods in Item_param and Type_handler · 6aedbf40
      Alexander Barkov authored
      - sql_prepare.cc: Moving functions set_param_xxx() as
        methods to Item_param
      
      - Replacing a pointer to a function Item_param::set_param_func
        to Type_handler based implementation:
        Item_param::value now derives from Type_handler_hybrid_field_type.
        Adding new virtual methods Type_handler::Item_param_setup_conversion()
        and Type_handler::Item_param_set_param_func()
      
      - Moving declaration of some Item_param members  from "public:" to "private:"
        (CONVERSION_INFO, value, decimal_value)
      
      - Adding a new method Item_param::set_limit_clause_param(),
        to share duplicate code, as well as to encapsulate
        Item_param::value.
      
      - Adding Item_param::setup_conversion_string() and
        Item_param::setup_conversion_blob() to share
        the code for binding from a client value
        (mysql_stmt_bind_param), and for binding from
        an expression (Item).
      
      - Removing two different functions set_param_str_or_null()
        and set_param_str(). Adding a common method Item_param::set_param_str().
        Item_param::m_empty_string_is_null, used by Item_param::set_param_str().
      
      - Removing the call for setup_one_conversion_function() from
        insert_params_from_actual_params_with_log(). It's not needed,
        because the call for ps_param->save_in_param() makes sure
        to initialized all data type dependent members properly,
        by calling setup_conversion_string() from
        Type_handler_string_result::Item_param_set_from_value()
        and by calling setup_conversion_blob() from
        Type_handler_blob_common::Item_param_set_from_value()
      
      - Cleanup: removing multiplication to MY_CHARSET_BIN_MB_MAXLEN
        in a few places. It's 1 anyway, and will never change.
      6aedbf40
    • Vladislav Vaintroub's avatar
      MDEV-14483 Export _mysl_client_plugin_declaration from auth_gssapi_client.so · c5fffb33
      Vladislav Vaintroub authored
      Update C/C to include fix for this bug.
      c5fffb33
    • Vladislav Vaintroub's avatar
      MDEV-14447 mariabackup incremental incorrectly extends system tablespace · 316f0d8f
      Vladislav Vaintroub authored
      for multi-file innodb_data_file_path.
      
      Use fil_extend_space_to_desired_size() to correctly extend system
      tablespace. Make sure to get tablespace size from the first tablespace
      part.
      316f0d8f
  6. 23 Nov, 2017 10 commits
    • Elena Stepanova's avatar
      e6d6b0c0
    • Andrei Elkin's avatar
      MDEV-12012. Post-push attempt to catch failure in rpl_gtid_delete_domain... · c666ca7b
      Andrei Elkin authored
      MDEV-12012. Post-push attempt to catch failure in rpl_gtid_delete_domain failing on P8. The test is made more verbose.
      c666ca7b
    • Marko Mäkelä's avatar
      Use ST_AsText() to get textual result · 1773116f
      Marko Mäkelä authored
      1773116f
    • Sergey Vojtovich's avatar
      Less code to depend on ut_crc32_init() · 84ee7a10
      Sergey Vojtovich authored
      84ee7a10
    • Sergey Vojtovich's avatar
      Removed HW acceleration for big endian checksum · aaf5ee85
      Sergey Vojtovich authored
      Big endian checksum is needed to workaround 10+ years old bug, where checksum
      was calculated incorrectly on big endian hardware. We can still checksum such
      tablespaces using software implementation of CRC32.
      aaf5ee85
    • Sergey Vojtovich's avatar
      62ce8ce7
    • Monty's avatar
      Improve performance of heap tables · e69466d0
      Monty authored
      - make hp_mask an inline function (short and called 16 times)
      - Simplify hp_search. Biggest benefit is for doing key lookup
        without a matching row. Matching rows may be a bit slower, but
        is offseted by having hp_mask inlined.
      e69466d0
    • Marko Mäkelä's avatar
      MDEV-14477 InnoDB update_time is wrongly updated after partial rollback or internal COMMIT · d8ada081
      Marko Mäkelä authored
      The non-persistent UPDATE_TIME for InnoDB tables was not being
      updated consistently at transaction commit.
      
      If a transaction is partly rolled back so that in the end it will
      not modify a table that it intended to modify, the update_time will
      be updated nevertheless. This will also happen when InnoDB fails
      to write an undo log record for the intended modification.
      
      If a transaction is committed internally in InnoDB, instead of
      being committed from the SQL interface, then the trx_t::mod_tables
      will not be applied to the update_time of the tables.
      
      trx_t::mod_tables: Replace the std::set<dict_table_t*>
      with std::map<dict_table_t*,undo_no_t>, so that the very first
      modification within the transaction is identified.
      
      trx_undo_report_row_operation(): Update mod_tables for every operation
      after the undo log record was successfully written.
      
      trx_rollback_to_savepoint_low(): After partial rollback, erase from
      trx_t::mod_tables any tables for which all changes were rolled back.
      
      trx_commit_in_memory(): Tighten some assertions and simplify conditions.
      Invoke trx_update_mod_tables_timestamp() if persistent tables were
      affected.
      
      trx_commit_for_mysql(): Remove the call to
      trx_update_mod_tables_timestamp(), as it is now invoked at the
      lower level, in trx_commit_in_memory().
      
      trx_rollback_finish(): Clear mod_tables before invoking trx_commit(),
      because the trx_commit_in_memory() would otherwise wrongly process
      mod_tables after a full ROLLBACK.
      d8ada081
    • Marko Mäkelä's avatar
      Correct a comment · fda4fabe
      Marko Mäkelä authored
      fda4fabe
    • Michael Widenius's avatar
      Less dependencies in include files · 8a24be6e
      Michael Widenius authored
      8a24be6e