1. 22 Mar, 2007 29 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · e17b6fdd
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/26813-bug-5.0-opt-mysql
      
      e17b6fdd
    • unknown's avatar
      sql_view.cc: · 3548ccc9
      unknown authored
        Post-fix for bug#26813.
      
      
      sql/sql_view.cc:
        Post-fix for bug#26813.
      3548ccc9
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 25b34c7b
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      25b34c7b
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 40609c75
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      40609c75
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-4.1-opt · f8b24de4
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      f8b24de4
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0 · 61ff2625
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      61ff2625
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1 · fad244c5
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-4.1-opt
      
      fad244c5
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · c7831e89
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/26813-bug-5.0-opt-mysql
      
      c7831e89
    • unknown's avatar
      Bug#26813: The SUPER privilege is wrongly required to alter a view created by · b6acfac5
      unknown authored
      another user.
      
      When the DEFINER clause isn't specified in the ALTER statement then it's loaded
      from the view definition. If the definer differs from the current user then
      the error is thrown because only a super-user can set other users as a definers.
      
      Now if the DEFINER clause is omitted in the ALTER VIEW statement then the
      definer from the original view is used without check.
      
      
      mysql-test/t/view_grant.test:
        Added a test case for the bug#27006: The SUPER privilege is wrongly required
        to alter a view created by another user.
      mysql-test/r/view_grant.result:
        Added a test case for the bug#27006: The SUPER privilege is wrongly required
        to alter a view created by another user.
      sql/sql_view.cc:
        Bug#26813: The SUPER privilege is wrongly required to alter a view created by
        another user.
        Now if the DEFINER clause is omitted in the ALTER VIEW statement then the
        definer from the original view is used without check.
      b6acfac5
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · a6bf4308
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B26207-5.0-opt
      
      
      sql/sql_select.h:
        Auto merged
      a6bf4308
    • unknown's avatar
      Bug #26207: When making the key image to use · 843ce85a
      unknown authored
       in index search MySQL was not explicitly
       suppressing warnings. And if the context 
       happens to enable warnings (e.g. INSERT ..
       SELECT) the warnings resulting from converting 
       the data the key is compared to are 
       reported to the client.
       Fixed by suppressing warnings when converting
       the data to the same type as the key parts.
      
      
      mysql-test/r/insert_select.result:
        Bug #26207: test case
      mysql-test/t/insert_select.test:
        Bug #26207: test case
      sql/sql_select.h:
        Bug #26207: supress warnings when converting
          data of the same type to key buffer format.
      843ce85a
    • unknown's avatar
      Bug#24791: Union with AVG-groups generates wrong results · 2e72abed
      unknown authored
      Patch appled after doing a pull from the team tree. Additional tests had to be
      fixed
      
      
      mysql-test/r/union.result:
        Bug 24791
        
        The tests for temporary tables have been fixed. Since the call to 
        display_length(Item) was removed from the constructor for Item_type_holder, items 
        in temporary tables keep the original values of the items, rather than the magic
        numbers supplied by display_length.
      2e72abed
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.0-opt · d25303d0
      unknown authored
      into  linux-st28.site:/home/martin/mysql/src/5.0o-bug24791
      
      
      sql/item.cc:
        Auto merged
      d25303d0
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · 74ef4a53
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0-ndb
      
      74ef4a53
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/50-work · 890b9cce
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0-ndb
      
      
      ndb/test/ndbapi/testNodeRestart.cpp:
        Auto merged
      890b9cce
    • unknown's avatar
      ndb - · 3ad18a30
      unknown authored
        fix test prg
      
      
      ndb/test/ndbapi/testNodeRestart.cpp:
        fix test prg
      3ad18a30
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.0-opt · 22316ade
      unknown authored
      into  linux-st28.site:/home/martin/mysql/src/5.0o-bug24791
      
      
      sql/field.h:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      22316ade
    • unknown's avatar
      Bug #24791: Union with AVG-groups generates wrong results · 86e12ec9
      unknown authored
      The problem in this bug is when we create temporary tables. When
      temporary tables are created for unions, there is some 
      inferrence being carried out regarding the type of the column.
      Whenever this column type is inferred to be REAL (i.e. FLOAT or
      DOUBLE), MySQL will always try to maintain exact precision, and
      if that is not possible (there are hardware limits, since FLOAT
      and DOUBLE are stored as approximate values) will switch to
      using approximate values. The problem here is that at this point
      the information about number of significant digits is not 
      available. Furthermore, the number of significant digits should
      be increased for the AVG function, however, this was not properly 
      handled. There are 4 parts to the problem:
      
      #1: DOUBLE and FLOAT fields don't display their proper display 
      lengths in max_display_length(). This is hard-coded as 53 for 
      DOUBLE and 24 for FLOAT. Now changed to instead return the 
      field_length.
      
      #2: Type holders for temporary tables do not preserve the 
      max_length of the Item's from which they are created, and is 
      instead reverted to the 53 and 24 from above. This causes 
      *all* fields to get non-fixed significant digits.
      
      #3: AVG function does not update max_length (display length)
      when updating number of decimals.
      
      #4: The function that switches to non-fixed number of 
      significant digits should use DBL_DIG + 2 or FLT_DIG + 2 as 
      cut-off values (Since fixed precision does not use the 'e' 
      notation)
      
      Of these points, #1 is the controversial one, but this 
      change is preferred and has been cleared with Monty. The 
      function causes quite a few unit tests to blow up and they had
      to b changed, but each one is annotated and motivated. We 
      frequently see the magical 53 and 24 give way to more relevant
      numbers.
      
      
      mysql-test/r/create.result:
        bug#24791
        
        changed test result
        
        With the changes made for FLOAT and DOUBLE, the original display
        lengths are now preserved.
      mysql-test/r/temp_table.result:
        bug#24791
        
        changed test resullt
        
        Test case added
      mysql-test/r/type_float.result:
        bug#24791
        
        changed test result
        
        delta 1: field was originally declared as DOUBLE with no display
        length, so the hardware maximum is chosen rather than 53.
        
        delta 2: fields exceed the maximum precision and thus switch to
        non-fixed significant digits
        
        delta 3: Same as above, number of decmals and significant digits
        was not specified when t3 was created.
      mysql-test/t/temp_table.test:
        bug#24791
        
        Test case
      sql/field.h:
        bug#24791
        
        The method max_display_length is reimplemented as
        
        uint32 max_display_length() { return field_length; }
        
        in Field_double and Field_float. Since all subclasses of 
        Field_real now have the same implementation of this method, the
        implementation has been moved up the hierarchy to Field_real.
      sql/item.cc:
        bug#24791
        
        We switch to a non-fixed number of significant digits
        (by setting decimals=NOT_FIXED_DECIMAL) if the calculated 
        display length is greater than the display length of a value 
        with the maximum precision. These values differ for double and 
        float, obviously.
      sql/item_sum.cc:
        bug#24791
        
        We must increase the display length accordinly whenever we 
        change number of decimal places.
      86e12ec9
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · f66b2278
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb
      
      f66b2278
    • unknown's avatar
      bug #16546 (DATETIME+0 not always coerced the same way) · aa1e73ca
      unknown authored
        fix for cast( AS DATETIME)+0 in 5.0 and above versions.
        val_real now works using val_decimal for DATETIME Items
        Superfluous val_real() methods deleted
      
      
      sql/item_timefunc.h:
        val_real() for datetime functions implemented
            as { return val_real_from_decimal(); }
            It's not a fastest possible way, but code is simple and less
            error-prone, what i belive is more important here as this part
            works unfrequently.
      aa1e73ca
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-4.1-opt · 1b601e64
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      
      mysql-test/t/type_datetime.test:
        Auto merged
      mysql-test/r/type_datetime.result:
        SCCS merged
      sql/item_timefunc.h:
        SCCS merged
      1b601e64
    • unknown's avatar
      bug #16546 (DATETIME + 0 not always coerced in the same way) · bd268daa
      unknown authored
        fix for cast( AS DATETIME) + 0 operation.
        I just implemented Item_datetime_typecast::val() method
        as it is usually done in other classes.
        Should be fixed more radically in 5.0
      
      
      mysql-test/r/type_datetime.result:
        result added
      mysql-test/t/type_datetime.test:
        testcase
      sql/item_timefunc.h:
        added double conversion to Item_datetime_typecast
      bd268daa
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0 · 4986d75a
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      
      sql/item.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      4986d75a
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-4.1-opt · d6c46bdb
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      d6c46bdb
    • unknown's avatar
      Merge mysql.com:/home/hf/work/25492/my50-25492 · 0d91aacb
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      
      libmysqld/lib_sql.cc:
        Auto merged
      0d91aacb
    • unknown's avatar
      Merge mysql.com:/home/hf/work/25492/my41-25492 · b89a30c9
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-4.1-opt
      
      b89a30c9
    • unknown's avatar
      Merge mysql.com:/home/hf/work/25492/my41-25492 · 0a8a9f67
      unknown authored
      into  mysql.com:/home/hf/work/25492/my50-25492
      
      
      libmysqld/lib_sql.cc:
        merging
      0a8a9f67
    • unknown's avatar
      Fixed bug #27362: crash at evaluation of IN predicate when one · 3e950bba
      unknown authored
      of its argument happened to be a decimal expression returning
      the NULL value.
      The crash was due to the fact the function in_decimal::set did
      not take into account that val_decimal() could return 0 if 
      the decimal expression had been evaluated to NULL.  
      
      
      mysql-test/r/func_in.result:
        Added a test case for bug #27362.
      mysql-test/t/func_in.test:
        Added a test case for bug #27362.
      3e950bba
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 7f274b5b
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb
      
      7f274b5b
  2. 21 Mar, 2007 11 commits
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0-runtime · b22f62a4
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/50
      
      b22f62a4
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 5351224e
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime
      
      5351224e
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · aca0c227
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/23345-bug-5.0-opt-mysql
      
      aca0c227
    • unknown's avatar
      Bug#23345: Wrongly allowed INTO in a non-last select of a UNION. · 685219e1
      unknown authored
      INTO clause can be specified only for the last select of a UNION and it
      receives the result of the whole query. But it was wrongly allowed in
      non-last selects of a UNION which leads to a confusing query result.
      
      Now INTO allowed only in the last select of a UNION.
      
      
      mysql-test/t/union.test:
        Added a test case for the bug#23345: Wrongly allowed INTO in a non-last select of a UNION.
      mysql-test/r/union.result:
        Added a test case for the bug#23345: Wrongly allowed INTO in a non-last select of a UNION.
      sql/sql_yacc.yy:
        Bug#23345: Wrongly allowed INTO in a non-last select of a UNION.
        Now INTO allowed only in the last select of a UNION.
      685219e1
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · de72e4c1
      unknown authored
      into  recycle.(none):/src/bug27144/my50-bug27144
      
      de72e4c1
    • unknown's avatar
      Bug#27144 sp-destruct.test is disabled on Windows · 1e28904b
      unknown authored
      - Update test to run properly on Windows.
      
      
      mysql-test/t/sp-destruct.test:
        Bug#27144 sp-destruct.test is disabled on Windows
        - Enabled test on Windows.
        - Replaced non-portable system commands (mkdir, rmdir, mv, cp, echo) 
        with the mysqltest builtin commands.
        - Replace Windows directory seperator in error ER_NOT_FROM_FILE with
        posix directory seperator for single test/result pair.
      1e28904b
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 4f10e5bf
      unknown authored
      into  recycle.(none):/src/bug23736/my50-bug23736
      
      4f10e5bf
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/50-work · ba755856
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0-ndb
      
      
      ndb/src/kernel/blocks/dbdih/Dbdih.hpp:
        Auto merged
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbtc/Dbtc.hpp:
        Auto merged
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Auto merged
      ba755856
    • unknown's avatar
      ndb - bug#27283 · 897a01fa
      unknown authored
          Additional fix for 2-node case
      
      
      ndb/src/kernel/blocks/dbdih/Dbdih.hpp:
        Add error insert ref for errcode = 7181
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Make GSN_GCP_NODEFINISH always be sent to DIH node requesting it
      ndb/src/kernel/blocks/dbtc/Dbtc.hpp:
        Make GSN_GCP_NODEFINISH always be sent to DIH node requesting it
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Make GSN_GCP_NODEFINISH always be sent to DIH node requesting it
      897a01fa
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-maint · eedbddb6
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
      
      
      BitKeeper/etc/ignore:
        auto-union
      BitKeeper/deleted/.del-init_db.sql~e2b8d0c8390e8023:
        Auto merged
      BitKeeper/deleted/.del-test_db.sql:
        Auto merged
      mysql-test/install_test_db.sh:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_acl.h:
        Auto merged
      netware/Makefile.am:
        Manual merge
      eedbddb6
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · 764be136
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb
      
      764be136