- 07 Sep, 2007 1 commit
-
-
unknown authored
In the ha_partition::position() we don't calculate the number of the partition of the record, but use m_last_part value instead, relying on that it's previously set by some other call like ::write_row(). Delete_rows_log_event::do_exec_row() calls find_and_fetch_row(), where we used position() + rnd_pos() call for the InnoDB-based PARTITION-ed table as there HA_PRIMARY_KEY_REQUIRED_FOR_POSITION enabled. fixed by introducing new handler::rnd_pos_by_record() method to be used for random record-based positioning sql/ha_partition.cc: Bug #28430 Failure in replication of innodb partitioned tables on row/mixed format. ha_partition::rnd_pos_by_record() implemented sql/ha_partition.h: Bug #28430 Failure in replication of innodb partitioned tables on row/mixed format. ha_partition::rnd_pos_by_record() declared sql/handler.h: Bug #28430 Failure in replication of innodb partitioned tables on row/mixed format. handler::rnd_pos_by_record() introduced sql/log_event.cc: Bug #28430 Failure in replication of innodb partitioned tables on row/mixed format. handler::rnd_pos_by_record used instead of position() + rnd_pos() call
-
- 05 Sep, 2007 2 commits
-
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt client/mysqldump.c: Auto merged
-
unknown authored
mysqldump --skip-events --all-databases dumped data of the mysqld.event table, and during the restoration from this dump events were created in spite of the --skip-events option. The mysqldump client has been modified to ignore mysql.event table data in case of --skip-events options. client/mysqldump.c: Fixed bug #29938. The dump_table function has been modified to skip dumping of the mysql.event table data in case of the --skip-event mysqldump client option. mysql-test/t/mysqldump.test: Updated test case for bug #29938. mysql-test/r/mysqldump.result: Updated test case for bug #29938.
-
- 03 Sep, 2007 3 commits
-
-
unknown authored
into dl145s.mysql.com:/data0/mhansson/my51-bug30234-push sql/sql_yacc.yy: Bug#30234: Manual merge
-
unknown authored
into linux-st28.site:/home/martin/mysql/src/bug30234-push/my51-bug30234-push sql/sql_yacc.yy: Auto merged
-
unknown authored
DELETE FROM ... USING ... statements with the following type of ambiguous aliasing gave unexpected results: DELETE FROM t1 AS alias USING t1, t2 AS alias WHERE t1.a = alias.a; This query would leave table t1 intact but delete rows from t2. Fixed by changing DELETE FROM ... USING syntax so that only alias references (as opposed to alias declarations) may be used in FROM. mysql-test/r/delete.result: Bug#30234: Test Result mysql-test/t/delete.test: Bug#30234: Test Case sql/sql_yacc.yy: Bug#30234: - Added parser rule table_alias_ref_list that contains a list of table aliases only. - Added parser rule table_alias_ref that sets the TL_OPTION_ALIAS in order to turn off semantic checking that applies only for table names.
-
- 31 Aug, 2007 2 commits
-
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt client/mysqldump.c: Auto merged sql/sql_parse.cc: SCCS merged
-
unknown authored
When dumping database from a 4.x server, the mysqldump client inserted a delimiter sign inside special commentaries of the form: /*!... CREATE DATABASE IF NOT EXISTS ... ;*/ During restoration that dump file was splitten by delimiter signs on the client side, and the rest of some commentary strings was prepended to following statements. The 4x_server_emul test case option has been added for use with the DBUG_EXECUTE_IF debugging macro. This option affects debug server builds only to emulate particular behavior of a 4.x server for the mysqldump client testing. Non-debugging builds are not affected. mysql-test/r/mysqldump-compat.result: Added test case for bug #30126. mysql-test/t/mysqldump-compat.opt: Added test case for bug #30126. mysql-test/t/mysqldump-compat.test: Added test case for bug #30126. sql/sql_parse.cc: Fixed bug #30126. The mysqldump client uses the "SHOW CREATE DATABASE" query to obtain the "CREATE DATABASE" statement from that database. The 4.x server doesn't recognise that query, and mysqldump forms the "CREATE DATABASE" statement from scratch. That statement was formed incorrectly. To enforce the mysqldump client to create that statement from scratch, debugging code has been added to the mysql_execute_command function: in tcase of the --loose-debug=d,4x_server_emul option, the server returns parse error to client to emulate old behaviour. The 4x_server_emul test case option has been added for use with the DBUG_EXECUTE_IF debugging macro. This option affects debug server builds only to emulate particular behavior of a 4.x server for the mysqldump client testing. Non-debugging builds are not affected. client/mysqldump.c: Fixed bug #30126. The init_dumping_tables function has been modified to output semicolon outside of commentaries.
-
- 29 Aug, 2007 6 commits
-
-
unknown authored
into magare.gmz:/home/kgeorge/mysql/work/B30393-5.1-opt
-
unknown authored
into magare.gmz:/home/kgeorge/mysql/autopush/B30244-5.1-opt sql/item_create.cc: Auto merged
-
unknown authored
The functions ROW_COUNT/FOUND_ROWS are indeed not safe to be used in statement based replication. Added code to declare them as such and switch the statement they're in to row based logging for mixed mode. sql/item_create.cc: Bug #30244: row_count/found_rows does not replicate well - add the functions to the set of "unsafe functions" for statement based replication mysql-test/suite/rpl/r/rpl_row_unsafe_funcs.result: BitKeeper file /home/kgeorge/mysql/work/B30244-5.1-opt/mysql-test/suite/rpl/r/rpl_row_unsafe_funcs.result mysql-test/suite/rpl/t/rpl_row_unsafe_funcs.test: BitKeeper file /home/kgeorge/mysql/work/B30244-5.1-opt/mysql-test/suite/rpl/t/rpl_row_unsafe_funcs.test
-
unknown authored
and strategy (explain) The fix for WL3527 adds tests that test if the index usage hints combinations don't cause syntax errors. The EXPLAIN for one of these tests can be affected by the size of the rowid on the disk (affected by the presence of large file support). Fixed to avoid the platform dependent test result by removing the irrelevant columns from the EXPLAIN result. mysql-test/r/group_by.result: Bug #30393: ignore columns irrelevant to the test mysql-test/t/group_by.test: Bug #30393: ignore columns irrelevant to the test
-
unknown authored
for bug 30377: use the function instead of the complex condition.
-
unknown authored
into magare.gmz:/home/kgeorge/mysql/work/B30377-5.1-opt mysql-test/t/status.test: Auto merged mysql-test/r/status.result: merge 5.0->5.1 of the fix for bug 30377 sql/sql_lex.h: merge 5.0->5.1 of the fix for bug 30377 sql/sql_select.cc: merge 5.0->5.1 of the fix for bug 30377
-
- 28 Aug, 2007 4 commits
-
-
unknown authored
into linux-st28.site:/home/martin/mysql/src/5.1o-bug30596 sql/sql_select.cc: Auto merged
-
unknown authored
The optimization that uses a unique index to remove GROUP BY did not ensure that the index was actually used, thus violating the ORDER BY that is implied by GROUP BY. Fixed by replacing GROUP BY with ORDER BY if the GROUP BY clause contains a unique index over non-nullable field(s). In case GROUP BY ... ORDER BY null is used, GROUP BY is simply removed. mysql-test/include/mix1.inc: Bug#30596: Test case for InnoDB Here, as opposed to for MyISAM, row lookup is done using index whenever the index covers the group list. mysql-test/r/distinct.result: Bug#30596: Changed test case. Prior to Bug#16458, These queries use temp table and filesort. The bug was that they used a temp table. However, that patch removed filesort also, in which case we can no longer gurantee correct ordering. mysql-test/r/group_by.result: Bug#30596: Correct result The test case for IGNORE INDEX FOR GROUP BY gets degraded performance (unneccesary filesort). This is due to Bug#30665, which will be fixed separately. mysql-test/r/innodb_mysql.result: Bug#30596: Test result mysql-test/t/group_by.test: Bug#30596: Test case sql/sql_select.cc: Bug#30596: The fix: - replace GROUP BY with ORDER BY unless ORDER BY [NULL|<constant>] - make sure to use the keys for GROUP BY in this ORDER BY.
-
unknown authored
Currently the Last_query_cost session status variable shows only the cost of a single flat subselect. For complex queries (with subselects or unions etc) Last_query_cost is not valid as it was showing the cost for the last optimized subselect. Fixed by reseting to zero Last_query_cost when the complete cost of the query cannot be determined. Last_query_cost will be non-zero only for single flat queries. mysql-test/r/status.result: Bug #30377: test case mysql-test/t/status.test: Bug #30377: test case sql/sql_lex.h: Bug #30377: helper function sql/sql_select.cc: Bug #30377: don't assign cost if not on single level statement
-
unknown authored
into magare.gmz:/home/kgeorge/mysql/autopush/B28284-5.1-opt include/my_pthread.h: Auto merged
-
- 26 Aug, 2007 3 commits
- 25 Aug, 2007 8 commits
-
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt sql/sql_select.cc: Auto merged
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.0-opt
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt mysql-test/r/type_bit.result: Auto merged mysql-test/t/type_bit.test: Auto merged sql/sql_select.cc: Merge with 5.0-opt.
-
unknown authored
Additional fix for the bug#30245. sql/sql_select.cc: Additional fix for the bug#30245.
-
unknown authored
into a88-113-38-195.elisa-laajakaista.fi:/home/my/bk/mysql-5.1-marvel
-
unknown authored
into a88-113-38-195.elisa-laajakaista.fi:/home/my/bk/mysql-5.1-marvel client/mysqldump.c: Auto merged libmysql/libmysql.c: Auto merged mysql-test/mysql-test-run.pl: Auto merged mysql-test/r/status.result: Auto merged sql/event_db_repository.cc: Auto merged sql/event_queue.cc: Auto merged sql/field.cc: Auto merged sql/ha_partition.cc: Auto merged sql/ha_partition.h: Auto merged sql/handler.cc: Auto merged sql/item.cc: Auto merged sql/item_cmpfunc.h: Auto merged sql/item_func.cc: Auto merged sql/item_subselect.cc: Auto merged sql/log.cc: Auto merged sql/log_event.h: Auto merged sql/log_event_old.cc: Auto merged sql/mysql_priv.h: Auto merged sql/mysqld.cc: Auto merged sql/opt_range.cc: Auto merged sql/sp.cc: Auto merged sql/sp_head.cc: Auto merged sql/sql_class.cc: Auto merged sql/sql_class.h: Auto merged sql/sql_db.cc: Auto merged sql/sql_handler.cc: Auto merged sql/sql_insert.cc: Auto merged sql/sql_lex.cc: Auto merged sql/sql_plugin.cc: Auto merged sql/sql_select.cc: Auto merged sql/sql_show.cc: Auto merged sql/sql_string.cc: Auto merged sql/sql_table.cc: Auto merged sql/table.h: Auto merged tests/mysql_client_test.c: Auto merged mysql-test/t/status.test: Manual resolve with 5.1. sql/log_event.cc: Manual resolve with 5.1. sql/sql_yacc.yy: Manual resolve with 5.1.
-
unknown authored
into a88-113-38-195.elisa-laajakaista.fi:/home/my/bk/mysql-5.0-marvel
-
- 24 Aug, 2007 11 commits
-
-
unknown authored
into moonbone.local:/mnt/gentoo64/work/30245-bug-5.0-opt-mysql sql/sql_select.cc: Auto merged
-
unknown authored
into trift2.:/MySQL/M51/push-5.1 netware/Makefile.am: Auto merged
-
unknown authored
into trift2.:/MySQL/M50/push-5.0 netware/Makefile.am: Auto merged
-
unknown authored
into trift2.:/MySQL/M51/push-5.1 netware/BUILD/compile-netware-END: Auto merged netware/Makefile.am: Auto merged
-
unknown authored
into trift2.:/MySQL/M51/netware2-5.1 netware/BUILD/compile-netware-END: Auto merged netware/Makefile.am: Manual merge.
-
unknown authored
1) Ensure "init_db.sql" and "test_db-sql" really get built. 2) Ensure the "*.def" files with NetWare linker options get distributed to the proper directories. netware/BUILD/compile-netware-END: Ensure the "*.def" files are built for NetWare. This is a backport of a 5.1 fix which may not be needed in 5.0 but cannot do any harm: the general "link_sources" step might fall victim to a cleanup which would be fatal just for NetWare, because of problems in the ordering of SUBDIR entries. netware/Makefile.am: 1) The scripts "init_db.sql" and "test_db.sql" must be built in the NetWare phase. 2) Use "basename", not sed.
-
unknown authored
When locking a "fast" mutex a static variable cpu_count was used as a flag to initialize itself on the first usage by calling sysconf() and setting non-zero value. This is not thread and optimization safe on some platforms. That's why the global initialization needs to be done once in a designated function. This will also speed up the usage (by a small bit) because it won't have to check if it's initialized on every call. Fixed by moving the fast mutexes initialization out of my_pthread_fastmutex_lock() to fastmutex_global_init() and call it from my_init() include/my_pthread.h: Bug #28284: move the fast mutexes initialization out of my_pthread_fastmutex_lock() to fastmutex_global_init() and call it from my_init() mysys/my_init.c: Bug #28284: move the fast mutexes initialization out of my_pthread_fastmutex_lock() to fastmutex_global_init() and call it from my_init() mysys/thr_mutex.c: Bug #28284: move the fast mutexes initialization out of my_pthread_fastmutex_lock() to fastmutex_global_init() and call it from my_init()
-
unknown authored
into a88-113-38-195.elisa-laajakaista.fi:/home/my/bk/mysql-5.1-marvel
-
unknown authored
into a88-113-38-195.elisa-laajakaista.fi:/home/my/bk/mysql-5.1-marvel libmysql/libmysql.c: Auto merged mysql-test/r/query_cache.result: Auto merged mysql-test/t/query_cache.test: Auto merged sql/ha_partition.cc: Auto merged sql/ha_partition.h: Auto merged sql/handler.cc: Auto merged sql/item.cc: Auto merged sql/item_cmpfunc.h: Auto merged sql/opt_range.cc: Auto merged sql/sql_lex.cc: Auto merged sql/sql_select.cc: Auto merged sql/sql_show.cc: Auto merged tests/mysql_client_test.c: Auto merged
-
unknown authored
into a88-113-38-195.elisa-laajakaista.fi:/home/my/bk/mysql-5.0-marvel
-
unknown authored
into trift2.:/MySQL/M51/push-5.1
-