1. 28 Feb, 2019 3 commits
    • Marko Mäkelä's avatar
      MDEV-18601 Can't create table with ENCRYPTED=DEFAULT when innodb_default_encryption_key_id!=1 · e39d6e0c
      Marko Mäkelä authored
      The problem with the InnoDB table attribute encryption_key_id is that it is
      not being persisted anywhere in InnoDB except if the table attribute
      encryption is specified and is something else than encryption=default.
      MDEV-17320 made it a hard error if encryption_key_id is specified to be
      anything else than 1 in that case.
      
      Ideally, we would always persist encryption_key_id in InnoDB. But, then we
      would have to be prepared for the case that when encryption is being enabled
      for a table whose encryption_key_id attribute refers to a non-existing key.
      
      In MariaDB Server 10.1, our best option remains to not store anything
      inside InnoDB. But, instead of returning the error that MDEV-17320
      introduced, we should merely issue a warning that the specified
      encryption_key_id is going to be ignored if encryption=default.
      
      To improve the situation a little more, we will issue a warning if
      SET [GLOBAL|SESSION] innodb_default_encryption_key_id is being set
      to something that does not refer to an available encryption key.
      
      Starting with MariaDB Server 10.2, thanks to MDEV-5800, we could open the
      table definition from InnoDB side when the encryption is being enabled,
      and actually fix the root cause of what was reported in MDEV-17320.
      e39d6e0c
    • Jan Lindström's avatar
      MDEV-18265: Replace deprecated variable debug to debug_dbug on Galera tests · 622e9e8a
      Jan Lindström authored
      Replaced debug to debug_dbug on 10.1 on galera suite. Nothing to do
      in wsrep and galera_3nodes suites.
      622e9e8a
    • Jan Lindström's avatar
      Revert offending part of MDEV-9519: Data corruption will happen on the Galera cluster size change · 5a87e3ee
      Jan Lindström authored
      This will allow test binlog.binlog_stm_binlog to pass more often.
      Note that this is not a real fix to that test failure.
      5a87e3ee
  2. 25 Feb, 2019 1 commit
    • Julius Goryavsky's avatar
      MDEV-9519: Data corruption will happen on the Galera cluster size change · 243f829c
      Julius Goryavsky authored
      If we have a 2+ node cluster which is replicating from an async master
      and the binlog_format is set to STATEMENT and multi-row inserts are executed
      on a table with an auto_increment column such that values are automatically
      generated by MySQL, then the server node generates wrong auto_increment
      values, which are different from what was generated on the async master.
      
      In the title of the MDEV-9519 it was proposed to ban start slave on a Galera
      if master binlog_format = statement and wsrep_auto_increment_control = 1,
      but the problem can be solved without such a restriction.
      
      The causes and fixes:
      
      1. We need to improve processing of changing the auto-increment values
      after changing the cluster size.
      
      2. If wsrep auto_increment_control switched on during operation of
      the node, then we should immediately update the auto_increment_increment
      and auto_increment_offset global variables, without waiting of the next
      invocation of the wsrep_view_handler_cb() callback. In the current version
      these variables retain its initial values if wsrep_auto_increment_control
      is switched on during operation of the node, which leads to inconsistent
      results on the different nodes in some scenarios.
      
      3. If wsrep auto_increment_control switched off during operation of the node,
      then we must return the original values of the auto_increment_increment and
      auto_increment_offset global variables, as the user has set. To make this
      possible, we need to add a "shadow copies" of these variables (which stores
      the latest values set by the user).
      
      https://jira.mariadb.org/browse/MDEV-9519
      243f829c
  3. 21 Feb, 2019 2 commits
  4. 20 Feb, 2019 4 commits
  5. 19 Feb, 2019 4 commits
  6. 18 Feb, 2019 1 commit
  7. 14 Feb, 2019 1 commit
  8. 12 Feb, 2019 1 commit
    • Julius Goryavsky's avatar
      MDEV-18426: Most of the mtr tests in the galera_3nodes suite fail · 5b827511
      Julius Goryavsky authored
      Most of the mtr tests in the galera_3nodes suite fail
      for a variety of reasons with a variety of errors.
      
      This patch fixes several substantial flaws
      in the galera_3nodes suite tests and in the mtr framework
      service files, adapting the tests from galera_3nodes
      for the current version of MariaDB.
      
      This patch also synchronizes some galera_3nodes-related
      files with the latest changes made for MDEV-17835 (v2 patch)
      and for MDEV-18379 in other branches (10.2 and 10.3).
      
      Closes #1161
      5b827511
  9. 11 Feb, 2019 1 commit
  10. 06 Feb, 2019 1 commit
  11. 05 Feb, 2019 1 commit
  12. 04 Feb, 2019 1 commit
  13. 03 Feb, 2019 1 commit
  14. 02 Feb, 2019 2 commits
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.1 · 213ece2f
      Marko Mäkelä authored
      This is joint work with Oleksandr Byelkin.
      213ece2f
    • Marko Mäkelä's avatar
      Fix embedded innodb_plugin after 560799eb · c1e1764f
      Marko Mäkelä authored
      wsrep_certification_rules: Define as a weak global symbol.
      While there are separate _embedded.a for statically
      linked storage engine plugins, there is only one ha_innodb.so
      which is supposed to work with both values of WITH_WSREP.
      
      The merge from 10.0-galera introduced a reference to a global
      variable that is only defined when the server is built WITH_WSREP.
      We must define that symbol as weak global, so that when
      a dynamically linked InnoDB or XtraDB is used with the embedded
      server (which never includes write-set replication patches),
      the variable will be read as 0, instead of causing a failure to
      load the InnoDB or XtraDB plugin.
      c1e1764f
  15. 01 Feb, 2019 3 commits
  16. 31 Jan, 2019 3 commits
  17. 30 Jan, 2019 1 commit
  18. 29 Jan, 2019 6 commits
  19. 28 Jan, 2019 3 commits