1. 24 Mar, 2010 3 commits
  2. 22 Mar, 2010 2 commits
    • Joerg Bruehe's avatar
      Fixes related to bug#46587: · 7d57fda9
      Joerg Bruehe authored
      archive storage engine headers don't include my_global.h first
      
      
      During the build of 5.5.3-m3 on older Linux platforms
      (kernels 2.4 or early 2.6),
      the symptom described in the bug report occurred both
      in the "archive" and in the "innobase" storage engine.
      
      This change is the patch proposed in that bug report,
      and a similar one in innobase, that latter is aligned
      with Vasil Dimov of Innobase, the original author.
      7d57fda9
    • Joerg Bruehe's avatar
      Some fixes for the build on Windows · c3ed8bb1
      Joerg Bruehe authored
      as found necessary during the release build of 5.5.3-m3.
      
      scripts/CMakeLists.txt:
        The scripts "mysqldumpslow" and "mysqlhotcopy" need to be handled.
      scripts/make_win_bin_dist:
        1) We do not create ".map" files any more.
        
        2) Typing error fixed, it isn't "$DISTDIR" but "$DESTDIR".
        
        3) Security fix:
           If the argument isn't of the form "dst=src",
           then we want the variables to be empty.
        The original code would have used an argument "foo"
        to set both "$src" and "$dst" to this string,
        which doesn't make much sense.
      c3ed8bb1
  3. 16 Mar, 2010 1 commit
    • Joerg Bruehe's avatar
      Fix a syntax error: · 8b3a95c4
      Joerg Bruehe authored
      A variable declaration was preceded by "DBUG_PRINT()".
      
      sql-common/client.c:
        Thou shalt not declare a variable after an executable statement
        (and "DBUG_PRINT()" is executable).
      8b3a95c4
  4. 15 Mar, 2010 3 commits
  5. 13 Mar, 2010 1 commit
  6. 12 Mar, 2010 6 commits
  7. 11 Mar, 2010 7 commits
  8. 10 Mar, 2010 17 commits
    • Luis Soares's avatar
      Fix for BUG#51716 and BUG#51787: test case improvements. · a7c0e6e4
      Luis Soares authored
      Split rpl_row_charset into:
      
        - rpl_row_utf16.
        - rpl_row_utf32.
      
      This way these tests can run independently if server supports
      either one of the charsets but not both.
      
      Cleaned up rpl_row_utf32 which had a spurious instruction:
      -- let $reset_slave_type_conversions= 0
      a7c0e6e4
    • Davi Arnaut's avatar
      Automatic merge. · 9a08e823
      Davi Arnaut authored
      9a08e823
    • Luis Soares's avatar
      Fix for BUG#51716 and BUG#51787. · 496562f1
      Luis Soares authored
      In BUG#51787 we were using the wrong charset to print out the
      data. We were using the field charset for the string that would
      hold the information. This caused the assertion, because the
      string length was not aligned with UTF32 bytes requirements for
      storage.
      
      We fix this by using &my_charset_latin1 in the string object
      instead of the field->charset(). As a side-effect, we needed to
      extend the show_sql_type interface so that it took the field
      charset is now passed as a parameter, so that one is able to
      calculate the correct field size.
      
      In BUG#51716 we had issues with Field_string::pack and
      Field_string::unpack. When packing, the length was incorrectly
      calculated. When unpacking, the padding the string would be
      padded with the wrong bytes (a few bytes less than it should).
      
      We fix this by resorting to charset abstractions (functions) that
      calculate the correct length when packing and pad correctly the
      string when unpacking.
      496562f1
    • Joerg Bruehe's avatar
      Automerge into next-mr-bugfixing. · 9ce490c8
      Joerg Bruehe authored
      9ce490c8
    • Alexander Nozdrin's avatar
      5bdd80fa
    • Konstantin Osipov's avatar
      A fix and a test case for Bug#51710 FLUSH TABLES <view> WITH READ · a8838f14
      Konstantin Osipov authored
      LOCK kills the server.
      
      Prohibit FLUSH TABLES WITH READ LOCK application to views or
      temporary tables.
      Fix a subtle bug in the implementation when we actually
      did not remove table share objects from the table cache after 
      acquiring exclusive locks.
      
      mysql-test/r/flush.result:
        Update results (Bug#51710)
      mysql-test/t/flush.test:
        Add a test case for Bug#51710.
      sql/sql_parse.cc:
        Fix Bug#51710 "FLUSH TABLES <view> WITH READ LOCK
        killes the server.
        Ensure we don't open views and temporary tables.
        Fix a yet another bug in the implementation which 
        did not actually remove the tables from cache after acquiring
        exclusive locks.
      a8838f14
    • Davi Arnaut's avatar
      Bug#33669: Transactional temporary tables do not work under --read-only · 6f9a684a
      Davi Arnaut authored
      The problem was that in read only mode (read_only enabled),
      the server would mistakenly deny data modification attempts
      for temporary tables which belong to a transactional storage
      engine (eg. InnoDB).
      
      The solution is to allow transactional temporary tables to be
      modified under read only mode. As a whole, the read only mode
      does not apply to any kind of temporary table.
      
      
      mysql-test/r/read_only_innodb.result:
        Add test case result for Bug#33669
      mysql-test/t/read_only_innodb.test:
        Add test case for Bug#33669
      sql/lock.cc:
        Rename mysql_lock_tables_check to lock_tables_check and make
        it static. Move locking related checks from get_lock_data to
        lock_tables_check. Allow write locks to temporary tables even
        under read-only.
      6f9a684a
    • Joerg Bruehe's avatar
      Part of the fixes for bug#49022 · df457dea
      Joerg Bruehe authored
          Plugins included into bin release cannot be
          installed on debug version of server
      
      Ensure that the plugin files of the debug build
      get into the optimized tree, so that they find
      their way into the final RPMs.
      
      
      support-files/mysql.spec.sh:
        Use "make install" in the debug build tree to get the debug
        plugin files to a temporary location,
        then move them to "plugin/debug/" in the optimized build tree
        so that the install hook in "plugin/Makefile.am" forwards them
        into the final installation.
        
        This fixes bug#49022 for the generic RPMs.
        
        Unrelated:
        The plugin objects were listed twice in the file list,
        do a cleanup.
      df457dea
    • Alexander Nozdrin's avatar
      9d72b5f6
    • Alexander Nozdrin's avatar
      Auto-merge (empty) from mysql-next-mr. · 67d43e6d
      Alexander Nozdrin authored
      67d43e6d
    • Alexander Nozdrin's avatar
      Auto-merge from mysql-trunk. · f5d5e36c
      Alexander Nozdrin authored
      f5d5e36c
    • Alexander Nozdrin's avatar
      Auto-merge (empty) from mysql-trunk. · 95103b95
      Alexander Nozdrin authored
      95103b95
    • Alexander Nozdrin's avatar
      Auto-merge from mysql-next-mr. · 8c0a0ec3
      Alexander Nozdrin authored
      8c0a0ec3
    • Alexander Nozdrin's avatar
      156c4e56
    • Joerg Bruehe's avatar
    • He Zhenxing's avatar
      Post fix for Bug#49557 · b151c878
      He Zhenxing authored
      b151c878
    • Joerg Bruehe's avatar
      Part of the fixes for bug#49022 · 7dc4b08a
      Joerg Bruehe authored
          Plugins included into bin release cannot be
          installed on debug version of server
      
      IF    the build process was split into separate "debug" and
            "optimized" builds
         AND
            the plugin files of the debug build got copied into
            "plugin/debug/"
      (both is done for MySQL release builds starting from 5.5.3),
      THEN these debug plugin files are to be included in the
           final binary package.
      
      This change deals with the inclusion only,
      the other parts are done in different changesets.
      
      
      plugin/Makefile.am:
        The "install" rule must not assume that "debug" files are
        present, this depends on the preceding steps in the build.
        
        If they are present, we cannot copy them by simply using
        "libtool install" (as we could do during an ordinary build)
        because they are already kept in "plugin/debug/".
        
        When doing the copy to the destination hierarchy, we must
        ensure that symlinks are not expanded but rather copied
        as symlinks.
        "cp -d" is specific to GNU, the portable way would use
        "cp -P", but that is not fully specified with recursion.
        So we fall back on "tar c | tar x", which is known to
        keep symlinks unchanged (and un-expanded).
        
        Using "$(TAR)" is just a precaution in case of weird path
        settings or other portability issues.
      7dc4b08a