1. 30 Aug, 2006 3 commits
    • unknown's avatar
      WL#3368 mixed format as default · e67d8523
      unknown authored
      Two minor fixes:
       1. to make make test executes with mixed;
       2. proper isolation of binlog_statement_insert_delayed 
          from others through reset master cleaning up binlog
          todo: adapt this technique to other restarting for binlog tests
      
      
      Makefile.am:
        Binlog format switches to MIXED. A new Makefile target
        test-binlog-statement 
        is introduced for checking tests requiring exclusive STATEMENT format.
      mysql-test/t/binlog_statement_insert_delayed.test:
        cheapest method to clean up binlog after previous tests
      e67d8523
    • unknown's avatar
      Merge aelkin@bk-internal.mysql.com:/home/bk/mysql-5.1-rpl · 330fc74d
      unknown authored
      into  andrepl.dsl.inet.fi:/home/elkin/MySQL/TEAM/FIXES/5.1/wl3368_mixed_default
      
      330fc74d
    • unknown's avatar
      Changes made according to HLD/LLD. · f225a87b
      unknown authored
         The following is an excerption from the WL.
            
         1. Change so that MIXED is default format
            1.1 to change the default for command line --binlog-format
            1.2 to alter global_system_variables.binlog_format calculation
                basing on command line --binlog-format parameter and 
                its default.
         2. Change test suite so that more testing is done by MIXED format.
            2.1 to check if there are test cases requiring --binlog-foramt=statement via
                `source include/have_binlog_format_statement.inc' and affected by 
                altering the latter to be "mixed".
            2.2 to check the content of such vulnerable cases to find if
                extending to the mixed does not modify results. In that case simply
                substitute source arguments as explained.
            2.3 if a test in mixed mode deals with features triggering
                row-binlogging then if necessary we can switch explicitly
                to statement mode or create another test to run with 
                non-recommended STATEMENT mode
         
                Particullarily, extracting INSERT DELAYED 
                binlogging subtest for statement mode is performed, and 
                the snippet is moved into a separate test file.
                Note that since now all three modes verify this use case
                through 3 different tests.
         
         No changes in item 3 of HLD appeared to be needed.
      
      
      mysql-test/extra/binlog_tests/binlog.test:
        Moving INSERT DELAYED verification section into separate file. The latter is sourced
        from two different files: the current one and a newly created for STATEMENT
        mode check.
      mysql-test/extra/rpl_tests/rpl_loaddata.test:
        require mixed_or_statement
      mysql-test/extra/rpl_tests/rpl_stm_000001.test:
        require mixed_or_statement
      mysql-test/extra/rpl_tests/rpl_stm_charset.test:
        require mixed_or_statement
      mysql-test/r/binlog_stm_binlog.result:
        new result to correspond to MIXED mode.
      mysql-test/r/rpl_rbr_to_sbr.result:
        result changed
      mysql-test/t/archive.test:
        require mixed_or_statement
      mysql-test/t/binlog_stm_binlog.test:
        require exclusive mixed format because of INSERT DELAYED.
      mysql-test/t/binlog_stm_blackhole.test:
        require mixed_or_statement
      mysql-test/t/binlog_stm_ctype_cp932.test:
        require mixed_or_statement
      mysql-test/t/binlog_stm_ctype_ucs.test:
        require mixed_or_statement
      mysql-test/t/binlog_stm_drop_tmp_tbl.test:
        require mixed_or_statement
      mysql-test/t/binlog_stm_innodb_stat.test:
        require mixed_or_statement
      mysql-test/t/binlog_stm_insert_select.test:
        require mixed_or_statement
      mysql-test/t/binlog_stm_mix_innodb_myisam.test:
        require mixed_or_statement
      mysql-test/t/create_select_tmp.test:
        require mixed_or_statement
      mysql-test/t/ctype_cp932_binlog_stm.test:
        require mixed_or_statement
      mysql-test/t/date_formats.test:
        MIXED case appended to the replace instruction
      mysql-test/t/mysqlbinlog.test:
        require mixed_or_statement
      mysql-test/t/mysqlbinlog2.test:
        require mixed_or_statement
      mysql-test/t/ndb_multi.test:
        require mixed_or_statement
      mysql-test/t/rpl000013.test:
        require mixed_or_statement
      mysql-test/t/rpl_heap.test:
        require mixed_or_statement
      mysql-test/t/rpl_loaddata_s.test:
        require mixed_or_statement
      mysql-test/t/rpl_mixed_ddl_dml.test:
        require mixed_or_statement
      mysql-test/t/rpl_rbr_to_sbr.test:
        Rather meaningless line is discarded.
        The test does not loose anything without it and without considering the WL.
      mysql-test/t/rpl_rewrt_db.test:
        require mixed_or_statement
      mysql-test/t/rpl_rotate_logs.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_EE_err2.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_flsh_tbls.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_log.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_max_relay_size.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_multi_query.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_mystery22.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_no_op.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_reset_slave.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_until.test:
        require mixed_or_statement
      mysql-test/t/rpl_temp_table.test:
        require mixed_or_statement
      mysql-test/t/rpl_trigger.test:
        require mixed_or_statement
      mysql-test/t/rpl_trunc_temp.test:
        require mixed_or_statement
      mysql-test/t/user_var-binlog.test:
        require mixed_or_statement
      sql/mysqld.cc:
        Implementation of making BINLOG_FORMAT_MIXED to be the default of
        global_system_variables.binlog_format. Not in the case of embedded.
      mysql-test/extra/binlog_tests/binlog_insert_delayed.test:
        Snippend sourced from two tests to verify INSERT DELAYED in all three binlog formats.
      mysql-test/include/have_binlog_format_mixed.inc:
        Part of exclusive MIXED format requirement
      mysql-test/include/have_binlog_format_mixed_or_statement.inc:
        requirement to have mixed or statement. Most of the tests with STATEMENT format indeed
        are tolerant to MIXED format to yield the same result files. There are few exception
        because of features triggering RBR events when MIXED format.
      mysql-test/r/binlog_statement_insert_delayed.result:
        BitKeeper file /home/elkin/MySQL/TEAM/FIXES/5.1/wl3368_mixed_default/mysql-test/r/binlog_statement_insert_delayed.result
      mysql-test/r/have_binlog_format_mixed.require:
        Exclusive MIXED format
      mysql-test/t/binlog_statement_insert_delayed.test:
        BitKeeper file /home/elkin/MySQL/TEAM/FIXES/5.1/wl3368_mixed_default/mysql-test/t/binlog_statement_insert_delayed.test
      f225a87b
  2. 29 Aug, 2006 1 commit
    • unknown's avatar
      Various fixes to make MyTAP build on all platforms. · 3f3ab391
      unknown authored
      
      unittest/Makefile.am:
        Not installing unit.pl any more.
        Adding test-verbose target to see the TAP output (for debugging).
      unittest/mytap/tap.h:
        Including portability file.
        Whitespace changes.
        Code sample for BAIL_OUT() function.
      3f3ab391
  3. 25 Aug, 2006 4 commits
  4. 17 Aug, 2006 1 commit
  5. 16 Aug, 2006 2 commits
    • unknown's avatar
      Merging with mysql-5.1-new-rpl tree · e6ce7abd
      unknown authored
      
      sql/log.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      mysql-test/r/rpl_switch_stm_row_mixed.result:
        Merge with mysql-5.1-new-rpl
      mysql-test/t/rpl_switch_stm_row_mixed.test:
        Merge with mysql-5.1-new-rpl
      e6ce7abd
    • unknown's avatar
      BUG#20863 (if binlog format is changed between update and unlock table, wrong binlogging): · 3c75ea0a
      unknown authored
      Fix to allow the binlog format to be changed between the LOCK and
      UNLOCK tables, as well as under MIXED mode.
      
      
      mysql-test/r/rpl_switch_stm_row_mixed.result:
        Result change
      mysql-test/t/rpl_switch_stm_row_mixed.test:
        Adding test to see that binlog format can be changed when using
        LOCK/UNLOCK TABLES both under ROW format and MIXED format.
      sql/log.cc:
        Removing pre-condition assertion since binlog can now be
        statement based.
      sql/sql_class.cc:
        Adding code to always flush pending event regardless of the binlog
        format used. The only exception is if we are inside a stored routine,
        where the pending event is never flushed.
      3c75ea0a
  6. 01 Aug, 2006 3 commits
  7. 31 Jul, 2006 3 commits
  8. 30 Jul, 2006 1 commit
  9. 29 Jul, 2006 2 commits
    • unknown's avatar
      Make innodb_flush_log_at_trx_commit a settable global variable. · bc2a948a
      unknown authored
      
      sql/ha_innodb.cc:
        Remove innobase_flush_log_at_trx_commit
        (set srv_flush_log_at_trx_commit directly).
      sql/ha_innodb.h:
        Remove innobase_flush_log_at_trx_commit.
        Declare srv_flush_log_at_trx_commit.
      sql/mysqld.cc:
        Bypass the innobase_flush_log_at_trx_commit variable.
      storage/innobase/include/srv0srv.h:
        Change the type of srv_flush_log_at_trx_commit.
      storage/innobase/srv/srv0srv.c:
        Change the type of srv_flush_log_at_trx_commit.
      bc2a948a
    • unknown's avatar
      Fix tests after merge and disable rpl_ndb_dd_advance due to bug 18679. · 98ceb853
      unknown authored
      
      mysql-test/r/date_formats.result:
        Fix results after merge
      mysql-test/r/mysqldump.result:
        Fix results after merge
      mysql-test/t/disabled.def:
        Add randomly-failing test with open bug
      mysql-test/t/mysqldump.test:
        Clean up test after merge and fix 'End of test' markers
      98ceb853
  10. 28 Jul, 2006 7 commits
    • unknown's avatar
      Make innodb_thread_concurrency 0 by default, and extend · 38688f37
      unknown authored
       the usable range to 0..1000 (0 disables the thread throttling).
      
      
      sql/mysqld.cc:
        innodb_thread_concurrency is 0..1000 now, and
         0 (the default) disables the thread throttling.
      38688f37
    • unknown's avatar
      Merge rama.(none):/home/jimw/my/tmp_merge · 80d4fa0a
      unknown authored
      into  rama.(none):/home/jimw/my/mysql-5.1-clean
      
      
      client/mysql.cc:
        Auto merged
      client/mysqldump.c:
        Auto merged
      configure.in:
        Auto merged
      extra/yassl/include/openssl/ssl.h:
        Auto merged
      extra/yassl/include/yassl_int.hpp:
        Auto merged
      extra/yassl/src/ssl.cpp:
        Auto merged
      extra/yassl/src/template_instnt.cpp:
        Auto merged
      extra/yassl/src/yassl_imp.cpp:
        Auto merged
      extra/yassl/src/yassl_int.cpp:
        Auto merged
      include/mysql.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      libmysqld/embedded_priv.h:
        Auto merged
      BitKeeper/deleted/.del-mysql_explain_log.sh~5ddc62808e16bd57:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      libmysqld/libmysqld.c:
        Auto merged
      mysql-test/r/date_formats.result:
        Auto merged
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/r/mysqldump-max.result:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/date_formats.test:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      scripts/mysqld_safe.sh:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_string.h:
        Auto merged
      sql/table.cc:
        Auto merged
      sql/table.h:
        Auto merged
      sql/time.cc:
        Auto merged
      storage/myisam/mi_create.c:
        Auto merged
      storage/ndb/src/kernel/blocks/dbtup/DbtupMeta.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/ConfigInfo.cpp:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      BitKeeper/deleted/.del-have_case_sensitive_file_system.inc:
        Delete: mysql-test/include/have_case_sensitive_file_system.inc
      BitKeeper/deleted/.del-case_sensitive_file_system.require:
        Delete: mysql-test/r/case_sensitive_file_system.require
      mysql-test/lib/mtr_cases.pl:
        Resolve conflict
      mysql-test/mysql-test-run.pl:
        Resolve conflict
      mysql-test/r/mysqldump.result:
        Resolve conflict
      mysql-test/t/mysqldump.test:
        Resolve conflict
      sql/sql_parse.cc:
        Resolve conflict
      80d4fa0a
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 0e17c165
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime-merge
      
      
      mysql-test/r/create_not_windows.result:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      0e17c165
    • unknown's avatar
      Add sql_locale.cc to cmake scripts. · a354bbba
      unknown authored
      a354bbba
    • unknown's avatar
      Removing temporary changes. · 0452244d
      unknown authored
      0452244d
    • unknown's avatar
      Removing temporary changes. · 7c6110d8
      unknown authored
      7c6110d8
    • unknown's avatar
      e804eb02
  11. 27 Jul, 2006 6 commits
  12. 26 Jul, 2006 7 commits
    • unknown's avatar
      Merge bodhi.local:/opt/local/work/tmp_merge · ef256aea
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime-merge
      
      
      BitKeeper/etc/ignore:
        auto-union
      BitKeeper/deleted/.del-libmysqld.dsp~78dc6a589e5a4149:
        Auto merged
      BitKeeper/deleted/.del-libmysqld.vcproj~a75d5b9a5967dea0:
        Auto merged
      BitKeeper/deleted/.del-mysqld.dsp~ffdbf2d234e23e56:
        Auto merged
      BitKeeper/deleted/.del-mysqld.vcproj~6aa7b3f9c3e28fcb:
        Auto merged
      libmysqld/Makefile.am:
        Auto merged
      mysql-test/Makefile.am:
        Auto merged
      mysql-test/r/date_formats.result:
        Auto merged
      mysql-test/r/view_grant.result:
        Auto merged
      mysql-test/t/date_formats.test:
        Auto merged
      mysql-test/t/init_connect.test:
        Auto merged
      mysql-test/t/mysqldump.test:
        Auto merged
      mysql-test/t/view_grant.test:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/handler.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_create.cc:
        Auto merged
      sql/item_create.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/set_var.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_trigger.cc:
        Auto merged
      sql/sql_udf.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      storage/ndb/include/kernel/GlobalSignalNumbers.h:
        Auto merged
      storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbdict/Dbdict.hpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      storage/ndb/src/ndbapi/ndberror.c:
        Auto merged
      support-files/mysql.spec.sh:
        Auto merged
      mysql-test/r/federated.result:
        Use local.
      mysql-test/r/myisam.result:
        Manual merge.
      mysql-test/t/federated.test:
        Manual merge.
      mysql-test/t/myisam.test:
        Manual merge.
      sql/Makefile.am:
        Manual merge.
      sql/set_var.cc:
        Manual merge.
      sql/sql_parse.cc:
        Manual merge.
      sql/sql_update.cc:
        Manual merge.
      storage/myisam/mi_create.c:
        Manual merge.
      ef256aea
    • unknown's avatar
      Merge orca.ndb.mysql.com:/space/pekka/ndb/version/my51 · f6d2231c
      unknown authored
      into  orca.ndb.mysql.com:/space_old/pekka/ndb/version/my51-bug14935
      
      
      storage/ndb/src/kernel/blocks/dbtup/Dbtup.hpp:
        Auto merged
      storage/ndb/src/kernel/blocks/ERROR_codes.txt:
        manual
      f6d2231c
    • unknown's avatar
      ndb - bug#14935 - post-review · c7a75373
      unknown authored
      
      storage/ndb/src/kernel/blocks/dbtup/Dbtup.hpp:
        bug#14935 - post-review
      storage/ndb/src/kernel/blocks/dbtup/DbtupAbort.cpp:
        bug#14935 - post-review
      storage/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp:
        bug#14935 - post-review
      c7a75373
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 8a1692e1
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime-merge
      
      
      sql/sql_table.cc:
        Auto merged
      8a1692e1
    • unknown's avatar
      Add support for valgrind with callgrind · 65e0db67
      unknown authored
      65e0db67
    • unknown's avatar
      Merge 192.168.0.20:mysql/my51-m-bug21039 · 6710ecdb
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.1-new-maint
      
      6710ecdb
    • unknown's avatar
      Cset exclude: msvensson@neptunus.(none)|ChangeSet|20060721184912|58688 · 04455dff
      unknown authored
      
      mysql-test/r/sp.result:
        Exclude
      mysql-test/t/sp.test:
        Exclude
      04455dff