1. 26 Nov, 2007 6 commits
  2. 24 Nov, 2007 5 commits
  3. 23 Nov, 2007 1 commit
  4. 22 Nov, 2007 5 commits
  5. 21 Nov, 2007 3 commits
  6. 20 Nov, 2007 10 commits
  7. 19 Nov, 2007 10 commits
    • evgen@moonbone.local's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · ddc04e76
      evgen@moonbone.local authored
      into  moonbone.local:/work/31048-bug-5.0-opt-mysql
      ddc04e76
    • evgen@moonbone.local's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 6f6fe52a
      evgen@moonbone.local authored
      into  moonbone.local:/work/31048-bug-5.0-opt-mysql
      6f6fe52a
    • evgen@moonbone.local's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 0288cc9d
      evgen@moonbone.local authored
      into  moonbone.local:/work/30384-bug-5.0-opt-mysql
      0288cc9d
    • evgen@moonbone.local's avatar
      Bug#30384: Having SQL_BUFFER_RESULT option in the CREATE .. KEY(..) .. SELECT · da7470af
      evgen@moonbone.local authored
      led to creating corrupted index.
      
      Corrected fix. The new method called prepare2 is added to the select_create
      class. As all preparations are done by the select_create::prepare function
      it doesn't do anything. Slightly changed algorithm of calling the 
      start_bulk_insert function. Now it's called from the select_insert::prepare2
      function when the SQL_BUFFER_RESULT flags is set.
      The is_bulk_insert_mode flag is removed as it is not needed anymore.
      da7470af
    • evgen@moonbone.local's avatar
      Bug#31048: Many nested subqueries may cause server crash. · 67cae0d4
      evgen@moonbone.local authored
      This bug is actually two. The first one manifests itself on an EXPLAIN
      SELECT query with nested subqueries that employs the filesort algorithm.
      The whole SELECT under explain is marked as UNCACHEABLE_EXPLAIN to preserve
      some temporary structures for explain. As a side-effect of this values of
      nested subqueries weren't cached and subqueries were re-evaluated many
      times. Each time buffer for filesort was allocated but wasn't freed because
      freeing occurs at the end of topmost SELECT. Thus all available memory was
      eaten up step by step and OOM event occur.
      The second bug manifests itself on SELECT queries with conditions where
      a subquery result is compared with a key field and the subquery itself also
      has such condition. When a long chain of such nested subqueries is present
      the stack overrun occur. This happens because at some point the range optimizer
      temporary puts the PARAM structure on the stack. Its size if about 8K and
      the stack is exhausted very fast.
      
      Now the subselect_single_select_engine::exec function allows subquery result
      caching when the UNCACHEABLE_EXPLAIN flag is set.
      Now the SQL_SELECT::test_quick_select function calls the check_stack_overrun
      function for stack checking purposes to prevent server crash.
      67cae0d4
    • gshchepa/uchum@gleb.loc's avatar
      Fixed bug #32282: TEXT silently truncates when value is exactly 65536 · fedeec6c
      gshchepa/uchum@gleb.loc authored
      bytes length.
      
      The server has been modified to report warnings on truncation to
      65536 bytes as usual.
      fedeec6c
    • kaa@polly.(none)'s avatar
      Fix for bug #32221: bug25714, mytest, mysql_client_test complaints and · 82c4059f
      kaa@polly.(none) authored
      crashes.
      
      MySQL distributions contain a number of programs that are used only by
      the MySQL test suite internally, i.e. they are not indended to be
      invoked directly by a user. As a result, such programs are not
      documented, do not have any built-in help or proper error reporting,
      which may confuse users.
      
      This patch fixes the problem with the following changes:
      - mytest, libmysqltest and all references to them were removed from the
      distribution since they are not used anymore
      - bug25714 now displays an error message when run with incorrect
      arguments or with the --help option
      - mysql_client_test now does not call abort() in case of errors,
      instead it does a clean exit() with a proper error status.
      82c4059f
    • kaa@polly.(none)'s avatar
      Merge polly.(none):/home/kaa/src/opt/bug32376/my50-bug26215 · ee1bb663
      kaa@polly.(none) authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      ee1bb663
    • kaa@polly.(none)'s avatar
      Changed the help text for --comments to make it clear which option · b93bbc5e
      kaa@polly.(none) authored
      disables the option explicitely.
      Changed the option location in code so that --help will show it in
      lexical option order.
      
      This is for bug #26215: mysql command line client should not strip
      comments from SQL statements
      b93bbc5e
    • holyfoot/hf@mysql.com/hfmain.(none)'s avatar
      Bug #30284 spatial key corruption. · 140dd4f3
      holyfoot/hf@mysql.com/hfmain.(none) authored
      SPATIAL key is fine actually, but the chk_key() function
      mistakenly returns error. It tries to compare checksums
      of btree and SPATIAL keys while the checksum for the SPATIAL isn't
      calculated (always 0). Same thing with FULLTEXT keys is handled
      using full_text_keys counter, so fixed by counting both
      SPATIAL and FULLTEXT keys in that counter.
      140dd4f3