- 25 Mar, 2019 2 commits
-
-
Sergey Vojtovich authored
By applying 7bd258c4.
-
Bernhard M. Wiedemann authored
unfortunately, the year 2038 problem prevented me from pushing the deadline even further into the future.
-
- 24 Mar, 2019 1 commit
-
-
Chris Calender authored
-
- 22 Mar, 2019 2 commits
-
-
Chris Calender authored
-
sachin authored
Fixed issue in logic.
-
- 21 Mar, 2019 1 commit
-
-
chriscalender authored
-
- 15 Mar, 2019 1 commit
-
-
Igor Babaev authored
If an IN-subquery is used in a table-less select the current code should never consider it as candidate for semi-join optimizations. Yet the function check_and_do_in_subquery_rewrites() improperly checked the property "to be a table-less select". As a result such select in IN subquery was used in INSERT .. SELECT then the IN subquery by mistake was registered as a semi-join subquery and convert_subq_to_sj() was called for it. However the code of this function does not assume that the parent select of the subquery could be a table-less select.
-
- 07 Mar, 2019 1 commit
-
-
Marko Mäkelä authored
row_mysql_handle_errors(): Correct the wrong error handling for the code DB_FOREIGN_EXCEED_MAX_CASCADE that was introduced in https://github.com/mysql/mysql-server/commit/c0923d396aef46799883390e9dcf7bbf173e4a03 commit 35f5429e Author: Jimmy Yang <jimmy.yang@oracle.com> Date: Wed Oct 6 06:55:34 2010 -0700 Manual port Bug #Bug #54582 "stack overflow when opening many tables linked with foreign keys at once" from mysql-5.1-security to mysql-5.5-security again. rb://391 approved by Heikki No known test case exists for repeating the bug before MariaDB 10.2. The scenario should be that DB_FOREIGN_EXCEED_MAX_CASCADE is returned, then InnoDB wrongly skips the rollback to the start of the current row operation, and finally the SQL layer commits the transaction. Normally the SQL layer would roll back either the entire transaction or to the start of the statement. In the faulty scenario, InnoDB would leave the transaction in an inconsistent state, and the SQL layer could commit the transaction.
-
- 28 Feb, 2019 2 commits
-
-
Oleksandr Byelkin authored
1. Always drop merged_for_insert flag on cleanup (there could be errors which prevent TABLE to be assigned) 2. Make more precise cleanup of select parts which was touched
-
Alexander Barkov authored
st_select_lex::handle_derived() and mysql_handle_list_of_derived() had exactly the same implementations. - Adding a new method LEX::handle_list_of_derived() instead - Removing public function mysql_handle_list_of_derived() - Reusing LEX::handle_list_of_derived() in st_select_lex::handle_derived()
-
- 07 Feb, 2019 1 commit
-
-
Vladislav Vaintroub authored
candle.exe's preprocessor flags (-dHaveUpgradeWizard=0 -DHaveInnodb=1) were not passed correctly to EXECUTE_PROCESS Fix is to make a list out of the EXTRA_WIX_PREPROCESSOR_FLAGS string, and use the preprocessor flags list in EXECUTE_PROCESS.
-
- 30 Jan, 2019 2 commits
-
-
Daniel Bartholomew authored
-
Varun Gupta authored
For multi-table views with LOAD, updates are not allowed, so we should just throw an error.
-
- 29 Jan, 2019 1 commit
-
-
Varun Gupta authored
For singe-table views, we need to find the bottom most base table in the embedded views and then update that table
-
- 28 Jan, 2019 1 commit
-
-
Sergei Golubchik authored
@@open_files_limit now behaves differenly and cannot be used to skip the test anymore.
-
- 27 Jan, 2019 2 commits
-
-
Sergei Golubchik authored
Disable LOAD DATA LOCAL INFILE suport by default and auto-enable it for the duration of one query, if the query string starts with the word "load". In all other cases the application should enable LOAD DATA LOCAL INFILE support explicitly.
-
Vicențiu Ciorbaru authored
If the rlimit.rlim_cur value returned by getrlimit is not the RLIM_INFINITY magic constant, but a *very* large number, we can allocate too many open files. Restrict set_max_open_files to only return at most max_file_limit, as passed via its parameter.
-
- 23 Jan, 2019 6 commits
-
-
Eugene Kosov authored
Close connection handler on connection failure. This fixes 14 failing tests in main suite under clang+ASAN build. ASAN report for main.connect looks like this: ================================================================= ==25495==ERROR: LeakSanitizer: detected memory leaks Direct leak of 146280 byte(s) in 115 object(s) allocated from: #0 0x4fba47 in calloc /fun/cpp_projects/llvm_toolchain/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:138 #1 0x5a7a02 in mysql_init /work/mariadb/libmariadb/libmariadb/mariadb_lib.c:977:26 #2 0x570a7a in do_connect(st_command*) /work/mariadb/client/mysqltest.cc:6096:26 #3 0x584c39 in main /work/mariadb/client/mysqltest.cc:9321:9 #4 0x7fd15514db96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310 Indirect leak of 7065600 byte(s) in 115 object(s) allocated from: #0 0x4fb80f in __interceptor_malloc /fun/cpp_projects/llvm_toolchain/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:129 #1 0x637a83 in my_context_init /work/mariadb/libmariadb/libmariadb/ma_context.c:367:23 #2 0x59fd16 in mysql_optionsv /work/mariadb/libmariadb/libmariadb/mariadb_lib.c:2738:9 #3 0x5bc1d4 in mysql_options /work/mariadb/libmariadb/libmariadb/mariadb_lib.c:3242:10 #4 0x570b94 in do_connect(st_command*) /work/mariadb/client/mysqltest.cc:6103:7 #5 0x584c39 in main /work/mariadb/client/mysqltest.cc:9321:9 #6 0x7fd15514db96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310 Indirect leak of 940240 byte(s) in 115 object(s) allocated from: #0 0x4fb80f in __interceptor_malloc /fun/cpp_projects/llvm_toolchain/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:129 #1 0x64386e in ma_init_dynamic_array /work/mariadb/libmariadb/libmariadb/ma_array.c:49:31 #2 0x649ead in _hash_init /work/mariadb/libmariadb/libmariadb/ma_hash.c:52:7 #3 0x5a3080 in mysql_optionsv /work/mariadb/libmariadb/libmariadb/mariadb_lib.c:2938:13 #4 0x5bc20c in mysql_options4 /work/mariadb/libmariadb/libmariadb/mariadb_lib.c:3248:10 #5 0x56f63b in connect_n_handle_errors(st_command*, st_mysql*, char const*, char const*, char const*, char const*, int, char const*) /work/mariadb/client/mysqltest.cc:5874:3 #6 0x57146b in do_connect(st_command*) /work/mariadb/client/mysqltest.cc:6193:7 #7 0x584c39 in main /work/mariadb/client/mysqltest.cc:9321:9 #8 0x7fd15514db96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310 ... Closes #809
-
Sergei Golubchik authored
don't run `su - mysql` is $USER is already mysql
-
Sergei Golubchik authored
test case
-
Sreeharsha Ramanavarapu authored
Issue: ------ When a subquery contains UNION the count of the number of subquery columns is calculated incorrectly. Only the first query block in the subquery's UNION is considered and an array indexing goes out-of-bounds, and this is caught by an assert. Solution: --------- Sum up the columns from all query blocks of the query expression. Change specific to 5.6/5.5: --------------------------- The "child" points to the last query block of the UNION (as opposed to 5.7+ where it points to the first member of UNION). So "child->master_unit()->first_select()" is used to reach the first query block of UNION.
-
Aditya A authored
PROBLEM ------- Memory sanitizer reports uninitialized comparisons in log_in_use(), because strings are compared with memcmp() instead of strncmp. FIX --- Use strncmp() to compare strings
-
Marko Mäkelä authored
fil_extend_space_to_desired_size(): Invoke fsync() after posix_fallocate() in order to durably extend the file in a crash-safe file system.
-
- 21 Jan, 2019 3 commits
-
-
Sergei Golubchik authored
Avoid introducing new dependencies or new syntax. That is, don't use $(...) and don't assume dirname is present. And remove unsighty /foo/bar/../xyz from the path. Use dirname instead of ../
-
Daniel Black authored
Closes #1086
-
Sergei Golubchik authored
don't shortcut trying to test for openssl version, test what is actually needed for a code to compile
-
- 19 Jan, 2019 1 commit
-
-
Vladislav Vaintroub authored
Patch by Eugene Kosov.
-
- 16 Jan, 2019 3 commits
-
-
Alexander Kuleshov authored
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
-
Natanael Copa authored
Fix the off-by-one overflow which was introduced with commit b0fd06a6 (MDEV-15670 - unit.my_atomic failed in buildbot with Signal 11 thrown) Closes #1098.
-
Oleksandr Byelkin authored
The problem was in calculating of the mask to clear unused null bits in case of using full byte.
-
- 15 Jan, 2019 1 commit
-
-
Vladislav Vaintroub authored
-
- 11 Jan, 2019 1 commit
-
-
Vladislav Vaintroub authored
mysql_install_db.exe should not remove datadir, if it was not created by it.
-
- 02 Jan, 2019 1 commit
-
-
Sergei Golubchik authored
-
- 18 Dec, 2018 1 commit
-
-
Sergey Vojtovich authored
Workaround glibc bug: https://sourceware.org/bugzilla/show_bug.cgi?id=20116 by making unittest threads joinable. It makes code better anyway.
-
- 17 Dec, 2018 1 commit
-
-
Sergei Golubchik authored
This reverts part of c5427172
-
- 13 Dec, 2018 1 commit
-
-
Sergey Vojtovich authored
Forbid ALTER DATABASE under read_only.
-
- 28 Nov, 2018 1 commit
-
-
Sergei Golubchik authored
-
- 16 Nov, 2018 1 commit
-
-
fran authored
Closes #3
-
- 15 Nov, 2018 2 commits
-
-
Alexander Barkov authored
The fix for "MDEV-17698 MEMORY engine performance regression" previously fixed this problem. - Adding the test for MDEV-17724 - Re-recording wrong results for tests: * engines/iuds/r/insert_number * engines/iuds/r/update_delete_number which started to fail since MDEV-17698
-
Alexander Barkov authored
Also, backporting a part of: MDEV-11485 Split Item_func_between::val_int() into virtual methods in Type_handler for easier merge to 10.3.
-