1. 16 Nov, 2007 2 commits
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32241/my50-bug29131 · e8ab63e6
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug32241/my51-bug29131
      
      
      mysql-test/r/explain.result:
        Auto merged
      mysql-test/t/explain.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      e8ab63e6
    • unknown's avatar
      Fix for bug #32241: memory corruption due to large index map in 'Range · 6c5b66aa
      unknown authored
      checked for each record'
      
      The problem was in incorrectly calculated length of the buffer used to
      store a hexadecimal representation of an index map in
      select_describe(). This could result in buffer overrun and stack
      corruption under some circumstances.
      
      Fixed by correcting the calculation.
      
      
      mysql-test/r/explain.result:
        Added a test case for bug #32241.
      mysql-test/t/explain.test:
        Added a test case for bug #32241.
      sql/sql_select.cc:
        Corrected the buffer length calculation. Count one hex digit as 4 bits,
        not 8.
      6c5b66aa
  2. 12 Nov, 2007 1 commit
  3. 07 Nov, 2007 1 commit
    • unknown's avatar
      Fix for bug #30666: Incorrect order when using range conditions on 2 · 00c125ee
      unknown authored
      tables or more
      
      The problem was that the optimizer used the join buffer in cases when
      the result set is ordered by filesort. This resulted in the ORDER BY
      clause being ignored, and the records being returned in the order
      determined by the order of matching records in the last table in join.
      
      Fixed by relaxing the condition in make_join_readinfo() to take
      filesort-ordered result sets into account, not only index-ordered ones.
      
      
      mysql-test/r/select.result:
        Added a test case for bug #30666.
      mysql-test/t/select.test:
        Added a test case for bug #30666.
      sql/sql_select.cc:
        Relaxed the condition to determine when the join buffer usage must be
        disabled. The condition is now true for cases when the result set is
        ordered by filesort, that is when 'join->order &&
        !join->skip_sort_order' is true.
      00c125ee
  4. 26 Oct, 2007 1 commit
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug29131/my50-bug29131 · c0d9ddda
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug29131/my51-bug29131
      
      
      mysql-test/r/variables.result:
        Null merge.
      mysql-test/t/variables.test:
        Null merge.
      sql/mysql_priv.h:
        Null merge.
      sql/mysqld.cc:
        Null merge.
      sql/set_var.cc:
        Null merge.
      sql/set_var.h:
        Null merge.
      c0d9ddda
  5. 25 Oct, 2007 2 commits
    • unknown's avatar
      Fix for bug #29131: SHOW VARIABLES reports variable 'log' but SET · a6457ad2
      unknown authored
      doesn't recognize it
        
      This is a 5.1 version of the patch.
        
      Problem:
        
      'log' and 'log_slow_queries' were "fixed" variables, i.e. they showed up
      in SHOW VARIABLES, but could not be used in expressions like 
      "select @@log". Also, using them in the SET statement produced an 
      incorrect "unknown system variable" error.
        
      Solution:
      
      Since as of MySQL 5.1.12 one can enable or disable the general query log
      or the slow query log at runtime by changing values of
      general_log/slow_query_log, make 'log' and 'log_slow_queries" to be 
      synonyms for 'general_log' and 'slow_query_log' respectively.  This 
      makes expressions using the '@@var' syntax backward compatible with 
      5.0 and SHOW VARIABLES output to be consistent with the SET statement.
      
      
      mysql-test/r/log_state.result:
        Added a test case for bug #29131.
      mysql-test/t/log_state.test:
        Added a test case for bug #29131.
      sql/set_var.cc:
        Made the 'log' and 'log_slow_queries' system variables to be synonyms for 'general_log' and 'slow_query_log'.
      a6457ad2
    • unknown's avatar
      Fix for bug #29131: SHOW VARIABLES reports variable 'log' but SET · ee50bb8c
      unknown authored
      doesn't recognize it
      
      This is a 5.0 version of the patch, it will be null-merged to 5.1
      
      Problem:
      
      'log' and 'log_slow_queries' were "fixed" variables, i.e. they showed up
      in SHOW VARIABLES, but could not be used in expressions like 
      "select @@log". Also, using them in the SET statement produced an 
      incorrect "unknown system variable" error.
      
      Solution:
      
      Make 'log' and 'log_slow_queries' read-only dynamic variables to make 
      them available for use in expressions, and produce a correct error 
      about the variable being read-only when used in the SET statement.
      
      
      mysql-test/r/variables.result:
        Added a test case for bug #29131.
      mysql-test/t/variables.test:
        Added a test case for bug #29131.
      sql/mysql_priv.h:
        Changed the type of opt_log and opt_slow_log to my_bool to 
        align with the interfaces in set_var.cc
      sql/mysqld.cc:
        Changed the type of opt_log and opt_slow_log to my_bool to 
        align with the interfaces in set_var.cc
      sql/set_var.cc:
        Made 'log' and 'log_slow_queries' to be read-only dynamic system 
        variable, i.e. available for use in expressions with the @@var syntax.
      sql/set_var.h:
        Added a new system variable class representing a read-only boolean
        variable.
      ee50bb8c
  6. 21 Oct, 2007 2 commits
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug28550/my50-bug28550 · 87784bf6
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug28550/my51-bug28550
      
      
      mysql-test/t/func_str.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      mysql-test/r/func_str.result:
        Manual merge.
      87784bf6
    • unknown's avatar
      Bug #28550 "Potential bugs related to the return type of the CHAR function". · 0ca57427
      unknown authored
        
      Since, as of MySQL 5.0.15, CHAR() arguments larger than 255 are converted into multiple result bytes, a single CHAR() argument can now take up to 4 bytes. This patch fixes Item_func_char::fix_length_and_dec() to take this into account.
        
      This patch also fixes a regression introduced by the patch for bug21513. As now we do not always have the 'name' member of Item set for Item_hex_string and Item_bin_string, an own print() method has been added to Item_hex_string so that it could correctly be printed by Item_func::print_args().
      
      
      mysql-test/r/func_str.result:
        Import patch bug288550.patch
      mysql-test/t/func_str.test:
        Import patch bug288550.patch
      sql/item.cc:
        Import patch bug288550.patch
      sql/item.h:
        Import patch bug288550.patch
      sql/item_strfunc.h:
        Import patch bug288550.patch
      0ca57427
  7. 17 Oct, 2007 3 commits
    • unknown's avatar
      Bug#31381 Error in retrieving Data from INFORMATION_SCHEMA · 5bce0171
      unknown authored
      move 'table_collation' field filling outside of if(file) condition
      because this field has 'OPEN_FRM_ONLY' attribute
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      sql/sql_show.cc:
        move 'table_collation' field filling outside of if(file) condition
        because this field has 'OPEN_FRM_ONLY' attribute
      5bce0171
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0-opt · 6541906d
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      mysql-test/suite/funcs_1/r/innodb__datadict.result:
        manual merge
      mysql-test/suite/funcs_1/r/myisam__datadict.result:
        manual merge
      6541906d
    • unknown's avatar
      Bug#31568 Some "information_schema" entries suddenly report a NULL default · a48ed6c9
      unknown authored
      updated result files
      
      
      mysql-test/suite/funcs_1/r/innodb__datadict.result:
        updated result file
      mysql-test/suite/funcs_1/r/memory__datadict.result:
        updated result file
      mysql-test/suite/funcs_1/r/myisam__datadict.result:
        updated result file
      a48ed6c9
  8. 16 Oct, 2007 2 commits
  9. 15 Oct, 2007 3 commits
  10. 14 Oct, 2007 2 commits
  11. 13 Oct, 2007 4 commits
  12. 12 Oct, 2007 8 commits
  13. 11 Oct, 2007 6 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/PA/5.0-opt-31471 · e9c4cbea
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      mysql-test/r/create.result:
        Auto merged
      mysql-test/r/null.result:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      e9c4cbea
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/PA/5.0-opt-31471 · 5bf0a2ec
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      5bf0a2ec
    • unknown's avatar
      after merge fix · 234fb583
      unknown authored
      234fb583
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0-opt · 8af8994c
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      sql/sql_yacc.yy:
        manual merge
      8af8994c
    • unknown's avatar
      Bug#30981 CHAR(0x41 USING ucs2) doesn't add leading zero · 835746d0
      unknown authored
      Bug#30982 CHAR(..USING..) can return a not-well-formed string
      Bug#30986 Character set introducer followed by a HEX string can return bad result
      check_well_formed_result moved to Item from Item_str_func
      fixed Item_func_char::val_str for proper ucs symbols converting
      added check for well formed strings for correct conversion of constants with underscore
      charset
      
      
      mysql-test/r/ctype_ucs.result:
        test result
      mysql-test/r/ctype_utf8.result:
        test result
      mysql-test/t/ctype_ucs.test:
        test case
      mysql-test/t/ctype_utf8.test:
        test case
      sql/item.cc:
        check_well_formed_result() moved from Item_str_func
      sql/item.h:
        check_well_formed_result() moved from Item_str_func
      sql/item_strfunc.cc:
        check_well_formed_result moved to Item
        fixed Item_func_char::val_str for proper ucs symbols converting
      sql/item_strfunc.h:
        check_well_formed_result moved to Item
      sql/sql_yacc.yy:
        added check for well formed string
      835746d0
    • unknown's avatar
      Bug #31440: 'select 1 regex null' asserts debug server · 6bae70ba
      unknown authored
      The special case with NULL as a regular expression
      was handled at prepare time. But in this special case
      the item was not marked as fixed. This caused an assertion
      at execution time.
      Fixed my marking the item as fixed even when known to 
      return NULL at prepare time.
      
      
      mysql-test/r/func_regexp.result:
        Bug #31440: test case
      mysql-test/t/func_regexp.test:
        Bug #31440: test case
      sql/item_cmpfunc.cc:
        Bug #31440: mark the item as fixed even when 
        known to return NULL.
      6bae70ba
  14. 10 Oct, 2007 3 commits
    • unknown's avatar
      Fixed bug #31471: decimal_bin_size: Assertion `scale >= 0 && · f23d0bc7
      unknown authored
                        precision > 0 && scale <= precision'.
      
      A sign of a resulting item of the IFNULL function was not
      updated and the maximal length of this result was calculated
      improperly. Correct algorithm was copy&pasted from the IF
      function implementation.
      
      
      sql/item_cmpfunc.cc:
        Fixed bug #31471.
        The Item_func_ifnull::fix_length_and_dec method has been
        modified to update the Item_func_ifnull::unsigned_flag field
        and to take this field into account when calculating the
        Item_func_ifnull::max_length value.
        (See Item_func_if::fix_length_and_dec for reference).
      mysql-test/t/null.test:
        Added test case for bug #31471.
      mysql-test/r/null.result:
        Added test case for bug #31471.
      mysql-test/r/create.result:
        Update test case after the bugfix of bug #31471.
      f23d0bc7
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0-opt · a0c8160e
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      libmysql/libmysql.c:
        Auto merged
      a0c8160e
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.1 · 92132352
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      libmysql/libmysql.c:
        Auto merged
      mysql-test/include/mix1.inc:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/ha_partition.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      92132352