1. 26 Nov, 2021 1 commit
    • Hugo Wen's avatar
      MDEV-27124: Update definer of Add/DropGeometryColumn procedures from 'root' to 'mariadb.sys' · e9572e53
      Hugo Wen authored
      From 10.4.13, the `mariadb.sys` user was created to replace `root` definers.
       - In commit 0253ea7f, definer of
         Add/DropGeometryColumn procedures was changed to `mariadb.sys`, in
         `scripts/maria_add_gis_sp.sql.in`.
         However, maria_add_gis_sp.sql only applies to new databases created by
         installation script. Databases upgraded from old versions will miss this
         change.
       - In addition, according to commit
         0d6d801e(MDEV-23102), in some scenarios
         when root user is replaced it will skip creating `mariadb.sys` user.
      
      This commit is to update the definer from `root` to `mariadb.sys` during
      upgrade. It only makes the change if the original definers are root.
      
      Doesn't choose to execute `maria_add_gis_sp.sql` in upgrade script to
      recreate the procedures is because of considering the scenarios of
      MDEV-23102 that `root` user is replaced and `mariadb.sys` is not created.
      
      All new code of the whole pull request, including one or several files
      that are either new files or modified ones, are contributed under the
      BSD-new license. I am contributing on behalf of my employer Amazon Web
      Services, Inc.
      e9572e53
  2. 24 Nov, 2021 2 commits
  3. 23 Nov, 2021 3 commits
  4. 18 Nov, 2021 2 commits
  5. 17 Nov, 2021 5 commits
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 70e788b1
      Marko Mäkelä authored
      70e788b1
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 9962cda5
      Marko Mäkelä authored
      9962cda5
    • Marko Mäkelä's avatar
      MDEV-23805 fixup: Adjsut the MDEV-16131 and MDEV-24730 tests · 878f7e38
      Marko Mäkelä authored
      MDEV-23805 simplified the treatment of empty tables during ALTER TABLE,
      which could prevent the scenarios that were previously reported and
      fixed as MDEV-16131 and MDEV-24730.
      
      With the MDEV-23805 fix, the statement
      SET DEBUG_SYNC = 'now WAIT_FOR copied';
      could occasionally time out, depending on timing.
      Apparently, there was a race condition where purge could resume
      (and empty the table) before ALTER TABLE got the chance to execute.
      We must prevent the purge of history from running before
      ALTER TABLE has started executing.
      878f7e38
    • Eugene Kosov's avatar
      MDEV-26747 improve corruption check for encrypted tables on ALTER IMPORT · ed0a224b
      Eugene Kosov authored
      fil_space_decrypt(): change signature to return status via dberr_t only.
      Also replace impossible condition with an assertion and prove it via
      test cases.
      ed0a224b
    • Igor Babaev's avatar
      MDEV-26825 Bogus error for query with two usage of CTE referring another CTE · 8f24f5fe
      Igor Babaev authored
        This bug affected queries with two or more references to a CTE referring
      another CTE if the definition of the latter contained an invocation of
      a stored function that used a base table. The bug could lead to a bogus
      error message or to an assertion failure.
        For any non-first reference to CTE cte1 With_element::clone_parsed_spec()
      is called that parses the specification of cte1 to construct the unit
      structure for this usage of cte1. If cte1 refers to another CTE cte2
      outside of the specification of cte1 then With_element::clone_parsed_spec()
      has to be called for cte2 as well. This call is made by the function
      LEX::resolve_references_to_cte() within the invocation of the function
      With_element::clone_parsed_spec() for cte1.
        When the specification of a CTE is parsed all table references encountered
      in it must be added to the global list of table references for the query.
      As the specification for the non-first usage of a CTE is parsed at a
      recursive call of the parser the function With_element::clone_parsed_spec()
      invoked at this recursive call should takes care of appending the list of
      table references encountered in the specification of this CTE cte1 to the
      list of table references created for the query. And it should do it after
      the call of LEX::resolve_references_to_cte() that resolves references to
      CTEs defined outside of the specification of cte1 because this call may
      invoke the parser again for specifications of other CTEs and  the table
      references from their specifications must ultimately appear in the global
      list of table references of the query.
        The code of With_element::clone_parsed_spec() misplaced the call of
      LEX::resolve_references_to_cte(). As a result LEX::query_tables_last used
      for the query that was supposed to point to the field 'next_global' of the
      last element in the global list of table references actually pointed to
      'next_global' of the previous element.
        The above inconsistency certainly caused serious problems when table
      references used in the stored functions invoked in cloned specifications
      of CTEs were added to the global list of table references.
      8f24f5fe
  6. 16 Nov, 2021 2 commits
  7. 12 Nov, 2021 1 commit
  8. 11 Nov, 2021 4 commits
  9. 10 Nov, 2021 1 commit
  10. 09 Nov, 2021 19 commits