1. 12 Feb, 2008 1 commit
  2. 11 Feb, 2008 3 commits
  3. 08 Feb, 2008 2 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 955f1885
      unknown authored
      into  dipika.(none):/opt/local/work/mysql-5.0-runtime
      
      955f1885
    • unknown's avatar
      Bug#33798 prepared statements improperly handle large unsigned ints · cea021da
      unknown authored
      The unsignedness of large integer user variables was not being
      properly preserved when feeded to prepared statements. This was
      happening because the unsigned flags wasn't being updated when
      converting the user variable is converted to a parameter.
      
      The solution is to copy the unsigned flag when converting the
      user variable to a parameter and take the unsigned flag into
      account when converting the integer to a string.
      
      
      mysql-test/r/binlog.result:
        Add test case result for Bug#33798
      mysql-test/r/ps.result:
        Add test case result for Bug#33798
      mysql-test/t/binlog.test:
        Add test case for Bug#33798
      mysql-test/t/ps.test:
        Add test case for Bug#33798
      sql/item.cc:
        Take the unsigned flag into account when converting the
        user variable.
      cea021da
  4. 07 Feb, 2008 2 commits
  5. 06 Feb, 2008 4 commits
  6. 05 Feb, 2008 1 commit
    • unknown's avatar
      Bug #34305 show slave status handling segfaults when slave io is about · 89e828b4
      unknown authored
          to leave
      
      The artifact was caused by
      a flaw in concurrent accessing the slave's io thd by
      the io itself and a handling show slave status thread.
      Namely, show_master_info did not acquire mi->run_lock mutex that is
      specified for mi->io_thd member.
      
      Fixed with deploying the mutex locking and unlocking. The mutex is kept
      short time and without interleaving with mi->data_lock mutex.
      
      Todo: to report and fix an issue with 
          sys_var_slave_skip_counter::{methods} 
      seem to acquire incorrectly
           active_mi->rli.run_lock
      instead of the specified
           active_mi->rli.data_lock
      
      A test case is difficult to compose, so rpl_packet should continue serving
      as the indicator.
      
      
      sql/slave.cc:
        implementing a TODO left at 4.1 time:
        mending access to mi->io_thd with the specified mutex;
      sql/slave.h:
        adding a member name to the list of that run_lock guards.
      89e828b4
  7. 04 Feb, 2008 4 commits
    • unknown's avatar
      ndb - some warnings, debug errors · 69f41d63
      unknown authored
      
      ndb/src/common/debugger/SignalLoggerManager.cpp:
        some warnings, debug errors
      ndb/src/common/debugger/signaldata/ScanTab.cpp:
        some warnings, debug errors
      ndb/src/kernel/vm/pc.hpp:
        some warnings, debug errors
      69f41d63
    • unknown's avatar
      Updating result file. · 9c81e797
      unknown authored
      
      mysql-test/r/rpl_user.result:
        Result change.
      9c81e797
    • unknown's avatar
      Fixes to make rpl_user test pass in pushbuild. · 42b9a0f1
      unknown authored
      
      mysql-test/t/rpl_user.test:
        Removing redundant reset master and deleting users from master
        and slave without using binary log.
      42b9a0f1
    • unknown's avatar
      bug#34169 - fix pthread_t abuse · 066da030
      unknown authored
      
      ndb/src/ndbapi/Ndb.cpp:
        fix pthread_t abuse
      ndb/test/ndbapi/testOIBasic.cpp:
        fix pthread_t abuse
      066da030
  8. 01 Feb, 2008 6 commits
  9. 31 Jan, 2008 7 commits
    • unknown's avatar
      ndb - bug#34107 - ndb api test case · 48d88798
      unknown authored
      
      ndb/test/ndbapi/testInterpreter.cpp:
        bug#34107 testInterpreter test case
      ndb/test/run-test/daily-basic-tests.txt:
        bug#34107 testInterpreter test case
      48d88798
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0 · fc72d468
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge
      
      
      include/my_sys.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      fc72d468
    • unknown's avatar
      Merge sama.ndb.mysql.com:/export/space/pekka/ndb/version/my50-ndb · 699acec1
      unknown authored
      into  sama.ndb.mysql.com:/export/space/pekka/ndb/version/my50-bug34107
      
      699acec1
    • unknown's avatar
      ndb - bug#34107 patch 2, ndb api · 330973bc
      unknown authored
      
      mysql-test/r/ndb_condition_pushdown.result:
        bug#34107 lower scanfilter max size to not hit TUP limit
      mysql-test/t/ndb_condition_pushdown.test:
        bug#34107 lower scanfilter max size to not hit TUP limit
      ndb/include/ndbapi/ndbapi_limits.h:
        bug#34107 lower scanfilter max size to not hit TUP limit
      330973bc
    • unknown's avatar
      ndb - bug#34107 patch 1, kernel · a16373be
      unknown authored
      
      ndb/src/kernel/blocks/dbtup/Dbtup.hpp:
        bug#34107 check stored proc overflow
      ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp:
        bug#34107 check stored proc overflow
      ndb/src/kernel/blocks/dbtup/DbtupStoredProcDef.cpp:
        bug#34107 check stored proc overflow
      ndb/src/ndbapi/ndberror.c:
        bug#34107 check stored proc overflow
      a16373be
    • unknown's avatar
      Changes to fix tests in pushbuild. · 5e0f848b
      unknown authored
      
      mysql-test/include/have_local_infile.inc:
        BitKeeper file /data0/mkindahl/mysql-5.0-rpl-merge/mysql-test/include/have_local_infile.inc
      mysql-test/r/have_local_infile.require:
        BitKeeper file /data0/mkindahl/mysql-5.0-rpl-merge/mysql-test/r/have_local_infile.require
      mysql-test/t/binlog_start_comment.test:
        Test requires that local_infile is on, so added require for that.
      mysql-test/t/rpl_sp.test:
        Adding missing sync_slave_with_master causing following tests to fail.
      5e0f848b
    • unknown's avatar
      Fixes to make code compile on Windows. · dcb6e497
      unknown authored
      
      sql/sql_repl.cc:
        Adding cast to remove compile error on Windows platform.
      dcb6e497
  10. 30 Jan, 2008 8 commits
    • unknown's avatar
      Disabling rpl_transaction test for non-debug builds. · 1f96c52a
      unknown authored
      
      mysql-test/t/rpl_transaction.test:
        Test only works for debug build.
      1f96c52a
    • unknown's avatar
      Changes to make tests pass in pushbuild. · e7a28528
      unknown authored
      
      mysql-test/r/bdb_notembedded.result:
        Result change.
      mysql-test/r/rpl_loaddata_map.result:
        Result change.
      mysql-test/t/rpl_loaddata_map.test:
        Blanking out file id as well.
      e7a28528
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.0 · 425e4995
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb-merge
      
      
      mysql-test/r/view.result:
        Auto merged
      425e4995
    • unknown's avatar
      ndb - bug#34160 · 16945f42
      unknown authored
        make sure release of not added ptr does not corrupt hashtable
      
      16945f42
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl · adb91e45
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge
      
      
      include/my_sys.h:
        Auto merged
      mysql-test/r/blackhole.result:
        Auto merged
      mysql-test/r/case.result:
        Auto merged
      mysql-test/r/mysqlbinlog2.result:
        Auto merged
      mysql-test/t/blackhole.test:
        Auto merged
      mysql-test/t/case.test:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      adb91e45
    • unknown's avatar
      Merge zhe@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · 69b9cf34
      unknown authored
      into  mail.hezx.com:/media/sda3/work/mysql/bkwork/bug26489_corruption_in_relay_log/5.0
      
      69b9cf34
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · 342021c5
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/50-ndb
      
      342021c5
    • unknown's avatar
      ndb - bug#30172 · ec106ca8
      unknown authored
        Backup can assert with "big" table definitions
        Correct condition before fetching next meta-table
        Increase meta-buffer, to cope with atleast 2 tables
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Correct condition, before fetching new meta-table
      ndb/src/kernel/blocks/backup/Backup.hpp:
        Make sure atleast 2 tables can fix
      ec106ca8
  11. 29 Jan, 2008 2 commits
    • unknown's avatar
      update test result · 6b608eaa
      unknown authored
      
      mysql-test/r/rpl_grant.result:
        update result
      6b608eaa
    • unknown's avatar
      BUG#26489 Corruption in relay logs · cbcbfd77
      unknown authored
      Here is the scenario that causes the failure.(by Mats)
      
      1. The to-be corrupt log event (let's call it X), is split into two
         packets B and C on the network level (net_write_buff()). The parts
         are X = (x',x''). The part x' ends up in packet B and part x''
         ends up in packet C. Prior to the corrupt event X, the event Y has
         been written successfully, but has been split into two packets as
         well, which we call (y',y'').
      2. The master sends packet A = (y'',x') to the slave, increases the
         packet sequence number, the slave receives the packet, but fails
         to reply before the master gets a timeout.
      3. Since the master got a timeout, it reports failure, and aborts
         sending the binary log by exiting mysql_binlog_send(). However, it
         leaves the buffer intact, still holding y'' (but not x', since the
         write_pos is not increased).
      4. After exiting mysql_binlog_send(), the master does a
         disconnection of the client thread, which involves sending an
         error message e to the client (i.e., the slave).
      5. In this case, net_write_buff() is used again, but this time the
         old contents of the packet is used so that the new packet is
         D = (y'',e). Note that this will use a new packet sequence number,
         since the packet number was increased in step 2.
      6. The slave receives the tail y'' of the Y log event, concatenates
         this with x' (which it already received), and writes the event
         (x',y'') it to the relay log since it hasn't noticed anything is
         amiss.
      7. It then tries to read more bytes, which is either e (if the length
         given for X just happened to match the length given for Y, or just
         plain garbage because the slave is out of sync with what is
         actually sent.
      8. After a while, the SQL thread tries to execute the event (x',y''),
         which is very likely to be just nonsense.
      
      The problem can be fixed by not resetting net->error after the call of 
      mysql_binlog_send, so the error message will not be sent and the connection
      will be closed.
      
      
      sql/sql_parse.cc:
        Do not reset net->error, if net->error == 2, we should not try to use the connection again
      cbcbfd77