1. 23 Mar, 2008 1 commit
  2. 19 Mar, 2008 1 commit
    • unknown's avatar
      Bug #33334 mysqltest_embedded crashes when disconnecting before reap. · 4018b139
      unknown authored
      Before breaking the connection we have to check that there's no query
        executing at the moment. Otherwise it can lead to crash in embedded server.
      
      
      client/mysqltest.c:
        Bug #33334 mysqltest_embedded crashes when disconnecting before reap.
        
        Wait until the query thread is finished before we break the connection.
        Waiting part moved to a separate wait_query_thread_end() function
      mysql-test/r/flush.result:
        Bug #33334 mysqltest_embedded crashes when disconnecting before reap.
        
        test result
      mysql-test/t/flush.test:
        Bug #33334 mysqltest_embedded crashes when disconnecting before reap.
        
        test case
      4018b139
  3. 24 Feb, 2008 2 commits
    • unknown's avatar
      Bug#32757: hang with sql_mode set when setting some global variables · 9bd3b854
      unknown authored
      If setting a system-variable provided by a plug-in failed, no OK or
      error was sent in some cases, hanging the client. We now send an error
      in the case from the ticket (integer-argument out of range in STRICT
      mode). We also provide a semi-generic fallback message for possible
      future cases like this where an error is signalled, but no message is
      sent to the client. The error/warning handling is unified so it's the
      same again for variables provided by plugins and those in the server
      proper.
      
      
      mysql-test/r/plugin.result:
        show that on out-of-range values, plugin interface throws errors
        in STRICT mode and warnings otherwise.
      mysql-test/t/plugin.test:
        show that on out-of-range values, plugin interface throws errors
        in STRICT mode and warnings otherwise.
      sql/set_var.cc:
        - handle signedness of values used in warnings
        - in STRICT mode, throw errors rather than warnings
      sql/sql_parse.cc:
        If sql_set_variables() returns with an error but no message
        was sent to the client, send a semi-generic one so the session
        won't hang and we won't fail silently.
      sql/sql_plugin.cc:
        throw a warning if more than just block-size was corrected
        (or an error in STRICT mode). use functions from set_var
        for uniform behaviour of server- and plug-in variables.
      storage/example/ha_example.cc:
        Add a ULONG system variable to example plugin so
        we can test integers in the plugin-interface without
        having to depend on the presence of innobase.
      9bd3b854
    • unknown's avatar
      Bug#32753: PAD_CHAR_TO_FULL_LENGTH is not documented and interferes with grant tables · a22c3d21
      unknown authored
      SQL-mode PAD_CHAR_TO_FULL_LENGTH affected mysqld's user-table too. If
      enabled, user-name and host were space-padded and no longer matched
      the login-data of incoming connexions.
      
      Patch disregards pad-flag while loading privileges so ability to log
      in does not depend on SQL-mode.
      
      
      mysql-test/r/sql_mode.result:
        show that SQL-mode 'PAD_CHAR_TO_FULL_LENGTH' does not affect
        loading of privileges (and by extension, ability to log in).
      mysql-test/t/sql_mode.test:
        show that SQL-mode 'PAD_CHAR_TO_FULL_LENGTH' does not affect
        loading of privileges (and by extension, ability to log in).
      sql/sql_acl.cc:
        temporarily disable SQL-mode 'PAD_CHAR_TO_FULL_LENGTH' while
        reloading privileges
      a22c3d21
  4. 22 Feb, 2008 2 commits
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug33049/my50-bug33790 · 72f1b329
      unknown authored
      into  kaamos.(none):/data/src/opt/bug33049/my51-bug33790
      
      
      mysql-test/r/view.result:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      mysql-test/t/view.test:
        Manual merge.
      72f1b329
    • unknown's avatar
      Fix for bug #33049: Assert while running test-as3ap test(mysql-bench · 012aab7d
      unknown authored
                          suite)
      
      Under some circumstances a combination of aggregate functions and
      GROUP BY in a SELECT query over a VIEW could lead to incorrect
      calculation of the result type of the aggregate function. This in
      turn could result in incorrect results, or assertion failures on debug
      builds.
      
      Fixed by changing the logic in Item_sum_hybrid::fix_fields() so that
      the argument's item is dereferenced before calling its type() method.
      
      
      mysql-test/r/view.result:
        Added a test case for bug #33049.
      mysql-test/t/view.test:
        Added a test case for bug #33049.
      sql/item_sum.cc:
        When calculating the result type of an aggregate function, dereference
        the argument's item before calling its type() method.
      012aab7d
  5. 14 Feb, 2008 4 commits
  6. 13 Feb, 2008 7 commits
    • unknown's avatar
      Merge host.loc:/home/uchum/work/5.1-opt-gca · 801cc51c
      unknown authored
      into  host.loc:/home/uchum/work/5.1-opt
      
      
      801cc51c
    • unknown's avatar
      Post-merge fixes. · 3d35b019
      unknown authored
      3d35b019
    • unknown's avatar
      Merge host.loc:/home/uchum/work/5.0-opt-gca · be891fc6
      unknown authored
      into  host.loc:/home/uchum/work/5.0-opt
      
      
      be891fc6
    • unknown's avatar
      Merge host.loc:/home/uchum/work/5.0-opt-gca · 22e27626
      unknown authored
      into  host.loc:/home/uchum/work/5.1-opt-gca
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      22e27626
    • unknown's avatar
      Fixed bug#31194: Privilege ordering does not order properly · 7a290b55
      unknown authored
                       for wildcard values.
      The server ignored escape character before wildcards during
      the calculation of priority values for sorting of a privilege
      list. (Actually the server counted an escape character as an
      ordinary wildcard like % or _). I.e. the table name template
      with a wildcard character like 'tbl_1' had higher priority in
      a privilege list than concrete table name without wildcards
      like 'tbl\_1', and some privileges of 'tbl\_1' was hidden
      by privileges for 'tbl_1'.
      
      The get_sort function has been modified to ignore escaped
      wildcards as usual.
      
      
      
      mysql-test/r/grant3.result:
        Added test case for bug#31194.
      mysql-test/t/grant3.test:
        Added test case for bug#31194.
      sql/sql_acl.cc:
        Fixed bug#31194.
        The server used the wild_prefix escape character (usually \-character)
        like % and _ wildcards in the get_sort function for sorting weights
        calculation.
        
        The get_sort function has been modified to ignore escaped wildcards
        and alone escapes like in the wild_case_compare function.
      7a290b55
    • unknown's avatar
      Fixed bug#33764: Wrong result with IN(), CONCAT() and implicit · 247efb9c
      unknown authored
                       type conversion.
      
      Instead of copying of whole character string from a temporary
      buffer, the server copied a short-living pointer to that string
      into a long-living structure. That has been fixed.
      
      
      mysql-test/r/select.result:
        Added test case for bug#33764.
      mysql-test/t/select.test:
        Added test case for bug#33764.
      sql/item_cmpfunc.cc:
        Fixed bug#33764.
        Copying of a pointer has been replaced with an optional copying of
        a whole array to a newly allocated memory space in case of a
        functional source item.
      247efb9c
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · 91123903
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/heap.result:
        Auto merged
      mysql-test/r/innodb.result:
        Auto merged
      mysql-test/r/myisam.result:
        Auto merged
      BitKeeper/deleted/.del-bdb.result:
        Auto merged
      mysql-test/r/strict.result:
        Auto merged
      mysql-test/r/type_binary.result:
        Auto merged
      mysql-test/r/type_set.result:
        Auto merged
      mysql-test/r/variables.result:
        Auto merged
      mysql-test/r/warnings.result:
        Auto merged
      mysql-test/t/range.test:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      mysql-test/t/warnings.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/mysqld.cc:
        Null merge.
      mysql-test/include/mix1.inc:
        Manual merge.
      mysql-test/r/innodb_mysql.result:
        Manual merge.
      mysql-test/r/range.result:
        Manual merge.
      mysql-test/r/sp.result:
        Manual merge.
      mysql-test/t/sp.test:
        Manual merge.
      sql/handler.cc:
        Manual merge.
      91123903
  7. 12 Feb, 2008 6 commits
  8. 11 Feb, 2008 2 commits
  9. 10 Feb, 2008 9 commits
  10. 08 Feb, 2008 3 commits
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 60ca0e34
      unknown authored
      into  host.loc:/home/uchum/work/5.0-opt
      
      
      60ca0e34
    • unknown's avatar
      Fixed bug#15409: Columns with 64-element SET may not be updated with integers. · 213b4dcd
      unknown authored
      SET column storing procedure has been modified to be 64bit-clean.
      
      
      mysql-test/r/type_set.result:
        Added test case for bug#15409.
      mysql-test/t/type_set.test:
        Added test case for bug#15409.
      sql/field.cc:
        Fixed bug#15409.
        The Field_set::store(longlong nr,...) method incompletely
        calculates a bit mask for the comparison with a given number:
        if that number is greater than 0x7F00 0000 0000 0000 (LONGLONG_MAX),
        it uses zero bit mask instead of 0xFFFF FFFF FFFF FFFF (ULONGLONG_MAX).
        
        Incomplete expression has been replaced with a set_bits macro call.
      213b4dcd
    • unknown's avatar
      Bug#31590: Wrong error message on sort buffer being too small. · d8eab976
      unknown authored
      The out of memory error was thrown when the sort buffer size were too small.
      This led to a user confusion.
      
      Now filesort throws the error message about sort buffer being too small.
      
      
      mysql-test/t/order_by.test:
        Added a test case for the bug#31590: Wrong error message on sort buffer being too small.
      mysql-test/r/order_by.result:
        Added a test case for the bug#31590: Wrong error message on sort buffer being too small.
      sql/filesort.cc:
        Bug#31590: Wrong error message on sort buffer being too small.
        Now filesort throws the error message about sort buffer being too small
        instead of out of memory error.
      d8eab976
  11. 07 Feb, 2008 3 commits