1. 06 May, 2013 1 commit
  2. 03 May, 2013 1 commit
  3. 30 Apr, 2013 5 commits
    • unknown's avatar
      merge from mysql-5.1 · e14c5ea8
      unknown authored
      e14c5ea8
    • unknown's avatar
      Bug#16405422 - RECOVERY FAILURE, ASSERT !RECV_NO_LOG_WRITE · 9d60b6c9
      unknown authored
      eliminate a race condition over recv_sys->n_addrs which might result in a database corruption
      in recovery, without reporting a recovery error.
      
      recv_recover_page_func(): move the code segment that decrements recv_sys->n_addrs
        to the end of the function, after the call to mtr_commit()
      
      rb://2282 approved by Inaam
      9d60b6c9
    • Neeraj Bisht's avatar
      BUG#16222245 - CRASH WITH EXPLAIN FOR A QUERY WITH LOOSE SCAN FOR · f671d4ec
      Neeraj Bisht authored
      GROUP BY, MYISAM 
      
      Merge fix for Bug#16222245 from mysql-5.1 to mysql-5.5
      f671d4ec
    • Neeraj Bisht's avatar
      BUG#16222245 - CRASH WITH EXPLAIN FOR A QUERY WITH LOOSE SCAN FOR · 7c63bb21
      Neeraj Bisht authored
      GROUP BY, MYISAM 
      
      Problem:-
      In a query, where we are using loose index scan optimization and 
      we have MIN() causes segmentation fault(where table row length 
      is less then key_length).
      
      Analysis:
      
      While using loose index scan for MIN(), we call key_copy(), to copy 
      the key data from record.
      This function is using temporary record buffer to store key data 
      from the record buffer.But in case where the key length is greater 
      then the buffer length, this will cause a segmentation fault.
      
      
      Solution:
      Give a proper buffer to store a key record.
      
      
      sql/opt_range.cc:
        We can't use record buffer to store key data.So, give a proper buffer to store a key record.
      7c63bb21
    • Marko Mäkelä's avatar
      Bug#16720368 INNODB IGNORES *.IBD FILE BREAKAGE AT STARTUP · 6df1195f
      Marko Mäkelä authored
      After a clean shutdown, InnoDB will not check the *.ibd file headers,
      for maximum performance. This is unchanged before and after this
      patch.
      
      What this fix addresses is the case when crash recovery is
      needed. Previously, InnoDB could load a corrupted tablespace file.
      
      buf_page_is_corrupted(): Add the parameter check_lsn.
      
      fil_check_first_page(): New function, to perform a consistency check
      on the first page of a file. This can be overridden by setting
      innodb_force_recovery.
      
      fil_read_first_page(), fil_open_single_table_tablespace(),
      fil_load_single_table_tablespace(): Invoke fil_check_first_page().
      
      open_or_create_data_files(): Check the status of
      fil_open_single_table_tablespace().
      
      rb#2352 approved by Jimmy Yang
      6df1195f
  4. 27 Apr, 2013 1 commit
    • Bill Qu's avatar
      Bug #13004581 BLACKHOLE BINARY LOG WITH ROW IGNORES UPDATE AND DELETE STATEMENTS · 81daf219
      Bill Qu authored
        
      When logging to the binary log in row, updates and deletes to a BLACKHOLE
      engine table are skipped.
        
      It is impossible to log binary log in row format for updates and deletes to
      a BLACKHOLE engine table, as no row events can be generated in these cases.
      After fix, generate a warning for UPDATE/DELETE statements that modify a
      BLACKHOLE table, as row events are not logged in row format.
      81daf219
  5. 25 Apr, 2013 1 commit
    • Venkatesh Duggirala's avatar
      BUG#16698172-CANNOT DO POINT-IN-TIME RECOVERY FOR · fe896b56
      Venkatesh Duggirala authored
      SINGLE DATABASE; MYSQLBINLOG
            
      Problem: If last subevent inside a RBR event
      is skipped while replaying a binary log
      using mysqlbinlog with --database=... option,
      generated output is missing end marker('/*!*/;)
      for that RBR event. Thence causing syntax error
      while replaying the generated output.
            
      Fix: Append end marker ('/*!*/;) if the last 
      subevent is getting skipped.
      Append end marker if the last 
      subevent is getting skipped.
      
      client/mysqlbinlog.cc:
        Append end marker if the last 
        subevent is getting skipped.
      fe896b56
  6. 24 Apr, 2013 6 commits
  7. 22 Apr, 2013 2 commits
  8. 20 Apr, 2013 2 commits
    • Neeraj Bisht's avatar
      Bug#16073689 : CRASH IN ITEM_FUNC_MATCH::INIT_SEARCH · 2e2a5c69
      Neeraj Bisht authored
      Problem:
      In query like
      select 1 from .. order by match .. against ...;
      causes a debug assert failue.
      
      Analysis:
      In union type query like
      
      (select * from order by a) order by b;
      or
      (select * from order by a) union (select * from order by b);
      
      We skip resolving of order by a for 1st query and order by of a and b in 
      2nd query.
      
      
      This means that, in case when our order by have Item_func_match class, 
      we skip resolving it.
      But we maintain a ft_func_list and at the time of optimization, when we 
      Perform FULLTEXT search before all regular searches on the bases of the 
      list we call Item_func_match::init_search() which will cause debug assert 
      as the item is not resolved.
      
      
      Solution:
      We will skip execution if the item is not fixed and we will not 
      fix index(Item_func_match::fix_index()) for which 
      Item_func_match::fix_field() is not called so that on later changes 
      we can check the dependency on fix field.
      bz
      
      sql/item_func.cc:
        skiping execution, if item is not resolved.
      2e2a5c69
    • Neeraj Bisht's avatar
      Bug#16073689 : CRASH IN ITEM_FUNC_MATCH::INIT_SEARCH · 197e8b29
      Neeraj Bisht authored
      Problem:
      In query like
      select 1 from .. order by match .. against ...;
      causes a debug assert failue.
      
      Analysis:
      In union type query like
      
      (select * from order by a) order by b;
      or
      (select * from order by a) union (select * from order by b);
      
      We skip resolving of order by a for 1st query and order by of a and b in 
      2nd query.
      
      
      This means that, in case when our order by have Item_func_match class, 
      we skip resolving it.
      But we maintain a ft_func_list and at the time of optimization, when we 
      Perform FULLTEXT search before all regular searches on the bases of the 
      list we call Item_func_match::init_search() which will cause debug assert 
      as the item is not resolved.
      
      
      Solution:
      We will skip execution if the item is not fixed and we will not 
      fix index(Item_func_match::fix_index()) for which 
      Item_func_match::fix_field() is not called so that on later changes 
      we can check the dependency on fix field.
      
      
      sql/item_func.cc:
        skiping execution, if item is not resolved.
      197e8b29
  9. 18 Apr, 2013 1 commit
  10. 17 Apr, 2013 1 commit
  11. 16 Apr, 2013 3 commits
  12. 14 Apr, 2013 2 commits
    • Chaithra Gopalareddy's avatar
      Merge from 5.1 to 5.5 · 9a80a0f8
      Chaithra Gopalareddy authored
      sql/sql_class.h:
        Parsing for group_concat's order by  is made independent.
        As a result, add_order_to_list cannot be used anymore.
      9a80a0f8
    • Chaithra Gopalareddy's avatar
      Bug#16347426:ASSERTION FAILED: (SELECT_INSERT && · 88007244
      Chaithra Gopalareddy authored
                   !TABLES->NEXT_NAME_RESOLUTION_TABLE) || !TAB
            
      Problem:
      The context info of select query gets corrupted when a query
      with group_concat having order by is present in an order by
      clause of the select query. As a result, server crashes with
      an assert.
            
      Analysis:
      While parsing order by for group_concat, it is presumed that
      it is always present before the actual order by for the
      select query.
      As a result, parser uses select->order_list to populate the
      order by items of group_concat and creates a select->gorder_list
      to which select->order_list is copied onto. Once this is done,
      it empties the select->order_list.
      In the case presented in the bugpage, as order by is already
      parsed when group_concat's order by is encountered, parser
      presumes that it is the second order by in the select query
      and creates fake_lex_unit which results in the change of
      context info.
            
      Solution:
      Make group_concat's order by parsing independent of the select
      
      
      sql/item_sum.cc:
        Change the argument as, select->gorder_list is not pointer anymore
      sql/item_sum.h:
        Change the argument as, select->gorder_list is not pointer anymore
      sql/mysql_priv.h:
        Parsing for group_concat's order by is made independent.
        As a result, add_order_to_list cannot be used anymore.
      sql/sql_lex.cc:
        Parsing for group_concat's order by is made independent.
        As a result, add_order_to_list cannot be used anymore.
      sql/sql_lex.h:
        Parsing for group_concat's order by is made independent.
        As a result, add_order_to_list cannot be used anymore.
      sql/sql_yacc.yy:
         Make group_concat's order by parsing independent of the select
        queries order by.
      88007244
  13. 12 Apr, 2013 3 commits
    • Balasubramanian Kandasamy's avatar
      55e5a785
    • Venkatesh Duggirala's avatar
      BUG#16615117 MYSQLDUMP PRODUCES A CHANGE MASTER STATEMENT · d8fedd0b
      Venkatesh Duggirala authored
      WITH A PORT NUMBER ENCLOSED IN QUOTES
      
      Problem: mysqldump --dump-slave --include-master-host-port
      prints the CHANGE MASTER command in the generated logical
      backup. The PORT number that is generated with this command
      is a string and should be an integer.
      
      Fix: Remove the Enclosed quotes for port number.
      d8fedd0b
    • Jorgen Loland's avatar
      Bug#16540042: WRONG QUERY RESULT WHEN USING RANGE OVER · d052f069
      Jorgen Loland authored
                    PARTIAL INDEX
      
      Consider the following table definition:
      
      CREATE TABLE t (
        my_col CHAR(10),
        ...
        INDEX my_idx (my_col(1))
      )
      
      The my_idx index is not able to distinguish between rows with
      equal first-character my_col-values (e.g. "f", "foo", "fee").
      
      Prior to this CS, the range optimizer would translate
      
      "WHERE my_col NOT IN ('f', 'h')" into (optimizer trace syntax)
      
      "ranges": [
        "NULL < my_col < f",
        "f < my_col"
      ]
      
      But this was not correct because the rows with values "foo" 
      and "fee" would not belong to any of those ranges. However, the
      predicate "my_col != 'f' AND my_col != 'h'" would translate
      to 
      
      "ranges": [
        "NULL < my_col"
      ]
      
      because get_mm_leaf() changes from "<" to "<=" for partial
      keyparts. This CS changes the range optimizer implementation 
      for NOT IN to behave like a conjunction of NOT EQUAL: it 
      replaces "<" with "<=" for all but the first range when the
      keypart is partial.
      d052f069
  14. 11 Apr, 2013 1 commit
  15. 10 Apr, 2013 2 commits
    • Tor Didriksen's avatar
      Bug#16395606 SCRIPTS MISSING EXECUTE BIT · 650f4ae0
      Tor Didriksen authored
      Add execute bit for scripts:
       - in build directory
       - in install directory
      650f4ae0
    • Thayumanavar's avatar
      BUG#16402143 - STACK CORRUPTION IN DBUG_EXPLAIN · 514c959b
      Thayumanavar authored
      DESCRIPTION AND FIX:
      DBUG_EXPLAIN result in buffer overflow when the
      DEBUG variable values length exceed 255.
      In _db_explain_ function which call macro str_to_buf
      incorrectly passes the length of buf avaliable to
      strnmov as len+1. The fix calculates the avaliable
      space in buf and passes it to strnxmov.
      514c959b
  16. 09 Apr, 2013 2 commits
  17. 08 Apr, 2013 5 commits
    • Gopal Shankar's avatar
      null merge · 15515e23
      Gopal Shankar authored
      15515e23
    • unknown's avatar
      No commit message · 94963f58
      unknown authored
      No commit message
      94963f58
    • unknown's avatar
      No commit message · 7df62479
      unknown authored
      No commit message
      7df62479
    • unknown's avatar
      No commit message · 33c44419
      unknown authored
      No commit message
      33c44419
    • Raghav Kapoor's avatar
      BUG#15978766 - TEST VALGRIND_REPORT FAILS INNODB TESTS · d6c245de
      Raghav Kapoor authored
      BACKGROUND:
      The testcase i_innodb.innodb_bug14036214 when run under valgrind
      leaks memory.
      
      ANALYSIS:
      In the code path of mysql_update, a temporary file is opened
      using open_cached_file().
      When an error has occured in that code path, this temporary
      file was not closed since call to close_cached_file() was 
      missing.
      This problem exists in 5.5 but it does not exists in 5.6 and 
      trunk. 
      This is because in 5.6 and trunk, when we issue the update
      statement in the test case, it does not take the same code path
      as in 5.5. The code path is different because a different plan 
      is chosen by optimizer. 
      See Bug#14036214 for details.
      However, the problem can still be examined in 5.6 and trunk
      by code inspection.
      
      FIX:
      The file opened by open_cached_file() has been closed by calling
      close_cached_file() when an error occurs so that it does not 
      results in a memory leak.
      d6c245de
  18. 04 Apr, 2013 1 commit