1. 26 Feb, 2007 2 commits
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.1-new-rpl · ec7a703b
      unknown authored
      into  romeo.(none):/home/bk/b25091-mysql-5.1-new-rpl
      
      
      sql/handler.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/table.h:
        Auto merged
      ec7a703b
    • unknown's avatar
      BUG#25091 (A DELETE statement to mysql database is not logged in ROW format): · cdfc516d
      unknown authored
      With this patch, statements that change metadata (in the mysql database)
      is logged as statements, while normal changes (e.g., using INSERT, DELETE,
      and/or UPDATE) is logged according to the format in effect.
      
      The log tables (i.e., general_log and slow_log) are not replicated at all.
      
      With this patch, the following statements are replicated as statements:
      GRANT, REVOKE (ALL), CREATE USER, DROP USER, and RENAME USER.
      
      
      mysql-test/extra/binlog_tests/binlog.test:
        Added test to check that normal INSERT, DELETE, and UPDATE to a table in
        the mysql database is replicated both under row-based and statement-based
        replication.
      mysql-test/r/binlog_row_binlog.result:
        Result change.
      mysql-test/r/binlog_stm_binlog.result:
        Result change.
      sql/handler.cc:
        Removed hardcoded check for mysql database.
        Added table-specific flag for non-replication (used by log tables).
      sql/log.cc:
        Adding flag that a table shall not be replicated and set it for log
        tables.
      sql/sp.cc:
        Turning row-based replication off for statements that change metadata.
      sql/sql_acl.cc:
        Turning row-based replication off for statements that change metadata.
      sql/table.h:
        Adding flag that a table shall not be replicated.
      cdfc516d
  2. 24 Feb, 2007 12 commits
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.1-new-rpl · 56e143c5
      unknown authored
      into  romeo.(none):/home/bk/b26286-mysql-5.1-rpl
      
      
      56e143c5
    • unknown's avatar
      Fixes to make it compile on Windows. · a74cdb23
      unknown authored
      
      sql/log_event.cc:
        The type byte is not equivalent to char on Windows, so compile fails.
      a74cdb23
    • unknown's avatar
      Changes to fix building on Windows. · c13e1694
      unknown authored
      
      include/my_global.h:
        Using Standard C++ header file <new> instead of defining all the versions
        of operator new and operator delete ourself.
      c13e1694
    • unknown's avatar
      rpl_insert_delayed.test: · 072d62c7
      unknown authored
        fix after merge: server now returns ER_DUP_ENTRY_WITH_KEY_NAME, not ER_DUP_ENTRY
      
      
      mysql-test/extra/rpl_tests/rpl_insert_delayed.test:
        fix after merge: server now returns ER_DUP_ENTRY_WITH_KEY_NAME, not ER_DUP_ENTRY
      072d62c7
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.1-new-rpl · 67d0f8cf
      unknown authored
      into  romeo.(none):/home/bk/b26286-mysql-5.1-rpl
      
      
      sql/log_event.cc:
        Auto merged
      67d0f8cf
    • unknown's avatar
      BUG#26286 (row-based logging scales worse than statement-based logging): · 13bee852
      unknown authored
      Submitting patch on Guilhem's behalf (he found the solution).
        
      Correcting a typo that caused very big increases in memory usage when
      more memory needed to be allocated for row-based events. Also correcting
      a border case check when more memory needed to be allocated.
      
      
      sql/log_event.cc:
        Correcting typo that caused very big increases in memory allocation.
        Correcting border case for when more memory should be allocated.
      13bee852
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge · 045ffa8c
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.1-merge
      
      
      sql/field.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      mysql-test/t/disabled.def:
        SCCS merged
      045ffa8c
    • unknown's avatar
      log_on variable needed also in embedded library · f3af1238
      unknown authored
      f3af1238
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/MERGE/mysql-4.1-merge · 849b95ce
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge
      
      
      sql/item_func.cc:
        Auto merged
      849b95ce
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-5.1-new-rpl · 2a86b8ec
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.1-merge
      
      
      client/mysqlbinlog.cc:
        Auto merged
      include/my_global.h:
        Auto merged
      mysql-test/extra/rpl_tests/rpl_insert_id.test:
        Auto merged
      mysql-test/t/show_check.test:
        Auto merged
      mysys/mf_iocache2.c:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item_xmlfunc.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/log_event.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/slave.h:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      mysql-test/t/disabled.def:
        Manual merge
      sql/log.cc:
        Manual merge
      sql/sql_insert.cc:
        Manual merge
      2a86b8ec
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-5.0-rpl · dfb019ea
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge
      
      
      sql/field.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      mysql-test/t/disabled.def:
        Manual merge
      dfb019ea
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-4.1-rpl · 1322c4aa
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-4.1-merge
      
      
      sql/item_func.cc:
        Auto merged
      1322c4aa
  3. 23 Feb, 2007 5 commits
    • unknown's avatar
      Fix for BUG#25628: "mysqlbinlog crashes while processing binary logs". · 6f6951d2
      unknown authored
      mysqlbinlog prints all row-based events of a single statement as a
      single "BINLOG" statement containing the concatenation of those events.
      Big (i.e. >64k) concatenations of row-based events
      (e.g. Write_rows_log_event) caused mysqlbinlog's IO_CACHE to overflow
      to a temporary file but the IO_CACHE had not been inited with
      open_cached_file(), so it tried to create a temporary file in
      an uninitialized directory (thus failing to create, then to write;
      some OS errors were printed, and it finally segfaulted).
      After fixing this, it appeared that mysqlbinlog was printing only
      a piece of big concatenations of row-based events (it printed
      at most the size of the IO_CACHE's buffer i.e. 64k); that caused data
      loss at restore. We fix and test that.
      Last, mysqlbinlog's printouts looked a bit strange with the informative
      header (#-prefixed) of groupped Rows_log_event all on one line,
      so we insert \n. After that, a small bug in the --hexdump code appeared
      (only if the string to hex-print had its length a multiple of 16),
      we fix it.
      
      
      
      client/mysqlbinlog.cc:
        if we write to IO_CACHE more than can fit into its memory buffer,
        it will try to overflow into a file; for that to work, IO_CACHE
        must be inited via open_cached_file().
      mysql-test/r/mysqlbinlog_base64.result:
        result update
      mysql-test/t/mysqlbinlog_base64.test:
        test for BUG#25628: test that mysqlbinlog does not have OS errors
        with big concatenations of row-based events
        (e.g. Write_rows_log_event), and prints those concatenations entirely
        (testing by piping the output back into the server and comparing data).
      mysys/mf_iocache2.c:
        my_b_copy_to_file() had a problem: it assumed that bytes_in_cache
        are all the bytes to copy to the file, while it only tells how many
        bytes are in the buffer; so the code forgot to copy what had already
        overflown into a temporary file. Thus any big event was printed only
        partially by mysqlbinlog (loss of data at restore). The fix is
        inspired by MYSQL_BIN_LOG::write_cache().
      sql/log_event.cc:
        Several Table_map/Write_rows events generated by one single statement
        get groupped together in mysqlbinlog's output; it printed things like
        #718 7:30:51 server id 12 end_log_pos 988      Write_rows: table id 17#718 7:30:51 server id 12 #718 7:30:51 server id 12  end_log_pos 988      Write_rows: table id 17#718 7:30:51 server id 12 end_log_pos 1413 <cut>
        It didn't look nice to have printouts glued like this without line
        breaks. Adding a line break.
        Doing this, when using --hexdump the result was:
        #718 7:30:51 server id 12 end_log_pos 988
        # <hexdump output>
        # Write_rows: table id 17
        which is correct; unfortunately if the hex dump had only full lines
        (i.e the string to print in hex had its length a multiple of 16),
        then the # in front of Write_rows was not printed. Fixed.
      sql/log_event.h:
        removing strcpy() (one less function call).
        If we write to IO_CACHE more than can fit into its memory buffer,
        it will try to overflow into a file; for that to work, IO_CACHE
        must be inited via open_cached_file().
        open_cached_file(), like init_io_cache(), can fail; we make sure to
        catch this constructor's problem via the init_ok() method.
      6f6951d2
    • unknown's avatar
      Merge dl145h.mysql.com:/users/gbichot/mysql-5.0-rpl · 8777e35a
      unknown authored
      into  dl145h.mysql.com:/users/gbichot/mysql-5.1-rpl
      
      
      sql/slave.cc:
        Auto merged
      mysql-test/t/disabled.def:
        merge
      8777e35a
    • unknown's avatar
      BUG#19033 (RBR: slave does not handle schema changes correctly): · f6034619
      unknown authored
      Post-merge fixes.
      
      
      include/my_global.h:
        Post-merge fixes.
        Moving placement versions of operator new and operator delete to general
        server-wide header.
      sql/slave.h:
        Post-merge fixes.
        Moving placement versions of operator new and operator delete to general
        server-wide header.
      storage/ndb/include/ndb_global.h.in:
        Removing local definition of placement versions of
        operator new and operator delete.
      f6034619
    • unknown's avatar
      the fix for BUG#24432 · 8c07265c
      unknown authored
        "INSERT... ON DUPLICATE KEY UPDATE skips auto_increment values"
      didn't make it into 5.0.36 and 5.1.16,
      so we need to adjust the bug-detection-based-on-version-number code.
      Because the rpl tree has a too old version, rpl_insert_id cannot pass,
      so I disable it (like is already the case in 5.1-rpl for the same reason),
      and the repl team will re-enable it when they merge 5.0 and 5.1 into
      their trees (thus getting the right version number).
      
      
      mysql-test/t/disabled.def:
            rpl_insert_id tests statement-based replication of INSERT ON
            DUPLICATE KEY UPDATE. This type of INSERT had BUG#24432, which is
            fixed in 5.0.38; we made the slave detect if it is connected to a
            <5.0.38 master and if so refuse to replicate.
            The problem is that this 5.0-rpl tree, even though it will produce
            the 5.0.38 release, still has a 5.0.36 version in configure.in.
            Thus rpl_insert_id fails. So I disable it. As soon as the 5.0-rpl
            tree gets the changesets from the main 5.0, its version will change
            to 5.0.38 and so the repl team will re-enable the test.
      sql/slave.cc:
        the fix for BUG#24432 didn't make it into 5.0.36 and 5.1.16,
        so we need to adjust the bug-detection-based-on-version-number code.
      8c07265c
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.1-new-rpl · 5f7f3a5b
      unknown authored
      into  romeo.(none):/home/bk/b19033-mysql-5.1-new-rpl
      
      
      sql/log.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/log_event.h:
        Auto merged
      sql/slave.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      5f7f3a5b
  4. 21 Feb, 2007 11 commits
    • unknown's avatar
      Merge trift2.:/MySQL/M51/mysql-5.1 · 61587c18
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      sql/mysqld.cc:
        Auto merged
      61587c18
    • unknown's avatar
      Merge poseidon.mysql.com:/home/tomas/mysql-5.0 · 680ae98b
      unknown authored
      into  poseidon.mysql.com:/home/tomas/mysql-5.1
      
      
      storage/ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbdih/Dbdih.hpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbdih/DbdihInit.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/InitConfigFileParser.cpp:
        Auto merged
      storage/ndb/test/include/NdbRestarter.hpp:
        Auto merged
      storage/ndb/test/ndbapi/testNodeRestart.cpp:
        Auto merged
      storage/ndb/test/run-test/daily-basic-tests.txt:
        Auto merged
      storage/ndb/test/src/NdbRestarter.cpp:
        Auto merged
      680ae98b
    • unknown's avatar
      Merge poseidon.mysql.com:/home/tomas/mysql-5.1-new-ndb · 7e94b4fc
      unknown authored
      into  poseidon.mysql.com:/home/tomas/mysql-5.1
      
      
      7e94b4fc
    • unknown's avatar
      archive_reader.c: · dfaa2564
      unknown authored
        Added include of m_string.h, to find 64 bit mapping of strtoll to strtol
      
      
      storage/archive/archive_reader.c:
        Added include of m_string.h, to find 64 bit mapping of strtoll to strtol
      dfaa2564
    • unknown's avatar
      Merge poseidon.mysql.com:/home/tomas/mysql-5.1-new-ndb · 23f4479d
      unknown authored
      into  poseidon.mysql.com:/home/tomas/mysql-5.1
      
      
      23f4479d
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.1 · 437126a5
      unknown authored
      into  trift2.:/MySQL/M51/merge-5.1
      
      
      configure.in:
        Auto merged
      437126a5
    • unknown's avatar
      Merge trift2.:/MySQL/M50/merge-5.0 · ee351622
      unknown authored
      into  trift2.:/MySQL/M51/merge-5.1
      
      
      include/config-win.h:
        Auto merged
      mysys/my_pthread.c:
        Auto merged
      mysys/my_thr_init.c:
        Auto merged
      mysys/thr_alarm.c:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      support-files/mysql.spec.sh:
        Auto merged
      configure.in:
        Null-merge: 5.0 version number upgrade only, irrelevant for 5.1
      ee351622
    • unknown's avatar
      Merge... · 7c7dbce2
      unknown authored
      Merge mysqldev@production.mysql.com:/data0/mysqldev/my/build-200702202011-5.1.16-beta/mysql-5.1-release
      into  poseidon.mysql.com:/home/tomas/mysql-5.1-new-ndb
      
      
      
      7c7dbce2
    • unknown's avatar
      fix c++ syntac in c file · 51a60123
      unknown authored
      51a60123
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · a0933646
      unknown authored
      into  poseidon.mysql.com:/home/tomas/mysql-5.0-ndb
      
      
      a0933646
    • unknown's avatar
      Bug #26490 duplicate cluster error code · fe89684a
      unknown authored
      - fixed error code
      - added test program run in mysql-test-run bk version
      
      
      mysql-test/ndb/ndbcluster.sh:
        Bug #26490 duplicate cluster error code
        - added check for duplicate error in mysql-test run
      storage/ndb/include/kernel/signaldata/CreateFilegroup.hpp:
        Bug #26490 duplicate cluster error code
        - fixed error code
      storage/ndb/src/ndbapi/Makefile.am:
        Bug #26490 duplicate cluster error code
        - added test program for duplicate error messages
      storage/ndb/src/ndbapi/ndberror.c:
        Bug #26490 duplicate cluster error code
        - fixed error code
      storage/ndb/src/ndbapi/ndberror_check.c:
        New BitKeeper file ``storage/ndb/src/ndbapi/ndberror_check.c''
      fe89684a
  5. 20 Feb, 2007 10 commits