1. 10 Feb, 2004 1 commit
    • unknown's avatar
      after merge & valgrind test fixes (BUG#2120) · ecb11989
      unknown authored
      
      sql/sql_derived.cc:
        memory leack fixed
      sql/sql_lex.cc:
        flag to avoid double cleaning
      sql/sql_lex.h:
        flag to avoid double cleaning
      sql/sql_select.cc:
        right way to cleanup JOIN_TAB
      sql/sql_select.h:
        right way to cleanup JOIN_TAB
      sql/sql_union.cc:
        flag to avoid double cleaning
      ecb11989
  2. 09 Feb, 2004 6 commits
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · d4767576
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-derived2-4.1
      
      
      mysql-test/r/derived.result:
        Auto merged
      mysql-test/t/derived.test:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      d4767576
    • unknown's avatar
      Ensure that result from date_format() is binary · 74b81a80
      unknown authored
      Removed warnings from test suite
      
      
      mysql-test/r/ctype_utf8.result:
        Update results after fix of return argument from date_format()
      mysql-test/r/date_formats.result:
        Remove unnecessary warnings
      mysql-test/r/type_decimal.result:
        Remove unnecessary warnings
      mysql-test/r/warnings.result:
        Remove unnecessary warnings
      mysql-test/t/ctype_utf8.test:
        Fixed test
      mysql-test/t/date_formats.test:
        Remove unnecessary warnings
      mysql-test/t/type_decimal.test:
        Remove unnecessary warnings
      mysql-test/t/warnings.test:
        Remove unnecessary warnings
      sql/field.cc:
        Optimize
      sql/item_timefunc.cc:
        Ensure that result from date_format() is binary
      strings/ctype-simple.c:
        Better names for arguments
      74b81a80
    • unknown's avatar
      ufter revview fix (BUG#2120) · 61f0e69c
      unknown authored
      
      mysql-test/r/derived.result:
        test of error handling in derived tables with UPDATE & DELETE
      mysql-test/t/derived.test:
        test of error handling in derived tables with UPDATE & DELETE
      sql/mysql_priv.h:
        opened tables counter added to avoid loop of tables calculating in lock_tables
      sql/sql_acl.cc:
        opened tables counter added to avoid loop of tables calculating in lock_tables, here it is just for compatibility
      sql/sql_base.cc:
        removed unneeded assignment
        opened tables counter added to avoid loop of tables calculating in lock_tables
        commentary fixed
      sql/sql_derived.cc:
        mysql_derived made static
        variable res moved in place where it used
        priveleges written in correct place
      sql/sql_handler.cc:
        opened tables counter added to avoid loop of tables calculating in lock_tables
      sql/sql_parse.cc:
        mistyping in commentary fixed
      61f0e69c
    • unknown's avatar
      merge · 1c810278
      unknown authored
      1c810278
    • unknown's avatar
      Added --compact to mysqlbinlog · 35b1f544
      unknown authored
      Fixed output from mysqlbinlog when using --skip-comments
      Fixed warnings from valgrind
      Fixed ref_length when used with HEAP tables
      More efficent need_conversion()
      Fixed error handling in UPDATE with not updateable tables
      Fixed bug in null handling in CAST to signed/unsigned
      
      
      
      client/client_priv.h:
        cleanup & added OPT_COMPACT
      client/mysqldump.c:
        Added option --compact to get a compact readable dump.
        Ensure that SET CHARACTER_SET_CLIENT is not done if we have not remembered the old character set
        Print optimization comments even if --skip-comments are given as these are not true comments. (Before these where only printed at end, which was a bug)
      mysql-test/r/cast.result:
        More cast tests
      mysql-test/r/derived.result:
        Removed warnings
      mysql-test/r/mysqldump.result:
        Update results after fixing mysqlbinlog
      mysql-test/r/query_cache.result:
        Make test usable with --extern
        more tests
      mysql-test/r/rpl_until.result:
        Make test repeatable under valgrind
      mysql-test/r/sql_mode.result:
        Fix test result
      mysql-test/r/subselect.result:
        Make test smaller. Update wrong results
      mysql-test/t/cast.test:
        More cast tests
      mysql-test/t/derived.test:
        Removed warnings
      mysql-test/t/query_cache.test:
        Make test usable with --extern
        more tests
      mysql-test/t/rpl_until.test:
        fix for valgrind.  Becasue of unknown reason one got 'Slave_SQL_Running=yes' in this setup
      mysql-test/t/subselect.test:
        Make test case smaller
      sql/field.cc:
        Updated need_conversion() to use new arguments
      sql/ha_heap.cc:
        Moved initialization of ref_length to right place. This fixed problem that we had a ref_length of 8 for heap tables, which was not efficent.
      sql/item_func.cc:
        Cleanup
      sql/item_func.h:
        Fixed bug in null_handling for cast to signed/unsigned
      sql/item_strfunc.cc:
        Optimized/cleaned up Item_func_conv_charset3
      sql/item_sum.cc:
        Cleanup.
        Ensure that some flag variables are cleared in cleanup()
      sql/item_sum.h:
        Fixed references to uninitialized memory
      sql/opt_range.cc:
        Fixed spelling error
      sql/sql_class.cc:
        Fixed wrong return code, which could case protocol problems
      sql/sql_class.h:
        After merge fix
      sql/sql_prepare.cc:
        Added comments
      sql/sql_show.cc:
        Cleanup
      sql/sql_string.cc:
        Optimzed usage of need_conversion().
        - Removed not used argument
        - Save diff lenght in 'offset' to not have to recalculate length several times.
        Cleaned up comment
        Optimized copy_aligned() based on the knowledge that it's only called when you have wrong data
      sql/sql_string.h:
        Updated need_conversion() and copy_aligned() to use new arguments
      sql/sql_update.cc:
        Fixed error handling with non-updateable tables
      sql/sql_yacc.yy:
        Ensure that lex->lock_options are set correctly (to get rid of warnings from valgrind)
        Ensure that cast_type sets lex->charset and lex->length. Without these CONVERT() didn't work properly
      35b1f544
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · 584ddfda
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-derived2-4.1
      
      
      sql/sql_delete.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      584ddfda
  3. 06 Feb, 2004 1 commit
  4. 05 Feb, 2004 5 commits
    • unknown's avatar
      merge · 44289ba6
      unknown authored
      
      mysql-test/r/subselect.result:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/opt_range.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      44289ba6
    • unknown's avatar
      Merge vvagin@bk-internal.mysql.com:/home/bk/mysql-4.1 · e5ab7070
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_2310/mysql-4.1
      
      
      e5ab7070
    • unknown's avatar
      code and comments cleanup · 04675623
      unknown authored
      04675623
    • unknown's avatar
      Added SQL_SELECT::cleanup() to make it easier to reuse SQL_SELECT item's for... · 0db0b601
      unknown authored
      Added SQL_SELECT::cleanup() to make it easier to reuse SQL_SELECT item's for sub selects. Needed for proper fix for bug #2479.
      Added 'select_to_file' class to be able to merge identical code for select_export and select_dump
      
      
      client/mysql.cc:
        Print mysql_insert_id() in 'status'
      mysys/charset.c:
        after merge fixup
      sql/item_func.cc:
        Code cleanup + new comments
      sql/opt_range.cc:
        Added SQL_SELECT::cleanup() to make it easier to reuse SQL_SELECT item's for sub selects.
      sql/opt_range.h:
        Added SQL_SELECT::cleanup() to make it easier to reuse SQL_SELECT item's for sub selects.
      sql/sql_class.cc:
        Added 'select_to_file' class to be able to merge identical code for select_export and select_dump
      sql/sql_class.h:
        Added 'select_to_file' class to be able to merge identical code for select_export and select_dump
      sql/sql_select.cc:
        Fixed bug when calling 'delete select' in sub selects. (Bug 2479)
        (Test case is already commited to global source repository)
      0db0b601
    • unknown's avatar
      Bug#2634 · 7b0ee22d
      unknown authored
        Emit "TYPE=" for 4.0 and 3.23 compatible modes
      
      
      mysql-test/r/mysqldump.result:
        Bug#2634
          New test case
      mysql-test/t/mysqldump.test:
        Bug#2634
          New test case
      7b0ee22d
  5. 04 Feb, 2004 2 commits
  6. 03 Feb, 2004 4 commits
  7. 02 Feb, 2004 8 commits
    • unknown's avatar
      Merge vvagin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 0058d24d
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_2438/mysql-4.1
      
      
      0058d24d
    • unknown's avatar
      Merge eagle.mysql.r18.ru:/home/vva/work/mysql.orig/clear/mysql-4.1 · bfadd733
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_2438/mysql-4.1
      
      
      bfadd733
    • unknown's avatar
      changed allocation of st_table::insert_values · bbdba292
      unknown authored
      from table->mem_root to thd->mem_root 
      (fixed bug #2438 "Runaway memory consumption")
      
      
      bbdba292
    • unknown's avatar
      just tried to find all 'skipp' and replace it with 'skip'. · f1bfba29
      unknown authored
      
      client/sql_string.cc:
        skipp -> skip
      dbug/dbug.c:
        skipp -> skip
      myisam/mi_create.c:
        skipp -> skip
      myisam/mi_dynrec.c:
        skipp -> skip
      myisam/mi_packrec.c:
        skipp -> skip
      myisam/mi_rrnd.c:
        skipp -> skip
      myisam/mi_test1.c:
        skipp -> skip
      myisam/myisampack.c:
        skipp -> skip
      myisam/rt_test.c:
        skipp -> skip
      myisam/sp_test.c:
        skipp -> skip
      mysys/default.c:
        skipp -> skip
      mysys/mf_iocache.c:
        skipp -> skip
      mysys/mf_pack.c:
        skipp -> skip
      mysys/mf_wcomp.c:
        skipp -> skip
      mysys/typelib.c:
        skipp -> skip
      sql/filesort.cc:
        skipp -> skip
      sql/item_strfunc.cc:
        skipp -> skip
      sql/mysqld.cc:
        skipp -> skip
      sql/opt_range.h:
        skipp -> skip
      sql/sql_delete.cc:
        skipp -> skip
      sql/sql_select.cc:
        skipp -> skip
      sql/sql_string.cc:
        skipp -> skip
      sql/sql_update.cc:
        skipp -> skip
      strings/ctype-bin.c:
        skipp -> skip
      strings/ctype-simple.c:
        skipp -> skip
      strings/r_strinstr.c:
        skipp -> skip
      strings/strinstr.c:
        skipp -> skip
      strings/strstr.c:
        skipp -> skip
      f1bfba29
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-4.1 · f85e469e
      unknown authored
      into gw.mysql.r18.ru:/usr/home/ram/work/4.1.b2419
      
      
      sql/opt_range.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      f85e469e
    • unknown's avatar
      Added a comment for NULL range creation. · 8131ccaf
      unknown authored
      8131ccaf
    • unknown's avatar
      Indexes can be used for optimization if the operation · 65534b77
      unknown authored
      collation is the same with the index collation.
      
      
      65534b77
    • unknown's avatar
      preload.result, key_cache.result, preload.test, key_cache.test, sql_yacc.yy: · c91c1470
      unknown authored
        Fixed bug #2602 in CACHE INDEX, LOAD INDEX
      
      
      sql/sql_yacc.yy:
        Fixed bug #2602 in CACHE INDEX, LOAD INDEX
      mysql-test/t/key_cache.test:
        Fixed bug #2602 in CACHE INDEX, LOAD INDEX
      mysql-test/t/preload.test:
        Fixed bug #2602 in CACHE INDEX, LOAD INDEX
      mysql-test/r/key_cache.result:
        Fixed bug #2602 in CACHE INDEX, LOAD INDEX
      mysql-test/r/preload.result:
        Fixed bug #2602 in CACHE INDEX, LOAD INDEX
      c91c1470
  8. 01 Feb, 2004 3 commits
    • unknown's avatar
      make JOIN::prepare, JOIN::optimize only once for EXPLAIN of derived table · 1f739ca4
      unknown authored
      (BUG#2120 sfter merge)
      
      
      mysql-test/r/derived.result:
        correct results of derived tble EXPLAIN
        test of "Using Index" with derived tables
      mysql-test/t/derived.test:
        test of "Using Index" with derived tables
      sql/mysql_priv.h:
        way to force derived table save JOIN after execution
      sql/sql_derived.cc:
        way to force derived table save JOIN after execution
      sql/sql_lex.h:
        way to force derived table save JOIN after execution
      sql/sql_select.cc:
        make JOIN::prepare, JOIN::optimize only once for EXPLAIN of derived table
      1f739ca4
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · 00b2168b
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-derived2-4.1
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      00b2168b
    • unknown's avatar
      now all tables of query are locked in one place (including derived tables) · 68c0a299
      unknown authored
      fixed BUG#2120 and other problem with EXPLAINing derived tables
      
      
      mysql-test/r/derived.result:
        correct tables names & Co in derived tables
        test case for BUG#2120
      mysql-test/t/derived.test:
        test case for BUG#2120
      sql/mysql_priv.h:
        derived tables processing moved after open/locking all tables (in open_and_lock_tables)
      sql/repl_failsafe.cc:
        correct initialization of TABLE_LIST
      sql/sql_acl.cc:
        used simple table opening without derived table processing to avoid unneeded initialization of SELECT_LEX
      sql/sql_base.cc:
        derived tables processing moved after open/locking all tables (in open_and_lock_tables)
      sql/sql_delete.cc:
        all tables processing is done during opening
      sql/sql_derived.cc:
        derived tables processing moved after open/locking all tables (in open_and_lock_tables) to sutisfy "all query tables locking" at the moment
      sql/sql_insert.cc:
        all tables processing is done during opening
        correct initialization of TABLE_LIST
      sql/sql_lex.cc:
        now table list will be created for whole query
        layout fix
        correct check of updated table in subqueries
      sql/sql_lex.h:
        now table list will be created for whole query
        correct check of updated table in subqueries
      sql/sql_olap.cc:
        THIS FUNCTION IS USED NOWHERE
        it will be good to remove it at all (handle_olaps)
      sql/sql_parse.cc:
        derived tables processing moved after open/locking all tables (in open_and_lock_tables)
      sql/sql_prepare.cc:
        new creating list parameters
        all tables processing is done during opening
      sql/sql_select.cc:
        all tables processing is done during opening
      sql/sql_select.h:
        now it used only within file where is defined
      sql/sql_udf.cc:
        used simple table opening without derived table processing to avoid unneeded initialization of SELECT_LEX
      sql/sql_update.cc:
        all tables processing is done during opening
      68c0a299
  9. 31 Jan, 2004 1 commit
    • unknown's avatar
      fix for the bug #2419: order by ignores rows. · abc17f8f
      unknown authored
      null_ref_key moved to TABLE_REF.
      new null range created if necessary.
      
      
      mysql-test/r/order_by.result:
        fix for the bug #2419: order by ignores rows
      mysql-test/t/order_by.test:
        fix for the bug #2419: order by ignores rows
      sql/item_subselect.cc:
        fix for the bug #2419: order by ignores rows
      sql/opt_range.cc:
        fix for the bug #2419: order by ignores rows
      sql/sql_select.cc:
        fix for the bug #2419: order by ignores rows
      sql/sql_select.h:
        fix for the bug #2419: order by ignores rows
      abc17f8f
  10. 30 Jan, 2004 5 commits
  11. 29 Jan, 2004 2 commits
  12. 28 Jan, 2004 2 commits
    • unknown's avatar
      Fixed Bug#2479, "dependant subquery with limit crash". · 735eab8a
      unknown authored
      The problem was that memory was free'd, but it was referenced
      later. This free was unneccessary anyway, because join_free() /
      JOIN::cleanup takes care of this later on.
      
      Added test case into t/subselect.test for it.
      
      Regards,
      Jani
      
      
      mysql-test/r/subselect.result:
        Added a test case for Bug#2479.
      mysql-test/t/subselect.test:
        Added a test case for Bug#2479.
      sql/sql_select.cc:
        Fixed Bug#2479, "dependant subquery with limit crash".
        The problem was that memory was free'd, but it was referenced
        later. This free was unneccessary anyway, because join_free() /
        JOIN::cleanup takes care of this later on.
      735eab8a
    • unknown's avatar