1. 28 Jun, 2007 1 commit
    • unknown's avatar
      Bug #29157: UPDATE, changed rows incorrect · ecc52aeb
      unknown authored
      Sometimes the number of really updated rows (with changed
      column values) cannot be determined at the server level
      alone (e.g. if the storage engine does not return enough
      column values to verify that). So the only dependable way
      in such cases is to let the storage engine return that
      information if possible.
      Fixed the bug at server level by providing a way for the 
      storage engine to return information about wether it 
      actually updated the row or the old and the new column 
      values are the same. It can do that by returning 
      HA_ERR_RECORD_IS_THE_SAME in ha_update_row().
      Note that each storage engine may choose not to try to
      return this status code, so this behaviour remains 
      storage engine specific.
      
      
      include/my_base.h:
        Bug #29157: handle the row not updated special return value
      sql/log_event.cc:
        Bug #29157: handle the row not updated special return value
      sql/sp.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_acl.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_insert.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_servers.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_update.cc:
        Bug #29157: handle the row not updated special return value
      ecc52aeb
  2. 27 Jun, 2007 3 commits
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · c8e93715
      unknown authored
      into  mysql.com:/home/hf/work/29156/my51-29156
      
      c8e93715
    • unknown's avatar
      Bug #29156 events crash server in test suite · 208b9e2c
      unknown authored
      don't free thd->lex->sphead if we didn't do lex_start(),
      as we can have garbage there
      
      
      mysql-test/r/events_bugs.result:
        Bug #29156 events crash server in test suite
        
        test result added
      mysql-test/t/events_bugs.test:
        Bug #29156 events crash server in test suite
        
        testcase
      208b9e2c
    • unknown's avatar
      rpl_partition.test fixed · 2c958640
      unknown authored
      
      mysql-test/r/rpl_partition.result:
        result fixed
      mysql-test/t/rpl_partition.test:
        machine-depending lines hidden in result
      2c958640
  3. 26 Jun, 2007 3 commits
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · d2de5a0d
      unknown authored
      into  mysql.com:/home/hf/work/28430/my51-28430
      
      d2de5a0d
    • unknown's avatar
      Bug #28430 Failure in replication of innodb partitioned tables on row/mixed format. · 04a8a48d
      unknown authored
      In the ha_partition::position we don't calculate the number of
      the partition of the record. We use m_last_part_value instead relying on
      that it is set in other place like previous calls of ::write_row().
      In replication we do neither of these calls before ::position().
      Delete_row_log_event::do_exec_row calls find_and_fetch_row() where
      we used position() & rnd_pos() calls to find the record for the
      PARTITION/INNODB table as it posesses InnoDB table flags.
      Fixed by removing HA_PRIMARY_KEY_REQUIRED_FOR_POSITION flag from PARTITION
      
      
      sql/ha_partition.cc:
        Bug #28430 Failure in replication of innodb partitioned tables on row/mixed format.
        
        add HA_PRIMARY_KEY_REQUIRED_FOR_POSITION flag added to PRTITION engine
      mysql-test/r/rpl_partition.result:
        New BitKeeper file ``mysql-test/r/rpl_partition.result''
      mysql-test/t/rpl_partition.test:
        New BitKeeper file ``mysql-test/t/rpl_partition.test''
      04a8a48d
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 16f96430
      unknown authored
      into  dl145s.mysql.com:/dev/shm/mhansson/my51-bug28677
      
      16f96430
  4. 25 Jun, 2007 12 commits
  5. 24 Jun, 2007 4 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.1 · 9548afda
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      sql/item.h:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_trigger.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      mysql-test/r/rpl_change_master.result:
        Merge with 5.1.
      mysql-test/t/rpl_change_master.test:
        Merge with 5.1.
      sql/sql_acl.cc:
        Merge with 5.1.
      9548afda
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 683a1119
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug25602
      
      
      sql/sql_select.cc:
        Auto merged
      683a1119
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0 · 98646c96
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      sql/log_event.cc:
        Auto merged
      98646c96
    • unknown's avatar
      Fixed bug #25602. A query with DISTINCT in the select list to which · 09e2b603
      unknown authored
      the loose scan optimization for grouping queries was applied returned 
      a wrong result set when the query was used with the SQL_BIG_RESULT
      option.
      
      The SQL_BIG_RESULT option forces to use sorting algorithm for grouping
      queries instead of employing a suitable index. The current loose scan
      optimization is applied only for one table queries when the suitable
      index is covering. It does not make sense to use sort algorithm in this
      case. However the create_sort_index function does not take into account
      the possible choice of the loose scan to implement the DISTINCT operator
      which makes sorting unnecessary. Moreover the current implementation of
      the loose scan for queries with distinct assumes that sorting will
      never happen. Thus in this case create_sort_index should not call
      the function filesort.
      
      
      mysql-test/r/group_min_max.result:
        Added a test case for bug #25602.
      mysql-test/t/group_min_max.test:
        Added a test case for bug #25602.
      09e2b603
  6. 23 Jun, 2007 5 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 3fb40cd8
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      3fb40cd8
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1-opt · 6688a54f
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      6688a54f
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · ddf53f6e
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      libmysql/libmysql.c:
        Merge with 5.0-opt.
      mysql-test/r/insert_select.result:
        Merge with 5.0-opt.
      mysql-test/r/mysqlbinlog.result:
        Merge with 5.0-opt.
      mysql-test/r/rpl_change_master.result:
        Merge with 5.0-opt.
      mysql-test/r/view.result:
        Merge with 5.0-opt.
      mysql-test/t/insert_select.test:
        Merge with 5.0-opt.
      mysql-test/t/mysqlbinlog.test:
        Merge with 5.0-opt.
      mysql-test/t/rpl_change_master.test:
        Merge with 5.0-opt.
      mysql-test/t/view.test:
        Merge with 5.0-opt.
      sql/item.cc:
        Merge with 5.0-opt.
      sql/item.h:
        Merge with 5.0-opt.
      sql/log_event.cc:
        Merge with 5.0-opt.
      sql/sql_select.cc:
        Merge with 5.0-opt.
      ddf53f6e
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29095 · e45576ac
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      e45576ac
    • unknown's avatar
      Fixed bug #29095. · e7778b65
      unknown authored
      INSERT into table from SELECT from the same table
      with ORDER BY and LIMIT was inserting other data
      than sole SELECT ... ORDER BY ... LIMIT returns.
      
      One part of the patch for bug #9676 improperly pushed
      LIMIT to temporary table in the presence of the ORDER BY
      clause.
      That part has been removed.
      
      
      sql/sql_select.cc:
        Fixed bug #29095.
        One part of the patch for bug #9676 improperly pushed
        LIMIT to temporary table in the presence of the ORDER BY
        clause.
        That part has been removed.
      mysql-test/t/insert_select.test:
        Expanded the test case for bug #9676.
        Created a test case for bug #29095.
      mysql-test/r/insert_select.result:
        Expanded the test case for bug #9676.
        Created a test case for bug #29095.
      e7778b65
  7. 22 Jun, 2007 12 commits