1. 16 May, 2007 2 commits
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG25712/mysql-4.1-engines · ece8497b
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG25712/mysql-5.0-engines
      
      
      myisam/mi_check.c:
        Auto merged
      mysys/my_seek.c:
        Manual merge.
      ece8497b
    • unknown's avatar
      BUG#25712 - insert delayed and check table run together report crashed · fe7b572a
      unknown authored
                  tables
      
      In case system doesn't have native pread/pwrite calls (e.g. Windows)
      and there is CHECK TABLE runs concurrently with another statement that
      reads from a table, the table may be reported as crashed.
      
      This is fixed by locking file descriptor when my_seek is executed on
      MyISAM index file and emulated pread/pwrite may be executed concurrently.
      
      Affects MyISAM tables on platforms that do not have native
      pread/pwrite calls (e.g. Windows).
      
      No deterministic test case for this bug.
      
      
      myisam/mi_check.c:
        Key file descriptor is shared among threads and mixed set of
        my_pread/my_pwrite and my_seek calls is possible. This is not
        a problem on systems that have native pread/pwrite calls.
        
        In case system doesn't have native pread/pwrite calls (e.g. Windows)
        we must ensure that my_pread/my_pwrite are not executed at the same
        time with my_seek. This is done by passing MY_THREADSAFE flag to
        my_seek.
      mysys/my_seek.c:
        On platforms that do not have native pread/pwrite calls (e.g. Windows)
        these calls are emulated as follow: lock fd, lseek, read, unlock fd.
        
        In case file descriptor is shared among threads, where one thread
        executes my_pread and another thread executes my_seek, we may read
        from a wrong position. This may happen because my_seek doesn't lock
        fd and thus may be executed by another thread after emulated pread
        has done lseek and before it has done read.
        
        To fix problem mentioned above we introduce new flag MY_THREADSAFE to
        my_seek, which is meaningful only in case pread/pwrite calls are
        emulated. If this flag is set, lseek operation is performed as follow:
        lock fd, seek, unlock fd.
      fe7b572a
  2. 10 May, 2007 1 commit
  3. 28 Apr, 2007 1 commit
    • unknown's avatar
      BUG#27998 - mysqld crashed when executing INSERT DELAYED · c20b0ff5
      unknown authored
                  on a BLACKHOLE table
      
      Using INSERT DELAYED on BLACKHOLE tables could lead to server
      crash.
      
      This happens because delayed thread wants to upgrade a lock,
      but BLACKHOLE tables do not have locks at all.
      
      This patch rejects attempts to use INSERT DELAYED on MERGE
      tables.
      
      
      mysql-test/r/blackhole.result:
        A test case for BUG#27998.
      mysql-test/t/blackhole.test:
        A test case for BUG#27998.
      sql/ha_blackhole.h:
        Removed HA_CAN_INSERT_DELAYED flag from table_flags().
        The insert delayed thread upgrades the lock. Hence it is
        incapable to handle BLACKHOLE tables, which do not have
        locks at all.
      c20b0ff5
  4. 26 Apr, 2007 7 commits
  5. 25 Apr, 2007 2 commits
  6. 24 Apr, 2007 15 commits
  7. 23 Apr, 2007 12 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 44ad1937
      unknown authored
      into  recycle.(none):/src/bug24732/my50-bug24732
      
      44ad1937
    • unknown's avatar
      Bug#24732 Executables do not include Vista manifests · 1ceb29e1
      unknown authored
      - Added script to generate application specific manifest.
      - Added new CMake MACRO to add customer build events which will first
      generate a manifest and then embeds that manifest into an executable.
      
      
      BitKeeper/etc/ignore:
        Bug#24732 Executables do not include Vista manifests
        - Revise ignore rules to disallow auto-generated cmake files but to allow
        custom macros defined in a .cmake file.
      CMakeLists.txt:
        Bug#24732 Executables do not include Vista manifests
        - Added logic for EMBED_MANIFESTS configuration option.
      client/CMakeLists.txt:
        Bug#24732 Executables do not include Vista manifests
        - Embed manifest with custom CMake MACRO for client executables.
      extra/CMakeLists.txt:
        Bug#24732 Executables do not include Vista manifests
        - Embed manifest with custom CMake MACRO for my_print_default executable.
      libmysql/CMakeLists.txt:
        Bug#24732 Executables do not include Vista manifests
        - Embed manifest with custom CMake MACRO for myTest executable.
      myisam/CMakeLists.txt:
        Bug#24732 Executables do not include Vista manifests
        - Embed manifest with custom CMake MACRO for myisam executables.
      server-tools/instance-manager/CMakeLists.txt:
        Bug#24732 Executables do not include Vista manifests
        - Embed manifest with custom CMake MACRO for mysqlmanager executable.
      sql/CMakeLists.txt:
        Bug#24732 Executables do not include Vista manifests
        - Embed manifest with custom CMake MACRO for mysqld executable.
      win/README:
        Bug#24732 Executables do not include Vista manifests
        - Added new configuration option documentation.
      win/configure.js:
        Bug#24732 Executables do not include Vista manifests
        - Added new EMBED_MANIFESTS configuration option.
      win/create_manifest.js:
        Bug#24732 Executables do not include Vista manifests
        - Manifest generator.  This script generates a basic manifest.
      win/mysql_manifest.cmake:
        Bug#24732 Executables do not include Vista manifests
        - Define new CMake MACRO for adding Windows manifests to executables.
      1ceb29e1
    • unknown's avatar
      Merge quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/41 · 2b4d20e9
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/41
      
      2b4d20e9
    • unknown's avatar
      mysql_upgrade.test: · 656003c2
      unknown authored
        Fix minor merge "oopsie"
      
      
      mysql-test/t/mysql_upgrade.test:
        Fix minor merge "oopsie"
      656003c2
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 0cf6d704
      unknown authored
      into  recycle.(none):/src/bug25621/my50-bug25621
      
      
      sql/mysqld.cc:
        Auto merged
      0cf6d704
    • unknown's avatar
      Bug#25621 Error in my_thread_global_end(): 1 threads didn't exit · 535a21f3
      unknown authored
      - On Windows, connection handlers while exiting properly did not 
      decrement the server's thread count.
      
      
      sql/mysqld.cc:
        Bug#25621 Error in my_thread_global_end(): 1 threads didn't exit
        - Make sure that connection handlers decrement number of threads
        and handlers on Windows.
        - Signal condition variable before unlocking mutex.
      535a21f3
    • unknown's avatar
      Merge debian.(none):/M41/push-4.1 · 652bc2b9
      unknown authored
      into  debian.(none):/M50/push-5.0
      
      652bc2b9
    • unknown's avatar
      Merge debian.(none):/M50/bug14685-5.0 · 43bc19cc
      unknown authored
      into  debian.(none):/M50/push-5.0
      
      43bc19cc
    • unknown's avatar
      Don't copy any subdirs in scripts/ · ac1f630b
      unknown authored
      ac1f630b
    • unknown's avatar
      Merge pilot.blaudden:/home/msvensson/mysql/mysql-5.0 · e391dafd
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
      
      
      client/mysql.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      e391dafd
    • unknown's avatar
      Add "name of struct" as first arg to comp_sql · d8ba5b09
      unknown authored
      Fix "make distcheck"
      
      
      scripts/CMakeLists.txt:
        Add "name of struct" as first arg to comp_sql
      scripts/comp_sql.c:
        Add "name of struct" as first arg to comp_sql
      d8ba5b09
    • unknown's avatar
      dbug/dbug_analyze.c : Avoid the unresolved symbol "my_thread_global_init()" · df057770
      unknown authored
                              in a build "--without-server".
      
      Fix for bug#14685
      
      
      dbug/dbug_analyze.c:
        In a build "--without-server", the libraries will be built without threading.
        In this case, "my_thread_global_init()" is missing in the libraries, and the 
        linker will report an unresolved symbol.
        
        Avoid this error by making the call to "my_thread_global_init()" depend on 
        "#ifdef THREAD".
        
        Fix for bug#14685
      df057770