1. 04 Dec, 2013 2 commits
    • Jan Lindström's avatar
      MDEV-443: Galera: Server crashes on flushing tables for SST if started with... · ed26f701
      Jan Lindström authored
      MDEV-443: Galera: Server crashes on flushing tables for SST if started with character_set_server utf16 or utf32 or ucs2, and with wsrep_sst_method=rsync
      
      Analysis: In SST Galera directly calls parser using current client character
      set. Similarly in BF Galera uses client character set to apply. However,
      there are character sets that are not currently supported by the parser.
      
      Fix: If currenct client character set is one of those that is not supported
      by the parser, temporally set character set to latin1 before we enter
      parser and restore it after we have parsed.
      
      ed26f701
    • Jan Lindström's avatar
      Fixed additional problem with kernel_mutex. Kernel mutex is also · eea69c57
      Jan Lindström authored
      held on lock_rec_other_has_conflicting that will also call (eventually)
      wsrep_innobase_kill_one_trx. Added a new parameter have_kernel_mutex
      to mark do we already own kernel mutex or not.
      eea69c57
  2. 02 Dec, 2013 1 commit
  3. 30 Nov, 2013 1 commit
    • Nirbhay Choubey's avatar
      MDEV#4138: Galera: mysqld_safe doesn't pass on wsrep_provider to mysqld · 730466b3
      Nirbhay Choubey authored
      In mysqld_safe script, during the processing of command line
      options, the supplied wsrep_provider option was not getting
      appended to the set of mysqld options. Hence, wsrep plugin
      would never receive the path for wsrep provider.
      
      Fixed by adding logic to append the wsrep_provider option
      to the set of mysqld options.
      730466b3
  4. 29 Nov, 2013 3 commits
    • Nirbhay Choubey's avatar
      MDEV#4109: Galera: Valgrind warnings "blocks are still · e4f5e49c
      Nirbhay Choubey authored
                 reachable" in wsrep_init_startup on MTR tests
      
      The initialization & de-initialization of wsrep plugin is solely
      controlled by wsrep_on system variable. Now, as wsrep_on is ON by
      default, the plugin gets initialized during server start. However,
      there would be a leakage in case wsrep_on is turned off before plugin's
      deinitialization (while server is shutting down) takes place, in which
      case the deinit routine will not be invoked.
      
      In this particular case, wsrep_on is turned off as no wsrep provider
      has been specified & thus the valgrind warnings.
      
      Fixed by introducing a flag which tracks and now controls the
      (de|)initialization of the wsrep plugin instead on wsrep_on.
      Added necessary asserts.
      
      main.connect                             [ pass ]  16534
      valgrind_report                          [ pass ]
      e4f5e49c
    • Nirbhay Choubey's avatar
      MDEV-4222: Assertion `( ((global_system_variables.wsrep_on) && · 6271c06a
      Nirbhay Choubey authored
        (thd && thd->variables.wsrep_on)) && wsrep_emulate_bin_log) ||
        mysql_bin_log .is_open()' fails on SAVEPOINT with disabled
        wsrep_provider
      
      As wsrep_on system variable is ON by default the binlog handlerton
      is implicitly enabled during the server initialization phase. Later,
      while wsrep plugin is getting initialized, wsrep_on in corrected &
      turned OFF in case wsrep provider is not specified (leaving binlog
      in ON state!). This leads to the reported assertion.
      
      Fixed by adding another check for wsrep provider before binlog
      is enabled.
      
      Added a test case.
      6271c06a
    • Jan Lindström's avatar
      MDEV-4235: Galera: Assertion `0' fails in tdc_remove_table on creating a trigger · 62bd131d
      Jan Lindström authored
      Analysis: There is two different THD's using the same table.
      
      Fix: In galera brute force (BF) exclusive locks are cancelled. Thus other threads
      could access the same table. Added additional check if this is the case, then we
      should not assert here.
      62bd131d
  5. 27 Nov, 2013 1 commit
  6. 26 Nov, 2013 1 commit
  7. 25 Nov, 2013 4 commits
    • Nirbhay Choubey's avatar
      MDEV-4108 Compilation warnings with RelWithDebInfo · 88f0e0eb
      Nirbhay Choubey authored
      only present in the Galera tree
      
      Fix for some compiler warnings.
      88f0e0eb
    • Jan Lindström's avatar
      Merge with MariaDB 5.5.34. · 071edcfe
      Jan Lindström authored
      071edcfe
    • Jan Lindström's avatar
      Merged revisions 3931--3942 from from lp:~codership/codership-mysql/5.5-23. · 4f85baab
      Jan Lindström authored
      ```---------------------------------------------------------
      revno: 3942
      committer: Seppo Jaakola <seppo.jaakola@codership.com>
      branch nick: wsrep-5.5-23
      timestamp: Thu 2013-11-07 17:37:10 +0200
      message:
        References: lp:1248921 - checking if index is foreign earlier to adhere to lat
      ch order protocol
      ```
      
      ---------------------------------------------------------
      revno: 3941
      fixes bug: https://launchpad.net/bugs/1248908
      committer: Teemu Ollakka <teemu.ollakka@codership.com>
      branch nick: 5.5-23
      timestamp: Thu 2013-11-07 14:31:04 +0200
      message:
        References lp:1248908 - Fixed access to trx sys header
          
        Pass trx sys header as argument for trx_sys_update_wsrep_checkpoint()
        and trx_sys_update_mysql_binlog_offset() to avoid successive calls
        to trx_sysf_get().
      ------------------------------------------------------------
      revno: 3940
      fixes bug: https://launchpad.net/bugs/1244100
      committer: Teemu Ollakka <teemu.ollakka@codership.com>
      branch nick: 5.5-23
      timestamp: Tue 2013-11-05 15:31:12 +0200
      message:
        References lp:1244100 - assign value for check_purge before return
      ------------------------------------------------------------
      revno: 3939
      fixes bug: https://launchpad.net/bugs/1247978
      committer: Teemu Ollakka <teemu.ollakka@codership.com>
      branch nick: 5.5-23
      timestamp: Tue 2013-11-05 01:01:36 +0200
      message:
        References lp:1247978 - force release transactional MDL locks if wsrep is on a
      nd no active transaction at the end of mysql_execute_command()
      ------------------------------------------------------------
      revno: 3938
      committer: Vladislav Klyachin <vladislav.klyachin@codership.com>
      branch nick: 5.5-23
      timestamp: Sun 2013-11-03 20:48:06 +0400
      message:
        References lp:1232789 - fix FLUSH STATUS zeroes up wsrep_cluster_size and wsre
      p_local_index
      ------------------------------------------------------------
      revno: 3937  5kB/s - 
      committer: Vladislav Klyachin <vladislav.klyachin@codership.com>
      branch nick: 5.5-23
      timestamp: Sun 2013-11-03 17:06:31 +0400
      message:
        References lp:587170 - reset auto_increment_* vars to defaults for TOI operati
      ons
      ------------------------------------------------------------
      revno: 3936
      committer: Vladislav Klyachin <vladislav.klyachin@codership.com>
      branch nick: 5.5-23
      timestamp: Sun 2013-11-03 00:10:45 +0400
      message:
        References lp:1072839 - fix for memory leaks with wsrep variables
      ------------------------------------------------------------
      revno: 3935
      committer: Seppo Jaakola <seppo.jaakola@codership.com>
      branch nick: wsrep-5.5-23
      timestamp: Wed 2013-10-30 14:34:32 +0200
      message:
        References: lp:1246257 - skipping replication for CREATE TEMPORARY TABLE LIKE.
      ..  constructs
      ------------------------------------------------------------
      revno: 3934  6kB/s \ 
      fixes bug: https://launchpad.net/bugs/1241760
      committer: Teemu Ollakka <teemu.ollakka@codership.com>
      branch nick: 5.5-23
      timestamp: Mon 2013-10-28 11:01:53 +0200
      message:
        References lp:1241760 - save thd->db to wsrep_thd_shadow before replay
      ------------------------------------------------------------
      revno: 3933
      fixes bug: https://launchpad.net/bugs/1206129
      committer: Teemu Ollakka <teemu.ollakka@codership.com>
      branch nick: 5.5-23
      timestamp: Sun 2013-10-27 18:15:12 +0200
      message:
        References lp:1206129 - check binlog_hton->commit() return value, call wsrep_p
      ost_commit() instead of wsrep_cleanup_transaction()
      ------------------------------------------------------------
      revno: 3932
      fixes bug: https://launchpad.net/bugs/1244661
      committer: Teemu Ollakka <teemu.ollakka@codership.com>
      branch nick: 5.5-23
      timestamp: Sun 2013-10-27 13:14:02 +0200
      message:
        References lp:1244661 - added wsrep_register_hton() to trans_rollback_implicit
      ()
      ------------------------------------------------------------
      revno: 3931
      fixes bug: https://launchpad.net/bugs/1244667
      committer: Teemu Ollakka <teemu.ollakka@codership.com>
      branch nick: 5.5-23
      timestamp: Sun 2013-10-27 11:08:49 +0200
      message:
        References lp:1244667 - restore thd->server_status after replay
      4f85baab
    • Jan Lindström's avatar
      Merged revisions 2925--3929 from from lp:~codership/codership-mysql/5.5-23 · 0e248e62
      Jan Lindström authored
      ```---------------------------------------------------------
      revno: 3929 [merge]
      fixes bug: https://launchpad.net/bugs/1243150
      committer: Teemu Ollakka <teemu.ollakka@codership.com>
      branch nick: 5.5-23
      timestamp: Wed 2013-10-23 20:05:01 +0300
      message:     8kB/s - 
        References lp:1243150 - initial wsrep hton cleanups
        
        * Removed wsrep_seqno_changed boolean
        * wsrep_cleanup_transaction() is now called explicitly whenever it is
          clear that transaction has come to an end
        * wsrep_trans_cache_is_empty() now checks from cache_mngr recardless of
          command type
        * Separated call to wsrep->post_commit() to own function, called from
          transaction.cc whenever appropriate
        * wsrep_thd_is_brute_force() now investigates only thd->wsrep_exec_mode
        * More comments and debug time assertions
        * Debug code to check that wsrep position stored in InnoDB is
          monotinically increasing. Enabled with UNIV_DEBUG
      ```
      
      ---------------------------------------------------------
      revno: 3928
      fixes bug: https://launchpad.net/bugs/1237889
      committer: Teemu Ollakka <teemu.ollakka@codership.com>
      branch nick: 5.5-23
      timestamp: Tue 2013-10-22 22:01:20 +0300
      message:
        References lp:1237889 - reverting fix in r3926, it broke crash recovery
      ------------------------------------------------------------
      revno: 3927
      fixes bug: https://launchpad.net/bugs/1240040
      committer: Teemu Ollakka <teemu.ollakka@codership.com>
      branch nick: 5.5-23
      timestamp: Tue 2013-10-15 14:46:15 +0300
      message:
        References lp:1240040 - added WSREP_MYSQL_DB as a key for DROP VIEW
      ------------------------------------------------------------
      revno: 3926
      fixes bug: https://launchpad.net/bugs/1237889
      committer: Teemu Ollakka <teemu.ollakka@codership.com>
      branch nick: 5.5-23
      timestamp: Thu 2013-10-10 14:22:58 +0300
      message:
        References lp:1237889 - register wsrep hton only if thd->wsrep_exec_mode == LO
      CAL_STATE
      ------------------------------------------------------------
      revno: 3925
      fixes bug: https://launchpad.net/bugs/1235635
      committer: Alexey Yurchenko <alexey.yurchenko@codership.com>
      branch nick: 5.5-23
      timestamp: Sat 2013-10-05 18:03:06 +0300
      message:
        References lp:1235635 - fixed the warning by initializing c_lock to NULL.
      0e248e62
  8. 22 Nov, 2013 1 commit
    • Nirbhay Choubey's avatar
      MDEV-3895 Version naming for MariaDB-Galera builds · eb29ce25
      Nirbhay Choubey authored
      This patch fixes both the reported issues :
      (1) Included '-wsrep' to the server version information.
      
      > select @@version;
      +-----------------------------+
      | @@version                   |
      +-----------------------------+
      | 5.5.33a-MariaDB-wsrep-debug |
      +-----------------------------+
      
      (2) The @@version_comment would no longer have XXXX
      in the wsrep version information in case cmake couldn't
      determine the current bzr revision.
      eb29ce25
  9. 18 Nov, 2013 1 commit
    • Sergey Vojtovich's avatar
      MDEV-5182 - build of 10.0.4/r3863 fails @ 'cmake' with · 160236f8
      Sergey Vojtovich authored
                  -DINSTALL_SYSCONFDIR/-DDEFAULT_SYSCONFDIR specified
      
      The reason for a bug is in support-files/CMakeLists.txt that tries to
      install files in INSTALL_SYSCONF2DIR, without checking whether this
      variable is actually defined. 
      
      Normally INSTALL_SYSCONF2DIR is always defined if INSTALL_SYSCONFDIR is
      defined, and support-files/CMakeLists.txt assumes that. But when one
      specifies INSTALL_SYSCONFDIR manually on the command line, this
      assumption might be broken.
      160236f8
  10. 20 Nov, 2013 1 commit
  11. 19 Nov, 2013 6 commits
  12. 15 Nov, 2013 3 commits
  13. 14 Nov, 2013 8 commits
  14. 13 Nov, 2013 7 commits