1. 28 Feb, 2005 3 commits
    • unknown's avatar
      Merge mysql.com:/home/timka/mysql/src/5.0-virgin · ed3b4499
      unknown authored
      into mysql.com:/home/timka/mysql/src/5.0-bug-8532
      
      
      ed3b4499
    • unknown's avatar
      Fix for BUG#8532. · 7a703d6a
      unknown authored
      The problem was in that the code that analyses the applicability of the
      QUICK_GROUP_MIN_MAX access method for DISTINC queries assumed that there
      are no duplicate column references in the DISTINCT clause, and it added
      non-exiting key parts for the duplicate column references. 
      
      The solution adds a test to check whether the select list already contained
      a field with the same name. If such field was already present, then it was
      already decided to use its key part for index access. In this such case we
      must skip the duplicate field instead of counting it as a new field.
      
      
      mysql-test/r/group_min_max.result:
        Added test results for BUG#8532.
      mysql-test/t/group_min_max.test:
        Added tests for BUG#8532.
      sql/opt_range.cc:
        The problem was in that the code that analyses the applicability of the
        QUICK_GROUP_MIN_MAX access method for DISTINC queries assumed that there
        are no duplicate column references in the DISTINCT clause, and it added
        non-exiting key parts for the duplicate column references. 
        
        The solution adds a test to check whether the select list already contained
        a field with the same name. If such field was already present, then it was
        already decided to use its key part for index access. In this such case we
        must skip the duplicate field instead of counting it as a new field.
      7a703d6a
    • unknown's avatar
      Fixed small error in comment · 03a5cacc
      unknown authored
      03a5cacc
  2. 27 Feb, 2005 3 commits
  3. 26 Feb, 2005 6 commits
    • unknown's avatar
      Merge pnousiainen@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · 85b82a8a
      unknown authored
      into mysql.com:/space/pekka/ndb/version/my50-ndb
      
      
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Auto merged
      85b82a8a
    • unknown's avatar
      NdbDictionaryImpl.cpp: · 1f9a2667
      unknown authored
        fix error code
      
      
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        fix error code
      1f9a2667
    • unknown's avatar
      ndb - wl-1203 alignment fix · 477205f7
      unknown authored
      
      ndb/include/ndb_constants.h:
        consistent names
      ndb/include/ndbapi/NdbDictionary.hpp:
        consistent names
      ndb/include/util/NdbSqlUtil.hpp:
        consistent names
      ndb/src/common/util/NdbSqlUtil.cpp:
        minor completion
      ndb/src/ndbapi/NdbOperationInt.cpp:
        alignment fix
      477205f7
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.0 · 7cc7a628
      unknown authored
      into mysql.com:/usr/local/home/marty/MySQL/test/mysql-5.0-ndb
      
      
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      7cc7a628
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 8167f5e5
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      
      8167f5e5
    • unknown's avatar
      Fixes while during review of last pull · 25e03cdf
      unknown authored
      Temporary patch to remove some warnings
      
      
      sql/item.cc:
        Trivial optimization
      sql/protocol.cc:
        Fixed spelling error
      sql/sql_parse.cc:
        Fix to not get warnings during inital temp open (should be deleted after Dimitri's next push)
        Style fixes
      sql/table.cc:
        Ensure that cleanup is done, even if we get an error
      25e03cdf
  4. 25 Feb, 2005 21 commits
    • unknown's avatar
      trx0trx.c, trx0trx.h: · 2ab324db
      unknown authored
        Fix wrong spelling
      
      
      innobase/include/trx0trx.h:
        Fix wrong spelling
      innobase/trx/trx0trx.c:
        Fix wrong spelling
      2ab324db
    • unknown's avatar
      trx0undo.h, trx0undo.c, trx0trx.c, trx0roll.c: · a6e56b05
      unknown authored
        Make InnoDB-5.0.3 to process log records of 4.1 undo log header create and reuse just like in 4.1; storing XID to the start of the undo log is a separately logged operation; this conforms to Rule 3 of InnoDB redo logging
      
      
      innobase/trx/trx0roll.c:
        Make InnoDB-5.0.3 to process log records of 4.1 undo log header create and reuse just like in 4.1; storing XID to the start of the undo log is a separately logged operation; this conforms to Rule 3 of InnoDB redo logging
      innobase/trx/trx0trx.c:
        Make InnoDB-5.0.3 to process log records of 4.1 undo log header create and reuse just like in 4.1; storing XID to the start of the undo log is a separately logged operation; this conforms to Rule 3 of InnoDB redo logging
      innobase/trx/trx0undo.c:
        Make InnoDB-5.0.3 to process log records of 4.1 undo log header create and reuse just like in 4.1; storing XID to the start of the undo log is a separately logged operation; this conforms to Rule 3 of InnoDB redo logging
      innobase/include/trx0undo.h:
        Make InnoDB-5.0.3 to process log records of 4.1 undo log header create and reuse just like in 4.1; storing XID to the start of the undo log is a separately logged operation; this conforms to Rule 3 of InnoDB redo logging
      a6e56b05
    • unknown's avatar
      BUG#3190 fix (request for STDDEV_SAMP, VAR_SAMP). · d339dd13
      unknown authored
      This bug is also known as WL#1639.
      
      
      mysql-test/r/func_group.result:
        Test case for stddev_pop, var_pop, stddev_samp, var_samp was added.
      mysql-test/t/func_group.test:
        Test case for stddev_pop, var_pop, stddev_samp, var_samp was added.
      sql/item_sum.cc:
        New functions stddev_samp and var_samp were added.
      sql/item_sum.h:
        New functions stddev_samp and var_samp were added.
      sql/lex.h:
        New functions stddev_pop, var_pop, stddev_samp and var_samp were added.
      sql/sql_yacc.yy:
        New functions stddev_pop, var_pop, stddev_samp and var_samp were added.
      d339dd13
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 0be32e7e
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      
      sql/sp_pcontext.cc:
        Auto merged
      0be32e7e
    • unknown's avatar
      Fixed BUG#8757: Stored Procedures: Scope of Begin and End Statements do not work properly. · 3d8aed6d
      unknown authored
      
      mysql-test/r/sp.result:
        New test case for BUG#8757.
      mysql-test/t/sp.test:
        New test case for BUG#8757.
      sql/sp_pcontext.cc:
        Return the correct scope offset to cursors during parsing.
      3d8aed6d
    • unknown's avatar
      Merge with global tree · 08b3e79e
      unknown authored
      
      mysql-test/r/innodb.result:
        Auto merged
      mysql-test/t/innodb.test:
        Auto merged
      mysql-test/t/rpl_rotate_logs.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/protocol.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_db.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      sql/examples/ha_archive.cc:
        Merge with global tree
        (Use my changes)
      sql/sql_parse.cc:
        Remove 'tmp' fix to be able to run tests
      08b3e79e
    • unknown's avatar
      Remove compiler warnings and remove not used variables · 248e4494
      unknown authored
      (Found during build process)
      
      
      extra/comp_err.c:
        Remove compiler warnings
      extra/perror.c:
        Remove compiler warnings
      innobase/dict/dict0dict.c:
        Remove compiler warnings
      innobase/dict/dict0load.c:
        Remove compiler warnings
      innobase/pars/pars0sym.c:
        Remove compiler warnings
      innobase/row/row0row.c:
        Remove compiler warnings
      innobase/row/row0sel.c:
        Remove compiler warnings
      libmysqld/lib_sql.cc:
        Remove not used variables
      myisam/mi_key.c:
        Remove compiler warnings
      regex/engine.c:
        Added comment
      sql/derror.cc:
        Remove not used variables
      sql/examples/ha_archive.cc:
        Fixed bug in blob handling
        Removed not used variable
      sql/field.cc:
        Remove compiler warnings
        Remove not used variables
      sql/filesort.cc:
        Remove compiler warnings
      sql/ha_heap.cc:
        Remove not used variable
      sql/ha_innodb.cc:
        Remove not used variables
        Remove compiler warnings
      sql/handler.cc:
        Remove compiler warnings and remove not used variables
      sql/item.cc:
        Remove compiler warnings and remove not used variables
      sql/item_subselect.cc:
        Remove compiler warnings
      sql/item_sum.cc:
        Remove compiler warnings
      sql/item_sum.h:
        Remove compiler warnings and remove not used variables
      sql/log.cc:
        Remove compiler warnings and remove not used variables
      sql/log_event.cc:
        Remove compiler warnings
      sql/mysqld.cc:
        Remove compiler warnings and remove not used variables
      sql/opt_range.cc:
        Remove compiler warnings and remove not used variables
      sql/slave.cc:
        Remove compiler warnings and remove not used variables
      sql/sp_pcontext.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_acl.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_analyse.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_base.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_db.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_help.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_insert.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_load.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_parse.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_prepare.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_select.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_show.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_table.cc:
        Remove compiler warnings
      sql/sql_union.cc:
        Remove compiler warnings
      sql/sql_update.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_yacc.yy:
        Remove compiler warnings and remove not used variables
      sql/strfunc.cc:
        Remove compiler warnings and remove not used variables
      strings/ctype-ucs2.c:
        Remove compiler warnings
      tests/mysql_client_test.c:
        Remove compiler warnings and remove not used variables
      tools/mysqlmanager.c:
        Remove compiler warnings and remove not used variables
      248e4494
    • unknown's avatar
      Fixed BUG#7620: Stored procedure packet error if show mutex status · b67253a1
      unknown authored
        Another multi result statement added.
        Note: No test case, as it's not possible to get a deterministic result from this.
      
      
      sql/sp_head.cc:
        Another multi result statement added: show mutex status.
      b67253a1
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 89345986
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0
      
      
      89345986
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.0 · 613d326a
      unknown authored
      into mysql.com:/usr/local/home/marty/MySQL/test/mysql-5.0-ndb
      
      
      ndb/include/kernel/signaldata/CreateIndx.hpp:
        Auto merged
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Auto merged
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Auto merged
      ndb/src/ndbapi/ndb_cluster_connection.cpp:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      613d326a
    • unknown's avatar
      Fixed BUG#6857: current_time() in STORED PROCEDURES · 948bb77d
      unknown authored
        Have to thd->set_time() before each substatement execution, to make
        current_time() et al return different times within the same procedure.
      
      
      mysql-test/r/sp.result:
        New test case for BUG#6857: current_time() in STORED PROCEDURES.
        Note: The actual call is disable, to save time when running with slow debugging tools.
      mysql-test/t/sp.test:
        New test case for BUG#6857: current_time() in STORED PROCEDURES.
        Note: The actual call is disable, to save time when running with slow debugging tools.
      sql/sp_head.cc:
        Make current_time() et all work in stored procedures.
      948bb77d
    • unknown's avatar
      Merge mysql.com:/home/jonas/src/mysql-4.1 · c5d4d50a
      unknown authored
      into mysql.com:/home/jonas/src/mysql-5.0
      
      
      BitKeeper/etc/ignore:
        auto-union
      c5d4d50a
    • unknown's avatar
      add auto generated ndb dsp-files (for msvc++ 6.0) to ignore file · 5c15cc5c
      unknown authored
      
      BitKeeper/etc/ignore:
        added ndb/src/common/debugger/signaldata/libsignaldataprint.dsp ndb/src/common/debugger/libtrace.dsp ndb/src/common/logger/liblogger.dsp ndb/src/common/mgmcommon/libmgmsrvcommon.dsp ndb/src/common/portlib/libportlib.dsp ndb/src/common/transporter/libtransporter.dsp ndb/src/common/util/libgeneral.dsp ndb/src/kernel/blocks/backup/libbackup.dsp ndb/src/kernel/blocks/cmvmi/libcmvmi.dsp ndb/src/kernel/blocks/dbacc/libdbacc.dsp ndb/src/kernel/blocks/dbdict/libdbdict.dsp ndb/src/kernel/blocks/dbdih/libdbdih.dsp ndb/src/kernel/blocks/dblqh/libdblqh.dsp ndb/src/kernel/blocks/dbtc/libdbtc.dsp ndb/src/kernel/blocks/dbtup/libdbtup.dsp ndb/src/kernel/blocks/dbtux/libdbtux.dsp ndb/src/kernel/blocks/dbutil/libdbutil.dsp ndb/src/kernel/blocks/grep/libgrep.dsp ndb/src/kernel/blocks/ndbcntr/libndbcntr.dsp ndb/src/kernel/blocks/ndbfs/libndbfs.dsp ndb/src/kernel/blocks/qmgr/libqmgr.dsp ndb/src/kernel/blocks/suma/libsuma.dsp ndb/src/kernel/blocks/trix/libtrix.dsp ndb/src/kernel/error/liberror.dsp ndb/src/kernel/vm/libkernel.d
        sp ndb/src/kernel/ndbd.dsp ndb/src/mgmapi/libmgmapi.dsp ndb/src/mgmclient/ndb_mgm.dsp ndb/src/mgmclient/libndbmgmclient.dsp ndb/src/mgmsrv/ndb_mgmd.dsp ndb/src/ndbapi/libndbapi.dsp ndb/src/libndbclient.dsp ndb/test/ndbapi/flexBench.dsp ndb/test/ndbapi/testBasic.dsp ndb/test/ndbapi/testBlobs.dsp ndb/test/ndbapi/testScan.dsp ndb/test/src/libNDBT.dsp ndb/tools/ndb_waiter.dsp ndb/tools/ndb_drop_table.dsp ndb/tools/ndb_delete_all.dsp ndb/tools/ndb_desc.dsp ndb/tools/ndb_drop_index.dsp ndb/tools/ndb_show_tables.dsp ndb/tools/ndb_select_all.dsp ndb/tools/ndb_select_count.dsp
      5c15cc5c
    • unknown's avatar
      Cset exclude: joreland@mysql.com|ChangeSet|20050224071025|18754 · f46729c2
      unknown authored
      
      sql/sql_parse.cc:
        Exclude
      f46729c2
    • unknown's avatar
      Merge mysql.com:/home/jonas/src/mysql-4.1 · 918a030b
      unknown authored
      into mysql.com:/home/jonas/src/mysql-5.0
      
      
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Auto merged
      ndb/src/ndbapi/ndb_cluster_connection.cpp:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      918a030b
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-4.1 · 799489a7
      unknown authored
      into mysql.com:/home/jonas/src/mysql-4.1
      
      
      799489a7
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-5.0 · 4fb62979
      unknown authored
      into mysql.com:/home/jonas/src/mysql-5.0
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      4fb62979
    • unknown's avatar
      Merge mysql.com:/home/jonas/src/fix · 69d69553
      unknown authored
      into mysql.com:/home/jonas/src/mysql-5.0
      
      
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Auto merged
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Auto merged
      69d69553
    • unknown's avatar
      Merge mysql.com:/home/jonas/src/fix · 52902cb8
      unknown authored
      into mysql.com:/home/jonas/src/mysql-4.1
      
      
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Auto merged
      52902cb8
    • unknown's avatar
      BUG#8786 - ndb_autodiscover, post review · b89feadf
      unknown authored
        More explicit naming of variables
      
      
      ndb/include/kernel/signaldata/AlterIndx.hpp:
        Add union to indicate where master node is passed in ref
      ndb/include/kernel/signaldata/BuildIndx.hpp:
        Add union to indicate where master node is passed in ref
      ndb/include/kernel/signaldata/CreateIndx.hpp:
        Add union to indicate where master node is passed in ref
      ndb/include/kernel/signaldata/CreateTrig.hpp:
        Add union to indicate where master node is passed in ref
      ndb/include/kernel/signaldata/DropIndx.hpp:
        Add union to indicate where master node is passed in ref
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Set error/master node also on BuildIndxRef
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Use masterNodeId instead of errornode
      b89feadf
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.0 · 0d9ba267
      unknown authored
      into mysql.com:/usr/local/home/marty/MySQL/test/mysql-5.0-ndb
      
      
      BitKeeper/etc/logging_ok:
        auto-union
      BitKeeper/triggers/post-commit:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      0d9ba267
  5. 24 Feb, 2005 7 commits
    • unknown's avatar
      Show all generated warnings in SHOW ERROR · eb18f93a
      unknown authored
      Previously we only stored the first given error (the error sent to the client)
      
      
      include/mysys_err.h:
        Moved ER_FILENOTFOUND last to avoid getting 'error 0'
      mysql-test/r/backup.result:
        More warnings from in case of errors
      mysql-test/r/innodb.result:
        More warnings from in case of errors
      mysql-test/r/key_cache.result:
        More warnings from in case of errors
      mysql-test/r/myisam.result:
        More warnings from in case of errors
      mysql-test/r/preload.result:
        More warnings from in case of errors
      mysql-test/r/repair.result:
        More warnings from in case of errors
      mysql-test/r/rpl_failed_optimize.result:
        More warnings from in case of errors
      mysql-test/r/subselect.result:
        More warnings from in case of errors
      mysql-test/t/backup.test:
        Portability fix
      mysql-test/t/innodb.test:
        Avoid some warnings
      mysql-test/t/myisam.test:
        Portability fix
      mysql-test/t/rpl_rotate_logs.test:
        Portablitiy fix
      mysys/errors.c:
        Move ER_FILENOTFOUND last to avoid error 0
      sql/mysql_priv.h:
        Indentation change
      sql/mysqld.cc:
        Save all given errors for SHOW ERRORS
      sql/protocol.cc:
        Store new errors for SHOW ERROR
        (Ignore those that are already reported with my_error())
      sql/sql_class.cc:
        More errors with SHOW ERROR
      sql/sql_class.h:
        More errors with SHOW ERROR
      sql/sql_error.cc:
        More errors with SHOW ERROR
      sql/sql_parse.cc:
        Temporary fix: Don't give error for the to-be-removed 'pre-open tables code'
      sql/sql_show.cc:
        More debugging
        Don't register errors while populating schema tables.
        (If we do, we get a LOT of warnings from information_schema.test)
      sql/sql_table.cc:
        Don't register errors from handler in drop table (as we already do it the upper level DROP TABLE code)
        Don't register errors for 'restore_table' as in most cases the table doesn't exists
      sql/sql_union.cc:
        Use file->write_row() instead of 'write_record'.
        This gives us easer to handle error messages and is faster than the old version
      eb18f93a
    • unknown's avatar
      Merge baker@bk-internal.mysql.com:/home/bk/mysql-5.0 · a4b1bcef
      unknown authored
      into zim.(none):/home/brian/mysql/mysql-5.0
      
      
      a4b1bcef
    • unknown's avatar
      Solved bug 8691. · 48f0b277
      unknown authored
      Funny sometimes how things work when in reality you would think it would crash pretty hard :)
      
      
      sql/examples/ha_archive.cc:
        Solves bug #8691. This was reported in an internal build. Renamed ptr to bptr.
      48f0b277
    • unknown's avatar
      Merge mysql.com:/home/jonas/src/mysql-5.0 · dde2e462
      unknown authored
      into mysql.com:/home/jonas/src/mysql-5.0-ndb
      
      
      ndb/tools/drop_index.cpp:
        Auto merged
      ndb/tools/drop_tab.cpp:
        Auto merged
      dde2e462
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · 2f7fde48
      unknown authored
      into mysql.com:/home/jonas/src/mysql-5.0-ndb
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      2f7fde48
    • unknown's avatar
      bug#8786 - ndb_autodiscover - 5.0 specific details · a9201bf6
      unknown authored
        Wait some for all nodes to get connected
      
      
      ndb/tools/drop_index.cpp:
        Wait some for all nodes to get connected
      ndb/tools/drop_tab.cpp:
        Wait some for all nodes to get connected
      a9201bf6
    • unknown's avatar
      Merge mysql.com:/home/jonas/src/mysql-5.0 · 1c2ea24e
      unknown authored
      into mysql.com:/home/jonas/src/mysql-5.0-ndb
      
      
      ndb/include/kernel/signaldata/CreateIndx.hpp:
        Auto merged
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Auto merged
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Auto merged
      ndb/src/ndbapi/ndb_cluster_connection.cpp:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      1c2ea24e