1. 21 Oct, 2010 4 commits
  2. 20 Oct, 2010 4 commits
  3. 19 Oct, 2010 5 commits
    • Vasil Dimov's avatar
      Fix Bug#53916 storage/innodb_plugin does not compile on NetBSD/sparc64 · cb010506
      Vasil Dimov authored
      Just check for all the functions that we are going to use, not a subset
      of them.
      
      Reviewed by:	Davi (via IRC)
      cb010506
    • Marko Mäkelä's avatar
      ibuf_set_del_mark(): Do not complain about already delete-marked records. · 923003f9
      Marko Mäkelä authored
      According to a comment in row_upd_sec_index_entry(), it is a
      legitimate situation that can be caused by a lock wait.
      923003f9
    • Marko Mäkelä's avatar
      Merge Bug #56680 from mysql-5.1. · 6dfc85f0
      Marko Mäkelä authored
      Additional fixes in 5.5:
      
      ibuf_set_del_mark(): Add diagnostics when setting a buffered delete-mark fails.
      
      ibuf_delete(): Correct a misleading comment about non-found records.
      
      rec_print(): Add a const qualifier to the index parameter.
      
      Bug #56680 wrong InnoDB results from a case-insensitive covering index
      
      row_search_for_mysql(): When a secondary index record might not be
      visible in the current transaction's read view and we consult the
      clustered index and optionally some undo log records, return the
      relevant columns of the clustered index record to MySQL instead of the
      secondary index record.
      
      ibuf_insert_to_index_page_low(): New function, refactored from
      ibuf_insert_to_index_page().
      
      ibuf_insert_to_index_page(): When we are inserting a record in place
      of a delete-marked record and some fields of the record differ, update
      that record just like row_ins_sec_index_entry_by_modify() would do.
      
      btr_cur_update_alloc_zip(): Make the function public.
      
      mysql_row_templ_t: Add clust_rec_field_no.
      
      row_sel_store_mysql_rec(), row_sel_push_cache_row_for_mysql(): Add the
      flag rec_clust, for returning data at clust_rec_field_no instead of
      rec_field_no. Resurrect the debug assertion that the record not be
      marked for deletion. (Bug #55626)
      
      [UNIV_DEBUG || UNIV_IBUF_DEBUG] ibuf_debug, buf_page_get_gen(),
      buf_flush_page_try():
      Implement innodb_change_buffering_debug=1 for evicting pages from the
      buffer pool, so that change buffering will be attempted more
      frequently.
      6dfc85f0
    • Marko Mäkelä's avatar
      Bug #56680 wrong InnoDB results from a case-insensitive covering index · c38071ec
      Marko Mäkelä authored
      row_search_for_mysql(): When a secondary index record might not be
      visible in the current transaction's read view and we consult the
      clustered index and optionally some undo log records, return the
      relevant columns of the clustered index record to MySQL instead of the
      secondary index record.
      
      ibuf_insert_to_index_page_low(): New function, refactored from
      ibuf_insert_to_index_page().
      
      ibuf_insert_to_index_page(): When we are inserting a record in place
      of a delete-marked record and some fields of the record differ, update
      that record just like row_ins_sec_index_entry_by_modify() would do.
      
      btr_cur_update_alloc_zip(): Make the function public.
      
      mysql_row_templ_t: Add clust_rec_field_no.
      
      row_sel_store_mysql_rec(), row_sel_push_cache_row_for_mysql(): Add the
      flag rec_clust, for returning data at clust_rec_field_no instead of
      rec_field_no. Resurrect the debug assertion that the record not be
      marked for deletion. (Bug #55626)
      
      [UNIV_DEBUG || UNIV_IBUF_DEBUG] ibuf_debug, buf_page_get_gen(),
      buf_flush_page_try():
      Implement innodb_change_buffering_debug=1 for evicting pages from the
      buffer pool, so that change buffering will be attempted more
      frequently.
      c38071ec
    • Marko Mäkelä's avatar
      Bug #56680 wrong InnoDB results from a case-insensitive covering index · a8f2f7af
      Marko Mäkelä authored
      row_search_for_mysql(): When a secondary index record might not be
      visible in the current transaction's read view and we consult the
      clustered index and optionally some undo log records, return the
      relevant columns of the clustered index record to MySQL instead of the
      secondary index record.
      
      REC_INFO_DELETED_FLAG: Move the definition from rem0rec.ic to rem0rec.h.
      
      ibuf_insert_to_index_page_low(): New function, refactored from
      ibuf_insert_to_index_page().
      
      ibuf_insert_to_index_page(): When we are inserting a record in place
      of a delete-marked record and some fields of the record differ, update
      that record just like row_ins_sec_index_entry_by_modify() would do.
      
      mysql_row_templ_t: Add clust_rec_field_no.
      
      row_sel_store_mysql_rec(), row_sel_push_cache_row_for_mysql(): Add the
      flag rec_clust, for returning data at clust_rec_field_no instead of
      rec_field_no. Resurrect the debug assertion that the record not be
      marked for deletion. (Bug #55626)
      
      buf_LRU_free_block(): Refactored from
      buf_LRU_search_and_free_block(). This is needed for the
      innodb_change_buffering_debug diagnostics.
      
      [UNIV_DEBUG || UNIV_IBUF_DEBUG] ibuf_debug, buf_page_get_gen(),
      buf_flush_page_try():
      Implement innodb_change_buffering_debug=1 for evicting pages from the
      buffer pool, so that change buffering will be attempted more
      frequently.
      a8f2f7af
  4. 18 Oct, 2010 4 commits
    • Vasil Dimov's avatar
      Merge mysql-5.1-innodb -> mysql-5.5-innodb · 85e19dd3
      Vasil Dimov authored
      85e19dd3
    • Vasil Dimov's avatar
      Fix Bug#57252 disabling innobase_stats_on_metadata disables ANALYZE · 78804bc8
      Vasil Dimov authored
      This is a merge from 5.1/builtin to 5.1/plugin of:
      
        --------------
        revision-id: vasil.dimov@oracle.com-20101018104811-nwqhg9vav17kl5s1
        committer: Vasil Dimov <vasil.dimov@oracle.com>
        timestamp: Mon 2010-10-18 13:48:11 +0300
        message:
          Fix Bug#57252 disabling innobase_stats_on_metadata disables ANALYZE
          
          In order to fix this bug we need to distinguish whether ha_innobase::info()
          has been called from ::analyze() or not. Rename ::info() to ::info_low()
          and add a boolean parameter that tells whether the call is from ::analyze()
          or not. Create a new simple ::info() that just calls
          ::info_low(false => not called from analyze). From ::analyze() instead of
          ::info() call ::info_low(true => called from analyze).
          
          Approved by:	Jimmy (rb://487)
        --------------
      78804bc8
    • Vasil Dimov's avatar
      Fix Bug#57252 disabling innobase_stats_on_metadata disables ANALYZE · 902b13fa
      Vasil Dimov authored
      In order to fix this bug we need to distinguish whether ha_innobase::info()
      has been called from ::analyze() or not. Rename ::info() to ::info_low()
      and add a boolean parameter that tells whether the call is from ::analyze()
      or not. Create a new simple ::info() that just calls
      ::info_low(false => not called from analyze). From ::analyze() instead of
      ::info() call ::info_low(true => called from analyze).
      
      Approved by:	Jimmy (rb://487)
      902b13fa
    • Sunny Bains's avatar
      Fix bug encountered during testing on BSD. In the original fix for bug# 55681 · 8776f964
      Sunny Bains authored
      the check for overflow was wrong and the OS_SYNC_INFINITE_TIME was handled
      incorrectly.
        
      Approved by Jimmy Yang (IM)
      8776f964
  5. 15 Oct, 2010 7 commits
  6. 14 Oct, 2010 7 commits
    • Jimmy Yang's avatar
      9970a9cf
    • Jimmy Yang's avatar
      27c80dd4
    • Alexander Nozdrin's avatar
      A patch for Bug#48874 (Test "is_triggers" fails because of wrong charset info). · 650e4c25
      Alexander Nozdrin authored
      The thing is that the following attributes are fixed (remembered) when a trigger
      is created:
        - character_set_client
        - character_set_results
        - collation_connection
      
      There are two triggers created in mysql-test/include/mtr_warnings.sql.
      They were created using "current default" character set / collation.
      is_triggers.test shows definition of these triggers including recorded
      character set information.
      
      The problem was that if "current default" changed, the recorded character
      set information was not accurate.
      
      There might be two ways to fix that:
        a) update is_triggers.test so that it does not put character-set information
           into result-file;
        b) update mtr_warnings.sql so that the triggers are created using
           hard-coded character sets.
      
      This patch implements option b).
      650e4c25
    • Vasil Dimov's avatar
      Tune the test for Bug#56143 too many foreign keys causes output of show create... · c8163ef1
      Vasil Dimov authored
      Tune the test for Bug#56143 too many foreign keys causes output of show create table to become invalid
      
      Use a CREATE statement with all the FKs instead of ALTERing the table many
      times because it is faster (11 seconds vs 3 seconds).
      
      c8163ef1
    • Vasil Dimov's avatar
      Fix Bug#56143 too many foreign keys causes output of show create table to become invalid · f918ad43
      Vasil Dimov authored
      This is a port of the following changeset from
      5.1/storage/innobase to 5.1/storage/innodb_plugin:
      
        ------------------------------------------------------------
        revno: 3626
        revision-id: vasil.dimov@oracle.com-20101013171859-gi9n558yj89x9v3w
        parent: klewis@mysql.com-20101012175933-ce9kkgl0z8oeqffa
        committer: Vasil Dimov <vasil.dimov@oracle.com>
        branch nick: mysql-5.1-innodb
        timestamp: Wed 2010-10-13 20:18:59 +0300
        message:
          Fix Bug#56143 too many foreign keys causes output of show create table to become invalid
          
          Just remove the check whether the file is "too big".
          A similar code exists in ha_innobase::update_table_comment() but that
          method does not seem to be used.
      
      Also use a CREATE statement with all the FKs instead of ALTERing the
      table 550 times because it is faster.
      f918ad43
    • Sunny Bains's avatar
      Bug# 55681 - MTR slowdown after default storage engine was changed to InnoDB · e16a61c6
      Sunny Bains authored
      Add new function os_cond_wait_timed(). Change the os_thread_sleep() calls
      to timed conditional waits. Signal the background threads during the shutdown
      phase so that we avoid waiting for the sleep to timeout thus saving some time.
      
      rb://439 -- Approved by Jimmy Yang
      e16a61c6
    • Davi Arnaut's avatar
      Bug#56096: STOP SLAVE hangs if executed in parallel with user sleep · 1d43e72a
      Davi Arnaut authored
      The root of the problem is that to interrupt a slave SQL thread
      wait, the STOP SLAVE implementation uses thd->awake(THD::NOT_KILLED).
      This appears as a spurious wakeup (e.g. from a sleep on a
      condition variable) to the code that the slave SQL thread is
      executing at the time of the STOP. If the code is not written
      to be spurious-wakeup safe, unexpected behavior can occur. For
      the reported case, this problem led to an infinite loop around
      the interruptible_wait() function in item_func.cc (SLEEP()
      function implementation).  The loop was not being properly
      restarted and, consequently, would not come to an end. Since the
      SLEEP function sleeps on a timed event in order to be killable
      and to perform periodic checks until the requested time has
      elapsed, the spurious wake up was causing the requested sleep
      time to be reset every two seconds.
      
      The solution is to calculate the requested absolute time only
      once and to ensure that the thread only sleeps until this
      time is elapsed. In case of a spurious wake up, the sleep is
      restarted using the previously calculated absolute time. This
      restores the behavior present in previous releases. If a slave
      thread is executing a SLEEP function, a STOP SLAVE statement
      will wait until the time requested in the sleep function
      has elapsed.
      
      mysql-test/extra/rpl_tests/rpl_start_stop_slave.test:
        Add test case for Bug#56096.
      mysql-test/suite/rpl/r/rpl_stm_start_stop_slave.result:
        Add test case result for Bug#56096.
      sql/item_func.cc:
        Reorganize interruptible_wait into a class so that the absolute
        time can be preserved across calls to the wait function. This
        allows the sleep to be properly restarted in the presence of
        spurious wake ups, including those generated by a STOP SLAVE.
      1d43e72a
  7. 13 Oct, 2010 4 commits
  8. 14 Oct, 2010 1 commit
  9. 13 Oct, 2010 4 commits