1. 29 Sep, 2006 3 commits
    • unknown's avatar
      merge fixes · edd34f68
      unknown authored
      
      mysql-test/t/view.test:
        moved the new error message last
      sql/share/errmsg.txt:
        moved the new error message last
      edd34f68
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt · d3612560
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      d3612560
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1 · d5ea425a
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      d5ea425a
  2. 28 Sep, 2006 14 commits
    • unknown's avatar
      view.test: · 669d8a6f
      unknown authored
        After merge fix
      
      
      mysql-test/t/view.test:
        After merge fix
      669d8a6f
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 024f93c5
      unknown authored
      into  moonbone.local:/work/5505-bug-5.0-opt-mysql
      
      
      sql/share/errmsg.txt:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      mysql-test/r/view.result:
        Manual merge
      mysql-test/t/view.test:
        Manual merge
      024f93c5
    • unknown's avatar
      Fixed bug#5505: Wrong error message on INSERT into a view · 9cf17a35
      unknown authored
      On an INSERT into an updatable but non-insertable view an error message was
      issued stating the view being not updatable. This can lead to a confusion of a
      user.
      
      A new error message is introduced. Is is showed when a user tries to insert
      into a non-insertable view.
      
      
      sql/sql_base.cc:
        Fixed bug#5505: Wrong error message on INSERT into a view
        The update_non_unique_table_error() function now issues proper
        error for an INSERT.
      sql/sql_insert.cc:
        Fixed bug#5505: Wrong error message on INSERT into a view
        Issue the ER_NON_INSERTABLE_TABLE error instead of the 
        ER_NON_UPDATABLE_TABLE on insert into a view.
      sql/sql_view.cc:
        Fixed bug#5505: Wrong error message on INSERT into a view
        Issue the ER_NON_INSERTABLE_TABLE error instead of the
        ER_NON_UPDATABLE_TABLE on insert into a view.
      mysql-test/r/view.result:
        Added the test case for bug#5505: Wrong error message on INSERT into a view
        Corrected a few test cases after fixing bug#5505
      mysql-test/t/view.test:
        Added the test case for bug#5505: Wrong error message on INSERT into a view
        Corrected a few test cases after fixing bug#5505
      sql/share/errmsg.txt:
        Fixed bug#5505: Wrong error message on INSERT into a view
        Added the ER_NON_INSERTABLE_TABLE error definition.
      9cf17a35
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.1 · e9b342ce
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      e9b342ce
    • unknown's avatar
      after merge fix · 30b0b572
      unknown authored
      30b0b572
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1 · e039d51d
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      sql/mysql_priv.h:
        Auto merged
      e039d51d
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-opt · e43692a1
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      sql/item.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      e43692a1
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · edde4890
      unknown authored
      into  moonbone.local:/work/18360-bug-5.1-opt-mysql
      
      
      mysql-test/t/view.test:
        Auto merged
      sql/item.cc:
        Auto merged
      edde4890
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0 · ded8eed1
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1
      
      
      include/mysql_com.h:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/r/type_date.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/slave.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/sql_repl.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/sp.cc:
        manual merge
      sql/sp_head.cc:
        manual merge
      sql/sql_class.h:
        manual merge
      sql/table.cc:
        manual merge
      ded8eed1
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/mysql-5.1 · 5f7aeede
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      sql/field.h:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      5f7aeede
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt · 1b744c77
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      1b744c77
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/mysql-5.0 · 757c5dcf
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      757c5dcf
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/mysql-4.1 · e2452943
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt
      
      
      sql/sql_select.cc:
        Auto merged
      e2452943
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.1 · 614235d5
      unknown authored
      into  mysql.com:/home/cps/mysql/trees/5.1-runtime-new
      
      
      sql/handler.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      mysql-test/r/sp.result:
        manual merge
      mysql-test/t/sp.test:
        manual merge
      storage/csv/ha_tina.cc:
        manual merge
      storage/myisam/ha_myisam.cc:
        manual merge
      614235d5
  3. 27 Sep, 2006 12 commits
    • unknown's avatar
      additional 'after merge' fix · 96c11368
      unknown authored
      96c11368
    • unknown's avatar
      merge fixes 5.0-opt -> 5.1-opt · a48c6b2a
      unknown authored
      a48c6b2a
    • unknown's avatar
      after merge fix · 15947254
      unknown authored
      15947254
    • unknown's avatar
      Remove unused error messages (no release contains them · 4919d8b3
      unknown authored
      at the moment, so we can safely do that). Update an error
      mesage to make it translateable.
      
      
      mysql-test/r/log_tables.result:
        update result file
      sql/share/errmsg.txt:
        remove unused error messages
      sql/sql_table.cc:
        Use name of the statements rather then English words.
        This way error message is translateable.
      4919d8b3
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/4.1 · a1d2505e
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0
      
      
      sql/sql_parse.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/table.cc:
        Auto merged
      include/mysql_com.h:
        manual merge
      mysql-test/r/ctype_utf8.result:
        manual merge
      mysql-test/t/ctype_utf8.test:
        manual merge
      sql/sql_acl.cc:
        manual merge
      a1d2505e
    • unknown's avatar
      Patch for bug#21432 is reverted · 6c977010
      unknown authored
      6c977010
    • unknown's avatar
      456ce5f2
    • unknown's avatar
      Merge macbook.gmz:/Users/kgeorge/mysql/work/B21174-5.0-opt · 119fef85
      unknown authored
      into  macbook.gmz:/Users/kgeorge/mysql/work/B21174-5.1-opt
      
      
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/r/func_group.result:
        Auto merged
      mysql-test/r/group_by.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/field.h:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      storage/myisam/mi_check.c:
        Auto merged
      mysql-test/r/ps.result:
        merge 5.0-opt -> 5.1-opt
      sql/unireg.cc:
        merge 5.0-opt -> 5.1-opt
      119fef85
    • unknown's avatar
      Bug #21174: Index degrades sort performance and optimizer does not honor IGNORE INDEX · 8946c46e
      unknown authored
       - reversed the patch for 5.0 and moved to 5.1
      
      
      mysql-test/r/group_by.result:
        Bug #21174: Index degrades sort performance and optimizer does not honor IGNORE INDEX
         - reversed the patch for 5.0
      mysql-test/t/group_by.test:
        Bug #21174: Index degrades sort performance and optimizer does not honor IGNORE INDEX
         - reversed the patch for 5.0
      sql/sql_select.cc:
        Bug #21174: Index degrades sort performance and optimizer does not honor IGNORE INDEX
         - reversed the patch for 5.0
      8946c46e
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1 · dc64ac17
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug21414
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      mysql-test/r/sp.result:
        Manual merge.
      mysql-test/t/sp.test:
        Manual merge.
      dc64ac17
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · ba667a58
      unknown authored
      into  mysql.com:/home/hf/work/mysql-5.0-mrg
      
      ba667a58
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1-opt · e405769c
      unknown authored
      into  mysql.com:/home/hf/work/mysql-4.1.15428
      
      e405769c
  4. 26 Sep, 2006 5 commits
    • unknown's avatar
      Fixed bug #18360: Type aggregation for IN and CASE may lead to a wrong · 86ee562a
      unknown authored
      result
      
      The IN function aggregates result types of all expressions. It uses that 
      type in comparison of left expression and expressions in right part. 
      This approach works in most cases. But let's consider the case when the
      right part contains both strings and integers. In that case this approach may
      cause wrong results because all strings which do not start with a digit are
      evaluated as 0.
      CASE uses the same approach when a CASE expression is given thus it's also
      affected.
      
      The idea behind this fix is to make IN function to compare expressions with
      different result types differently. For example a string in the left
      part will be compared as string with strings specified in right part and
      will be converted to real for comparison to int or real items in the right
      part.
      
      A new function called collect_cmp_types() is added. It collects different
      result types for comparison of first item in the provided list with each 
      other item in the list. 
      
      The Item_func_in class now can refer up to 5 cmp_item objects: 1 for each
      result type for comparison purposes. cmp_item objects are allocated according
      to found result types. The comparison of the left expression with any
      right part expression is now based only on result types of these expressions.
      
      The Item_func_case class is modified in the similar way when a CASE
      expression is specified. Now it can allocate up to 5 cmp_item objects
      to compare CASE expression with WHEN expressions of different types.
      The comparison of the CASE expression with any WHEN expression now based only 
      on result types of these expressions.
      
      
      
      sql/item.cc:
        Cleaned up an outdated comment.
      sql/item_cmpfunc.cc:
            Fixed bug #18360: Type aggregation for IN and CASE may lead to a wrong result
            A new function called collect_cmp_types() is added. It collects different
            result types for comparison of first item in the provided list with each 
            other item in the list. 
            The Item_func_in class now can refer up to 5 cmp_item objects: 1 for each
            result type for comparison purposes. cmp_item objects are allocated according
            to found result types. The comparison of the left expression with any
            right part expression is now based only on result types of these expressions.
            The Item_func_case class is modified in the similar way when a CASE
            expression is specified. Now it can allocate up to 5 cmp_item objects
            to compare CASE expression with WHEN expressions of different types.
            The comparison of the CASE expression with any WHEN expression now based only 
            on result types of these expressions.
      sql/item_cmpfunc.h:
            Fixed bug#18360: Type aggregation for IN and CASE may lead to a wrong result
            The Item_func_in class now can refer up to 5 cmp_item objects.
            The Item_func_case class is modified in the similar way.
      sql/opt_range.cc:
            Fixed bug #18360: Type aggregation for IN and CASE may lead to a wrong
            resultSmall code changes due to changes in Item_func_in class.
      mysql-test/t/view.test:
        Added a test comment
      mysql-test/t/func_in.test:
        Added a test case for bug#18360: Type aggregation for IN and CASE may lead to a wrong
        result
      mysql-test/r/func_in.result:
        Added a test case for bug#18360: Type aggregation for IN and CASE may lead to a wrong
        result
      86ee562a
    • unknown's avatar
      Added more tests of field conversions. · 8cad2a45
      unknown authored
      8cad2a45
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-runtime · 93776ea3
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.1-runtime
      
      93776ea3
    • unknown's avatar
      Fix for bug#20208 · 428d428c
      unknown authored
      A better fix for bug#10025.
      
      Fixed test case plus added new tests.
      
      After fixing Bug#20208 "Blobs greater than 8K are being truncated to 8K"
      the fix to bug#10025 "Misleading error with COLLATE mediumtext and UNION"
      became more accurate. Earlier mediumtext got converted to longtext,
      although mediumtext was enough to contain the results. Now it converts
      correctly to mediumtext, if the length does not exceed that and if none
      of the original fields were type longtext.
      
      Type longtext still converts correctly to type longtext, as the extra
      tests prove.
      
      
      mysql-test/r/union.result:
        Fixed an earlier test case plus added two new tests.
      mysql-test/t/union.test:
        Fixed an earlier test case plus added two new tests.
      428d428c
    • unknown's avatar
      Merge trift2.:/MySQL/M50/clone-5.0 · 67fc6bc8
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      mysql-test/r/func_time.result:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/r/type_date.result:
        Auto merged
      mysql-test/r/view.result:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      mysql-test/t/func_time.test:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      mysql-test/t/type_date.test:
        Auto merged
      mysql-test/t/view.test:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      sql/item_cmpfunc.cc:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      67fc6bc8
  5. 25 Sep, 2006 6 commits
    • unknown's avatar
      Fix for bug#22662 Inconsistent values displayed for event_scheduler · e6fd6523
      unknown authored
      when set to DISABLED
        
      It was a silly ordering number error.
      
      
      
      sql/events.h:
        fix ordinal number, the cause for bug #22662
        Inconsistent values displayed for event_scheduler when set to DISABLED
      mysql-test/r/events_restart_phase0.result:
        New BitKeeper file ``mysql-test/r/events_restart_phase0.result''
      mysql-test/t/events_restart_phase0.log:
        New BitKeeper file ``mysql-test/t/events_restart_phase0.log''
      mysql-test/t/events_restart_phase0.result:
        New BitKeeper file ``mysql-test/t/events_restart_phase0.result''
      e6fd6523
    • unknown's avatar
      Fix for bug#22397 Events: crash with procedure which alters events · c1208a48
      unknown authored
        
      ALTER EVENT in stored procedure body led to a crash during the
      procedure call. Affected was only ALTER EVENT which changed the
      interval of the event. No problems with AT, STARTS, ENDS and so on.
      
      
      
      mysql-test/r/events_bugs.result:
        fix result
      mysql-test/t/events_bugs.test:
        add test case for bug 22397 : Events, crash with procedure which alters body
      sql/event_data_objects.cc:
        fix copy&paste error in code, which resulted in bug#22397
        Events: crash with procedure which alters body
      c1208a48
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0-opt · 1c17642e
      unknown authored
      into  rurik.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug21646
      
      1c17642e
    • unknown's avatar
      cleanups - fix a test and remove unneeded declaration · 7193b6fd
      unknown authored
      
      mysql-test/r/events.result:
        test result
      mysql-test/t/events.test:
        fix test
      sql/sql_show.cc:
        remove unneeded declaration
      7193b6fd
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-4.1-opt · 5b30853d
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-5.0-opt
      
      
      mysql-test/r/subselect.result:
        Manual merge
      mysql-test/t/subselect.test:
        Manual merge
      sql/item.cc:
        Manual merge
      5b30853d
    • unknown's avatar
      Fixed bug #21646. · fe2edf6d
      unknown authored
      Presence of a subquery in the ON expression of a join 
      should not block merging the view that contains this join.
      Before this patch the such views were converted into 
      into temporary table views.
      
      
      mysql-test/r/view.result:
        Added a test case for bug #21646.
      mysql-test/t/view.test:
        Added a test case for bug #21646.
      sql/mysql_priv.h:
        Fixed bug #21646.
        Added a new parsing state 'IN_ON', true when
        the parser is in an ON expression of a join.
      sql/sql_lex.cc:
        Fixed bug #21646.
        Presence of a subquery in the ON expression of a join 
        should not block merging the view that contains this join.
      sql/sql_yacc.yy:
        Fixed bug #21646.
        Added a new parsing state 'IN_ON', true when
        the parser is in an ON expression of a join.
      fe2edf6d