1. 28 Sep, 2006 1 commit
  2. 27 Sep, 2006 5 commits
    • unknown's avatar
      merge fixes 5.0-opt -> 5.1-opt · a48c6b2a
      unknown authored
      a48c6b2a
    • unknown's avatar
      456ce5f2
    • unknown's avatar
      Merge macbook.gmz:/Users/kgeorge/mysql/work/B21174-5.0-opt · 119fef85
      unknown authored
      into  macbook.gmz:/Users/kgeorge/mysql/work/B21174-5.1-opt
      
      
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/r/func_group.result:
        Auto merged
      mysql-test/r/group_by.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/field.h:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      storage/myisam/mi_check.c:
        Auto merged
      mysql-test/r/ps.result:
        merge 5.0-opt -> 5.1-opt
      sql/unireg.cc:
        merge 5.0-opt -> 5.1-opt
      119fef85
    • unknown's avatar
      Bug #21174: Index degrades sort performance and optimizer does not honor IGNORE INDEX · 8946c46e
      unknown authored
       - reversed the patch for 5.0 and moved to 5.1
      
      
      mysql-test/r/group_by.result:
        Bug #21174: Index degrades sort performance and optimizer does not honor IGNORE INDEX
         - reversed the patch for 5.0
      mysql-test/t/group_by.test:
        Bug #21174: Index degrades sort performance and optimizer does not honor IGNORE INDEX
         - reversed the patch for 5.0
      sql/sql_select.cc:
        Bug #21174: Index degrades sort performance and optimizer does not honor IGNORE INDEX
         - reversed the patch for 5.0
      8946c46e
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · ba667a58
      unknown authored
      into  mysql.com:/home/hf/work/mysql-5.0-mrg
      
      ba667a58
  3. 26 Sep, 2006 1 commit
    • unknown's avatar
      Fixed bug #18360: Type aggregation for IN and CASE may lead to a wrong · 86ee562a
      unknown authored
      result
      
      The IN function aggregates result types of all expressions. It uses that 
      type in comparison of left expression and expressions in right part. 
      This approach works in most cases. But let's consider the case when the
      right part contains both strings and integers. In that case this approach may
      cause wrong results because all strings which do not start with a digit are
      evaluated as 0.
      CASE uses the same approach when a CASE expression is given thus it's also
      affected.
      
      The idea behind this fix is to make IN function to compare expressions with
      different result types differently. For example a string in the left
      part will be compared as string with strings specified in right part and
      will be converted to real for comparison to int or real items in the right
      part.
      
      A new function called collect_cmp_types() is added. It collects different
      result types for comparison of first item in the provided list with each 
      other item in the list. 
      
      The Item_func_in class now can refer up to 5 cmp_item objects: 1 for each
      result type for comparison purposes. cmp_item objects are allocated according
      to found result types. The comparison of the left expression with any
      right part expression is now based only on result types of these expressions.
      
      The Item_func_case class is modified in the similar way when a CASE
      expression is specified. Now it can allocate up to 5 cmp_item objects
      to compare CASE expression with WHEN expressions of different types.
      The comparison of the CASE expression with any WHEN expression now based only 
      on result types of these expressions.
      
      
      
      sql/item.cc:
        Cleaned up an outdated comment.
      sql/item_cmpfunc.cc:
            Fixed bug #18360: Type aggregation for IN and CASE may lead to a wrong result
            A new function called collect_cmp_types() is added. It collects different
            result types for comparison of first item in the provided list with each 
            other item in the list. 
            The Item_func_in class now can refer up to 5 cmp_item objects: 1 for each
            result type for comparison purposes. cmp_item objects are allocated according
            to found result types. The comparison of the left expression with any
            right part expression is now based only on result types of these expressions.
            The Item_func_case class is modified in the similar way when a CASE
            expression is specified. Now it can allocate up to 5 cmp_item objects
            to compare CASE expression with WHEN expressions of different types.
            The comparison of the CASE expression with any WHEN expression now based only 
            on result types of these expressions.
      sql/item_cmpfunc.h:
            Fixed bug#18360: Type aggregation for IN and CASE may lead to a wrong result
            The Item_func_in class now can refer up to 5 cmp_item objects.
            The Item_func_case class is modified in the similar way.
      sql/opt_range.cc:
            Fixed bug #18360: Type aggregation for IN and CASE may lead to a wrong
            resultSmall code changes due to changes in Item_func_in class.
      mysql-test/t/view.test:
        Added a test comment
      mysql-test/t/func_in.test:
        Added a test case for bug#18360: Type aggregation for IN and CASE may lead to a wrong
        result
      mysql-test/r/func_in.result:
        Added a test case for bug#18360: Type aggregation for IN and CASE may lead to a wrong
        result
      86ee562a
  4. 25 Sep, 2006 7 commits
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0-opt · 1c17642e
      unknown authored
      into  rurik.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug21646
      
      1c17642e
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-4.1-opt · 5b30853d
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-5.0-opt
      
      
      mysql-test/r/subselect.result:
        Manual merge
      mysql-test/t/subselect.test:
        Manual merge
      sql/item.cc:
        Manual merge
      5b30853d
    • unknown's avatar
      Fixed bug #21646. · fe2edf6d
      unknown authored
      Presence of a subquery in the ON expression of a join 
      should not block merging the view that contains this join.
      Before this patch the such views were converted into 
      into temporary table views.
      
      
      mysql-test/r/view.result:
        Added a test case for bug #21646.
      mysql-test/t/view.test:
        Added a test case for bug #21646.
      sql/mysql_priv.h:
        Fixed bug #21646.
        Added a new parsing state 'IN_ON', true when
        the parser is in an ON expression of a join.
      sql/sql_lex.cc:
        Fixed bug #21646.
        Presence of a subquery in the ON expression of a join 
        should not block merging the view that contains this join.
      sql/sql_yacc.yy:
        Fixed bug #21646.
        Added a new parsing state 'IN_ON', true when
        the parser is in an ON expression of a join.
      fe2edf6d
    • unknown's avatar
      Fixed bug #21853: assert failure for a grouping query with · c492b149
      unknown authored
      an ALL/ANY quantified subquery in HAVING.
      The Item::split_sum_func2 method should not create Item_ref
      for objects of any class derived from Item_subselect.
      
      
      mysql-test/r/subselect.result:
        Added a test case for bug #21853.
      mysql-test/t/subselect.test:
        Added a test case for bug #21853.
      c492b149
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mysql-4.1.15428 · b91735a6
      unknown authored
      into  mysql.com:/home/hf/work/mysql-5.0-mrg
      
      
      myisam/mi_check.c:
        Auto merged
      mysys/my_chsize.c:
        Auto merged
      b91735a6
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mysql-4.1.12991 · adb7fc9b
      unknown authored
      into  mysql.com:/home/hf/work/mysql-4.1.15428
      
      
      myisam/mi_check.c:
        Auto merged
      adb7fc9b
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1-opt · 2833ae45
      unknown authored
      into  mysql.com:/home/hf/work/mysql-4.1.15428
      
      2833ae45
  5. 20 Sep, 2006 6 commits
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-4.1-opt · 82703ea4
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-5.0-opt
      
      
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      sql/field.h:
        Auto merged
      sql/unireg.cc:
        Auto merged
      82703ea4
    • unknown's avatar
      Fixed bug #20108. · 4017a533
      unknown authored
      Any default value for a enum fields over UCS2 charsets was corrupted
      when we put it into the frm file, as it had been overwritten by its
      HEX representation.
      To fix it now we save a copy of structure that represents the enum
      type and when putting the default values we use this copy. 
      
      
      mysql-test/r/ctype_ucs.result:
        Added a test case for bug #20108.
      mysql-test/t/ctype_ucs.test:
        Added a test case for bug #20108.
      4017a533
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 0464a219
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-5.0-opt
      
      0464a219
    • unknown's avatar
      Fixed bug #22015: crash with GROUP_CONCAT over a derived table · cc5e1972
      unknown authored
      that returns the results of aggregation by GROUP_CONCAT.
      The crash was due to an overflow happened for the field
      sortoder->length.
      The fix prevents this overflow exploiting the fact that the
      value of sortoder->length cannot be greater than the value of
      thd->variables.max_sort_length.   
      
      
      mysql-test/r/func_gconcat.result:
        Added a test case for bug #22015.
      mysql-test/t/func_gconcat.test:
        Added a test case for bug #22015.
      cc5e1972
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 36f8b3a8
      unknown authored
      into  rakia.(none):/home/kgeorge/mysql/autopush/B21540-5.0-opt
      
      36f8b3a8
    • unknown's avatar
      fixed merge · 151cb33e
      unknown authored
      151cb33e
  6. 19 Sep, 2006 5 commits
  7. 18 Sep, 2006 13 commits
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1 · 5bfc157b
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1
      
      5bfc157b
    • unknown's avatar
      In current 5.1 build we don't build embedded server for windows (this will be · dbafce68
      unknown authored
      fixed when 5.1-win will be pushed into main tree).
      Commenting the libmysqld and libmysqld/example subdirectories will allow us 
      to upgrade from cmake 2.2 to 2.4.
      
      
      CMakeLists.txt:
        comment libmysqld and libmysqld/example directories
      dbafce68
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt · 37945947
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      37945947
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · f1b67362
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      f1b67362
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-opt · dd727f70
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1
      
      
      mysql-test/t/disabled.def:
        Auto merged
      dd727f70
    • unknown's avatar
      merge fixes · 613678a9
      unknown authored
      613678a9
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt · 4c3557da
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1
      
      
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/r/func_group.result:
        Auto merged
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/r/group_by.result:
        Auto merged
      mysql-test/r/heap_hash.result:
        Auto merged
      mysql-test/r/information_schema.result:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/r/join_outer.result:
        Auto merged
      mysql-test/r/olap.result:
        Auto merged
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/r/range.result:
        Auto merged
      mysql-test/r/row.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/r/type_date.result:
        Auto merged
      mysql-test/r/union.result:
        Auto merged
      mysql-test/r/view_grant.result:
        Auto merged
      mysql-test/t/func_group.test:
        Auto merged
      mysql-test/t/func_str.test:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/opt_range.h:
        Auto merged
      sql/opt_sum.cc:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_list.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/t/sp.test:
        SCCS merged
      sql/item_cmpfunc.cc:
        SCCS merged
      sql/sql_select.cc:
        SCCS merged
      4c3557da
    • unknown's avatar
      BUG#22393: Very wrong E(#rows(ref(const)) for key with skewed distribution · 0c8423bd
      unknown authored
      - Check if we have E(#rows) for 'range' access on the smaller interval 
        on the same index. If yes, adjust the estimate.
      
      
      mysql-test/r/range.result:
        BUG#22393: Testcase
      mysql-test/t/range.test:
        BUG#22393: Testcase
      0c8423bd
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-opt · 62d5d7cd
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      62d5d7cd
    • unknown's avatar
      merge fixes · e21c120e
      unknown authored
      e21c120e
    • unknown's avatar
      disabled.def: · ea267f1a
      unknown authored
        Enabled rpl_sp_effects test due to fixed bug.
      
      
      mysql-test/t/disabled.def:
        Enabled rpl_sp_effects test due to fixed bug.
      ea267f1a
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt · bec689f3
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      mysql-test/r/subselect.result:
        SCCS merged
      mysql-test/t/subselect.test:
        SCCS merged
      bec689f3
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1-opt · 7fd21a59
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt
      
      7fd21a59
  8. 16 Sep, 2006 2 commits
    • unknown's avatar
      Fixed bug #22085: Crash on the execution of a prepared · e229307a
      unknown authored
      statement that uses an aggregating IN subquery with 
      HAVING clause.
      A wrong order of the call of split_sum_func2 for the HAVING
      clause of the subquery and the transformation for the 
      subquery resulted in the creation of a andor structure
      that could not be restored at an execution of the prepared
      statement.
      
      
      mysql-test/r/ps.result:
        Added a test cases for bug #22085.
      mysql-test/t/ps.test:
        Added a test cases for bug #22085.
      e229307a
    • unknown's avatar
      Fixed bug #21493: crash for the second execution of a function · 48bafe40
      unknown authored
      containing a select statement that uses an aggregating IN subquery.
      Added a parameter to the function fix_prepare_information 
      to restore correctly the having clause for the second execution.
      Saved andor structure of the having conditions at the proper moment
      before any calls of split_sum_func2 that could modify the having structure
      adding new Item_ref objects. (These additions, are produced not with 
      the statement mem_root, but rather with the execution mem_root.)
      
      
      mysql-test/r/sp.result:
        Added a test case for bug #21493.
      mysql-test/t/sp.test:
        Added a test case for bug #21493.
      sql/sql_delete.cc:
        Fixed bug #21493: crash for the second execution of a function
        containing a select statement that uses an aggregating IN subquery.
        Added a parameter to the function fix_prepare_information 
        to restore correctly the having clause for the second execution.
      sql/sql_insert.cc:
        Fixed bug #21493: crash for the second execution of a function
        containing a select statement that uses an aggregating IN subquery.
        Added a parameter to the function fix_prepare_information 
        to restore correctly the having clause for the second execution.
      sql/sql_lex.cc:
        Fixed bug #21493: crash for the second execution of a function
        containing a select statement that uses an aggregating IN subquery.
        Added a parameter to the function fix_prepare_information 
        to restore correctly the having clause for the second execution.
      sql/sql_lex.h:
        Fixed bug #21493: crash for the second execution of a function
        containing a select statement that uses an aggregating IN subquery.
        Added a parameter to the function fix_prepare_information 
        to restore correctly the having clause for the second execution.
      sql/sql_update.cc:
        Fixed bug #21493: crash for the second execution of a function
        containing a select statement that uses an aggregating IN subquery.
        Added a parameter to the function fix_prepare_information 
        to restore correctly the having clause for the second execution.
      48bafe40