- 28 Aug, 2006 1 commit
-
-
andrey@example.com authored
Don't send affected rows after CREATE/ALTER/DROP EVENT as this is inconsistent with the rest of the server in terms of CREATE/ALTER/DROP DDLs
-
- 23 Aug, 2006 5 commits
-
-
ahristov@bk-internal.mysql.com authored
into bk-internal.mysql.com:/data0/bk/mysql-5.1-wl3337
-
andrey@example.com authored
into example.com:/work/mysql-5.1-runtime-wl3337
-
andrey@example.com authored
handle them. Problem: CREATE|ALTER EVENT, HANDLER READ, KILL, Partitioning uses `expr` from the parser. This rule comes with all the rings and bells including subqueries. However, these commands are not subquery safe. For this reason there are two fuse checks in the parser. They were checking by command id. CREATE EVENT should forbid subquery is the fix for bug#16394 Events: Crash if schedule contains SELECT The fix has been incorporated as part of the patch for WL#3337 (Event scheduler new architecture). Solution: A new flag was added to LEX command_forbids_subselect. The fuse checks were changed. The commands are responsible to set the value to true whenever they can't handle subselects.
-
andrey@example.com authored
into example.com:/work/mysql-5.1-runtime
-
andrey@example.com authored
should work in Prepared Statements. Post-review changeset. Problem: There are some commands which are avaiable to be executed in SP but cannot be prepared. This patch fixes this and makes it possible prepare these statements. Changes: The commands later are made available in PS. RESET has been forbidden in SF/Trigger. Solution: All current server commands where checked and those missing (see later) we added. Tests for all of the commands with repeated executions were added - testing with SP, SF and PS. SHOW BINLOG EVENTS SHOW (MASTER | SLAVE) STATUS SHOW (MASTER | BINARY) LOGS SHOW (PROCEDURE | FUNCTION) CODE (parsable only in debug builds) SHOW CREATE (PROCEDURE | FUNCTION | EVENT | TABLE | VIEW) SHOW (AUTHORS | CONTRIBUTORS | WARNINGS | ERRORS) CHANGE MASTER RESET (MASTER | SLAVE | QUERY CACHE) SLAVE (START | STOP) CHECKSUM (TABLE | TABLES) INSTALL PLUGIN UNINSTALL PLUGIN CACHE INDEX LOAD INDEX INTO CACHE GRANT REVOKE KILL (CREATE | RENAME | DROP) DATABASE (CREATE | RENAME | DROP) USER FLUSH (TABLE | TABLES | TABLES WITH READ LOCK | HOSTS | PRIVILEGES | LOGS | STATUS | MASTER | SLAVE | DES_KEY_FILE | USER_RESOURCES)
-
- 21 Aug, 2006 4 commits
-
-
andrey@example.com authored
const for two parameters.
-
dlenev@mockturtle.local authored
from cache" and #21216 "Simultaneous DROP TABLE and SHOW OPEN TABLES causes server to crash". Crash happened when one ran DROP DATABASE or SHOW OPEN TABLES statements while concurrently doing DROP TABLE (or RENAME TABLE, CREATE TABLE LIKE or any other command that takes name-lock) in other connection. This problem was caused by the fact that table placeholders which were added to table cache in order to obtain name-lock on table had TABLE_SHARE::db and table_name set to 0. Therefore they broke assumption that these members are non-0 for all tables in table cache on which some of our code relies. The fix sets these members for such placeholders to appropriate value making this assumption true again. As attempt to avoid such problems in future we introduce auxiliary TABLE_SHARE::set_table_cache_key() methods which should be used when one wants to set TABLE_SHARE::table_cache_key and which ensure that TABLE_SHARE::table_name/db are set properly. Test cases for these bugs were added to 5.0 test-suite (with 5.0-specific fix for bug #21216).
-
dlenev@mockturtle.local authored
into mockturtle.local:/home/dlenev/src/mysql-5.1-bg19403-2
-
dlenev@mockturtle.local authored
server to crash". Crash caused by assertion failure happened when one ran SHOW OPEN TABLES while concurrently doing DROP TABLE (or RENAME TABLE, CREATE TABLE LIKE or any other command that takes name-lock) in other connection. For non-debug version of server problem exposed itself as wrong output of SHOW OPEN TABLES statement (it was missing name-locked tables). Finally in 5.1 both debug and non-debug versions simply crashed in this situation due to NULL-pointer dereference. This problem was caused by the fact that table placeholders which were added to table cache in order to obtain name-lock had TABLE_SHARE::table_name set to 0. Therefore they broke assumption that this member is non-0 for all tables in table cache which was checked by assert in list_open_tables() (in 5.1 this function simply relies on it). The fix simply sets this member for such placeholders to appropriate value making this assumption true again. This patch also includes test for similar bug 12212 "Crash that happens during removing of database name from cache" reappeared in 5.1 as bug 19403.
-
- 18 Aug, 2006 1 commit
-
-
ahristov@bk-internal.mysql.com authored
into bk-internal.mysql.com:/data0/bk/mysql-5.1-wl3337
-
- 17 Aug, 2006 4 commits
-
-
andrey@example.com authored
into example.com:/work/mysql-5.1-runtime
-
andrey@example.com authored
There is an existing macros for initializing LEX_STRINGs with constant strings -> C_STRING_WITH_LEN. Change existing code to use it. (char *) STRING_WITH_LEN -> C_STRING_WITH_LEN
-
andrey@example.com authored
Shift from direct usage of (char *) with STRING_WITH_LEN to C_STRING_WITH_LEN
-
andrey@example.com authored
Post-review fixes. Mostly whitespace, int-to-bool return value, fixed comments
-
- 15 Aug, 2006 1 commit
-
-
anozdrin/alik@alik. authored
in their name. The problem was that IM-tests contained grep-statements with too wide patterns. The fix is to make these patterns more restrictive. Only IM-tests have been fixed, no code has been touched.
-
- 14 Aug, 2006 9 commits
-
-
andrey@example.com authored
-
andrey@example.com authored
into example.com:/work/mysql-5.1-runtime-wl3337
-
kostja@bodhi.local authored
into bodhi.local:/opt/local/work/mysql-5.1-runtime-merge
-
joerg@trift2. authored
-
kostja@bodhi.local authored
-
andrey@example.com authored
into example.com:/work/mysql-5.1-runtime-wl3337
-
kostja@bodhi.local authored
into bodhi.local:/opt/local/work/mysql-5.1-runtime-merge
-
kostja@bodhi.local authored
-
kostja@bodhi.local authored
-
- 12 Aug, 2006 1 commit
-
-
kostja@bodhi.local authored
into bodhi.local:/opt/local/work/mysql-5.1-runtime-merge
-
- 11 Aug, 2006 1 commit
-
-
andrey@example.com authored
-
- 10 Aug, 2006 10 commits
-
-
pgalbraith/patg@govinda.patg.net authored
into govinda.patg.net:/home/patg/mysql-build/mysql-5.1-engines-merge
-
patg@govinda.patg.net authored
into govinda.patg.net:/home/patg/mysql-build/mysql-5.1-engines-merge
-
kroki/tomash@moonlight.intranet authored
into moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-runtine-merge
-
kroki/tomash@moonlight.intranet authored
into moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-merge
-
kroki/tomash@moonlight.intranet authored
into moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-merge
-
serg@janus.mylan authored
into janus.mylan:/usr/home/serg/Abk/m51
-
andrey@example.com authored
how did it get in?!? (it's only in local csets so no other tree is affected)
-
andrey@example.com authored
-
serg@janus.mylan authored
into janus.mylan:/usr/home/serg/Abk/m51
-
kroki/tomash@moonlight.intranet authored
into moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-merge
-
- 09 Aug, 2006 3 commits
-
-
evgen@moonbone.local authored
After merge fix
-
andrey@lmy004. authored
into lmy004.:/work/mysql-5.1-runtime
-
andrey@lmy004. authored
create function func() returns char(10) binary ... is no more possible. This will be reenabled when bug 2676 "DECLARE can't have COLLATE clause in stored procedure" is fixed. Fix after 2nd review
-