- 10 Nov, 2007 1 commit
-
-
unknown authored
into mysql.com:/misc/mysql/31990/51-31990 mysql-test/r/cast.result: Auto merged mysql-test/t/cast.test: Auto merged sql/item_timefunc.cc: Auto merged sql/item_timefunc.h: Auto merged
-
- 08 Nov, 2007 1 commit
-
-
unknown authored
HOUR(), MINUTE(), ... returned spurious results when used on a DATE-cast. This happened because DATE-cast object did not overload get_time() method in superclass Item. The default method was inappropriate here and misinterpreted the data. Patch adds missing method; get_time() on DATE-casts now returns SQL-NULL on NULL input, 0 otherwise. This coincides with the way DATE-columns behave. mysql-test/r/cast.result: Show that HOUR(), MINUTE(), ... return sensible values when used on DATE-cast objects, namely NULL for NULL-dates and 0 otherwise. Show that this coincides with how DATE-columns behave. mysql-test/t/cast.test: Show that HOUR(), MINUTE(), ... return sensible values when used on DATE-cast objects, namely NULL for NULL-dates and 0 otherwise. Show that this coincides with how DATE-columns behave. sql/item_timefunc.cc: Add get_time() method to DATE-cast object to overload the method in Item superclass that would return spurious results. Return zero-result; flag NULL if input was NULL. sql/item_timefunc.h: Add get_time() declaration to DATE-cast object.
-
- 29 Oct, 2007 14 commits
-
-
unknown authored
-
unknown authored
into mysql.com:/home/gluh/MySQL/Merge/5.1-opt mysql-test/r/type_decimal.result: Auto merged mysql-test/t/type_decimal.test: Auto merged sql/item_func.cc: Auto merged sql/item_func.h: Auto merged
-
unknown authored
There are two problems with ROUND(X, D) on an exact numeric (DECIMAL, NUMERIC type) field of a table: 1) The implementation of the ROUND function would change the number of decimal places regardless of the value decided upon in fix_length_and_dec. When the number of decimal places is not constant, this would cause an inconsistent state where the number of digits was less than the number of decimal places, which crashes filesort. Fixed by not allowing the ROUND operation to add any more decimal places than was decided in fix_length_and_dec. 2) fix_length_and_dec would allow the number of decimals to be greater than the maximium configured value for constant values of D. This led to the same crash as in (1). Fixed by not allowing the above in fix_length_and_dec. mysql-test/r/type_decimal.result: Bug#30889: Test result mysql-test/t/type_decimal.test: Bug#30889: Test case sql/item_func.cc: Bug#30889: - Avoid setting number of digits after decimal point (scale) higher than its maximum value. - Avoid increasing the number of decimal places in ::decimal_op sql/item_func.h: Bug#30889: Added comments to the declarations of Item_func_numhybrid::<type>_op family of methods.
-
unknown authored
into mysql.com:/home/gluh/MySQL/Merge/5.1-opt mysql-test/r/func_gconcat.result: Auto merged mysql-test/t/func_gconcat.test: Auto merged sql/item_sum.cc: Auto merged
-
unknown authored
The fix is a copy of Martin Friebe's suggestion. added testing for no_appended which will be false if anything, including the empty string is in result mysql-test/r/func_gconcat.result: test result mysql-test/t/func_gconcat.test: test case sql/item_sum.cc: added testing for no_appended which will be False if anything, including the empty string is in result
-
unknown authored
into mysql.com:/home/gluh/MySQL/Merge/5.1-opt mysql-test/r/information_schema.result: manual merge mysql-test/t/information_schema.test: manual merge
-
unknown authored
-
unknown authored
into mysql.com:/home/gluh/MySQL/Merge/5.1-opt
-
unknown authored
into polly.(none):/home/kaa/src/opt/mysql-5.1-opt sql/mysqld.cc: Null merge.
-
unknown authored
-
unknown authored
into mysql.com:/home/gluh/MySQL/Merge/5.1-opt
-
unknown authored
into polly.(none):/home/kaa/src/opt/mysql-5.1-opt mysql-test/r/variables.result: Auto merged mysql-test/t/variables.test: Auto merged sql/mysql_priv.h: Auto merged sql/mysqld.cc: Auto merged sql/set_var.cc: Auto merged sql/sql_base.cc: Auto merged
-
unknown authored
into polly.(none):/home/kaa/src/opt/mysql-5.1-opt mysql-test/r/variables.result: Auto merged mysql-test/t/variables.test: Auto merged sql/mysql_priv.h: Auto merged sql/mysqld.cc: Auto merged sql/set_var.cc: Auto merged
-
unknown authored
into polly.(none):/home/kaa/src/opt/mysql-5.0-opt mysql-test/r/variables.result: Auto merged mysql-test/t/variables.test: Auto merged sql/mysql_priv.h: Auto merged sql/mysqld.cc: Auto merged sql/set_var.cc: Auto merged
-
- 28 Oct, 2007 1 commit
-
-
unknown authored
Error message numbers. mysql-test/suite/rpl/r/rpl_extraCol_innodb.result: Error message numbers. mysql-test/suite/rpl/r/rpl_extraCol_myisam.result: Error message numbers. mysql-test/suite/rpl/r/rpl_row_tabledefs_3innodb.result: Error message numbers.
-
- 27 Oct, 2007 7 commits
-
-
unknown authored
Error message numbers. mysql-test/suite/rpl/r/rpl_row_colSize.result: Error message numbers. mysql-test/suite/rpl/r/rpl_row_tabledefs_2myisam.result: Error message numbers. mysql-test/r/sp.result: Error message numbers.
-
unknown authored
Post-merge fix. storage/archive/ha_archive.cc: Post-merge fix.
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt mysql-test/r/archive.result: Auto merged mysql-test/t/archive.test: Auto merged storage/archive/azio.c: Auto merged
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt mysql-test/r/type_decimal.result: Auto merged mysql-test/t/type_decimal.test: Auto merged sql/item.cc: Auto merged
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.0-opt
-
unknown authored
into magare.gmz:/home/kgeorge/mysql/autopush/B30715-merged-5.1-opt
-
unknown authored
into magare.gmz:/home/kgeorge/mysql/autopush/B30715-merged-5.0-opt
-
- 26 Oct, 2007 9 commits
-
-
unknown authored
Error message numbers. mysql-test/r/binlog_unsafe.result: Error message numbers. mysql-test/r/events_bugs.result: Error message numbers. mysql-test/r/events_trans.result: Error message numbers. mysql-test/r/sp_gis.result: Error message numbers. mysql-test/r/xml.result: Error message numbers. mysql-test/suite/rpl/r/rpl_incident.result: Error message numbers. mysql-test/suite/rpl/r/rpl_loaddata_fatal.result: Error message numbers. mysql-test/suite/rpl/r/rpl_udf.result: Error message numbers. mysql-test/suite/rpl_ndb/r/rpl_ndb_extraCol.result: Error message numbers. mysql-test/suite/ndb/r/ndb_dd_basic.result: Error message numbers. mysql-test/suite/ndb/r/ndb_dd_ddl.result: Error message numbers. mysql-test/suite/ndb/r/ndb_gis.result: Error message numbers. mysql-test/suite/ndb/r/ndb_row_format.result: Error message numbers. mysql-test/suite/ndb/r/ndb_single_user.result: Error message numbers.
-
unknown authored
1. Memory overrun have been fixed. 2. Server failure on assertion has been fixed. storage/archive/azio.c: Fixed bug #31036. The ha_archive::rnd_pos function has been modified to take into account the result of the azseek function and to return HA_ERR_CRASHED_ON_USAGE in case of seek error. storage/archive/ha_archive.cc: Fixed bug #31036. 1. Memory overrun has been fixed: maximal sizes of azio_stream::inbuf and azio_stream::outbuf was mixed. 2. Zero value of the output parameter of the azread function was incorrectly interpreted by the azseek function: after the first successful read attempt the execution of the azseek loop was interrupted and negative value was returned. (See ha_archive::rnd_pos: that negative value was silently ignored, and an incomplete data was used, for example, as a size of a packed record, and server failed with the assertion: "row_len <= record_buffer->length".) mysql-test/t/archive.test: Added test case for bug #31036. mysql-test/r/archive.result: Added test case for bug #31036.
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt mysql-test/r/select.result: Auto merged mysql-test/r/type_decimal.result: Auto merged mysql-test/t/select.test: Auto merged mysql-test/t/type_decimal.test: Auto merged sql/item.cc: Auto merged sql/sql_class.cc: Auto merged sql/sql_class.h: Auto merged sql/sql_yacc.yy: Auto merged sql/share/errmsg.txt: Merge with 5.0-opt
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.0-opt sql/sql_class.cc: Auto merged
-
unknown authored
into polly.(none):/home/kaa/src/opt/bug29131/my51-bug29131 mysql-test/r/variables.result: Null merge. mysql-test/t/variables.test: Null merge. sql/mysql_priv.h: Null merge. sql/mysqld.cc: Null merge. sql/set_var.cc: Null merge. sql/set_var.h: Null merge.
-
unknown authored
into mysql.com:/scratch/tnurnberg/31662/51-31662 sql/sql_base.cc: Auto merged
-
unknown authored
into mysql.com:/misc/mysql/31662/50-31662 sql/sql_base.cc: Auto merged
-
unknown authored
into mysql.com:/scratch/tnurnberg/31662/51-31662 mysql-test/r/information_schema_db.result: Auto merged sql/sql_base.cc: Auto merged
-
unknown authored
SHOW FIELDS FROM a view with no valid definer was possible (since fix for Bug#26817), but gave NULL as a field-type. This led to mysqldump-ing of such views being successful, but loading such a dump with the client failing. Patch allows SHOW FIELDS to give data-type of field in underlying table. mysql-test/r/information_schema_db.result: Fix test results: SHOW FIELDS FROM a view with no valid DEFINER gives us the field-type of the underlying table now rather than NULL. sql/sql_base.cc: In the case of SHOW FIELDS FROM <view>, do not require a valid DEFINER for determining underlying data-type like we usually do. This is needed for mysqldump.
-
- 25 Oct, 2007 4 commits
-
-
unknown authored
to get rid of a name clash among *deleted* files on case-insignificant file systems. BitKeeper/deleted/.del-changelog-bleh: Rename: BitKeeper/deleted/.del-changelog -> BitKeeper/deleted/.del-changelog-bleh
-
unknown authored
doesn't recognize it This is a 5.1 version of the patch. Problem: 'log' and 'log_slow_queries' were "fixed" variables, i.e. they showed up in SHOW VARIABLES, but could not be used in expressions like "select @@log". Also, using them in the SET statement produced an incorrect "unknown system variable" error. Solution: Since as of MySQL 5.1.12 one can enable or disable the general query log or the slow query log at runtime by changing values of general_log/slow_query_log, make 'log' and 'log_slow_queries" to be synonyms for 'general_log' and 'slow_query_log' respectively. This makes expressions using the '@@var' syntax backward compatible with 5.0 and SHOW VARIABLES output to be consistent with the SET statement. mysql-test/r/log_state.result: Added a test case for bug #29131. mysql-test/t/log_state.test: Added a test case for bug #29131. sql/set_var.cc: Made the 'log' and 'log_slow_queries' system variables to be synonyms for 'general_log' and 'slow_query_log'.
-
unknown authored
doesn't recognize it This is a 5.0 version of the patch, it will be null-merged to 5.1 Problem: 'log' and 'log_slow_queries' were "fixed" variables, i.e. they showed up in SHOW VARIABLES, but could not be used in expressions like "select @@log". Also, using them in the SET statement produced an incorrect "unknown system variable" error. Solution: Make 'log' and 'log_slow_queries' read-only dynamic variables to make them available for use in expressions, and produce a correct error about the variable being read-only when used in the SET statement. mysql-test/r/variables.result: Added a test case for bug #29131. mysql-test/t/variables.test: Added a test case for bug #29131. sql/mysql_priv.h: Changed the type of opt_log and opt_slow_log to my_bool to align with the interfaces in set_var.cc sql/mysqld.cc: Changed the type of opt_log and opt_slow_log to my_bool to align with the interfaces in set_var.cc sql/set_var.cc: Made 'log' and 'log_slow_queries' to be read-only dynamic system variable, i.e. available for use in expressions with the @@var syntax. sql/set_var.h: Added a new system variable class representing a read-only boolean variable.
-
unknown authored
all space column names. The parser has been modified to check VIEW column names with the check_column_name function and to report an error on empty and all space column names (same as for TABLE column names). sql/sql_yacc.yy: Fixed bug #27695. The parser has been modified to check VIEW column aliases with the check_column_name function and to report an error on empty columns and all space columns (same as for TABLE column names). mysql-test/t/select.test: Updated test case for bug #27695. mysql-test/r/select.result: Updated test case for bug #27695.
-
- 24 Oct, 2007 3 commits
-
-
unknown authored
into magare.gmz:/home/kgeorge/mysql/work/B30715-merged-5.1-opt mysql-test/r/func_group.result: Auto merged mysql-test/r/type_decimal.result: Auto merged mysql-test/t/func_group.test: Auto merged mysql-test/t/type_decimal.test: Auto merged sql/item.cc: Auto merged sql/opt_sum.cc: merge bug 30715 to 5.1-opt
-
unknown authored
into magare.gmz:/home/kgeorge/mysql/work/B30715-merged-5.0-opt
-
unknown authored
file .\opt_sum.cc, line The optimizer pre-calculates the MIN/MAX values for queries like SELECT MIN(kp_k) WHERE kp_1 = const AND ... AND kp_k-1 = const when there is a key over kp_1...kp_k In doing so it was not checking correctly nullability and there was a superfluous assert(). Fixed by making sure that the field can be null before checking and taking out the wrong assert(). . Introduced a correct check for nullability The MIN(field) can return NULL when all the row values in the group are NULL-able or if there were no rows. Fixed the assertion to reflect the case when there are no rows. mysql-test/r/func_group.result: Bug #30715: test case mysql-test/t/func_group.test: Bug #30715: test case sql/opt_sum.cc: Bug #30715: correct nullability check for MIN/MAX pre-calculation over index.
-