1. 22 Aug, 2012 4 commits
  2. 21 Aug, 2012 2 commits
    • unknown's avatar
      Fix bug mdev-447: Wrong output from the EXPLAIN command of the test case for lp bug #714999 · 80b3f747
      unknown authored
      The fix backports from MWL#182: Explain running statements the logic that
      saves the original JOIN_TAB array of a query plan after optimization. This
      array is later used during EXPLAIN to iterate over the original JOIN plan
      nodes in the cases when this plan could be changed by early subquery
      execution during the optimization phase of the outer query.
      80b3f747
    • Michael Widenius's avatar
      Fix for bug lp:1039277 "Crash in sql_cache.cc". · a45c451e
      Michael Widenius authored
      The crash happend when combining query cache, prepared statements and using a read only cursor.
      
      sql/sql_cache.cc:
        Fixed unlikely error when one adjust query cache size in middle of operation
      sql/sql_cursor.cc:
        Disable query cache when using cursors. This fixed lp:1039277
      tests/mysql_client_test.c:
        Test case for lp:1039277
      a45c451e
  3. 20 Aug, 2012 1 commit
    • Michael Widenius's avatar
      Ensure we don't assert with debug binaries if SHOW INNODB STATUS returns with an error. · 75e8ce6d
      Michael Widenius authored
      
      sql/handler.cc:
        SHOW INNODB STATUS sometimes returns 0 even if it has generated an error.
        This code is here to catch it until InnoDB some day is fixed.
      storage/innobase/handler/ha_innodb.cc:
        Catch at least one of the possible errors from SHOW INNODB STATUS to provide a correct return code.
      storage/xtradb/handler/ha_innodb.cc:
        Catch at least one of the possible errors from SHOW INNODB STATUS to provide a correct return code.
      support-files/my-huge.cnf.sh:
        Fixed typo
      75e8ce6d
  4. 17 Aug, 2012 2 commits
    • unknown's avatar
      ee27b50f
    • Michael Widenius's avatar
      Fixed compiler warnings · 89036b9f
      Michael Widenius authored
      Fixed error in test that caused following tests to fail
      
      extra/yassl/taocrypt/src/dsa.cpp:
        Fixed compiler warning by adding cast
      mysql-test/suite/rpl/t/rpl_start_slave_deadlock_sys_vars.test:
        We have to first test for have_debug_sync to not start master wrongly
      plugin/auth_pam/auth_pam.c:
        Fixed compiler warning
      sql/sys_vars.h:
        Fixed compiler warning (Sys_var_max_user_conn is now signed)
      support-files/compiler_warnings.supp:
        Don't give warnings for auth_pam.c (Tried to fix it by changing the code, but could not find an easy way to do that on solaris)
      89036b9f
  5. 15 Aug, 2012 4 commits
    • Michael Widenius's avatar
      Fixed MDEV-366: Assertion `share->reopen == 1' failed in maria_extra on DROP... · a1bc3936
      Michael Widenius authored
      Fixed MDEV-366: Assertion `share->reopen == 1' failed in maria_extra on DROP TABLE which is locked twice
      
      mysql-test/suite/maria/lock.result:
        Added test case
      mysql-test/suite/maria/lock.test:
        Added test case
      sql/sql_table.cc:
        One can't call HA_EXTRA_FORCE_REOPEN on something that may be opened twice.
        It's safe to remove the call in this case as we will call HA_EXTRA_PREPARE_FOR_DROP for the table anyway.
        (One nice side effect is that drop is a bit faster as we are not flushing the cache to disk before the drop anymore)
      a1bc3936
    • Michael Widenius's avatar
      Fixed MDEV-365 "Got assertion when doing alter table on a partition" · fbe5ac4e
      Michael Widenius authored
      
      mysql-test/r/partition.result:
        Added test case
      mysql-test/t/partition.test:
        Added test case
      sql/sql_partition.cc:
        Do mysql_trans_prepare_alter_copy_data() after all original tables are locked.
        (We don't want to disable transactions for the original tables, that still may be in the cache)
      sql/sql_table.cc:
        Fixed two wrong DBUG_ENTER
      fbe5ac4e
    • Michael Widenius's avatar
      automatic merge · 9c1cc61c
      Michael Widenius authored
      9c1cc61c
    • Michael Widenius's avatar
      Fixed compiler warnings · dd8bd2e4
      Michael Widenius authored
      sql/item_subselect.cc:
        Added purecov info
      sql/sql_select.cc:
        Added cast
      storage/innobase/handler/ha_innodb.cc:
        Added cast
      storage/xtradb/btr/btr0btr.c:
        Added buf_block_get_frame_fast() to avoid compiler warning
      storage/xtradb/handler/ha_innodb.cc:
        Added cast
      storage/xtradb/include/buf0buf.h:
        Innodb has buf_block_get_frame(block) defined as (block)->frame.
        Didn't want to do a big change to break xtradb as it may use block_get_frame() differently, so I mad this quick hack to patch one compiler warning.
      dd8bd2e4
  6. 14 Aug, 2012 2 commits
    • Michael Widenius's avatar
      Fixed compiler errors · b886cac7
      Michael Widenius authored
      Updated test to also work on 32 bit
      
      mysql-test/suite/heap/heap.test:
        Updated test to also work on 32 bit
      b886cac7
    • unknown's avatar
      MDEV-450: Deadlock between starting a slave and reading system variables · 47929af5
      unknown authored
      Starting the SQL thread might deadlock with reading the values of the
      replication filtering options.
      
      The deadlock is due to a lock order violation when the variables are
      read or set. For example, reading replicate_ignore_table first
      acquires LOCK_global_system_variables in sys_var::value_ptr and later
      acquires LOCK_active_mi in Sys_var_rpl_filter::global_value_ptr. This
      violates the order established when starting a SQL thread, where
      LOCK_active_mi is acquired before start_slave, and ends up creating a
      thread (handle_slave_sql) that allocates a THD handle whose
      constructor acquires LOCK_global_system_variables in THD::init.
      
      The solution is to unlock LOCK_global_system_variables before the
      replication filtering options are set or read. This way the lock
      order is preserved and the data being read/set is still protected
      given that it acquires LOCK_active_mi.
      47929af5
  7. 13 Aug, 2012 4 commits
  8. 11 Aug, 2012 1 commit
  9. 10 Aug, 2012 1 commit
  10. 09 Aug, 2012 2 commits
  11. 08 Aug, 2012 3 commits
  12. 06 Aug, 2012 2 commits
    • Michael Widenius's avatar
      Use less memory when growing HEAP tables. See MDEV-436 · f2d7609a
      Michael Widenius authored
      mysql-test/suite/heap/heap.result:
        Added test case for MDEV-436
      mysql-test/suite/heap/heap.test:
        Added test case for MDEV-436
      storage/heap/hp_block.c:
        Don't allocate a set of HP_PTRS when not needed. This saves us about 1024 bytes for most allocations.
      storage/heap/hp_create.c:
        Made the initial allocation of block sizes depending on min_records and max_records.
      f2d7609a
    • Michael Widenius's avatar
      Fixed compiler warnings · a7123f50
      Michael Widenius authored
      sql/log.h:
        Fixed compiler warnings reported for gcc 2.7.1
      storage/xtradb/handler/ha_innodb.cc:
        Remove not used variables
      a7123f50
  13. 01 Aug, 2012 1 commit
  14. 02 Aug, 2012 3 commits
  15. 01 Aug, 2012 1 commit
    • Elena Stepanova's avatar
      MDEV-369 (Mismatches in MySQL engines test suite) · 4f3674c8
      Elena Stepanova authored
      Following reasons caused mismatches:
        - different handling of invalid values;
        - different CAST results with fractional seconds;
        - microseconds support in MariaDB;
        - different algorithm of comparing temporal values;
        - differences in error and warning texts and codes;
        - different approach to truncating datetime values to time;
        - additional collations;
        - different record order for queries without ORDER BY;
        - MySQL bug#66034.
      More details in MDEV-369 comments.
      4f3674c8
  16. 31 Jul, 2012 5 commits
    • Sergei Golubchik's avatar
      MDEV-336 oqgraph 5.5 crashes in buildbot · 6d4acc43
      Sergei Golubchik authored
      make CMakeLists.txt to detect if the installed boost can be compiled with the
      installed compile and specified set of compiler options.
      
      Background: even sufficiently new Boost cannot be compiled with the sufficiently old gcc
      in the presence of -fno-rtti
      6d4acc43
    • Sergei Golubchik's avatar
      MDEV-419 ensure that all HAVE_XXX constants can be set by cmake · 0117a92f
      Sergei Golubchik authored
      add missing checks to configure.cmake
      remove dead code and unused HAVE_xxx constants from the sources
      0117a92f
    • Sergei Golubchik's avatar
      MDEV-375 Server crashes in THD::print_aborted_warning with log_warnings > 3 · 42ea25d4
      Sergei Golubchik authored
      Don't use ER(xxx) in THD::close_connection(), when current_thd is already reset to NULL.
      Prefer ER_THD() or ER_DEFAULT() instead.
      42ea25d4
    • Alexey Botchkov's avatar
      MDEV-340 Save replication comments for DROP TABLE. · 9705ad5e
      Alexey Botchkov authored
            mysql_rm_table_no_locks() function was modified.
            When we construct log record for the DROP TABLE, now we
            look if there's a comment before the first table name and
            add it to the record if so.
        
      per-file comments:
        sql/sql_table.cc
        MDEV-340 Save replication comments for DROP TABLE.
              comment_length() function implemented to find comments in the query,
              call it in mysql_rm_table_no_locks() and use the result to form log record.
        mysql-test/suite/binlog/r/binlog_drop_if_exists.result
        MDEV-340 Save replication comments for DROP TABLE.
              test result updated.
        mysql-test/suite/binlog/t/binlog_drop_if_exists.test
        MDEV-340 Save replication comments for DROP TABLE.
              test case added.
      9705ad5e
    • Sergei Golubchik's avatar
      MDEV-418 Feedback plugin statisics problem · 7368ef56
      Sergei Golubchik authored
      Add the check for sys/utsname.h to configure.cmake
      7368ef56
  17. 30 Jul, 2012 2 commits
    • Vladislav Vaintroub's avatar
      MDEV-417 - fix typo that prevented use of atomic instructions on Windows · 257fd9d3
      Vladislav Vaintroub authored
      use correct macro for Microsoft compiler. It is _MSC_VER , not _MSV_VER
      257fd9d3
    • Elena Stepanova's avatar
      MDEV-369 (Mismatches in MySQL engines test suite) · d1a90e85
      Elena Stepanova authored
      Following reasons caused mismatches:
        - different handling of invalid values;
        - different CAST results with fractional seconds;
        - microseconds support in MariaDB;
        - different algorithm of comparing temporal values;
        - differences in error and warning texts and codes;
        - different approach to truncating datetime values to time;
        - additional collations;
        - different record order for queries without ORDER BY;
        - MySQL bug#66034.
      More details in MDEV-369 comments.
      d1a90e85