- 22 Aug, 2022 1 commit
-
-
Brad Smith authored
As pointed out with MDEV-29308 there are issues with the code as is. MariaDB is built as C++11 / C99. aligned_alloc() is not guarenteed to be exposed when building with any mode other than C++17 / C11. The other *BSD's have their stdlib.h header to expose the function with C+11 anyway, but the issue exists in the C99 code too, the build just does not use -Werror. Linux globally defines _GNU_SOURCE hiding the issue as well.
-
- 19 Aug, 2022 3 commits
-
-
Thirunarayanan Balathandayuthapani authored
Reason: ====== This issue is caused by race condition between fulltext DDL and purge thread. DDL sets the signal to stop the purge thread to process the new undo log records and wait for the ongoing processed FTS table undo log records to finish. But in dict_acquire_mdl_shared(),InnoDB release all innodb table related locks before acquiring the mdl. At the same time, DDL assumes that there are no purge threads working on fts table. There is a possiblity that purge thread can skip processing the valid undo log records if it checks purge_sys.must_wait_FTS() twice in different places. Solution: ========== Add the purge_sys.must_wait_FTS() check in dict_acquire_mdl_shared() to avoid the purge thread processing undo log records. dict_open_table_on_id(): return -1 if the purge thread has to wait dict_acquire_mdl_shared(): Added 1 new parameters to indicate that purge thread invoking the function, return -1 if the purge thread has to wait.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
- 18 Aug, 2022 1 commit
-
-
Marko Mäkelä authored
In MySQL 5.7, rollback segments 1 to 32 are used for temporary tables, which is an unnecessary file format change from MySQL 5.6. This format change was avoided in MariaDB Server by commit 124bae08 (MDEV-12289). An upgrade from MySQL 5.7 would crash due to dereferencing a null pointer, which is a regression due to commit 0b47c126 (MDEV-13542). trx_rseg_t::get(): Return nullptr if no tablespace exists. This is where the upgrade would crash. trx_rseg_mem_restore(): Return DB_TABLESPACE_NOT_FOUND if the undo tablespace does not exist. This is likely dead code.
-
- 16 Aug, 2022 1 commit
-
-
Thirunarayanan Balathandayuthapani authored
failures
-
- 15 Aug, 2022 4 commits
-
-
Oleksandr Byelkin authored
-
Daniel Bartholomew authored
-
Daniel Bartholomew authored
-
Daniel Bartholomew authored
-
- 13 Aug, 2022 1 commit
-
-
qggcs authored
Analysis: The JSON functions(JSON_ARRAY[OBJECT|ARRAY_APPEND|ARRAY_INSERT|INSERT|SET|REPLACE]) result is truncated when the function is called based on LONGTEXT field. The overflow occurs when computing the result length due to the LONGTEXT max length is same as uint32 max length. It lead to wrong result length. Fix: Add static_cast<ulonglong> to avoid uint32 overflow and fix the arguments used.
-
- 10 Aug, 2022 11 commits
-
-
Addison G authored
The mysqld_safe script was using bad grep options. The line that was fixed was likely meant to be 2 separate grep commands, piped into each other, with each one removing any lines that matched. The `-E` option was unneeded, as the command is not using regex.
-
Oleksandr Byelkin authored
-
Addison G authored
The mysqld_safe script was using bad grep options. The line that was fixed was likely meant to be 2 separate grep commands, piped into each other, with each one removing any lines that matched. The `-E` option was unneeded, as the command is not using regex.
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
Nayuta Yanagisawa authored
-
Sergei Golubchik authored
first SIGTERM and if the process didn't die in 10 seconds, SIGKILL it. This allows various tools like `rr`, `gcov`, `gprof`, etc to flush their data to disk properly
-
Sergei Golubchik authored
-
Sergei Golubchik authored
MDEV-23149 Server crashes in my_convert / ErrConvString::ptr / Item_char_typecast::check_truncation_with_warn
-
Sergei Golubchik authored
-
Sergei Golubchik authored
--log-slow-queries was removed in 10.0. Now opt_slow_logname can be set either with --slow-query-log-file or with --log-basename --log was removed in 10.0. Now opt_logname can be set either with --general-log-file or with --log-basename
-
- 09 Aug, 2022 3 commits
- 08 Aug, 2022 4 commits
-
-
Oleksandr Byelkin authored
-
Sergei Golubchik authored
fixes srpm builds on centos7 and other old platforms (with cmake < 3.1) fixes pre-uninstall script fixes parallel builds
-
Monty authored
-
Monty authored
When creating a recursive CTE, the column types are taken from the non recursive part of the CTE (this is according to the SQL standard). This patch adds code to abort the CTE if the calculated values in the recursive part does not fit in the fields in the created temporary table. The new code only affects recursive CTE, so it should not cause any notable problems for old applications. Other things: - Fixed that we get correct row numbers for warnings generated with WITH RECURSIVE Reviewer: Alexander Barkov <bar@mariadb.com>
-
- 05 Aug, 2022 2 commits
-
-
Marko Mäkelä authored
A message used to say "failed to read or decrypt" but the "or decrypt" part was removed in commit 0b47c126 without adjusting rarely needed error message suppressions in some encryption tests. Let us improve the error message so that it mentions the file name, and adjust all error message suppressions in tests. Thanks to Oleksandr Byelkin for noticing one test failure.
-
Oleksandr Byelkin authored
-
- 04 Aug, 2022 9 commits
-
-
Oleksandr Byelkin authored
-
Sergei Petrunia authored
Make SEL_ARG::make_root() maintain SEL_ARG::weight. Also, an unrelated change: fix dbug_print_sel_arg() to correctly print SQL NULL for the right endpoint.
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
Daniel Black authored
Disable for embedded as mysqldump cannot connect to embedded server.
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
Marko Mäkelä authored
The test mariabackup.mdev-14447 is inserting relatively much data while concurrently backing up the data. The test often fails on CI systems, possibly due to an inherent race condition between the producer (server) and consumer (backup) that would be solved if the backup was being produced by the server (MDEV-14992). The written data volume was increased somewhat by commit 4179f93d (MDEV-18976). Let us trim the log volume by not writing PAGE_CHECKSUM records or row-level undo log records, and make the test cover what was intended to cover by creating the table in the system tablespace.
-